[jira] [Commented] (FLUME-2910) AsyncHBaseSink - Failure callbacks should log the exception that caused them
[ https://issues.apache.org/jira/browse/FLUME-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325277#comment-15325277 ] Hudson commented on FLUME-2910: --- FAILURE: Integrated in Flume-trunk-hbase-1 #161 (See [https://builds.apache.org/job/Flume-trunk-hbase-1/161/]) FLUME-2910. AsyncHBaseSink: Failure callbacks should log the exception (mpercy: [http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=ee4999bc23f42bc300ed87b0d46fd96418d6a185]) * flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java > AsyncHBaseSink - Failure callbacks should log the exception that caused them > > > Key: FLUME-2910 > URL: https://issues.apache.org/jira/browse/FLUME-2910 > Project: Flume > Issue Type: Improvement > Components: Sinks+Sources >Affects Versions: v1.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: v1.7.0 > > Attachments: FLUME-2910.patch > > > Failure callbacks in the AsyncHBaseSink currently do not log the exception > that causes them to be called, this should be fixed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLUME-2910) AsyncHBaseSink - Failure callbacks should log the exception that caused them
[ https://issues.apache.org/jira/browse/FLUME-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325173#comment-15325173 ] Mike Percy commented on FLUME-2910: --- Pushed to trunk. Thanks for the patch Abe! > AsyncHBaseSink - Failure callbacks should log the exception that caused them > > > Key: FLUME-2910 > URL: https://issues.apache.org/jira/browse/FLUME-2910 > Project: Flume > Issue Type: Improvement > Components: Sinks+Sources >Affects Versions: v1.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: v1.7.0 > > Attachments: FLUME-2910.patch > > > Failure callbacks in the AsyncHBaseSink currently do not log the exception > that causes them to be called, this should be fixed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLUME-2910) AsyncHBaseSink - Failure callbacks should log the exception that caused them
[ https://issues.apache.org/jira/browse/FLUME-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325172#comment-15325172 ] ASF subversion and git services commented on FLUME-2910: Commit ee4999bc23f42bc300ed87b0d46fd96418d6a185 in flume's branch refs/heads/trunk from [~mpercy] [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=ee4999b ] FLUME-2910. AsyncHBaseSink: Failure callbacks should log the exception that caused them (Abraham Fine via Mike Percy) > AsyncHBaseSink - Failure callbacks should log the exception that caused them > > > Key: FLUME-2910 > URL: https://issues.apache.org/jira/browse/FLUME-2910 > Project: Flume > Issue Type: Improvement > Components: Sinks+Sources >Affects Versions: v1.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Attachments: FLUME-2910.patch > > > Failure callbacks in the AsyncHBaseSink currently do not log the exception > that causes them to be called, this should be fixed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLUME-2910) AsyncHBaseSink - Failure callbacks should log the exception that caused them
[ https://issues.apache.org/jira/browse/FLUME-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325169#comment-15325169 ] Mike Percy commented on FLUME-2910: --- +1. Abe told me that he tested this offline. > AsyncHBaseSink - Failure callbacks should log the exception that caused them > > > Key: FLUME-2910 > URL: https://issues.apache.org/jira/browse/FLUME-2910 > Project: Flume > Issue Type: Improvement > Components: Sinks+Sources >Affects Versions: v1.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Attachments: FLUME-2910.patch > > > Failure callbacks in the AsyncHBaseSink currently do not log the exception > that causes them to be called, this should be fixed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLUME-2910) AsyncHBaseSink - Failure callbacks should log the exception that caused them
[ https://issues.apache.org/jira/browse/FLUME-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323229#comment-15323229 ] Mike Percy commented on FLUME-2910: --- [~abrahamfine]: Has this patch been tested? > AsyncHBaseSink - Failure callbacks should log the exception that caused them > > > Key: FLUME-2910 > URL: https://issues.apache.org/jira/browse/FLUME-2910 > Project: Flume > Issue Type: Improvement > Components: Sinks+Sources >Affects Versions: v1.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Attachments: FLUME-2910.patch > > > Failure callbacks in the AsyncHBaseSink currently do not log the exception > that causes them to be called, this should be fixed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLUME-2910) AsyncHBaseSink - Failure callbacks should log the exception that caused them
[
https://issues.apache.org/jira/browse/FLUME-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291953#comment-15291953
]
Abraham Fine commented on FLUME-2910:
-
Looking at the javadocs for stumbleupon's async (which asynchbase uses) here:
http://www.stumbleupon.com/su/19ESrH/tsunanet.net/~tsuna/async/api/
{quote}
When the current result of a Deferred is an instance of Exception, the next
errback is invoked. As for normal callbacks, whatever the errback returns
becomes the current result. If the current result is still an instance of
Exception, the next errback is invoked. If the current result is no longer an
Exception, the next callback is invoked.
{quote}
The code that calls the callback is a little clearer
(https://github.com/OpenTSDB/async/blob/v1.4.0/src/Deferred.java#L688,
https://github.com/OpenTSDB/async/blob/v1.4.0/src/Deferred.java#L1257):
{code:java}
doCall(result instanceof Exception ? eb : cb)
{code}
where eb is the "errback" and cb is the normal callback.
> AsyncHBaseSink - Failure callbacks should log the exception that caused them
>
>
> Key: FLUME-2910
> URL: https://issues.apache.org/jira/browse/FLUME-2910
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
>Affects Versions: v1.6.0
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Attachments: FLUME-2910.patch
>
>
> Failure callbacks in the AsyncHBaseSink currently do not log the exception
> that causes them to be called, this should be fixed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLUME-2910) AsyncHBaseSink - Failure callbacks should log the exception that caused them
[ https://issues.apache.org/jira/browse/FLUME-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291682#comment-15291682 ] Hari Shreedharan commented on FLUME-2910: - Does the Asynchbase API actually send the exception back as the argument of the call method? Do you have the javadoc that specifies this available? > AsyncHBaseSink - Failure callbacks should log the exception that caused them > > > Key: FLUME-2910 > URL: https://issues.apache.org/jira/browse/FLUME-2910 > Project: Flume > Issue Type: Improvement > Components: Sinks+Sources >Affects Versions: v1.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Attachments: FLUME-2910.patch > > > Failure callbacks in the AsyncHBaseSink currently do not log the exception > that causes them to be called, this should be fixed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
