[jira] [Commented] (FLUME-2998) Add missing configuration parameter to SequenceSource docs

2016-09-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535822#comment-15535822
 ] 

Hudson commented on FLUME-2998:
---

ABORTED: Integrated in Jenkins build Flume-trunk-hbase-1 #206 (See 
[https://builds.apache.org/job/Flume-trunk-hbase-1/206/])
FLUME-2998. Add a missing configuration parameter to SequenceSource docs 
(bessbd: 
[http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git=commit=fca8c5b970cf0bbae61bae08f2084dd4f3bd1143])
* (edit) flume-ng-doc/sphinx/FlumeUserGuide.rst


> Add missing configuration parameter to SequenceSource docs
> --
>
> Key: FLUME-2998
> URL: https://issues.apache.org/jira/browse/FLUME-2998
> Project: Flume
>  Issue Type: Documentation
>  Components: Docs
>Affects Versions: v1.7.0
>Reporter: Attila Simon
>Assignee: Attila Simon
> Fix For: v1.7.0
>
> Attachments: FLUME-2998.patch
>
>
> totalEvents can be specified



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2998) Add missing configuration parameter to SequenceSource docs

2016-09-30 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/FLUME-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535673#comment-15535673
 ] 

Bessenyei Balázs Donát commented on FLUME-2998:
---

Thank you for the patch, [~sati]

> Add missing configuration parameter to SequenceSource docs
> --
>
> Key: FLUME-2998
> URL: https://issues.apache.org/jira/browse/FLUME-2998
> Project: Flume
>  Issue Type: Documentation
>  Components: Docs
>Affects Versions: v1.7.0
>Reporter: Attila Simon
>Assignee: Attila Simon
> Fix For: v1.7.0
>
> Attachments: FLUME-2998.patch
>
>
> totalEvents can be specified



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2998) Add missing configuration parameter to SequenceSource docs

2016-09-30 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/FLUME-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535674#comment-15535674
 ] 

Bessenyei Balázs Donát commented on FLUME-2998:
---

Thank you for the review, [~denes]

> Add missing configuration parameter to SequenceSource docs
> --
>
> Key: FLUME-2998
> URL: https://issues.apache.org/jira/browse/FLUME-2998
> Project: Flume
>  Issue Type: Documentation
>  Components: Docs
>Affects Versions: v1.7.0
>Reporter: Attila Simon
>Assignee: Attila Simon
> Fix For: v1.7.0
>
> Attachments: FLUME-2998.patch
>
>
> totalEvents can be specified



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2998) Add missing configuration parameter to SequenceSource docs

2016-09-30 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535666#comment-15535666
 ] 

ASF subversion and git services commented on FLUME-2998:


Commit fca8c5b970cf0bbae61bae08f2084dd4f3bd1143 in flume's branch 
refs/heads/trunk from [~sati]
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=fca8c5b ]

FLUME-2998. Add a missing configuration parameter to SequenceSource docs

SequenceSource's totalEvents is configurable, but it is not in the 
documentation.

This patch fixes that problem by adding the missing configuration parameter to 
the docs.

Reviewers: Denes Arvay, Bessenyei Balázs Donát

(Attila Simon via Bessenyei Balázs Donát)


> Add missing configuration parameter to SequenceSource docs
> --
>
> Key: FLUME-2998
> URL: https://issues.apache.org/jira/browse/FLUME-2998
> Project: Flume
>  Issue Type: Documentation
>  Components: Docs
>Affects Versions: v1.7.0
>Reporter: Attila Simon
>Assignee: Attila Simon
> Fix For: v1.7.0
>
> Attachments: FLUME-2998.patch
>
>
> totalEvents can be specified



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2998) Add missing configuration parameter to SequenceSource docs

2016-09-30 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/FLUME-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535538#comment-15535538
 ] 

Bessenyei Balázs Donát commented on FLUME-2998:
---

LGTM. I'm about to commit this.

> Add missing configuration parameter to SequenceSource docs
> --
>
> Key: FLUME-2998
> URL: https://issues.apache.org/jira/browse/FLUME-2998
> Project: Flume
>  Issue Type: Documentation
>  Components: Docs
>Affects Versions: v1.7.0
>Reporter: Attila Simon
>Assignee: Attila Simon
> Fix For: v1.7.0
>
> Attachments: FLUME-2998.patch
>
>
> totalEvents can be specified



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2998) Add missing configuration parameter to SequenceSource docs

2016-09-30 Thread Denes Arvay (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535534#comment-15535534
 ] 

Denes Arvay commented on FLUME-2998:


+1, thanks [~sati] for the patch

> Add missing configuration parameter to SequenceSource docs
> --
>
> Key: FLUME-2998
> URL: https://issues.apache.org/jira/browse/FLUME-2998
> Project: Flume
>  Issue Type: Documentation
>  Components: Docs
>Affects Versions: v1.7.0
>Reporter: Attila Simon
>Assignee: Attila Simon
> Fix For: v1.7.0
>
> Attachments: FLUME-2998.patch
>
>
> totalEvents can be specified



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2998) Add missing configuration parameter to SequenceSource docs

2016-09-30 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/FLUME-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535464#comment-15535464
 ] 

Bessenyei Balázs Donát commented on FLUME-2998:
---

+1

Thank you for the changes, [~sati]

> Add missing configuration parameter to SequenceSource docs
> --
>
> Key: FLUME-2998
> URL: https://issues.apache.org/jira/browse/FLUME-2998
> Project: Flume
>  Issue Type: Documentation
>  Components: Docs
>Affects Versions: v1.7.0
>Reporter: Attila Simon
>Assignee: Attila Simon
> Fix For: v1.7.0
>
> Attachments: FLUME-2998.patch
>
>
> totalEvents can be specified



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2998) Add missing configuration parameter to SequenceSource docs

2016-09-30 Thread Denes Arvay (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535465#comment-15535465
 ] 

Denes Arvay commented on FLUME-2998:


I agree with [~bessbd]'s comments.
Regarding to the default value: I'd vote for using the Long.MAX_VALUE. Yes, it 
can't be set as value in this form but it's a lot cleaner than the exact number.

> Add missing configuration parameter to SequenceSource docs
> --
>
> Key: FLUME-2998
> URL: https://issues.apache.org/jira/browse/FLUME-2998
> Project: Flume
>  Issue Type: Documentation
>  Components: Docs
>Affects Versions: v1.7.0
>Reporter: Attila Simon
>Assignee: Attila Simon
> Fix For: v1.7.0
>
> Attachments: FLUME-2998.patch
>
>
> totalEvents can be specified



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2998) Add missing configuration parameter to SequenceSource docs

2016-09-29 Thread Attila Simon (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532922#comment-15532922
 ] 

Attila Simon commented on FLUME-2998:
-

Long.MAX_VALUE is 9223372036854775807. Although Long.MAX_VALUE is not a valid 
expression in the config file I would doubt that the exact number is useful in 
the docs. 
What I saw in other places is "see description". If it really needed to be 
changed from Long.MAX_VALUE in the "default value" column then we may use that 
trick and put it into the description column. 


> Add missing configuration parameter to SequenceSource docs
> --
>
> Key: FLUME-2998
> URL: https://issues.apache.org/jira/browse/FLUME-2998
> Project: Flume
>  Issue Type: Documentation
>  Components: Docs
>Affects Versions: v1.7.0
>Reporter: Attila Simon
>Assignee: Attila Simon
> Fix For: v1.7.0
>
> Attachments: FLUME-2998.patch
>
>
> totalEvents can be specified



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2998) Add missing configuration parameter to SequenceSource docs

2016-09-29 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/FLUME-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532585#comment-15532585
 ] 

Bessenyei Balázs Donát commented on FLUME-2998:
---

[~sati]: thank you for the patch!

* What do you mean be "practically" in the first line of the change?
* nit: "Retry if put failed." -> "Retries when it can't send events to the 
channel."

Side note: this would be the first parameter in the documentation with a Java 
constant ("Long.MAX_VALUE") for default. Do we want to maybe put numbers there 
instead?

> Add missing configuration parameter to SequenceSource docs
> --
>
> Key: FLUME-2998
> URL: https://issues.apache.org/jira/browse/FLUME-2998
> Project: Flume
>  Issue Type: Documentation
>  Components: Docs
>Affects Versions: v1.7.0
>Reporter: Attila Simon
>Assignee: Attila Simon
> Fix For: v1.7.0
>
> Attachments: FLUME-2998.patch
>
>
> totalEvents can be specified



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)