Re: Review Request 49403: FLUME-2937. Integrate checkstyle for non-test code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49403/#review140084 --- Ship it! I didn't look at the entire patch, but I like what I saw (~10%), but since the bytecode is the same - we should commit this. - Hari Shreedharan On June 29, 2016, 11:45 p.m., Mike Percy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49403/ > --- > > (Updated June 29, 2016, 11:45 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2937 > https://issues.apache.org/jira/browse/FLUME-2937 > > > Repository: flume-git > > > Description > --- > > This patch runs checkstyle as part of the Maven build and fixes existing > files to adhere to that style. This patch is only for the runtime code. It > does not include the unit test code. > > The style being used is the Google Java style, with some minor loosening to > be close to the style that the code is mostly already written in. > > > Diffs > - > > flume-checkstyle/pom.xml PRE-CREATION > flume-checkstyle/src/main/resources/flume/checkstyle-suppressions.xml > PRE-CREATION > flume-checkstyle/src/main/resources/flume/checkstyle.xml PRE-CREATION > > flume-ng-auth/src/main/java/org/apache/flume/api/SecureRpcClientFactory.java > c976458 > flume-ng-auth/src/main/java/org/apache/flume/api/SecureThriftRpcClient.java > f31582c > > flume-ng-auth/src/main/java/org/apache/flume/auth/FlumeAuthenticationUtil.java > 5627652 > > flume-ng-auth/src/main/java/org/apache/flume/auth/KerberosAuthenticator.java > 4a0e0f4 > flume-ng-auth/src/main/java/org/apache/flume/auth/KerberosUser.java dd37721 > flume-ng-auth/src/main/java/org/apache/flume/auth/SimpleAuthenticator.java > f7b5bea > flume-ng-auth/src/main/java/org/apache/flume/auth/UGIExecutor.java cd62b91 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/BadCheckpointException.java > 588506a > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/CheckpointRebuilder.java > b961ae2 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Commit.java > 3663244 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/CorruptEventException.java > 691d291 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java > 456df34 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java > 2b0987b > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV2.java > abd2ea3 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java > 9dfa0d1 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventUtils.java > ff5242a > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > ed2b996 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java > 5c3c48f > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEvent.java > 53c1251 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventPointer.java > 5f06ab7 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java > d305f4d > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 247c287 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java > 488dcf4 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java > 7d7fd85 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileRetryableIOException.java > 9447652 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV2.java > bb25e95 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java > 9b0ef93 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogRecord.java > 19ad0d6 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogUtils.java > d1498c2 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Pair.java > dfcdd73 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Put.java > f08f024
Review Request 49403: FLUME-2937. Integrate checkstyle for non-test code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49403/ --- Review request for Flume. Bugs: FLUME-2937 https://issues.apache.org/jira/browse/FLUME-2937 Repository: flume-git Description --- This patch runs checkstyle as part of the Maven build and fixes existing files to adhere to that style. This patch is only for the runtime code. It does not include the unit test code. The style being used is the Google Java style, with some minor loosening to be close to the style that the code is mostly already written in. Diffs - flume-checkstyle/pom.xml PRE-CREATION flume-checkstyle/src/main/resources/flume/checkstyle-suppressions.xml PRE-CREATION flume-checkstyle/src/main/resources/flume/checkstyle.xml PRE-CREATION flume-ng-auth/src/main/java/org/apache/flume/api/SecureRpcClientFactory.java c976458 flume-ng-auth/src/main/java/org/apache/flume/api/SecureThriftRpcClient.java f31582c flume-ng-auth/src/main/java/org/apache/flume/auth/FlumeAuthenticationUtil.java 5627652 flume-ng-auth/src/main/java/org/apache/flume/auth/KerberosAuthenticator.java 4a0e0f4 flume-ng-auth/src/main/java/org/apache/flume/auth/KerberosUser.java dd37721 flume-ng-auth/src/main/java/org/apache/flume/auth/SimpleAuthenticator.java f7b5bea flume-ng-auth/src/main/java/org/apache/flume/auth/UGIExecutor.java cd62b91 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/BadCheckpointException.java 588506a flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/CheckpointRebuilder.java b961ae2 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Commit.java 3663244 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/CorruptEventException.java 691d291 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java 456df34 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java 2b0987b flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV2.java abd2ea3 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java 9dfa0d1 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventUtils.java ff5242a flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java ed2b996 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java 5c3c48f flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEvent.java 53c1251 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventPointer.java 5f06ab7 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java d305f4d flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 247c287 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java 488dcf4 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java 7d7fd85 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileRetryableIOException.java 9447652 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV2.java bb25e95 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java 9b0ef93 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogRecord.java 19ad0d6 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogUtils.java d1498c2 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Pair.java dfcdd73 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Put.java f08f024 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/ReplayHandler.java a559503 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Rollback.java 335ad0b flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java a6eda75 flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Take.java 143143a flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/TransactionEventRecord.java 1eb3f4f flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/TransactionIDOracle.java a9f6be6 flume-ng-channels/flume-file-channel/src/main/
