[GitHub] incubator-gearpump issue #182: [GEARPUMP-307] Fix TransformTask$Transform in...

2017-05-09 Thread huafengw 
Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/182
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #182: [GEARPUMP-307] Fix TransformTask$Trans...

2017-05-09 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/182


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #182: [GEARPUMP-307] Fix TransformTask$Transform in...

2017-05-09 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/182
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/182?src=pr=h1)
 Report
> Merging 
[#182](https://codecov.io/gh/apache/incubator-gearpump/pull/182?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/232f527d696f81c6e1d98e794ab37dda32498811?src=pr=desc)
 will **decrease** coverage by `0.21%`.
> The diff coverage is `100%`.



```diff
@@Coverage Diff @@
##   master #182  +/-   ##
==
- Coverage   71.83%   71.62%   -0.22% 
==
  Files 191  191  
  Lines6086 6082   -4 
  Branches  527  524   -3 
==
- Hits 4372 4356  -16 
- Misses   1714 1726  +12
```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEARPUMP-307) TransformTask$Transform is not properly set up, finished, and torn down

2017-05-09 Thread Manu Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEARPUMP-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manu Zhang resolved GEARPUMP-307.
-
   Resolution: Fixed
Fix Version/s: 0.8.4

Issue resolved by pull request 182
[https://github.com/apache/incubator-gearpump/pull/182]

> TransformTask$Transform is not properly set up, finished, and torn down
> ---
>
> Key: GEARPUMP-307
> URL: https://issues.apache.org/jira/browse/GEARPUMP-307
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.3
>Reporter: Manu Zhang
>Assignee: Manu Zhang
> Fix For: 0.8.4
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEARPUMP-307) TransformTask$Transform is not properly set up, finished, and torn down

2017-05-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004056#comment-16004056
 ] 

ASF GitHub Bot commented on GEARPUMP-307:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/182


> TransformTask$Transform is not properly set up, finished, and torn down
> ---
>
> Key: GEARPUMP-307
> URL: https://issues.apache.org/jira/browse/GEARPUMP-307
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.3
>Reporter: Manu Zhang
>Assignee: Manu Zhang
> Fix For: 0.8.4
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEARPUMP-307) TransformTask$Transform is not properly set up, finished, and torn down

2017-05-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004044#comment-16004044
 ] 

ASF GitHub Bot commented on GEARPUMP-307:
-

Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/182
  
+1


> TransformTask$Transform is not properly set up, finished, and torn down
> ---
>
> Key: GEARPUMP-307
> URL: https://issues.apache.org/jira/browse/GEARPUMP-307
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.3
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEARPUMP-307) TransformTask$Transform is not properly set up, finished, and torn down

2017-05-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004042#comment-16004042
 ] 

ASF GitHub Bot commented on GEARPUMP-307:
-

Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/182
  
R: @huafengw 


> TransformTask$Transform is not properly set up, finished, and torn down
> ---
>
> Key: GEARPUMP-307
> URL: https://issues.apache.org/jira/browse/GEARPUMP-307
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.3
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEARPUMP-307) TransformTask$Transform is not properly set up, finished, and torn down

2017-05-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004000#comment-16004000
 ] 

ASF GitHub Bot commented on GEARPUMP-307:
-

Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/182
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/182?src=pr=h1)
 Report
> Merging 
[#182](https://codecov.io/gh/apache/incubator-gearpump/pull/182?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/232f527d696f81c6e1d98e794ab37dda32498811?src=pr=desc)
 will **decrease** coverage by `0.21%`.
> The diff coverage is `100%`.



```diff
@@Coverage Diff @@
##   master #182  +/-   ##
==
- Coverage   71.83%   71.62%   -0.22% 
==
  Files 191  191  
  Lines6086 6082   -4 
  Branches  527  524   -3 
==
- Hits 4372 4356  -16 
- Misses   1714 1726  +12
```




> TransformTask$Transform is not properly set up, finished, and torn down
> ---
>
> Key: GEARPUMP-307
> URL: https://issues.apache.org/jira/browse/GEARPUMP-307
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.3
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-gearpump pull request #182: [GEARPUMP-307] Fix TransformTask$Trans...

2017-05-09 Thread manuzhang 
GitHub user manuzhang opened a pull request:

https://github.com/apache/incubator-gearpump/pull/182

[GEARPUMP-307] Fix TransformTask$Transform invocation

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuzhang/incubator-gearpump fix_transform

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #182


commit 07a66564047ad35076379060428943cb1ebf0d76
Author: manuzhang 
Date:   2017-05-10T03:16:56Z

[GEARPUMP-307] Fix TransformTask$Transform invocation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEARPUMP-307) TransformTask$Transform is not properly set up, finished, and torn down

2017-05-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003968#comment-16003968
 ] 

ASF GitHub Bot commented on GEARPUMP-307:
-

GitHub user manuzhang opened a pull request:

https://github.com/apache/incubator-gearpump/pull/182

[GEARPUMP-307] Fix TransformTask$Transform invocation

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuzhang/incubator-gearpump fix_transform

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #182


commit 07a66564047ad35076379060428943cb1ebf0d76
Author: manuzhang 
Date:   2017-05-10T03:16:56Z

[GEARPUMP-307] Fix TransformTask$Transform invocation




> TransformTask$Transform is not properly set up, finished, and torn down
> ---
>
> Key: GEARPUMP-307
> URL: https://issues.apache.org/jira/browse/GEARPUMP-307
> Project: Apache Gearpump
>  Issue Type: Bug
>Affects Versions: 0.8.3
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEARPUMP-307) TransformTask$Transform is not properly set up, finished, and torn down

2017-05-09 Thread Manu Zhang (JIRA) 
Manu Zhang created GEARPUMP-307:
---

 Summary: TransformTask$Transform is not properly set up, finished, 
and torn down
 Key: GEARPUMP-307
 URL: https://issues.apache.org/jira/browse/GEARPUMP-307
 Project: Apache Gearpump
  Issue Type: Bug
Affects Versions: 0.8.3
Reporter: Manu Zhang
Assignee: Manu Zhang






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [jira] [Commented] (GEARPUMP-284) Oauth2 tests fail

2017-05-09 Thread Vincent Wang 
I remember that this UT actually will pass on travis sometimes, does it
fail all the time now?

Thanks,
Huafeng

Karol Brejna (JIRA) 于2017年5月9日周二 下午6:30写道：

>
> [
> https://issues.apache.org/jira/browse/GEARPUMP-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002448#comment-16002448
> ]
>
> Karol Brejna commented on GEARPUMP-284:
> ---
>
>
> From my observation, the test that fails is:
> services/jvm/src/test/scala/org/apache/gearpump/services/security/oauth2/GoogleOAuth2AuthenticatorSpec.scala
>
> The test tries to authenticate against google OAuth server.
>
> The log relevant for the error is:
> {code}
> ExecutorSystemLauncherSpec:^[[0m^[[0m
> - should report success when worker launch the system
> successfully^[[0m^[[0m
> - should report failure when worker refuse to launch the system
> explicitly^[[0m^[[0m
> - should report timeout when trying to start a executor system on worker,
> and worker doesn't response^[[0m^[[0m
> CloudFoundryUAAOAuth2AuthenticatorSpec:^[[0m^[[0m
> - should generate the correct authorization request^[[0m^[[0m
> - should authenticate the authorization code and return the correct
> profile *** FAILED ***^[[0m^[[0m
>   com.github.scribejava.core.exceptions.OAuthException: Response body is
> incorrect. Can't extract a '"access_token"\s*:\s*"(\S*?)"' from this:
> '^M^[[0m^[[0m
> Redirection^M^[[0m^[[0m
> Redirect^M^[[0m^[[0m
> '^[[0m^[[0m
>   at
> com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extractParameter(OAuth2AccessTokenJsonExtractor.java:64)^[[0m^[[0m
>   at
> com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extract(OAuth2AccessTokenJsonExtractor.java:37)^[[0m^[[0m
>   at
> com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extract(OAuth2AccessTokenJsonExtractor.java:12)^[[0m^[[0m
>   at
> com.github.scribejava.core.oauth.OAuth20Service$1.convert(OAuth20Service.java:47)^[[0m^[[0m
>   at
> com.github.scribejava.core.oauth.OAuth20Service$1.convert(OAuth20Service.java:43)^[[0m^[[0m
>   at
> com.github.scribejava.core.model.OAuthRequestAsync$OAuthAsyncCompletionHandler.onCompleted(OAuthRequestAsync.java:104)^[[0m^[[0m
>   at
> com.ning.http.client.AsyncCompletionHandler.onCompleted(AsyncCompletionHandler.java:55)^[[0m^[[0m
>   at
> com.ning.http.client.providers.netty.future.NettyResponseFuture.getContent(NettyResponseFuture.java:177)^[[0m^[[0m
>   at
> com.ning.http.client.providers.netty.future.NettyResponseFuture.done(NettyResponseFuture.java:214)^[[0m^[[0m
>   at
> com.ning.http.client.providers.netty.handler.HttpProtocol.finishUpdate(HttpProtocol.java:194)^[[0m^[[0m
>   ...^[[0m^[[0m
> GoogleOAuth2AuthenticatorSpec:^[[0m^[[0m
> - should generate the correct authorization request^[[0m^[[0m
> - should authenticate the authorization code and return the correct
> profile *** FAILED ***^[[0m^[[0m
>   com.github.scribejava.core.exceptions.OAuthException: Response body is
> incorrect. Can't extract a '"access_token"\s*:\s*"(\S*?)"' from this:
> '^M^[[0m^[[0m
> Redirection^M^[[0m^[[0m
> Redirect^M^[[0m^[[0m
> '^[[0m^[[0m
>   at
> com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extractParameter(OAuth2AccessTokenJsonExtractor.java:64)^[[0m^[[0m
>   at
> com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extract(OAuth2AccessTokenJsonExtractor.java:37)^[[0m^[[0m
>   at
> com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extract(OAuth2AccessTokenJsonExtractor.java:12)^[[0m^[[0m
>   at
> com.github.scribejava.core.oauth.OAuth20Service$1.convert(OAuth20Service.java:47)^[[0m^[[0m
>   at
> com.github.scribejava.core.oauth.OAuth20Service$1.convert(OAuth20Service.java:43)^[[0m^[[0m
> {code}
>
> It looks, like authorize url has moved recently. For me the following
> change worked:
> -  super.authorizeUrl.replace("https://accounts.google.com;, host)
> +  super.authorizeUrl.replace("
> https://accounts.google.com/ManageAccount;, host)
>
> I didn't check the rest of the test (what responses are sent, what secured
> endpoint it tries, etc. But I don't expect much changed there.
>
>
> > Oauth2 tests fail
> > -
> >
> > Key: GEARPUMP-284
> > URL: https://issues.apache.org/jira/browse/GEARPUMP-284
> > Project: Apache Gearpump
> >  Issue Type: Bug
> >  Components: services
> >Affects Versions: 0.8.2
> >Reporter: Karol Brejna
> >Assignee: Karol Brejna
> >   Original Estimate: 6h
> >  Remaining Estimate: 6h
> >
> > Running tests show that oauth2 tests fail.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>

Re: IntelliJ IDEA licence expired

2017-05-09 Thread Vincent Wang 
Hi Karol, I also noticed that. I tried to renew it but didn't find out how
to do that. Eventually I found that I can get a license using my apache
membership （email account).

Karol Brejna 于2017年5月9日周二 下午4:43写道：

> I've just noticed, that our IntelliJ license for Gearpump has expired.
>
> My license details:
>
> Licensed to: GearPump
> License restriction: For non-commercial open source development only
> Valid through: April 21, 2017
>
> Do you remember how to renew the license with JetBrains?
>
> Regards,
> Karol
>

[jira] [Commented] (GEARPUMP-284) Oauth2 tests fail

2017-05-09 Thread Karol Brejna (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002448#comment-16002448
 ] 

Karol Brejna commented on GEARPUMP-284:
---


>From my observation, the test that fails is: 
>services/jvm/src/test/scala/org/apache/gearpump/services/security/oauth2/GoogleOAuth2AuthenticatorSpec.scala

The test tries to authenticate against google OAuth server.

The log relevant for the error is:
{code}
ExecutorSystemLauncherSpec:^[[0m^[[0m
- should report success when worker launch the system successfully^[[0m^[[0m
- should report failure when worker refuse to launch the system 
explicitly^[[0m^[[0m
- should report timeout when trying to start a executor system on worker, and 
worker doesn't response^[[0m^[[0m
CloudFoundryUAAOAuth2AuthenticatorSpec:^[[0m^[[0m
- should generate the correct authorization request^[[0m^[[0m
- should authenticate the authorization code and return the correct profile *** 
FAILED ***^[[0m^[[0m
  com.github.scribejava.core.exceptions.OAuthException: Response body is 
incorrect. Can't extract a '"access_token"\s*:\s*"(\S*?)"' from this: 
'^M^[[0m^[[0m
Redirection^M^[[0m^[[0m
Redirect^M^[[0m^[[0m
'^[[0m^[[0m
  at 
com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extractParameter(OAuth2AccessTokenJsonExtractor.java:64)^[[0m^[[0m
  at 
com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extract(OAuth2AccessTokenJsonExtractor.java:37)^[[0m^[[0m
  at 
com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extract(OAuth2AccessTokenJsonExtractor.java:12)^[[0m^[[0m
  at 
com.github.scribejava.core.oauth.OAuth20Service$1.convert(OAuth20Service.java:47)^[[0m^[[0m
  at 
com.github.scribejava.core.oauth.OAuth20Service$1.convert(OAuth20Service.java:43)^[[0m^[[0m
  at 
com.github.scribejava.core.model.OAuthRequestAsync$OAuthAsyncCompletionHandler.onCompleted(OAuthRequestAsync.java:104)^[[0m^[[0m
  at 
com.ning.http.client.AsyncCompletionHandler.onCompleted(AsyncCompletionHandler.java:55)^[[0m^[[0m
  at 
com.ning.http.client.providers.netty.future.NettyResponseFuture.getContent(NettyResponseFuture.java:177)^[[0m^[[0m
  at 
com.ning.http.client.providers.netty.future.NettyResponseFuture.done(NettyResponseFuture.java:214)^[[0m^[[0m
  at 
com.ning.http.client.providers.netty.handler.HttpProtocol.finishUpdate(HttpProtocol.java:194)^[[0m^[[0m
  ...^[[0m^[[0m
GoogleOAuth2AuthenticatorSpec:^[[0m^[[0m
- should generate the correct authorization request^[[0m^[[0m
- should authenticate the authorization code and return the correct profile *** 
FAILED ***^[[0m^[[0m
  com.github.scribejava.core.exceptions.OAuthException: Response body is 
incorrect. Can't extract a '"access_token"\s*:\s*"(\S*?)"' from this: 
'^M^[[0m^[[0m
Redirection^M^[[0m^[[0m
Redirect^M^[[0m^[[0m
'^[[0m^[[0m
  at 
com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extractParameter(OAuth2AccessTokenJsonExtractor.java:64)^[[0m^[[0m
  at 
com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extract(OAuth2AccessTokenJsonExtractor.java:37)^[[0m^[[0m
  at 
com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.extract(OAuth2AccessTokenJsonExtractor.java:12)^[[0m^[[0m
  at 
com.github.scribejava.core.oauth.OAuth20Service$1.convert(OAuth20Service.java:47)^[[0m^[[0m
  at 
com.github.scribejava.core.oauth.OAuth20Service$1.convert(OAuth20Service.java:43)^[[0m^[[0m
{code}

It looks, like authorize url has moved recently. For me the following change 
worked:
-  super.authorizeUrl.replace("https://accounts.google.com;, host)
+  super.authorizeUrl.replace("https://accounts.google.com/ManageAccount;, 
host)

I didn't check the rest of the test (what responses are sent, what secured 
endpoint it tries, etc. But I don't expect much changed there.


> Oauth2 tests fail
> -
>
> Key: GEARPUMP-284
> URL: https://issues.apache.org/jira/browse/GEARPUMP-284
> Project: Apache Gearpump
>  Issue Type: Bug
>  Components: services
>Affects Versions: 0.8.2
>Reporter: Karol Brejna
>Assignee: Karol Brejna
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> Running tests show that oauth2 tests fail.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

IntelliJ IDEA licence expired

2017-05-09 Thread Karol Brejna 
I've just noticed, that our IntelliJ license for Gearpump has expired.

My license details:

Licensed to: GearPump
License restriction: For non-commercial open source development only
Valid through: April 21, 2017

Do you remember how to renew the license with JetBrains?

Regards,
Karol