[GitHub] incubator-gearpump issue #210: [GEARPUMP-339] Fix unknown tag parameter

[manuzhang]

Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/210
  
@huafengw Unfortunately, [genjavadoc doesn't support translating tparam 
tag](https://github.com/typesafehub/genjavadoc/issues/65). I will record this 
in jira and let's revisit when it's supported.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #211: [WIP] Move ClientContext into StreamAp...

[manuzhang]

GitHub user manuzhang opened a pull request:

https://github.com/apache/incubator-gearpump/pull/211

[WIP] Move ClientContext into StreamApp

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuzhang/incubator-gearpump wip_streaming_app

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #211


commit c84913a772d36f30f53b29e3f0e9787d299436c8
Author: manuzhang 
Date:   2017-08-05T09:43:26Z

[WIP] Move ClientContext into StreamApp




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #210: [GEARPUMP-339] Fix unknown tag paramet...

[manuzhang]

Github user manuzhang closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/210


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #210: [GEARPUMP-339] Fix unknown tag parameter

[huafengw]

Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/210
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #210: [GEARPUMP-339] Fix unknown tag paramet...

[manuzhang]

GitHub user manuzhang opened a pull request:

https://github.com/apache/incubator-gearpump/pull/210

[GEARPUMP-339] Fix unknown tag parameter

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuzhang/incubator-gearpump improve_scaladoc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #210


commit c9759ba5edb1ab7b9c5d81e2f0810a8f4712b256
Author: manuzhang 
Date:   2017-08-05T09:41:31Z

[GEARPUMP-339] Fix unknown tag parameter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

[Manu Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115360#comment-16115360
 ] 

Manu Zhang commented on GEARPUMP-339:
-

[genjavadoc doesn't support translating tparam 
tag|https://github.com/typesafehub/genjavadoc/issues/65] so we have to put up 
with Intellij complaining "Unknown Tag Parameter" or disable the inspection.

> Improve ScalaDoc for all public classes
> ---
>
> Key: GEARPUMP-339
> URL: https://issues.apache.org/jira/browse/GEARPUMP-339
> Project: Apache Gearpump
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>
> All public classes should have ScalaDoc and any warnings should be fixed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115358#comment-16115358
 ] 

ASF GitHub Bot commented on GEARPUMP-339:
-

Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/210
  
@huafengw Unfortunately, [genjavadoc doesn't support translating tparam 
tag](https://github.com/typesafehub/genjavadoc/issues/65). I will record this 
in jira and let's revisit when it's supported.


> Improve ScalaDoc for all public classes
> ---
>
> Key: GEARPUMP-339
> URL: https://issues.apache.org/jira/browse/GEARPUMP-339
> Project: Apache Gearpump
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>
> All public classes should have ScalaDoc and any warnings should be fixed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115359#comment-16115359
 ] 

ASF GitHub Bot commented on GEARPUMP-339:
-

Github user manuzhang closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/210


> Improve ScalaDoc for all public classes
> ---
>
> Key: GEARPUMP-339
> URL: https://issues.apache.org/jira/browse/GEARPUMP-339
> Project: Apache Gearpump
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>
> All public classes should have ScalaDoc and any warnings should be fixed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115352#comment-16115352
 ] 

ASF GitHub Bot commented on GEARPUMP-339:
-

Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/210
  
LGTM


> Improve ScalaDoc for all public classes
> ---
>
> Key: GEARPUMP-339
> URL: https://issues.apache.org/jira/browse/GEARPUMP-339
> Project: Apache Gearpump
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>
> All public classes should have ScalaDoc and any warnings should be fixed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115351#comment-16115351
 ] 

ASF GitHub Bot commented on GEARPUMP-339:
-

GitHub user manuzhang opened a pull request:

https://github.com/apache/incubator-gearpump/pull/210

[GEARPUMP-339] Fix unknown tag parameter

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuzhang/incubator-gearpump improve_scaladoc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #210


commit c9759ba5edb1ab7b9c5d81e2f0810a8f4712b256
Author: manuzhang 
Date:   2017-08-05T09:41:31Z

[GEARPUMP-339] Fix unknown tag parameter




> Improve ScalaDoc for all public classes
> ---
>
> Key: GEARPUMP-339
> URL: https://issues.apache.org/jira/browse/GEARPUMP-339
> Project: Apache Gearpump
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>
> All public classes should have ScalaDoc and any warnings should be fixed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEARPUMP-339) Improve ScalaDoc for all public classes

[Manu Zhang (JIRA)]

Manu Zhang created GEARPUMP-339:
---

 Summary: Improve ScalaDoc for all public classes
 Key: GEARPUMP-339
 URL: https://issues.apache.org/jira/browse/GEARPUMP-339
 Project: Apache Gearpump
  Issue Type: Improvement
Affects Versions: 0.8.4
Reporter: Manu Zhang
Assignee: Manu Zhang


All public classes should have ScalaDoc and any warnings should be fixed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEARPUMP-338) Improve time related types and constants

[Manu Zhang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEARPUMP-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manu Zhang resolved GEARPUMP-338.
-
Resolution: Fixed

Issue resolved by pull request 208
[https://github.com/apache/incubator-gearpump/pull/208]

> Improve time related types and constants
> 
>
> Key: GEARPUMP-338
> URL: https://issues.apache.org/jira/browse/GEARPUMP-338
> Project: Apache Gearpump
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Manu Zhang
> Fix For: 0.8.5
>
>
> Currently, there is a type {{TimeStamp}} in package object {{gearpump}}. It's 
> unclear what the time unit is, seconds or milliseconds. There are also 
> constants {{MAX_TIME_MILLIS}} and {{MIN_TIME_MILLIS}} for maximum and minimum 
> valid timestamps in milliseconds. All of them are not easy to find out and 
> import from the package object.
> Propose to move them into a new object singleton {{Time}} and rename type 
> {{TimeStamp}} to {{MilliSeconds}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)