[GitHub] incubator-gearpump issue #243: [GEARPUMP-339] Fix unknown tag parameter

2018-04-22 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/243
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/243?src=pr=h1)
 Report
> Merging 
[#243](https://codecov.io/gh/apache/incubator-gearpump/pull/243?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/2d13b9cf883ee59b97751d992c2b52dc4068b16c?src=pr=desc)
 will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.



```diff
@@Coverage Diff @@
##   master #243  +/-   ##
==
- Coverage   68.98%   68.91%   -0.07% 
==
  Files 191  191  
  Lines6171 6171  
  Branches  546  546  
==
- Hits 4257 4253   -4 
- Misses   1914 1918   +4
```




---

[GitHub] incubator-gearpump issue #243: [GEARPUMP-339] Fix unknown tag parameter

2018-04-22 Thread huafengw 
Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/243
  
+1


---

[GitHub] incubator-gearpump pull request #243: [GEARPUMP-339] Fix unknown tag paramet...

2018-04-22 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/243


---

[GitHub] incubator-gearpump issue #243: [GEARPUMP-339] Fix unknown tag parameter

2018-04-22 Thread manuzhang 
Github user manuzhang commented on the issue:

https://github.com/apache/incubator-gearpump/pull/243
  
R: @huafengw 


---

[GitHub] incubator-gearpump pull request #243: [GEARPUMP-339] Fix unknown tag paramet...

2018-04-22 Thread manuzhang 
GitHub user manuzhang opened a pull request:

https://github.com/apache/incubator-gearpump/pull/243

[GEARPUMP-339] Fix unknown tag parameter

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuzhang/incubator-gearpump improve_scaladoc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #243


commit 20024e1f4d43e776487cabcf67632d644fab07ae
Author: manuzhang 
Date:   2018-04-22T07:17:51Z

[GEARPUMP-339] Fix unknown tag parameter




---

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

2018-04-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447135#comment-16447135
 ] 

ASF GitHub Bot commented on GEARPUMP-339:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/243


> Improve ScalaDoc for all public classes
> ---
>
> Key: GEARPUMP-339
> URL: https://issues.apache.org/jira/browse/GEARPUMP-339
> Project: Apache Gearpump
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>Priority: Major
>
> All public classes should have ScalaDoc and any warnings should be fixed. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

2018-04-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447133#comment-16447133
 ] 

ASF GitHub Bot commented on GEARPUMP-339:
-

Github user codecov-io commented on the issue:

https://github.com/apache/incubator-gearpump/pull/243
  
# 
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/243?src=pr=h1)
 Report
> Merging 
[#243](https://codecov.io/gh/apache/incubator-gearpump/pull/243?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/2d13b9cf883ee59b97751d992c2b52dc4068b16c?src=pr=desc)
 will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.



```diff
@@Coverage Diff @@
##   master #243  +/-   ##
==
- Coverage   68.98%   68.91%   -0.07% 
==
  Files 191  191  
  Lines6171 6171  
  Branches  546  546  
==
- Hits 4257 4253   -4 
- Misses   1914 1918   +4
```




> Improve ScalaDoc for all public classes
> ---
>
> Key: GEARPUMP-339
> URL: https://issues.apache.org/jira/browse/GEARPUMP-339
> Project: Apache Gearpump
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>Priority: Major
>
> All public classes should have ScalaDoc and any warnings should be fixed. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

2018-04-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447128#comment-16447128
 ] 

ASF GitHub Bot commented on GEARPUMP-339:
-

Github user huafengw commented on the issue:

https://github.com/apache/incubator-gearpump/pull/243
  
+1


> Improve ScalaDoc for all public classes
> ---
>
> Key: GEARPUMP-339
> URL: https://issues.apache.org/jira/browse/GEARPUMP-339
> Project: Apache Gearpump
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>Priority: Major
>
> All public classes should have ScalaDoc and any warnings should be fixed. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GEARPUMP-339) Improve ScalaDoc for all public classes

2018-04-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447123#comment-16447123
 ] 

ASF GitHub Bot commented on GEARPUMP-339:
-

GitHub user manuzhang opened a pull request:

https://github.com/apache/incubator-gearpump/pull/243

[GEARPUMP-339] Fix unknown tag parameter

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuzhang/incubator-gearpump improve_scaladoc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #243


commit 20024e1f4d43e776487cabcf67632d644fab07ae
Author: manuzhang 
Date:   2018-04-22T07:17:51Z

[GEARPUMP-339] Fix unknown tag parameter




> Improve ScalaDoc for all public classes
> ---
>
> Key: GEARPUMP-339
> URL: https://issues.apache.org/jira/browse/GEARPUMP-339
> Project: Apache Gearpump
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: Manu Zhang
>Assignee: Manu Zhang
>Priority: Major
>
> All public classes should have ScalaDoc and any warnings should be fixed. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)