[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...

2017-07-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/196


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...

2017-07-20 Thread huafengw
Github user huafengw commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/196#discussion_r128453676
  
--- Diff: project/BuildExperiments.scala ---
@@ -46,7 +46,8 @@ object BuildExperiments extends sbt.Build {
   "org.apache.hadoop" % "hadoop-mapreduce-client-core" % 
hadoopVersion,
   "org.apache.hadoop" % "hadoop-yarn-server-resourcemanager" % 
hadoopVersion % "provided",
   "org.apache.hadoop" % "hadoop-yarn-server-nodemanager" % 
hadoopVersion % "provided"
-)
+).map(_.exclude("org.slf4j", "slf4j-api"))
--- End diff --

From gearpump-core


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-gearpump pull request #196: [GEARPUMP-322] Fix multiple SLF4J bind...

2017-07-20 Thread manuzhang
Github user manuzhang commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/196#discussion_r128451485
  
--- Diff: project/BuildExperiments.scala ---
@@ -46,7 +46,8 @@ object BuildExperiments extends sbt.Build {
   "org.apache.hadoop" % "hadoop-mapreduce-client-core" % 
hadoopVersion,
   "org.apache.hadoop" % "hadoop-yarn-server-resourcemanager" % 
hadoopVersion % "provided",
   "org.apache.hadoop" % "hadoop-yarn-server-nodemanager" % 
hadoopVersion % "provided"
-)
+).map(_.exclude("org.slf4j", "slf4j-api"))
--- End diff --

Then where will the yarn load `slf4j` libraries ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---