[GitHub] incubator-gearpump pull request #217: Merge remote-tracking branch 'origin/u...

2017-08-19 Thread buddhiayesha2015 
Github user buddhiayesha2015 closed the pull request at:

https://github.com/apache/incubator-gearpump/pull/217


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #217: Merge remote-tracking branch 'origin/u...

2017-08-18 Thread manuzhang 
Github user manuzhang commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/217#discussion_r133892457
  
--- Diff: 
experiments/sql/src/main/java/org/apache/gearpump/sql/rel/GearAggregationRel.java
 ---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gearpump.sql.rel;
+
+import org.apache.calcite.linq4j.Ord;
+import org.apache.calcite.plan.RelOptCluster;
+import org.apache.calcite.plan.RelTraitSet;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.RelWriter;
+import org.apache.calcite.rel.core.Aggregate;
+import org.apache.calcite.rel.core.AggregateCall;
+import org.apache.calcite.util.ImmutableBitSet;
+import org.apache.calcite.util.Util;
+import org.apache.gearpump.sql.table.SampleString;
+import org.apache.gearpump.streaming.dsl.api.functions.MapFunction;
+import org.apache.gearpump.streaming.dsl.api.functions.ReduceFunction;
+import org.apache.gearpump.streaming.dsl.javaapi.JavaStream;
+import org.apache.gearpump.streaming.dsl.javaapi.JavaStreamApp;
+import org.apache.gearpump.streaming.dsl.javaapi.functions.GroupByFunction;
+import org.apache.gearpump.streaming.dsl.window.api.Trigger;
+import org.apache.gearpump.streaming.dsl.window.api.WindowFunction;
+import org.apache.log4j.Logger;
--- End diff --

We use `org.slf4j.Logger` and `Logger  LOG = LogUtil.getLogger(className)` 
for logging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #217: Merge remote-tracking branch 'origin/u...

2017-08-18 Thread buddhiayesha2015 
Github user buddhiayesha2015 commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/217#discussion_r133880032
  
--- Diff: 
examples/streaming/wordcount-java/src/test/java/org/apache/gearpump/streaming/examples/wordcountjava/WordCountSpecJava.java
 ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gearpump.streaming.examples.wordcountjava;
+
+import org.apache.gearpump.cluster.ClusterConfig;
+import org.apache.gearpump.streaming.examples.wordcountjava.dsl.WordCount;
+import org.apache.log4j.Logger;
+import org.junit.Test;
+
+/**
+ * Created by Buddhi on 7/14/2017.
+ */
+public class WordCountSpecJava {
--- End diff --

I will remove that. That is a testing class and it is not essential


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #217: Merge remote-tracking branch 'origin/u...

2017-08-18 Thread manuzhang 
Github user manuzhang commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/217#discussion_r133879510
  
--- Diff: 
examples/streaming/wordcount-java/src/test/java/org/apache/gearpump/streaming/examples/wordcountjava/WordCountSpecJava.java
 ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gearpump.streaming.examples.wordcountjava;
+
+import org.apache.gearpump.cluster.ClusterConfig;
+import org.apache.gearpump.streaming.examples.wordcountjava.dsl.WordCount;
+import org.apache.log4j.Logger;
+import org.junit.Test;
+
+/**
+ * Created by Buddhi on 7/14/2017.
+ */
+public class WordCountSpecJava {
+
+private final static Logger logger = 
Logger.getLogger(WordCountSpecJava.class);
--- End diff --

We indent with 2 spaces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #217: Merge remote-tracking branch 'origin/u...

2017-08-18 Thread manuzhang 
Github user manuzhang commented on a diff in the pull request:

https://github.com/apache/incubator-gearpump/pull/217#discussion_r133879776
  
--- Diff: 
examples/streaming/wordcount-java/src/test/java/org/apache/gearpump/streaming/examples/wordcountjava/WordCountSpecJava.java
 ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gearpump.streaming.examples.wordcountjava;
+
+import org.apache.gearpump.cluster.ClusterConfig;
+import org.apache.gearpump.streaming.examples.wordcountjava.dsl.WordCount;
+import org.apache.log4j.Logger;
+import org.junit.Test;
+
+/**
+ * Created by Buddhi on 7/14/2017.
+ */
+public class WordCountSpecJava {
--- End diff --

Is this used anywhere ? It's a simple wrapper around 
`org.apache.gearpump.streaming.examples.wordcountjava.dsl.WordCount`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #217: Merge remote-tracking branch 'origin/u...

2017-08-17 Thread buddhiayesha2015 
GitHub user buddhiayesha2015 opened a pull request:

https://github.com/apache/incubator-gearpump/pull/217

Merge remote-tracking branch 'origin/upstream_sql' into 'sql'

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the commit message is formatted like:
   `[GEARPUMP-] Meaningful description of pull request` 
 - [ ] Make sure tests pass via `sbt clean test`.
 - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/buddhiayesha2015/incubator-gearpump 
upstream_sql

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gearpump/pull/217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #217


commit 6a44f4f9cf5b11d94e5e8e1b37d6b2207bcd36a9
Author: Buddhi Ayesha 
Date:   2017-07-15T07:28:46Z

Fix ComparisonFailure import

commit aaa80557246704b6cb3336b075f3811974cb573b
Author: Buddhi Ayesha 
Date:   2017-07-15T07:53:31Z

Rename org.apache.calcite package name

commit 3c4d87bbddac2421b0e92809f6709d2265adbe5c
Author: Buddhi Ayesha 
Date:   2017-07-15T10:51:01Z

Add Rel

commit 6909a8f0dca51759e079783e86b6f228ef459ccf
Author: Buddhi Ayesha 
Date:   2017-07-15T10:52:35Z

Add rules

commit 9f2762bc626e0c30187154ced5444c47b46195e7
Author: Buddhi Ayesha 
Date:   2017-07-15T10:54:34Z

Remove redundant files

commit 16ab5a17e33601712450741cd44a3ce575fd82fd
Author: Buddhi Ayesha 
Date:   2017-07-20T09:16:20Z

Allow examples to run in IDE for Java

commit e0100c297beae2c22ebc7ecf010105efd5b459e6
Author: Buddhi Ayesha 
Date:   2017-07-20T11:20:53Z

Test WordCount example in IDE

commit b7a3dde8229083cd0173713dedf738d5c1386c8c
Author: Buddhi Ayesha 
Date:   2017-08-05T16:07:14Z

Remove WordCountTest class

commit 988396af85a649c2db5b8c2bb0f193de9e0ad3d7
Author: Buddhi Ayesha 
Date:   2017-08-12T03:35:53Z

Add test method to check connecting Gearpump

commit e18ca5e5a4a0920a5d5c57f50a1f2f8686ae22fd
Author: Buddhi Ayesha 
Date:   2017-08-12T03:37:48Z

Add SQL WordCount example

commit e09c973724a3d8c08f8bad666d76986ccb30cc63
Author: Buddhi Ayesha 
Date:   2017-08-12T03:40:08Z

Change method signature of "buildGearPipeline"

commit 87de2ac7ecca5d7765b667528a3499fc409de017
Author: Buddhi Ayesha 
Date:   2017-08-12T03:44:22Z

Update buildGearPipeline method

commit c5d3786ba0c4f38738e23111e6ba38d2583b6ac3
Author: Buddhi Ayesha 
Date:   2017-08-14T02:12:24Z

Add GearIO rel

commit d1dbb67a4c8c534c143241999a01e3a404539b2d
Author: Buddhi Ayesha 
Date:   2017-08-14T02:16:09Z

Update "buildGearPipeline" method

commit 359a0a599db63538482fa101975e6477c6b9c164
Author: Buddhi Ayesha 
Date:   2017-08-14T02:18:16Z

Add GearIO rule

commit a6fb236cca8522b5ad3258b372ce397daedb424f
Author: Buddhi Ayesha 
Date:   2017-08-14T02:20:56Z

Add GearRuleSets class

commit cb8ba3362605f49f6e2d24eb500250f9a67846b8
Author: Buddhi Ayesha 
Date:   2017-08-14T02:22:34Z

Add GearRelDataType class

commit 0cf8cf2dd29ab9418fc10fd1317e6119ebb94874
Author: Buddhi Ayesha 
Date:   2017-08-15T17:04:56Z

Remove unnecessary method

commit 91733e1edc8ca425bda3a0406e0e91dde9def1bc
Author: Buddhi Ayesha 
Date:   2017-08-15T18:09:18Z

Add logger

commit 44fff192998facfd211afbbab475dfb7bad56e1f
Author: Buddhi Ayesha 
Date:   2017-08-16T14:42:58Z

Add license

commit dba5bb27cd3ba13f274f80099fbd668369334f6d
Author: Buddhi Ayesha 
Date:   2017-08-16T15:11:25Z

Update README

commit 6c1b7d3ad0f97cd69a1c7d64fffdec3ba77ad875
Author: Buddhi Rathnayaka 
Date:   2017-08-17T02:33:38Z

Update README.md




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---