[jira] [Commented] (GEODE-734) gfsh export stack-traces should not require an output file with extension .txt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734352#comment-15734352
 ] 

ASF GitHub Bot commented on GEODE-734:
--

Github user deepakddixit commented on the issue:

https://github.com/apache/geode/pull/297
  
Thank you @kirklund and @metatype for review and merge.


> gfsh export stack-traces should not require an output file with extension .txt
> --
>
> Key: GEODE-734
> URL: https://issues.apache.org/jira/browse/GEODE-734
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Jens Deppe
>
> gfsh {{export stack-traces}} requires a file with a {{.txt}} extension:
> {noformat}
> gfsh>export stack-traces --file=/tmp/trace.log
> Invalid file type, the file extension must be ".txt"
> {noformat}
> This seems like a totally arbitrary restriction. Please can it be removed.
> If the concern is that an existing file might be overwritten then we should 
> have a user prompt indicating that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] geode issue #297: GEODE-734: gfsh export stack-traces should not require an ...

[deepakddixit]

Github user deepakddixit commented on the issue:

https://github.com/apache/geode/pull/297
  
Thank you @kirklund and @metatype for review and merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2201) Make UITests more resilient

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734321#comment-15734321
 ] 

ASF subversion and git services commented on GEODE-2201:


Commit d4276136337d2c9bee7336bafa281f2301af2a40 in geode's branch 
refs/heads/feature/GEODE-2201 from [~jens.deppe]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d427613 ]

GEODE-2201 Make UITests a bit more resilient

- Increase some timeouts
- Avoid StaleElementReferenceExceptions by retrying the element
  retrieval.


> Make UITests more resilient
> ---
>
> Key: GEODE-2201
> URL: https://issues.apache.org/jira/browse/GEODE-2201
> Project: Geode
>  Issue Type: Improvement
>  Components: pulse
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>
> The UITests are continually failing in CI. We need to make them great again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2175) CI failure from TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734302#comment-15734302
 ] 

ASF subversion and git services commented on GEODE-2175:


Commit 1d951e334334393c2052307988a21c1cd1f11985 in geode's branch 
refs/heads/feature/GEODE-2201 from zhouxh
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1d951e3 ]

GEODE-2175: wait for results from other members is not needed in result 
collector. It's already handled by Function framework.


> CI failure from TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime
> -
>
> Key: GEODE-2175
> URL: https://issues.apache.org/jira/browse/GEODE-2175
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> {noformat}
> org.apache.geode.cache.lucene.internal.distributed.TopEntriesFunctionCollectorJUnitTest
>  > expectErrorAfterWaitTime FAILED
> java.lang.Exception: Unexpected exception, 
> expected but 
> was
> Caused by:
> java.lang.AssertionError: expected:<1> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.cache.lucene.internal.distributed.TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime(TopEntriesFunctionCollectorJUnitTest.java:195)
> {noformat}
> Looking at this test, it looks like it's a race condition waiting to happen 
> because it does a bunch of 1 second awaits.
> I'm also suspicious of the functionality that is being tested here in the 
> first place. A user's result collector shouldn't have to contain logic to 
> wait for all of the results to be gather, that's handled by the function 
> execution framework. So the real fix may be to remove these tests and the 
> logic in TopEntriesFunctionCollector that waits for the results to be 
> gathered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2201) Make UITests more resilient

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734303#comment-15734303
 ] 

ASF subversion and git services commented on GEODE-2201:


Commit 8056a302558c042ec8cbe39003feaedc712b7021 in geode's branch 
refs/heads/feature/GEODE-2201 from [~jens.deppe]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8056a30 ]

GEODE-2201 Make UITests a bit more resilient

- Increase some timeouts
- Avoid StaleElementReferenceExceptions by retrying the element
  retrieval.


> Make UITests more resilient
> ---
>
> Key: GEODE-2201
> URL: https://issues.apache.org/jira/browse/GEODE-2201
> Project: Geode
>  Issue Type: Improvement
>  Components: pulse
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>
> The UITests are continually failing in CI. We need to make them great again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2192) NPE in GMSLocator

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734301#comment-15734301
 ] 

ASF subversion and git services commented on GEODE-2192:


Commit f22809a448ba5ab177be0d1d790f0ec91801d0f0 in geode's branch 
refs/heads/feature/GEODE-2201 from [~hitesh.khamesra]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f22809a ]

GEODE-2192 Fixed NPE in GMSLocator. Added null check for publickey


> NPE in GMSLocator
> -
>
> Key: GEODE-2192
> URL: https://issues.apache.org/jira/browse/GEODE-2192
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Hitesh Khamesra
>Assignee: Mark Bretl
>
> 22999-1: [severe 2016/12/07 16:36:20.976 EST 
> locatorgemfire2_rs-intTest-rhel7-20
> 16-12-07-21-14-10-client-2_22999  tid=0x18] 
> Exception
>  in processing request from 10.32.111.110
> java.lang.NullPointerException
> at 
> java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)
> at 
> java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006)
> at 
> org.apache.geode.distributed.internal.membership.gms.locator.GMSLocator.processRequest(GMSLocator.java:192)
> at 
> org.apache.geode.distributed.internal.InternalLocator$PrimaryHandler.processRequest(InternalLocator.java:1328)
> at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer$3.run(TcpServer.java:411)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2201) Make UITests more resilient

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15734290#comment-15734290
 ] 

ASF subversion and git services commented on GEODE-2201:


Commit 26fb32020f678bb4659cf4c141b6c720d5fcea95 in geode's branch 
refs/heads/feature/GEODE-2201 from [~jens.deppe]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=26fb320 ]

GEODE-2201 Make UITests a bit more resilient

- Increase some timeouts
- Avoid StaleElementReferenceExceptions by retrying the element
  retrieval.


> Make UITests more resilient
> ---
>
> Key: GEODE-2201
> URL: https://issues.apache.org/jira/browse/GEODE-2201
> Project: Geode
>  Issue Type: Improvement
>  Components: pulse
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>
> The UITests are continually failing in CI. We need to make them great again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (GEODE-2175) CI failure from TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime

[xiaojian zhou (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

xiaojian zhou resolved GEODE-2175.
--
Resolution: Fixed

> CI failure from TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime
> -
>
> Key: GEODE-2175
> URL: https://issues.apache.org/jira/browse/GEODE-2175
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Dan Smith
>Assignee: xiaojian zhou
>
> {noformat}
> org.apache.geode.cache.lucene.internal.distributed.TopEntriesFunctionCollectorJUnitTest
>  > expectErrorAfterWaitTime FAILED
> java.lang.Exception: Unexpected exception, 
> expected but 
> was
> Caused by:
> java.lang.AssertionError: expected:<1> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.cache.lucene.internal.distributed.TopEntriesFunctionCollectorJUnitTest.expectErrorAfterWaitTime(TopEntriesFunctionCollectorJUnitTest.java:195)
> {noformat}
> Looking at this test, it looks like it's a race condition waiting to happen 
> because it does a bunch of 1 second awaits.
> I'm also suspicious of the functionality that is being tested here in the 
> first place. A user's result collector shouldn't have to contain logic to 
> wait for all of the results to be gather, that's handled by the function 
> execution framework. So the real fix may be to remove these tests and the 
> logic in TopEntriesFunctionCollector that waits for the results to be 
> gathered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[DRAFT] Geode Board Report for December 2016

[Dan Smith]

Here's a draft of our report to the board for December. Please review
and give your feedback. Did anyone else do a talk since our last
report (written Oct 5th)? I know Jinmei presented at ApacheCon.

-Dan

## Description:
 - Apache Geode provides a database-like consistency model, reliable
   transaction processing and a shared-nothing architecture to maintain
   very low latency performance with high concurrency.

## Issues:
 - No issues requiring board attention at this time

## Activity:
 - Graduated from the incubator November 21, 2016!
 - Released our first non-milestone release, 1.0.0-incubating
 - Started discussions about our first release as a TLP
 - Jinmei Liao presented a talk at apachecon Europe: "Implementing
Security in Apache Geode Using Apache Shiro"

## Health report:
 - Geode is still seeing active development. With our first
non-milestone release we're hoping to settle into a more regular
release cadence. We're still working to attract more contributors from
outside of Pivotal and since graduation we're seeing more
contributions coming in from other sources which is a good sign.

## PMC changes:

 - No PMC changes since the last report to the incubator board.

## Committer base changes:

 - Ken Howe joined as a committer Nov 15th

## Releases:

 - 1.0.0-incubating October 25, 2016
 - 1.0.0-incubating.M3 August 23, 2016
 - 1.0.0-incubating.M2 April 22, 2016
 - 1.0.0-incubating.M1 Feb 8, 2016

## Mailing list activity:

 - PMC Chair is able to provide statistics

## JIRA activity:

 - PMC Chair is able to provide statistics

[jira] [Commented] (GEODE-1027) MBeans should be initialized with current stats when they are created.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733803#comment-15733803
 ] 

ASF GitHub Bot commented on GEODE-1027:
---

Github user jinmeiliao commented on the issue:

https://github.com/apache/geode/pull/307
  
LGTM


> MBeans should be initialized with current stats when they are created.
> --
>
> Key: GEODE-1027
> URL: https://issues.apache.org/jira/browse/GEODE-1027
> Project: Geode
>  Issue Type: Improvement
>  Components: jmx
>Affects Versions: 1.0.0-incubating
>Reporter: Jens Deppe
>Assignee: Kirk Lund
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (GEODE-2198) import cluster-config should continue if the running servers have no data in their application regions

[Jinmei Liao (JIRA)]

Jinmei Liao created GEODE-2198:
--

 Summary: import cluster-config should continue if the running 
servers have no data in their application regions
 Key: GEODE-2198
 URL: https://issues.apache.org/jira/browse/GEODE-2198
 Project: Geode
  Issue Type: Sub-task
Reporter: Jinmei Liao
Assignee: Mark Bretl






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 54542: [GEODE-2191] Add a new randomized string serialization test.

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54542/#review158603
---




geode-core/src/test/java/org/apache/geode/internal/InternalDataSerializerRandomizedJUnitTest.java
 (line 102)


Since you named the variable codepoint maybe something like this would be 
more appropriate:

int codepoint = ...;
char character = (new Character(codepoint)).charValue();
stringBuilder.append(character);

If you want to keep the code you have you need to change the "if" statement 
to (stringBuilder.length() + numdigits(codepoint) < strlen) because  
StringBuilder.append(int) is going to convert the int to a String, like "12345" 
and append it.


- Bruce Schuchardt


On Dec. 8, 2016, 10:10 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54542/
> ---
> 
> (Updated Dec. 8, 2016, 10:10 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-2191
> https://issues.apache.org/jira/browse/GEODE-2191
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * Added a new test that generates random strings, and attempts to serialize 
> and deserialize them looking for differences or errors.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/internal/InternalDataSerializerRandomizedJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54542/diff/
> 
> 
> Testing
> ---
> 
> This is a new test; I've run it both from IntelliJ and as a part of the test 
> suite. I filed GEODE-2191 for this; I'm not sure if a new JIRA is strictly 
> necessary for any new changes but it does seem to be encouraged.
> 
> I don't know of any random string generator that is already available in the 
> codebase; had there been one I would have used it rather than rolling my own. 
> We could eventually use something like 
> [junit-quickcheck](https://github.com/pholser/junit-quickcheck) for these 
> types of tests.
> 
> 
> Thanks,
> 
> Galen O'Sullivan
> 
>

Review Request 54546: GEODE-2193 a member is kicked out immediately after joining

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54546/
---

Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: geode-2193
https://issues.apache.org/jira/browse/geode-2193


Repository: geode


Description
---

The problem is happening because we send a shutdown message, initiating 
election of a new coordinator, but the old ViewCreator is allowed to send out a 
view announcing a new member.  The new coordinator manages to send out a new 
view before the old ViewCreator sends out the new member's view.  Other members 
ignore the old ViewCreator's view because its view ID is old.  Then the reject 
the new member because it has an old view ID and it isn't in their membership 
view.

initial view ID is x
new coordinator prepares view x+10
old coordinator prepares view x+1
other members install x+10, reject view x+1
new member joins in view x+1 when it receives view-prepare message
new member is rejected by other members because x+1 < x+10


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 6d782b147529d0d37a3b130e40e2a79322469fa4 

Diff: https://reviews.apache.org/r/54546/diff/


Testing
---

precheckin, new unit test, integration testing


Thanks,

Bruce Schuchardt

[GitHub] geode pull request #307: GEODE-1027: add unit test for previously committed ...

[kirklund]

GitHub user kirklund opened a pull request:

https://github.com/apache/geode/pull/307

GEODE-1027: add unit test for previously committed fix

* create new unit tests for MBeanStatsMonitor to test previously committed 
fix for GEODE-1027
* remove unnecessary final modifier from class and methods in 
StatisticsMonitor and ValueMonitor
* update logging in MBeanStatsMonitor
* change couple methods in SampleCollector from public to package
* clean up StatisticsMonitor
* clean up ValueMonitor
* clean up MBeanStatsMonitor


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kirklund/geode feature/GEODE-1027

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #307


commit 65e5450ccc3556774589867627c19cc2842f0fa5
Author: Kirk Lund 
Date:   2016-12-07T23:33:51Z

GEODE-1027: add unit test for previously committed fix




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Volunteer Needed For Creating Monthly Report

[Dan Smith]

Hi Mark,

You've been working hard enough on the transition to TLP! I can take a
crack at this. Do you know if we should be including information since we
last reported to the incubator board, or just since we became a TLP?

-Dan

On Thu, Dec 8, 2016 at 2:05 PM, Mark Bretl  wrote:

> Would anyone like to volunteer for this?
>
> I will take this on tomorrow if there are no takers.
>
> --Mark
>
> On Mon, Dec 5, 2016 at 10:35 AM, Mark Bretl  wrote:
>
> > Hi Everyone,
> >
> > Its that time again where we need to prepare our status report. As we did
> > with starting in the Incubator, we will be sending monthly reports for
> the
> > first three months (December, January, and February) and then we will
> > report quarterly.
> >
> > The board meeting this month is on December 21, so we need to submit our
> > report by December 14. I have created a page on the Wiki for the report
> > template at [1] to help the volunteer. My hope would be that we can
> > finalize a draft by this Friday, December 9th, then submit the report
> early
> > next week.
> >
> > Best Regards,
> >
> > --Mark
> >
> >
> > [1] https://cwiki.apache.org/confluence/display/GEODE/ASF+
> > Board+Report+Template
> >
>

[jira] [Created] (GEODE-2193) a member is kicked out immediately after joining

[Bruce Schuchardt (JIRA)]

Bruce Schuchardt created GEODE-2193:
---

 Summary: a member is kicked out immediately after joining
 Key: GEODE-2193
 URL: https://issues.apache.org/jira/browse/GEODE-2193
 Project: Geode
  Issue Type: Bug
  Components: membership
Reporter: Bruce Schuchardt
Assignee: Mark Bretl


We have observed a number of cases where a member is kicked out immediately 
after joining.  The problem seems to be this:

1) the member sends a join request to the current coordinator
2) the current coordinator is in the process of shutting down
3) the current coordinator sends a view preparation message admitting the new 
member
4) another member receives the current coordinator's shutdown message and 
initiates becoming the coordinator
5) the new coordinator sends out a membership view that does not include the 
new member
6) the new member receives the prepared view and continues with startup
7) the new member sends startup messages to other members
8) the other members have the new coordinator's view and request removal of the 
new member as being rogue
9) the new coordinator sends a Leave message to the new member, causing it to 
issue a ForcedDisconnect

The old coordinator should not initiate a new view if it is shutting down.  It 
needs to have cancellation & shutdown checks in its view transmission methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (GEODE-2121) add DLockTest, MembershipTest, ClientServerTest, ClientSubscriptionTest and RestAPITest categories

[Bruce Schuchardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt resolved GEODE-2121.
-
Resolution: Fixed

the test categories have been created

> add DLockTest, MembershipTest, ClientServerTest, ClientSubscriptionTest and 
> RestAPITest categories
> --
>
> Key: GEODE-2121
> URL: https://issues.apache.org/jira/browse/GEODE-2121
> Project: Geode
>  Issue Type: Test
>  Components: client queues, client/server, distributed lock service, 
> membership, rest (dev), serialization
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>
> I need these test categories in order to run code-coverage analysis for the 
> components I usually work with.  The categories should be added to the 
> appropriate unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Unable to post reviews on reviews.apache.org

[Dan Smith]

Cool. I just wanted to make sure the base of your diff was a valid
revision. Your git diff command with three dots will generate a diff of
your HEAD against that revision.

That's definitely a valid revision, it's still no develop (no one forced
pushed it!) And I was able to create a review request with the webui using
your command and a branch based on that revision.

One more stupid question - you are creating the request against the geode
repository, right?

I don't think it would be that bad to submit a PR, actually. I've been
wondering if we should start using PRs instead of review requests so it's
easier for contributors to make the transition to committers. PRs also have
the nice property of commenting on related tickets, running travis, etc.

-Dan



On Thu, Dec 8, 2016 at 2:00 PM, Kirk Lund  wrote:

> I'm not sure what it should be but here's the output...
>
> $ git merge-base HEAD origin/develop
> ef7418140b903e73bc3a38d3a86c01349924bd09
>
>
> On Thu, Dec 8, 2016 at 12:49 PM, Dan Smith  wrote:
>
> > What does git merge-base HEAD origin/develop tell you? That's the
> revision
> > it's generated a diff against. You could try fetching from origin and
> > rebasing your branch on origin/develop to help.
> >
> > -Dan
> >
> > On Thu, Dec 8, 2016 at 9:23 AM, Kirk Lund  wrote:
> >
> > > I'm unable to post any reviews for Apache Geode on
> > > https://reviews.apache.org
> > >
> > > I've updated .git/config in my checkout to match the non-incubator URL
> > for
> > > asf git. I've also rebased on latest origin/develop, but every time I
> try
> > > to upload my diff file, I get this error...
> > >
> > > The specified diff file could not be parsed.
> > > Line undefined: error: unable to find
> > > 390fb894c9a9095c87284f7f4389b2aeda090408 fatal: git cat-file
> > > 390fb894c9a9095c87284f7f4389b2aeda090408: bad file
> > >
> > > I generated my diff for feature/GEODE-1027 with this command:
> > >
> > > $ git diff --full-index origin/develop...HEAD > GEODE-1027.diff
> > >
> > > Any ideas what's wrong?
> > >
> > > I could switch to using PRs to review my changes, but that's silly.
> > >
> > > -Kirk
> > >
> >
>

Re: Unable to post reviews on reviews.apache.org

[Jinmei Liao]

Usually, I just ran the following command under in my feature branch:
rbt post --repository geode --tracking-branch=origin/develop
--target-groups=geode

It will post the diff between my branch and develop automatically.

On Thu, Dec 8, 2016 at 12:23 PM, Kirk Lund  wrote:

> The web gui.
>
> On Thu, Dec 8, 2016 at 11:31 AM Anthony Baker  wrote:
>
> > Are you trying to post reviews using `rbt post` or the web gui?
> >
> >
> >
> > Anthony
> >
> >
> >
> >
> >
> > > On Dec 8, 2016, at 9:23 AM, Kirk Lund  wrote:
> >
> > >
> >
> > > I'm unable to post any reviews for Apache Geode on
> >
> > > https://reviews.apache.org
> >
> > >
> >
> > > I've updated .git/config in my checkout to match the non-incubator URL
> > for
> >
> > > asf git. I've also rebased on latest origin/develop, but every time I
> try
> >
> > > to upload my diff file, I get this error...
> >
> > >
> >
> > > The specified diff file could not be parsed.
> >
> > > Line undefined: error: unable to find
> >
> > > 390fb894c9a9095c87284f7f4389b2aeda090408 fatal: git cat-file
> >
> > > 390fb894c9a9095c87284f7f4389b2aeda090408: bad file
> >
> > >
> >
> > > I generated my diff for feature/GEODE-1027 with this command:
> >
> > >
> >
> > > $ git diff --full-index origin/develop...HEAD > GEODE-1027.diff
> >
> > >
> >
> > > Any ideas what's wrong?
> >
> > >
> >
> > > I could switch to using PRs to review my changes, but that's silly.
> >
> > >
> >
> > > -Kirk
> >
> >
> >
> >
>



-- 
Cheers

Jinmei

Review Request 54542: [GEODE-2191] Add a new randomized string serialization test.

[Galen O'Sullivan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54542/
---

Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-2191
https://issues.apache.org/jira/browse/GEODE-2191


Repository: geode


Description
---

* Added a new test that generates random strings, and attempts to serialize and 
deserialize them looking for differences or errors.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/internal/InternalDataSerializerRandomizedJUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/54542/diff/


Testing
---

This is a new test; I've run it both from IntelliJ and as a part of the test 
suite. I filed GEODE-2191 for this; I'm not sure if a new JIRA is strictly 
necessary for any new changes but it does seem to be encouraged.

I don't know of any random string generator that is already available in the 
codebase; had there been one I would have used it rather than rolling my own. 
We could eventually use something like 
[junit-quickcheck](https://github.com/pholser/junit-quickcheck) for these types 
of tests.


Thanks,

Galen O'Sullivan

[jira] [Comment Edited] (GEODE-2192) NPE in GMSLocator

[Hitesh Khamesra (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733255#comment-15733255
 ] 

Hitesh Khamesra edited comment on GEODE-2192 at 12/8/16 8:02 PM:
-

This happened when locator started accepting requests, but services have not 
started yet. This can happen when multiple nodes and locator started 
simultaneously.  And locator started receiving requests from servers before it 
initializes other services.


was (Author: hitesh.khamesra):
This happened when locator started accepting requests, but services have not 
started yet. This can happen when multiple nodes and locator started 
simultaneously. 

> NPE in GMSLocator
> -
>
> Key: GEODE-2192
> URL: https://issues.apache.org/jira/browse/GEODE-2192
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Hitesh Khamesra
>Assignee: Mark Bretl
>
> 22999-1: [severe 2016/12/07 16:36:20.976 EST 
> locatorgemfire2_rs-intTest-rhel7-20
> 16-12-07-21-14-10-client-2_22999  tid=0x18] 
> Exception
>  in processing request from 10.32.111.110
> java.lang.NullPointerException
> at 
> java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)
> at 
> java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006)
> at 
> org.apache.geode.distributed.internal.membership.gms.locator.GMSLocator.processRequest(GMSLocator.java:192)
> at 
> org.apache.geode.distributed.internal.InternalLocator$PrimaryHandler.processRequest(InternalLocator.java:1328)
> at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer$3.run(TcpServer.java:411)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GEODE-2192) NPE in GMSLocator

[Hitesh Khamesra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hitesh Khamesra updated GEODE-2192:
---
Summary: NPE in GMSLocator  (was: NPE in GSMSlocator)

> NPE in GMSLocator
> -
>
> Key: GEODE-2192
> URL: https://issues.apache.org/jira/browse/GEODE-2192
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Hitesh Khamesra
>Assignee: Mark Bretl
>
> 22999-1: [severe 2016/12/07 16:36:20.976 EST 
> locatorgemfire2_rs-intTest-rhel7-20
> 16-12-07-21-14-10-client-2_22999  tid=0x18] 
> Exception
>  in processing request from 10.32.111.110
> java.lang.NullPointerException
> at 
> java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)
> at 
> java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006)
> at 
> org.apache.geode.distributed.internal.membership.gms.locator.GMSLocator.processRequest(GMSLocator.java:192)
> at 
> org.apache.geode.distributed.internal.InternalLocator$PrimaryHandler.processRequest(InternalLocator.java:1328)
> at 
> org.apache.geode.distributed.internal.tcpserver.TcpServer$3.run(TcpServer.java:411)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] geode issue #296: GEODE-2109 : Calling submit on ExecutionService can cause ...

[upthewaterspout]

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/296
  
@deepakddixit I was running ./gradlew test when it failed. What's weird to 
me is that we're not seeing the stack trace from the test for what actually 
failed the test, but I think there's definitely something doing wrong here. 
Maybe it is a bug in SystemErrRule.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2191) Add more randomized tests for PDX string serialization/deserialization.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733106#comment-15733106
 ] 

ASF GitHub Bot commented on GEODE-2191:
---

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/306

[GEODE-2191] Test randomized string serialization/deserialization.

I added this test partly as an exercise in getting used to the Geode 
codebase, and partly because I'd like to see more randomized testing. The 
random string generator isn't perfect (I don't think all codepoints in that 
range are valid), but for our purposes it should be fine.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/incubator-geode 
feature/GEODE-2191

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #306


commit 5cd44dd929545552ad0df1bca3219cd9d80d51cc
Author: Galen O'Sullivan 
Date:   2016-12-08T18:43:55Z

[GEODE-2191] Test randomized string serialization/deserialization.




> Add more randomized tests for PDX string serialization/deserialization.
> ---
>
> Key: GEODE-2191
> URL: https://issues.apache.org/jira/browse/GEODE-2191
> Project: Geode
>  Issue Type: Test
>Reporter: Galen O'Sullivan
>Assignee: Mark Bretl
>
> There are currently a number of tests for `DataSerializer.writeString` and 
> `DataSerializer.readString`, which cover many of the corner cases we expect 
> for string serialization/deserialization, but it would be nice to have 
> randomized testing that generated Unicode strings and verified that they were 
> the same after being serialized and deserialized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] geode pull request #306: [GEODE-2191] Test randomized string serialization/d...

[galen-pivotal]

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/306

[GEODE-2191] Test randomized string serialization/deserialization.

I added this test partly as an exercise in getting used to the Geode 
codebase, and partly because I'd like to see more randomized testing. The 
random string generator isn't perfect (I don't think all codepoints in that 
range are valid), but for our purposes it should be fine.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/incubator-geode 
feature/GEODE-2191

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #306


commit 5cd44dd929545552ad0df1bca3219cd9d80d51cc
Author: Galen O'Sullivan 
Date:   2016-12-08T18:43:55Z

[GEODE-2191] Test randomized string serialization/deserialization.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2191) Add more randomized tests for PDX string serialization/deserialization.

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-2191:

Description: 
There are currently a number of tests for `DataSerializer.writeString` and 
`DataSerializer.readString`, which cover many of the corner cases we expect for 
string serialization/deserialization, but it would be nice to have randomized 
testing that generated Unicode strings and verified that they were the same 
after being serialized and deserialized.


  was:
There are currently a number of tests for InternalDataSerializer, which cover 
many of the corner cases we expect for string serialization/deserialization, 
but it would be nice to have randomized testing that generated Unicode strings 
and verified that they were the same after being serialized and deserialized.



> Add more randomized tests for PDX string serialization/deserialization.
> ---
>
> Key: GEODE-2191
> URL: https://issues.apache.org/jira/browse/GEODE-2191
> Project: Geode
>  Issue Type: Test
>Reporter: Galen O'Sullivan
>Assignee: Mark Bretl
>
> There are currently a number of tests for `DataSerializer.writeString` and 
> `DataSerializer.readString`, which cover many of the corner cases we expect 
> for string serialization/deserialization, but it would be nice to have 
> randomized testing that generated Unicode strings and verified that they were 
> the same after being serialized and deserialized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (GEODE-2191) Add more randomized tests for PDX string serialization/deserialization.

[Galen O'Sullivan (JIRA)]

Galen O'Sullivan created GEODE-2191:
---

 Summary: Add more randomized tests for PDX string 
serialization/deserialization.
 Key: GEODE-2191
 URL: https://issues.apache.org/jira/browse/GEODE-2191
 Project: Geode
  Issue Type: Test
Reporter: Galen O'Sullivan
Assignee: Mark Bretl


There are currently a number of tests for InternalDataSerializer, which cover 
many of the corner cases we expect for string serialization/deserialization, 
but it would be nice to have randomized testing that generated Unicode strings 
and verified that they were the same after being serialized and deserialized.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1923) CI Failure: FixedPRSinglehopDUnitTest.test_FPAmetadataFetch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732911#comment-15732911
 ] 

ASF GitHub Bot commented on GEODE-1923:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/305#discussion_r91569800
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java
 ---
@@ -293,18 +295,24 @@ public void test_FPAmetadataFetch() {
   putIntoPartitionedRegionsThreeQs();
 
   getFromPartitionedRegionsFor3Qs();
-  Wait.pause(2000);
+  Awaitility.await().atMost(15, TimeUnit.SECONDS).until(() ->
+// Server 1 is actually primary for both Q1 and Q2, since there is 
no FPA server with
--- End diff --

@bschuchardt `./gradlew spotlessApply` wants to reduce the indent on this 
comment and the following lines to the same as the previous line... looks like 
a bug with Spotless. I'll just move the comment above the wait.


> CI Failure: FixedPRSinglehopDUnitTest.test_FPAmetadataFetch
> ---
>
> Key: GEODE-1923
> URL: https://issues.apache.org/jira/browse/GEODE-1923
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Eric Shu
>Assignee: Bruce Schuchardt
>  Labels: ci, flaky
>
> java.lang.AssertionError: expected: but was:
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:144)
>   at 
> org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest.updateIntoSinglePR(FixedPRSinglehopDUnitTest.java:765)
>   at 
> org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest.test_FPAmetadataFetch(FixedPRSinglehopDUnitTest.java:339)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> 

[GitHub] geode pull request #305: [GEODE-1923] Fix a test race condition.

[galen-pivotal]

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/305#discussion_r91569800
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java
 ---
@@ -293,18 +295,24 @@ public void test_FPAmetadataFetch() {
   putIntoPartitionedRegionsThreeQs();
 
   getFromPartitionedRegionsFor3Qs();
-  Wait.pause(2000);
+  Awaitility.await().atMost(15, TimeUnit.SECONDS).until(() ->
+// Server 1 is actually primary for both Q1 and Q2, since there is 
no FPA server with
--- End diff --

@bschuchardt `./gradlew spotlessApply` wants to reduce the indent on this 
comment and the following lines to the same as the previous line... looks like 
a bug with Spotless. I'll just move the comment above the wait.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2190) CI Failure: ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732879#comment-15732879
 ] 

ASF subversion and git services commented on GEODE-2190:


Commit 2075ee348e221d662468ead4c18b56923d3d7329 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=2075ee3 ]

GEODE-2190: add FlakyTest category to flaky test


> CI Failure: 
> ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt
> -
>
> Key: GEODE-2190
> URL: https://issues.apache.org/jira/browse/GEODE-2190
> Project: Geode
>  Issue Type: Bug
>  Components: tests, wan
>Affects Versions: 1.1.0
>Reporter: Kirk Lund
>  Labels: CI, Flaky
>
> I've seen this fail multiple times during precheckin.
> {noformat}
> :geode-wan:distributedTest
> org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationDUnitTest 
> > testParallelPropagationWithLocalCacheClosedAndRebuilt FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.wan.WANTestBase$$Lambda$15/754368253.run in 
> VM 6 running on Host f68591f2a480 with 8 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at 
> org.apache.geode.internal.cache.wan.WANTestBase.createCacheInVMs(WANTestBase.java:869)
> at 
> org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt(ParallelWANPropagationDUnitTest.java:295)
> Caused by:
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distributed System is shutting down, caused by 
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
> Caused by:
> 
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 2808
> [fatal 2016/12/08 03:25:16.646 UTC  
> tid=0x2c] Membership service failure: Member isn't responding to heartbeat 
> requests
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
>   at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.forceDisconnect(GMSMembershipManager.java:2520)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:999)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processRemoveRequest(GMSJoinLeave.java:635)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1698)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1286)
>   at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
>   at org.jgroups.JChannel.up(JChannel.java:741)
>   at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
>   at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
>   at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
>   at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1070)
>   at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:785)
>   at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:426)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:74)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:72)
>   at org.jgroups.protocols.TP.passMessageUp(TP.java:1601)
>   at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1817)
>   at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
>   at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1729)
>   at org.jgroups.protocols.TP.receive(TP.java:1654)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:160)
>   at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
>   at 

[jira] [Commented] (GEODE-1923) CI Failure: FixedPRSinglehopDUnitTest.test_FPAmetadataFetch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732858#comment-15732858
 ] 

ASF GitHub Bot commented on GEODE-1923:
---

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/305
  
It looks like you also need to run "./gradlew spotlessApply" to reformat 
your changes.  The Travis build complained that spotlessJavaCheck failed.


> CI Failure: FixedPRSinglehopDUnitTest.test_FPAmetadataFetch
> ---
>
> Key: GEODE-1923
> URL: https://issues.apache.org/jira/browse/GEODE-1923
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Eric Shu
>Assignee: Bruce Schuchardt
>  Labels: ci, flaky
>
> java.lang.AssertionError: expected: but was:
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:144)
>   at 
> org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest.updateIntoSinglePR(FixedPRSinglehopDUnitTest.java:765)
>   at 
> org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest.test_FPAmetadataFetch(FixedPRSinglehopDUnitTest.java:339)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at 

[GitHub] geode issue #305: [GEODE-1923] Fix a test race condition.

[bschuchardt]

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/305
  
It looks like you also need to run "./gradlew spotlessApply" to reformat 
your changes.  The Travis build complained that spotlessJavaCheck failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Unable to post reviews on reviews.apache.org

[Kirk Lund]

I'm unable to post any reviews for Apache Geode on
https://reviews.apache.org

I've updated .git/config in my checkout to match the non-incubator URL for
asf git. I've also rebased on latest origin/develop, but every time I try
to upload my diff file, I get this error...

The specified diff file could not be parsed.
Line undefined: error: unable to find
390fb894c9a9095c87284f7f4389b2aeda090408 fatal: git cat-file
390fb894c9a9095c87284f7f4389b2aeda090408: bad file

I generated my diff for feature/GEODE-1027 with this command:

$ git diff --full-index origin/develop...HEAD > GEODE-1027.diff

Any ideas what's wrong?

I could switch to using PRs to review my changes, but that's silly.

-Kirk

[jira] [Commented] (GEODE-1923) CI Failure: FixedPRSinglehopDUnitTest.test_FPAmetadataFetch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732801#comment-15732801
 ] 

ASF GitHub Bot commented on GEODE-1923:
---

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/305

[GEODE-1923] Fix a test race condition.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/incubator-geode 
feature/GEODE-1923

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/305.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #305


commit 8373c0d9152bfe52fc8a9094e9a6e316aa498e9f
Author: Galen O'Sullivan 
Date:   2016-12-07T20:23:46Z

[GEODE-1923] Fix a test race condition.




> CI Failure: FixedPRSinglehopDUnitTest.test_FPAmetadataFetch
> ---
>
> Key: GEODE-1923
> URL: https://issues.apache.org/jira/browse/GEODE-1923
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Eric Shu
>Assignee: Bruce Schuchardt
>  Labels: ci, flaky
>
> java.lang.AssertionError: expected: but was:
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:118)
>   at org.junit.Assert.assertEquals(Assert.java:144)
>   at 
> org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest.updateIntoSinglePR(FixedPRSinglehopDUnitTest.java:765)
>   at 
> org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest.test_FPAmetadataFetch(FixedPRSinglehopDUnitTest.java:339)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> 

[jira] [Commented] (GEODE-2179) GatewaySenderMBeans isConnected flag does not notice if a connection is destroyed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732782#comment-15732782
 ] 

ASF subversion and git services commented on GEODE-2179:


Commit 0494b31caf6f43cec85660fd8d939f2b1c6739c2 in geode's branch 
refs/heads/feature/GEODE-1027 from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0494b31 ]

GEODE-2179 - Checking for disconnected connection in GatewaySenderMBean

Making sure that the mbean returns false for isConnected if the gateway
is not actually connected to the remote side.


> GatewaySenderMBeans isConnected flag does not notice if a connection is 
> destroyed
> -
>
> Key: GEODE-2179
> URL: https://issues.apache.org/jira/browse/GEODE-2179
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Dan Smith
>Assignee: Dan Smith
> Fix For: 1.1.0
>
>
> The GatewaySenderMBean has a method called isConnected which ultimately calls 
> this code in GatewaySenderEventRemoteDispatcher
> {code}
> @Override
> public boolean isConnectedToRemote() {
>   return connection != null;
> }
> {code}
> However, this doesn't take into account that the connection may be destroyed, 
> but not null. Therefore the mbean can incorrectly indicate that the sender is 
> connected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-734) gfsh export stack-traces should not require an output file with extension .txt

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732785#comment-15732785
 ] 

ASF subversion and git services commented on GEODE-734:
---

Commit 903135115a0466d86fa663e965ace3ff47eba6b4 in geode's branch 
refs/heads/feature/GEODE-1027 from [~deepakddixit]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9031351 ]

GEODE-734: Remove txt file restriction when exporting stack traces

Adding throws clause to signature instead of catching it in Test.

Separating test scenarios into multiple test cases. Creating files in
TemporaryFolder.

Applying spotless checks

Updated export stack-traces in controller. Removed compulsory file
option. If file is not provided then name is generated. Added one
boolean option fail-if-file-present, if true and file already exists
then command will fail.

Updated Offline help file.

Added test cases to verify new added options

Removed compulsory file option. If file is not provided then name is
generated. Added one boolean option fail-if-file-present, if true and
file already exists then command will fail.

Added message warning user about possible overwrite of file if already
present.

Added test to check if non txt extension file is allowed.

This closes #297


> gfsh export stack-traces should not require an output file with extension .txt
> --
>
> Key: GEODE-734
> URL: https://issues.apache.org/jira/browse/GEODE-734
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Jens Deppe
>
> gfsh {{export stack-traces}} requires a file with a {{.txt}} extension:
> {noformat}
> gfsh>export stack-traces --file=/tmp/trace.log
> Invalid file type, the file extension must be ".txt"
> {noformat}
> This seems like a totally arbitrary restriction. Please can it be removed.
> If the concern is that an existing file might be overwritten then we should 
> have a user prompt indicating that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1027) MBeans should be initialized with current stats when they are created.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732788#comment-15732788
 ] 

ASF subversion and git services commented on GEODE-1027:


Commit 65e5450ccc3556774589867627c19cc2842f0fa5 in geode's branch 
refs/heads/feature/GEODE-1027 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=65e5450 ]

GEODE-1027: add unit test for previously committed fix


> MBeans should be initialized with current stats when they are created.
> --
>
> Key: GEODE-1027
> URL: https://issues.apache.org/jira/browse/GEODE-1027
> Project: Geode
>  Issue Type: Improvement
>  Components: jmx
>Affects Versions: 1.0.0-incubating
>Reporter: Jens Deppe
>Assignee: Kirk Lund
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1835) A message logged by the configure pdx command is incorrect

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732787#comment-15732787
 ] 

ASF subversion and git services commented on GEODE-1835:


Commit ef7418140b903e73bc3a38d3a86c01349924bd09 in geode's branch 
refs/heads/feature/GEODE-1027 from [~abarve]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ef74181 ]

GEODE-1835 : unit test to verify a warning message by the configure pdx
command only when there are members in the distributed system.

This closes #304


> A message logged by the configure pdx command is incorrect
> --
>
> Key: GEODE-1835
> URL: https://issues.apache.org/jira/browse/GEODE-1835
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Barry Oglesby
>Assignee: Amey Barve
>
> The message below is only logged when there are no members. Instead, it 
> should be logged when there are members.
> {noformat}
> The command would only take effect on new data members joining the 
> distributed system. It won't affect the existing data members
> {noformat}
> The condition in {{PDXCommands.configurePDX}} is:
> {noformat}
> if (CliUtil.getAllNormalMembers(CliUtil.getCacheIfExists()).isEmpty()) {
>   ird.addLine(CliStrings.CONFIGURE_PDX__NORMAL__MEMBERS__WARNING);
> }
> {noformat}
> It should test for {{!isEmpty}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1835) A message logged by the configure pdx command is incorrect

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732786#comment-15732786
 ] 

ASF subversion and git services commented on GEODE-1835:


Commit 28efd90290b519d9fe531c826ee4c6e606bcd8e4 in geode's branch 
refs/heads/feature/GEODE-1027 from [~abarve]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=28efd90 ]

GEODE-1835 : logging a warning message by the configure pdx command only
when there are members in the distributed system.


> A message logged by the configure pdx command is incorrect
> --
>
> Key: GEODE-1835
> URL: https://issues.apache.org/jira/browse/GEODE-1835
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Barry Oglesby
>Assignee: Amey Barve
>
> The message below is only logged when there are no members. Instead, it 
> should be logged when there are members.
> {noformat}
> The command would only take effect on new data members joining the 
> distributed system. It won't affect the existing data members
> {noformat}
> The condition in {{PDXCommands.configurePDX}} is:
> {noformat}
> if (CliUtil.getAllNormalMembers(CliUtil.getCacheIfExists()).isEmpty()) {
>   ird.addLine(CliStrings.CONFIGURE_PDX__NORMAL__MEMBERS__WARNING);
> }
> {noformat}
> It should test for {{!isEmpty}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2004) Create/update/delete query through rest api should require DATA:READ instead of DATA:WRITE

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732781#comment-15732781
 ] 

ASF subversion and git services commented on GEODE-2004:


Commit 1d34eeb9f6217a4375590094166e5b81a820abae in geode's branch 
refs/heads/feature/GEODE-1027 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1d34eeb ]

GEODE-2004: [doc update] change to a permission for REST-initiated queries. 
Updated error messages.


> Create/update/delete query through rest api should require DATA:READ instead 
> of DATA:WRITE
> --
>
> Key: GEODE-2004
> URL: https://issues.apache.org/jira/browse/GEODE-2004
> Project: Geode
>  Issue Type: Bug
>  Components: docs, management, security
>Affects Versions: 1.0.0-incubating
>Reporter: Jinmei Liao
>Assignee: Kevin Duling
> Fix For: 1.0.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-2092) Security examples should not be in product package

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732780#comment-15732780
 ] 

ASF subversion and git services commented on GEODE-2092:


Commit 22ec6a789a1cbf64e1d7677078558e17efb0c668 in geode's branch 
refs/heads/feature/GEODE-1027 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=22ec6a7 ]

GEODE-2092 Update docs with security examples location


> Security examples should not be in product package
> --
>
> Key: GEODE-2092
> URL: https://issues.apache.org/jira/browse/GEODE-2092
> Project: Geode
>  Issue Type: Bug
>  Components: docs, security
>Affects Versions: 1.0.0-incubating
>Reporter: Kirk Lund
>Assignee: Kevin Duling
>
> These three classes are currently in geode-core product package which implies 
> they are fully supported user API. They cannot be released in a user API 
> package. 
> 1) Move the security examples to examples package within geode-core
> * 
> geode-core/src/main/java/org/apache/geode/security/templates/SampleSecurityManager.java
> * 
> geode-core/src/main/java/org/apache/geode/security/templates/SamplePostProcessor.java
> To:
> * 
> geode-core/src/main/java/org/apache/geode/security/examples/ExampleSecurityManager.java
> * 
> geode-core/src/main/java/org/apache/geode/security/examples/ExamplePostProcessor.java
> Delete this one (it should only exist in some GitHub application for demoing):
> * 
> geode-core/src/main/java/org/apache/geode/security/templates/SimpleSecurityManager.java
> 2) We have geode-core tests that use the security examples. These tests must 
> be altered to use new classes that implement SecurityManager and 
> PostProcessor. These new classes need to live under 
> geode-core/src/tests/java/org/apache/geode/security.
> I also see 
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RedactingPostProcessor.java
>  with javadocs indicating that it is an example. Either a) remove the 
> javadocs saying it's an example or b) move it to 
> geode-core/src/main/java/org/apache/geode/security/examples and then create a 
> new implementation of PostProcessor which the rest tests will use.
> End results should be:
> a) all examples live in either geode-examples or 
> geode-core/src/main/java/org/apache/geode/security/examples
> b) no tests should be using the examples, they should be using test specific 
> implementations under geode-core/src/tests/java
> c) no demoing code should be GEODE -- such code belongs in GitHub or other 
> project repos -- for a really good example, please see:
> * https://github.com/spring-projects/spring-gemfire-examples
> * 
> https://github.com/spring-projects/spring-gemfire-examples/tree/master/quickstart/repository
> If anyone needs help creating an example repo outside of GEODE, then please 
> discuss this on geode dev mailing list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1835) A message logged by the configure pdx command is incorrect

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732773#comment-15732773
 ] 

ASF subversion and git services commented on GEODE-1835:


Commit 28efd90290b519d9fe531c826ee4c6e606bcd8e4 in geode's branch 
refs/heads/develop from [~abarve]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=28efd90 ]

GEODE-1835 : logging a warning message by the configure pdx command only
when there are members in the distributed system.


> A message logged by the configure pdx command is incorrect
> --
>
> Key: GEODE-1835
> URL: https://issues.apache.org/jira/browse/GEODE-1835
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Barry Oglesby
>Assignee: Amey Barve
>
> The message below is only logged when there are no members. Instead, it 
> should be logged when there are members.
> {noformat}
> The command would only take effect on new data members joining the 
> distributed system. It won't affect the existing data members
> {noformat}
> The condition in {{PDXCommands.configurePDX}} is:
> {noformat}
> if (CliUtil.getAllNormalMembers(CliUtil.getCacheIfExists()).isEmpty()) {
>   ird.addLine(CliStrings.CONFIGURE_PDX__NORMAL__MEMBERS__WARNING);
> }
> {noformat}
> It should test for {{!isEmpty}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] geode pull request #304: GEODE-1835: A message logged by the configure pdx c...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/304


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-734) gfsh export stack-traces should not require an output file with extension .txt

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732697#comment-15732697
 ] 

ASF subversion and git services commented on GEODE-734:
---

Commit 903135115a0466d86fa663e965ace3ff47eba6b4 in geode's branch 
refs/heads/develop from [~deepakddixit]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9031351 ]

GEODE-734: Remove txt file restriction when exporting stack traces

Adding throws clause to signature instead of catching it in Test.

Separating test scenarios into multiple test cases. Creating files in
TemporaryFolder.

Applying spotless checks

Updated export stack-traces in controller. Removed compulsory file
option. If file is not provided then name is generated. Added one
boolean option fail-if-file-present, if true and file already exists
then command will fail.

Updated Offline help file.

Added test cases to verify new added options

Removed compulsory file option. If file is not provided then name is
generated. Added one boolean option fail-if-file-present, if true and
file already exists then command will fail.

Added message warning user about possible overwrite of file if already
present.

Added test to check if non txt extension file is allowed.

This closes #297


> gfsh export stack-traces should not require an output file with extension .txt
> --
>
> Key: GEODE-734
> URL: https://issues.apache.org/jira/browse/GEODE-734
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Jens Deppe
>
> gfsh {{export stack-traces}} requires a file with a {{.txt}} extension:
> {noformat}
> gfsh>export stack-traces --file=/tmp/trace.log
> Invalid file type, the file extension must be ".txt"
> {noformat}
> This seems like a totally arbitrary restriction. Please can it be removed.
> If the concern is that an existing file might be overwritten then we should 
> have a user prompt indicating that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-734) gfsh export stack-traces should not require an output file with extension .txt

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732698#comment-15732698
 ] 

ASF GitHub Bot commented on GEODE-734:
--

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/297


> gfsh export stack-traces should not require an output file with extension .txt
> --
>
> Key: GEODE-734
> URL: https://issues.apache.org/jira/browse/GEODE-734
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Jens Deppe
>
> gfsh {{export stack-traces}} requires a file with a {{.txt}} extension:
> {noformat}
> gfsh>export stack-traces --file=/tmp/trace.log
> Invalid file type, the file extension must be ".txt"
> {noformat}
> This seems like a totally arbitrary restriction. Please can it be removed.
> If the concern is that an existing file might be overwritten then we should 
> have a user prompt indicating that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] geode pull request #297: GEODE-734: gfsh export stack-traces should not requ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/297


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (GEODE-2190) CI Failure: ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2190:
-
Assignee: (was: Mark Bretl)

> CI Failure: 
> ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt
> -
>
> Key: GEODE-2190
> URL: https://issues.apache.org/jira/browse/GEODE-2190
> Project: Geode
>  Issue Type: Bug
>  Components: tests, wan
>Affects Versions: 1.1.0
>Reporter: Kirk Lund
>  Labels: CI, Flaky
>
> I've seen this fail multiple times during precheckin.
> {noformat}
> :geode-wan:distributedTest
> org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationDUnitTest 
> > testParallelPropagationWithLocalCacheClosedAndRebuilt FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.wan.WANTestBase$$Lambda$15/754368253.run in 
> VM 6 running on Host f68591f2a480 with 8 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at 
> org.apache.geode.internal.cache.wan.WANTestBase.createCacheInVMs(WANTestBase.java:869)
> at 
> org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt(ParallelWANPropagationDUnitTest.java:295)
> Caused by:
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distributed System is shutting down, caused by 
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
> Caused by:
> 
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 2808
> [fatal 2016/12/08 03:25:16.646 UTC  
> tid=0x2c] Membership service failure: Member isn't responding to heartbeat 
> requests
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
>   at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.forceDisconnect(GMSMembershipManager.java:2520)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:999)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processRemoveRequest(GMSJoinLeave.java:635)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1698)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1286)
>   at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
>   at org.jgroups.JChannel.up(JChannel.java:741)
>   at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
>   at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
>   at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
>   at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1070)
>   at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:785)
>   at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:426)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:74)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:72)
>   at org.jgroups.protocols.TP.passMessageUp(TP.java:1601)
>   at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1817)
>   at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
>   at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1729)
>   at org.jgroups.protocols.TP.receive(TP.java:1654)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:160)
>   at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
>   at java.lang.Thread.run(Thread.java:745)
> ---
> Found suspect string in log4j at line 2836
> [error 2016/12/08 03:25:17.132 UTC  
> tid=0x1e] 
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distributed 

[jira] [Updated] (GEODE-2190) CI Failure: ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2190:
-
Labels: CI Flaky  (was: )

> CI Failure: 
> ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt
> -
>
> Key: GEODE-2190
> URL: https://issues.apache.org/jira/browse/GEODE-2190
> Project: Geode
>  Issue Type: Bug
>  Components: tests, wan
>Affects Versions: 1.1.0
>Reporter: Kirk Lund
>  Labels: CI, Flaky
>
> I've seen this fail multiple times during precheckin.
> {noformat}
> :geode-wan:distributedTest
> org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationDUnitTest 
> > testParallelPropagationWithLocalCacheClosedAndRebuilt FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.wan.WANTestBase$$Lambda$15/754368253.run in 
> VM 6 running on Host f68591f2a480 with 8 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at 
> org.apache.geode.internal.cache.wan.WANTestBase.createCacheInVMs(WANTestBase.java:869)
> at 
> org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt(ParallelWANPropagationDUnitTest.java:295)
> Caused by:
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distributed System is shutting down, caused by 
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
> Caused by:
> 
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 2808
> [fatal 2016/12/08 03:25:16.646 UTC  
> tid=0x2c] Membership service failure: Member isn't responding to heartbeat 
> requests
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
>   at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.forceDisconnect(GMSMembershipManager.java:2520)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:999)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processRemoveRequest(GMSJoinLeave.java:635)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1698)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1286)
>   at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
>   at org.jgroups.JChannel.up(JChannel.java:741)
>   at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
>   at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
>   at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
>   at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1070)
>   at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:785)
>   at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:426)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:74)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:72)
>   at org.jgroups.protocols.TP.passMessageUp(TP.java:1601)
>   at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1817)
>   at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
>   at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1729)
>   at org.jgroups.protocols.TP.receive(TP.java:1654)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:160)
>   at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
>   at java.lang.Thread.run(Thread.java:745)
> ---
> Found suspect string in log4j at line 2836
> [error 2016/12/08 03:25:17.132 UTC  
> tid=0x1e] 
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distributed System is 

[jira] [Updated] (GEODE-2190) CI Failure: ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2190:
-
Summary: CI Failure: 
ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt
  (was: CI Failure: 
ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt
 fails )

> CI Failure: 
> ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt
> -
>
> Key: GEODE-2190
> URL: https://issues.apache.org/jira/browse/GEODE-2190
> Project: Geode
>  Issue Type: Bug
>  Components: tests, wan
>Affects Versions: 1.1.0
>Reporter: Kirk Lund
>Assignee: Mark Bretl
>  Labels: CI, Flaky
>
> I've seen this fail multiple times during precheckin.
> {noformat}
> :geode-wan:distributedTest
> org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationDUnitTest 
> > testParallelPropagationWithLocalCacheClosedAndRebuilt FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.wan.WANTestBase$$Lambda$15/754368253.run in 
> VM 6 running on Host f68591f2a480 with 8 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
> at 
> org.apache.geode.internal.cache.wan.WANTestBase.createCacheInVMs(WANTestBase.java:869)
> at 
> org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt(ParallelWANPropagationDUnitTest.java:295)
> Caused by:
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distributed System is shutting down, caused by 
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
> Caused by:
> 
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 2808
> [fatal 2016/12/08 03:25:16.646 UTC  
> tid=0x2c] Membership service failure: Member isn't responding to heartbeat 
> requests
> org.apache.geode.ForcedDisconnectException: Member isn't responding to 
> heartbeat requests
>   at 
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.forceDisconnect(GMSMembershipManager.java:2520)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:999)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processRemoveRequest(GMSJoinLeave.java:635)
>   at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1698)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1286)
>   at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
>   at org.jgroups.JChannel.up(JChannel.java:741)
>   at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
>   at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
>   at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
>   at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1070)
>   at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:785)
>   at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:426)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:74)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:72)
>   at org.jgroups.protocols.TP.passMessageUp(TP.java:1601)
>   at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1817)
>   at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
>   at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1729)
>   at org.jgroups.protocols.TP.receive(TP.java:1654)
>   at 
> org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:160)
>   at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
>   at java.lang.Thread.run(Thread.java:745)
> 

[jira] [Created] (GEODE-2190) CI Failure: ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt fails

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-2190:


 Summary: CI Failure: 
ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt
 fails 
 Key: GEODE-2190
 URL: https://issues.apache.org/jira/browse/GEODE-2190
 Project: Geode
  Issue Type: Bug
  Components: tests, wan
Reporter: Kirk Lund
Assignee: Mark Bretl


I've seen this fail multiple times during precheckin.
{noformat}
:geode-wan:distributedTest

org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationDUnitTest > 
testParallelPropagationWithLocalCacheClosedAndRebuilt FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.wan.WANTestBase$$Lambda$15/754368253.run in VM 
6 running on Host f68591f2a480 with 8 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:344)
at org.apache.geode.test.dunit.VM.invoke(VM.java:314)
at org.apache.geode.test.dunit.VM.invoke(VM.java:259)
at 
org.apache.geode.internal.cache.wan.WANTestBase.createCacheInVMs(WANTestBase.java:869)
at 
org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationDUnitTest.testParallelPropagationWithLocalCacheClosedAndRebuilt(ParallelWANPropagationDUnitTest.java:295)

Caused by:
org.apache.geode.distributed.DistributedSystemDisconnectedException: 
Distributed System is shutting down, caused by 
org.apache.geode.distributed.DistributedSystemDisconnectedException: 
org.apache.geode.ForcedDisconnectException: Member isn't responding to 
heartbeat requests

Caused by:

org.apache.geode.distributed.DistributedSystemDisconnectedException: 
org.apache.geode.ForcedDisconnectException: Member isn't responding to 
heartbeat requests

java.lang.AssertionError: Suspicious strings were written to the log during 
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 2808

[fatal 2016/12/08 03:25:16.646 UTC  
tid=0x2c] Membership service failure: Member isn't responding to heartbeat 
requests
org.apache.geode.ForcedDisconnectException: Member isn't responding to 
heartbeat requests
at 
org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.forceDisconnect(GMSMembershipManager.java:2520)
at 
org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:999)
at 
org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processRemoveRequest(GMSJoinLeave.java:635)
at 
org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1698)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1286)
at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
at org.jgroups.JChannel.up(JChannel.java:741)
at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1070)
at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:785)
at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:426)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:74)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:72)
at org.jgroups.protocols.TP.passMessageUp(TP.java:1601)
at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1817)
at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1729)
at org.jgroups.protocols.TP.receive(TP.java:1654)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:160)
at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
at java.lang.Thread.run(Thread.java:745)

---
Found suspect string in log4j at line 2836

[error 2016/12/08 03:25:17.132 UTC  
tid=0x1e] org.apache.geode.distributed.DistributedSystemDisconnectedException: 
Distributed System is shutting down, caused by 
org.apache.geode.distributed.DistributedSystemDisconnectedException: 
org.apache.geode.ForcedDisconnectException: Member isn't responding to 
heartbeat requests

org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderOperation_2_DUnitTest
 > shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread FAILED

[jira] [Commented] (GEODE-2109) calling submit on ExecutionService can cause exceptions to be lost

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732339#comment-15732339
 ] 

ASF GitHub Bot commented on GEODE-2109:
---

Github user deepakddixit commented on the issue:

https://github.com/apache/geode/pull/296
  
@upthewaterspout It looks like from IDE when we run all tests under 
UnitTest category above test fails. But when we run either :geode-core:test 
target or complete precheckin I never observed such failure. I have observed 
that in IDE, SystemErrRule.getLog is not populated from thrown exception. 


> calling submit on ExecutionService can cause exceptions to be lost
> --
>
> Key: GEODE-2109
> URL: https://issues.apache.org/jira/browse/GEODE-2109
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Darrel Schneider
>
> Geode has a number of places that call submit on ExecutionService. The submit 
> method returns a Future object. If the caller makes sure it calls "get" on 
> the Future then all is well. But in many places geode is not calling get. In 
> that case if the Runnable that was submitted throws an exception it gets 
> stored in the get and never logged. This can make it very hard to diagnose 
> problems.
> If the caller does not want to call get on the returned Future then it should 
> instead call the "execute" method. In that case the exception will be 
> unhandled and the unhandled exception handler code we have on the 
> LoggingThreadGroup class will cause the exception to be logged.
> Here are the places that should be changed to use execute instead of submit:
> org.apache.geode.internal.util.concurrent.CustomEntryConcurrentHashMap.clear()
> org.apache.geode.internal.cache.DiskStoreImpl.executeDiskStoreTask(Runnable)
> org.apache.geode.internal.cache.lru.HeapEvictor.onEvent(MemoryEvent)
> org.apache.geode.distributed.internal.InternalLocator.restartWithDS(InternalDistributedSystem,
>  GemFireCacheImpl)
> org.apache.geode.distributed.internal.FunctionExecutionPooledExecutor.FunctionExecutionPooledExecutor(BlockingQueue,
>  int, PoolStatHelper, ThreadFactory, int, boolean)
> org.apache.geode.internal.cache.PRHARedundancyProvider.scheduleCreateMissingBuckets()
> org.apache.geode.distributed.internal.InternalLocator.startSharedConfigurationService(GemFireCacheImpl)
> org.apache.geode.cache.client.internal.SingleHopClientExecutor.submitTask(Runnable)
> org.apache.geode.management.internal.FederatingManager.submitTask(Callable)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)