date:20170213

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/7#discussion_r100958376
  
--- Diff: src/dependencies/xerces-c/CMakeLists.txt ---
@@ -32,10 +32,10 @@ if (WIN32)
 set( _BUILD_DIR Build/Win32/VC${MSVC_VERSION}/${_DEBUG_OR_RELEASE} )
   endif()
 
-  if (MSVC_VERSION GREATER 12)
-# Only have project files for VS12 and older
-set(MSVC_VERSION 12)
-  endiF()
+  #if (MSVC_VERSION GREATER 12)
--- End diff --

Also, if we are removing code we should remove it, not comment it out. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #7: Feature/geode 2467

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/7#discussion_r100958307
  
--- Diff: src/dependencies/xerces-c/CMakeLists.txt ---
@@ -32,10 +32,10 @@ if (WIN32)
 set( _BUILD_DIR Build/Win32/VC${MSVC_VERSION}/${_DEBUG_OR_RELEASE} )
   endif()
 
-  if (MSVC_VERSION GREATER 12)
-# Only have project files for VS12 and older
-set(MSVC_VERSION 12)
-  endiF()
+  #if (MSVC_VERSION GREATER 12)
--- End diff --

xerces-c does not have project files for VC>14. You should limit the 
MSVC_VERSION locally in the module to 14 otherwise xerces-c will not compile. 
See the `projects\Win32\` directory in the xerces-c distribution for list of 
supported VC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56633/#review165438
---




geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/NetstatFunction.java
 (line 116)


It turns out that -e is not a valid option on Mac OS!

If I execute netstat on Mac OS without --with-lsof, then the output is 
simply:

gfsh>netstat
##
Host: 192.168.1.12
OS: Mac OS X 10.11.6 x86_64
Member(s):
 loc1
##

NetstatDUnitTest passes on Mac, and there's no sign of any failures in gfsh 
or the locator/member logs. If I debug though I find that the netstat command 
does fail. Executing the same string manually shows us why:

/Users/klund/dev/gemfire/open [1948]$ netstat -v 
-a -e
netstat: illegal option -- e
Usage:  netstat [-AaLlnW] [-f address_family | -p protocol]
netstat [-gilns] [-f address_family]
netstat -i | -I interface [-w wait] [-abdgRtS]
netstat -s [-s] [-f address_family | -p protocol] [-w wait]
netstat -i | -I interface -s [-f address_family | -p protocol]
netstat -m [-m]
netstat -r [-Aaln] [-f address_family]
netstat -rs [-s]

So two problems here: 1) it's broken on Mac, 2) we clearly don't have test 
coverage to verify that netstat command works or not. So we'll need to fix up 
NetstatDUnit and probaby add soem integration tests as well.


- Kirk Lund


On Feb. 14, 2017, 2:31 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56633/
> ---
> 
> (Updated Feb. 14, 2017, 2:31 a.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Ken 
> Howe.
> 
> 
> Bugs: GEODE-2474
> https://issues.apache.org/jira/browse/GEODE-2474
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2474: refactor code to use SystemUtils to read OS system props
> 
> Centralize OS system property reading in SystemUtils.
> 
> Refactor NetstatFunction and GemFireVersion to use SystemUtils.
> 
> This fixes use of --with-lsof on Mac (manually tested). I'll add new tests to 
> NetstatDUnitTest and a new integration test for netstat command in a 
> follow-up commit & review.
> 
> I have several changes on feature/GEODE-2474 branch which I'll separate into 
> multiple reviews. I'll do a final precheckin on the entire branch and then 
> merge the changes in after everything passes review and precheckin.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/GemFireVersion.java 
> 26d4fb3c5705bffdcdbbc6c261dbe9ffd297642e 
>   geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 
> 66c158c93fecac4feb2da56f617f5efc7bba56e1 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/NetstatFunction.java
>  5fa30f47187972a209a781eae9024957dc80fb72 
>   
> geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
>  48f176eabc18d3ffa56daaa7da12634a9554f39d 
> 
> Diff: https://reviews.apache.org/r/56633/diff/
> 
> 
> Testing
> ---
> 
> SystemUtilsJUnitTest
> NetstatDUnitTest
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[jira] [Commented] (GEODE-2467) Support Newer Versions of Visual Studio

2017-02-13 Thread Jacob S. Barrett (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865025#comment-15865025
 ] 

Jacob S. Barrett commented on GEODE-2467:
-

Are you intending to break VS 2013 or just ensure that 2015 and 2017 work as 
well?

> Support Newer Versions of Visual Studio
> ---
>
> Key: GEODE-2467
> URL: https://issues.apache.org/jira/browse/GEODE-2467
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Michael Martell
>
> This task is to support building the native client with newer versions of 
> Visual Studio including VS 2015 and VS 2017.
> Reasons include:
> 1) with 2017 release date of March 7 just announced, this makes a 2013 basd 
> build really old
> 2) stronger C++11/14/17 support
> 3) dotNetty requires newer tool chains, and nice to use a single tool
> 4) much better built-in git support
> 5) there are no source changes required, only tweak is to xerces 
> CMakeLists.txt



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56637: refactor ServerStarterRule and LocatorStarterRule so that they can be created without a Properties first.

2017-02-13 Thread Jinmei Liao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56637/
---

(Updated Feb. 14, 2017, 4:14 a.m.)


Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk Lund.


Repository: geode


Description
---

refactor ServerStarterRule and LocatorStarterRule so that they can be created 
without a Properties first.

* this would ease the usage of thsee rules, so that it can always be used as a 
rule and users don't have to worry about stopping the locator/server manually.


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityWithSSLTest.java
 2fd6771e24a0a1c2b0450348845dbd9ee36e4d38 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerStartupRule.java
 07e82c319dac25a3d0997d5ea9419127db171487 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/MemberMBeanSecurityJUnitTest.java
 33b32e9f720319b9ddbf70d5ab21c688897e1210 
  
geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java
 d202b768f14d6ada6c94700df417b733a49c8d8b 
  
geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
 23ffa9a9e5eb403742d31db042b3d0b59f095400 
  
geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java
 fcda2a322e31f5bcd00f922adb9fe7332e2073ef 
  
geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java
 3add1abe0c14b7948716bce44c0ad7b4dbebd2ea 
  
geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java
 8a797022b05c5e3d24599639b5a44830cf669f25 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 0ac459c96cb6e588e016de67fa5b827e62fdcfa0 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterRule.java
 00a0f1e580d17417004e4462ff42c3364522550c 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
 f93498fcbcea0ec8d8f0b91a0367e9b6fb7d4ae1 
  geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDunitTest.java 
1aa275d0cda7b7dcf9de9fe2837d48491bebfcfa 

Diff: https://reviews.apache.org/r/56637/diff/


Testing (updated)
---

precheckin successful


Thanks,

Jinmei Liao

[jira] [Commented] (GEODE-2470) Remove Dependency on sed tool


[ 
https://issues.apache.org/jira/browse/GEODE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865018#comment-15865018
 ] 

ASF GitHub Bot commented on GEODE-2470:
---

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/6#discussion_r100956921
  
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void 
CacheHelper::createDuplicateXMLFile(std::string& originalFile,
  CacheHelper::staticConfigFileList.size());
 }
 
+void CacheHelper::replacePortsInFile(int hostPort1, int hostPort2,
+ int hostPort3, int hostPort4, int 
locPort1,
+ int locPort2, const std::string& 
inFile,
+ const std::string& outFile) {
+  std::ifstream in(inFile, std::ios::in | std::ios::binary);
+  if (in) {
+std::string contents;
+in.seekg(0, std::ios::end);
+contents.resize(in.tellg());
+in.seekg(0, std::ios::beg);
+in.read([0], contents.size());
--- End diff --

```
contents.assign((std::istreambuf_iterator(in)),
std::istreambuf_iterator());
```


> Remove Dependency on sed tool
> -
>
> Key: GEODE-2470
> URL: https://issues.apache.org/jira/browse/GEODE-2470
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Martell
>
> The integration tests currently rely on sed to replace strings inside config 
> xml files. This task replaces that dependency with standard C++ code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2470) Remove Dependency on sed tool


[ 
https://issues.apache.org/jira/browse/GEODE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865019#comment-15865019
 ] 

ASF GitHub Bot commented on GEODE-2470:
---

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/6#discussion_r100956809
  
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void 
CacheHelper::createDuplicateXMLFile(std::string& originalFile,
  CacheHelper::staticConfigFileList.size());
 }
 
+void CacheHelper::replacePortsInFile(int hostPort1, int hostPort2,
+ int hostPort3, int hostPort4, int 
locPort1,
+ int locPort2, const std::string& 
inFile,
+ const std::string& outFile) {
+  std::ifstream in(inFile, std::ios::in | std::ios::binary);
+  if (in) {
+std::string contents;
+in.seekg(0, std::ios::end);
+contents.resize(in.tellg());
--- End diff --

I think you want `reserve()`. `resize()` causes the string to be resized 
and initialized with `CharT()`. `reserve()` just allocates enough capacity but 
does not resize or initialize the string.




> Remove Dependency on sed tool
> -
>
> Key: GEODE-2470
> URL: https://issues.apache.org/jira/browse/GEODE-2470
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Martell
>
> The integration tests currently rely on sed to replace strings inside config 
> xml files. This task replaces that dependency with standard C++ code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2470) Remove Dependency on sed tool


[ 
https://issues.apache.org/jira/browse/GEODE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865017#comment-15865017
 ] 

ASF GitHub Bot commented on GEODE-2470:
---

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/6#discussion_r100957079
  
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void 
CacheHelper::createDuplicateXMLFile(std::string& originalFile,
  CacheHelper::staticConfigFileList.size());
 }
 
+void CacheHelper::replacePortsInFile(int hostPort1, int hostPort2,
+ int hostPort3, int hostPort4, int 
locPort1,
+ int locPort2, const std::string& 
inFile,
+ const std::string& outFile) {
+  std::ifstream in(inFile, std::ios::in | std::ios::binary);
+  if (in) {
+std::string contents;
+in.seekg(0, std::ios::end);
+contents.resize(in.tellg());
+in.seekg(0, std::ios::beg);
+in.read([0], contents.size());
+in.close();
+
+contents = std::regex_replace(contents, std::regex("HOST_PORT1"), 
std::to_string(hostPort1));
+contents = std::regex_replace(contents, std::regex("HOST_PORT2"), 
std::to_string(hostPort2));
+contents = std::regex_replace(contents, std::regex("HOST_PORT3"), 
std::to_string(hostPort3));
+contents = std::regex_replace(contents, std::regex("HOST_PORT4"), 
std::to_string(hostPort4));
+contents = std::regex_replace(contents, std::regex("LOC_PORT1"), 
std::to_string(locPort1));
+contents = std::regex_replace(contents, std::regex("LOC_PORT2"), 
std::to_string(locPort2));
+
+std::ofstream out(outFile, std::ios::out);
+out.write([0], contents.size());
--- End diff --

```
out << contents;
out.close();
```


> Remove Dependency on sed tool
> -
>
> Key: GEODE-2470
> URL: https://issues.apache.org/jira/browse/GEODE-2470
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Martell
>
> The integration tests currently rely on sed to replace strings inside config 
> xml files. This task replaces that dependency with standard C++ code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #6: GEODE-2470: Replace sed dependency with standa...

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/6#discussion_r100957079
  
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void 
CacheHelper::createDuplicateXMLFile(std::string& originalFile,
  CacheHelper::staticConfigFileList.size());
 }
 
+void CacheHelper::replacePortsInFile(int hostPort1, int hostPort2,
+ int hostPort3, int hostPort4, int 
locPort1,
+ int locPort2, const std::string& 
inFile,
+ const std::string& outFile) {
+  std::ifstream in(inFile, std::ios::in | std::ios::binary);
+  if (in) {
+std::string contents;
+in.seekg(0, std::ios::end);
+contents.resize(in.tellg());
+in.seekg(0, std::ios::beg);
+in.read([0], contents.size());
+in.close();
+
+contents = std::regex_replace(contents, std::regex("HOST_PORT1"), 
std::to_string(hostPort1));
+contents = std::regex_replace(contents, std::regex("HOST_PORT2"), 
std::to_string(hostPort2));
+contents = std::regex_replace(contents, std::regex("HOST_PORT3"), 
std::to_string(hostPort3));
+contents = std::regex_replace(contents, std::regex("HOST_PORT4"), 
std::to_string(hostPort4));
+contents = std::regex_replace(contents, std::regex("LOC_PORT1"), 
std::to_string(locPort1));
+contents = std::regex_replace(contents, std::regex("LOC_PORT2"), 
std::to_string(locPort2));
+
+std::ofstream out(outFile, std::ios::out);
+out.write([0], contents.size());
--- End diff --

```
out << contents;
out.close();
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 56637: refactor ServerStarterRule and LocatorStarterRule so that they can be created without a Properties first.

2017-02-13 Thread Jinmei Liao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56637/
---

Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk Lund.


Repository: geode


Description
---

refactor ServerStarterRule and LocatorStarterRule so that they can be created 
without a Properties first.

* this would ease the usage of thsee rules, so that it can always be used as a 
rule and users don't have to worry about stopping the locator/server manually.


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityWithSSLTest.java
 2fd6771e24a0a1c2b0450348845dbd9ee36e4d38 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerStartupRule.java
 07e82c319dac25a3d0997d5ea9419127db171487 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/MemberMBeanSecurityJUnitTest.java
 33b32e9f720319b9ddbf70d5ab21c688897e1210 
  
geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java
 d202b768f14d6ada6c94700df417b733a49c8d8b 
  
geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
 23ffa9a9e5eb403742d31db042b3d0b59f095400 
  
geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java
 fcda2a322e31f5bcd00f922adb9fe7332e2073ef 
  
geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java
 3add1abe0c14b7948716bce44c0ad7b4dbebd2ea 
  
geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java
 8a797022b05c5e3d24599639b5a44830cf669f25 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 0ac459c96cb6e588e016de67fa5b827e62fdcfa0 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterRule.java
 00a0f1e580d17417004e4462ff42c3364522550c 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
 f93498fcbcea0ec8d8f0b91a0367e9b6fb7d4ae1 
  geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDunitTest.java 
1aa275d0cda7b7dcf9de9fe2837d48491bebfcfa 

Diff: https://reviews.apache.org/r/56637/diff/


Testing
---

precheckin successful
http://precheckin.gemfire.pivotalci.info:8080/teams/main/pipelines/jiliao-geode-1716


Thanks,

Jinmei Liao

[GitHub] geode-native pull request #6: GEODE-2470: Replace sed dependency with standa...

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/6#discussion_r100956921
  
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void 
CacheHelper::createDuplicateXMLFile(std::string& originalFile,
  CacheHelper::staticConfigFileList.size());
 }
 
+void CacheHelper::replacePortsInFile(int hostPort1, int hostPort2,
+ int hostPort3, int hostPort4, int 
locPort1,
+ int locPort2, const std::string& 
inFile,
+ const std::string& outFile) {
+  std::ifstream in(inFile, std::ios::in | std::ios::binary);
+  if (in) {
+std::string contents;
+in.seekg(0, std::ios::end);
+contents.resize(in.tellg());
+in.seekg(0, std::ios::beg);
+in.read([0], contents.size());
--- End diff --

```
contents.assign((std::istreambuf_iterator(in)),
std::istreambuf_iterator());
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #6: GEODE-2470: Replace sed dependency with standa...

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/6#discussion_r100956809
  
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void 
CacheHelper::createDuplicateXMLFile(std::string& originalFile,
  CacheHelper::staticConfigFileList.size());
 }
 
+void CacheHelper::replacePortsInFile(int hostPort1, int hostPort2,
+ int hostPort3, int hostPort4, int 
locPort1,
+ int locPort2, const std::string& 
inFile,
+ const std::string& outFile) {
+  std::ifstream in(inFile, std::ios::in | std::ios::binary);
+  if (in) {
+std::string contents;
+in.seekg(0, std::ios::end);
+contents.resize(in.tellg());
--- End diff --

I think you want `reserve()`. `resize()` causes the string to be resized 
and initialized with `CharT()`. `reserve()` just allocates enough capacity but 
does not resize or initialize the string.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #7: Feature/geode 2467

2017-02-13 Thread mmartell

Github user mmartell commented on the issue:

https://github.com/apache/geode-native/pull/7
  
Removed the extraneous commit. This PR now only has the commit to change 
the Xerces CMakeLists.txt.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: New Committer And PMC Member: Jared Stewart

Welcome Jared! It's great to have you with us!

On Mon, Feb 13, 2017 at 11:58 AM, Mark Bretl  wrote:

> The Apache Geode Project Management Committee has invited Jared Stewart to
> be a committer on the project and join the Geode PMC. We are pleased to
> announce he has accepted the invitation.
>
> Please join me in welcoming Jared!
>
> Best Regards,
>
> Mark Bretl
> On behalf of the Apache Geode PMC
>

[jira] [Commented] (GEODE-2470) Remove Dependency on sed tool


[ 
https://issues.apache.org/jira/browse/GEODE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864977#comment-15864977
 ] 

ASF GitHub Bot commented on GEODE-2470:
---

Github user mmartell commented on the issue:

https://github.com/apache/geode-native/pull/6
  
Simplified by switching to regex_replace instead custom function.


> Remove Dependency on sed tool
> -
>
> Key: GEODE-2470
> URL: https://issues.apache.org/jira/browse/GEODE-2470
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Martell
>
> The integration tests currently rely on sed to replace strings inside config 
> xml files. This task replaces that dependency with standard C++ code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2482) gfsh intermittently repeats output and prompt


 [ 
https://issues.apache.org/jira/browse/GEODE-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2482:
-
Affects Version/s: 1.1.0
   1.0.0-incubating

> gfsh intermittently repeats output and prompt
> -
>
> Key: GEODE-2482
> URL: https://issues.apache.org/jira/browse/GEODE-2482
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Kirk Lund
>
> The exact results varies. In the example, below stopping the locator that 
> gfsh is connected to results in printing the prompt 3 times and printing "No 
> longer connected to $name" 2 times.
> Actual output:
> {noformat}
> gfsh>stop locator --name=loc1
> Stopping Locator running in /Users/klund/dev/gemfire/open/loc1 on 
> 192.168.1.12[10334] as loc1...
> Process ID: 56456
> Log File: /Users/klund/dev/gemfire/open/loc1/loc1.log
> 
> No longer connected to 192.168.1.12[1099].
> gfsh>
> No longer connected to 192.168.1.12[1099].
> gfsh>
> gfsh>exit
> Exiting... 
> {noformat}
> This should only print "No longer connected to $name" and a prompt once.
> Desired output:
> {noformat}
> gfsh>stop locator --name=loc1
> Stopping Locator running in /Users/klund/dev/gemfire/open/loc1 on 
> 192.168.1.12[10334] as loc1...
> Process ID: 56456
> Log File: /Users/klund/dev/gemfire/open/loc1/loc1.log
> 
> No longer connected to 192.168.1.12[1099].
> gfsh>exit
> Exiting... 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2482) gfsh intermittently repeats output and prompt


 [ 
https://issues.apache.org/jira/browse/GEODE-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2482:
-
Priority: Minor  (was: Major)

> gfsh intermittently repeats output and prompt
> -
>
> Key: GEODE-2482
> URL: https://issues.apache.org/jira/browse/GEODE-2482
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Kirk Lund
>Priority: Minor
>
> The exact results varies. In the example, below stopping the locator that 
> gfsh is connected to results in printing the prompt 3 times and printing "No 
> longer connected to $name" 2 times.
> Actual output:
> {noformat}
> gfsh>stop locator --name=loc1
> Stopping Locator running in /Users/klund/dev/gemfire/open/loc1 on 
> 192.168.1.12[10334] as loc1...
> Process ID: 56456
> Log File: /Users/klund/dev/gemfire/open/loc1/loc1.log
> 
> No longer connected to 192.168.1.12[1099].
> gfsh>
> No longer connected to 192.168.1.12[1099].
> gfsh>
> gfsh>exit
> Exiting... 
> {noformat}
> This should only print "No longer connected to $name" and a prompt once.
> Desired output:
> {noformat}
> gfsh>stop locator --name=loc1
> Stopping Locator running in /Users/klund/dev/gemfire/open/loc1 on 
> 192.168.1.12[10334] as loc1...
> Process ID: 56456
> Log File: /Users/klund/dev/gemfire/open/loc1/loc1.log
> 
> No longer connected to 192.168.1.12[1099].
> gfsh>exit
> Exiting... 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2482) gfsh intermittently repeats output and prompt

Kirk Lund created GEODE-2482:


 Summary: gfsh intermittently repeats output and prompt
 Key: GEODE-2482
 URL: https://issues.apache.org/jira/browse/GEODE-2482
 Project: Geode
  Issue Type: Bug
  Components: gfsh
Reporter: Kirk Lund


The exact results varies. In the example, below stopping the locator that gfsh 
is connected to results in printing the prompt 3 times and printing "No longer 
connected to $name" 2 times.

Actual output:
{noformat}
gfsh>stop locator --name=loc1
Stopping Locator running in /Users/klund/dev/gemfire/open/loc1 on 
192.168.1.12[10334] as loc1...
Process ID: 56456
Log File: /Users/klund/dev/gemfire/open/loc1/loc1.log

No longer connected to 192.168.1.12[1099].
gfsh>
No longer connected to 192.168.1.12[1099].
gfsh>
gfsh>exit
Exiting... 
{noformat}
This should only print "No longer connected to $name" and a prompt once.

Desired output:
{noformat}
gfsh>stop locator --name=loc1
Stopping Locator running in /Users/klund/dev/gemfire/open/loc1 on 
192.168.1.12[10334] as loc1...
Process ID: 56456
Log File: /Users/klund/dev/gemfire/open/loc1/loc1.log

No longer connected to 192.168.1.12[1099].
gfsh>exit
Exiting... 
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56635: GEODE-2481: extract default properties generation to its own class

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56635/
---

(Updated Feb. 14, 2017, 2:33 a.m.)

Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Ken
Howe.

Bugs: GEODE-2481
https://issues.apache.org/jira/browse/GEODE-2481

Repository: geode

Description (updated)
---

GEODE-2481: extract default properties generation to its own class

While refactoring GemFireVersion for GEODE-2474, I noticed that
GemFireVersionIntegrationJUnitTest has nothing to do with GemFireVersion.

Extract generation of default properties to DefaultPropertiesGenerator.

Rename GemFireVersionIntegrationJUnitTest to
DefaultPropertiesGeneratorIntegrationTest. Add tests to increase code coverage.

Note: I have several changes on feature/GEODE-2474 branch which I'll separate
into multiple reviews. I'll do a final precheckin on the entire branch and then
merge the changes in after everything passes review and precheckin.

DistributionConfig and DefaultPropertiesGenerator should eventually move to a
configuration package, but I don't really want to combine anything that big
with this change.

Diffs
-

geode-assembly/build.gradle f34688043dd3e6bf8e8bdf0cb223d533b692e301

geode-core/src/main/java/org/apache/geode/distributed/internal/DefaultPropertiesGenerator.java
PRE-CREATION

geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfigImpl.java
fa6d13f7cec40ae18f78da28b3b912e01be363aa

geode-core/src/test/java/org/apache/geode/distributed/internal/DefaultPropertiesGeneratorIntegrationTest.java
PRE-CREATION

geode-core/src/test/java/org/apache/geode/internal/GemFireVersionIntegrationJUnitTest.java
cae331325f17b470e6dd786d0f9a52bba7cb42a6

Diff: https://reviews.apache.org/r/56635/diff/

Testing
---

DefaultPropertiesGeneratorIntegrationTest
GemFireVersionJUnitTest

Thanks,

Kirk Lund

Re: Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56633/
---

(Updated Feb. 14, 2017, 2:31 a.m.)

Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Ken
Howe.

Changes
---

Add info about --with-lsof on Mac OS.

Bugs: GEODE-2474
https://issues.apache.org/jira/browse/GEODE-2474

Repository: geode

Description (updated)
---

GEODE-2474: refactor code to use SystemUtils to read OS system props

Centralize OS system property reading in SystemUtils.

Refactor NetstatFunction and GemFireVersion to use SystemUtils.

This fixes use of --with-lsof on Mac (manually tested). I'll add new tests to
NetstatDUnitTest and a new integration test for netstat command in a follow-up
commit & review.

I have several changes on feature/GEODE-2474 branch which I'll separate into
multiple reviews. I'll do a final precheckin on the entire branch and then
merge the changes in after everything passes review and precheckin.

Diffs
-

geode-core/src/main/java/org/apache/geode/internal/GemFireVersion.java
26d4fb3c5705bffdcdbbc6c261dbe9ffd297642e
geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java
66c158c93fecac4feb2da56f617f5efc7bba56e1

geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/NetstatFunction.java
5fa30f47187972a209a781eae9024957dc80fb72

geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
48f176eabc18d3ffa56daaa7da12634a9554f39d

Diff: https://reviews.apache.org/r/56633/diff/

Testing
---

SystemUtilsJUnitTest
NetstatDUnitTest

Thanks,

Kirk Lund

Re: Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56633/
---

(Updated Feb. 14, 2017, 2:24 a.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Ken 
Howe.


Bugs: GEODE-2474
https://issues.apache.org/jira/browse/GEODE-2474


Repository: geode


Description (updated)
---

GEODE-2474: refactor code to use SystemUtils to read OS system props

Centralize OS system property reading in SystemUtils.

Refactor NetstatFunction and GemFireVersion to use SystemUtils.

I have several changes on feature/GEODE-2474 branch which I'll separate into 
multiple reviews. I'll do a final precheckin on the entire branch and then 
merge the changes in after everything passes review and precheckin.


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/GemFireVersion.java 
26d4fb3c5705bffdcdbbc6c261dbe9ffd297642e 
  geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 
66c158c93fecac4feb2da56f617f5efc7bba56e1 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/NetstatFunction.java
 5fa30f47187972a209a781eae9024957dc80fb72 
  
geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
 48f176eabc18d3ffa56daaa7da12634a9554f39d 

Diff: https://reviews.apache.org/r/56633/diff/


Testing
---

SystemUtilsJUnitTest
NetstatDUnitTest


Thanks,

Kirk Lund

Review Request 56635: GEODE-2481: extract default properties generation to its own class


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56635/
---

Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Ken 
Howe.


Bugs: GEODE-2481
https://issues.apache.org/jira/browse/GEODE-2481


Repository: geode


Description
---

GEODE-2481: extract default properties generation to its own class

While refactoring GemFireVersion for GEODE-2474, I noticed that 
GemFireVersionIntegrationJUnitTest has nothing to do with GemFireVersion.

Extract generation of default properties to DefaultPropertiesGenerator.

Rename GemFireVersionIntegrationJUnitTest to 
DefaultPropertiesGeneratorIntegrationTest.

Note: I have several changes on feature/GEODE-2474 branch which I'll separate 
into multiple reviews. I'll do a final precheckin on the entire branch and then 
merge the changes in after everything passes review and precheckin.

DistributionConfig and DefaultPropertiesGenerator should eventually move to a 
configuration package, but I don't really want to combine anything that big 
with this change.


Diffs
-

  geode-assembly/build.gradle f34688043dd3e6bf8e8bdf0cb223d533b692e301 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DefaultPropertiesGenerator.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfigImpl.java
 fa6d13f7cec40ae18f78da28b3b912e01be363aa 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/DefaultPropertiesGeneratorIntegrationTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/GemFireVersionIntegrationJUnitTest.java
 cae331325f17b470e6dd786d0f9a52bba7cb42a6 

Diff: https://reviews.apache.org/r/56635/diff/


Testing
---

DefaultPropertiesGeneratorIntegrationTest
GemFireVersionJUnitTest


Thanks,

Kirk Lund

Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56633/
---

Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Ken 
Howe.


Bugs: GEODE-2474
https://issues.apache.org/jira/browse/GEODE-2474


Repository: geode


Description
---

GEODE-2474: refactor code to use SystemUtils to read OS system props

Centralize OS system property reading in SystemUtils.
Refactor NetstatFunction and GemFireVersion to use SystemUtils.

I have several changes on feature/GEODE-2474 branch which I'll separate into 
multiple reviews. I'll do a final precheckin on the entire branch and then 
merge the changes in after everything passes review and precheckin.


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/GemFireVersion.java 
26d4fb3c5705bffdcdbbc6c261dbe9ffd297642e 
  geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 
66c158c93fecac4feb2da56f617f5efc7bba56e1 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/NetstatFunction.java
 5fa30f47187972a209a781eae9024957dc80fb72 
  
geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java
 48f176eabc18d3ffa56daaa7da12634a9554f39d 

Diff: https://reviews.apache.org/r/56633/diff/


Testing
---

SystemUtilsJUnitTest
NetstatDUnitTest


Thanks,

Kirk Lund

Review Request 56632: This is caused by race condition that bucket is moved, but 'moved' is not set to true yet

2017-02-13 Thread xiaojian zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56632/
---

Review request for geode and Jason Huynh.


Bugs: GEODE-2471
https://issues.apache.org/jira/browse/GEODE-2471


Repository: geode


Description
---

I can reproduce the bug by put a sleep between moveBucket() and move=true.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/internal/cache/wan/asyncqueue/AsyncEventListenerDUnitTest.java
 e2e062b 

Diff: https://reviews.apache.org/r/56632/diff/


Testing
---


Thanks,

xiaojian zhou

[jira] [Assigned] (GEODE-2471) AsyncEventListenerOffHeapDUnitTest.testParallelAsyncEventQueueMoveBucketAndMoveItBackDuringDispatching

2017-02-13 Thread xiaojian zhou (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

xiaojian zhou reassigned GEODE-2471:


Assignee: xiaojian zhou

> AsyncEventListenerOffHeapDUnitTest.testParallelAsyncEventQueueMoveBucketAndMoveItBackDuringDispatching
> --
>
> Key: GEODE-2471
> URL: https://issues.apache.org/jira/browse/GEODE-2471
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: xiaojian zhou
>Assignee: xiaojian zhou
>  Labels: CI
>
> {noformat}
> found in concourse distributedTest #383
> java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertTrue(Assert.java:52)
>   at 
> org.apache.geode.internal.cache.wan.asyncqueue.AsyncEventListenerDUnitTest.testParallelAsyncEventQueueMoveBucketAndMoveItBackDuringDispatching(AsyncEventListenerDUnitTest.java:1675)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
>

[jira] [Assigned] (GEODE-2474) netstat command fails to correctly identify OS and --with-lsof fails on Mac


 [ 
https://issues.apache.org/jira/browse/GEODE-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-2474:


Assignee: Kirk Lund

> netstat command fails to correctly identify OS and --with-lsof fails on Mac
> ---
>
> Key: GEODE-2474
> URL: https://issues.apache.org/jira/browse/GEODE-2474
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, management
>Affects Versions: 1.0.0-incubating, 1.1.0
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>  Labels: MiscellaneousCommands, NetstatCommand, gfsh, netstat
>
> The netstat gfsh command uses NetstatFunction which has its own faulty logic 
> for identifying the operating system. This logic identifies Mac as Windows 
> and fails to process --with-lsof.
> NetstatFunction should instead use org.apache.geode.internal.lang.SystemUtils 
> which correctly identifies the operating system.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2481) Refactor generation of default configuration properties

Kirk Lund created GEODE-2481:


 Summary: Refactor generation of default configuration properties
 Key: GEODE-2481
 URL: https://issues.apache.org/jira/browse/GEODE-2481
 Project: Geode
  Issue Type: Wish
Reporter: Kirk Lund


The build currently invokes DistributionConfigImpl.main to generate the default 
configuration properties file.

The test for this is currently named GemFireVersionIntegrationJUnitTest.

The code for generating the default configuration properties file should be 
extracted to its own class. GemFireVersionIntegrationJUnitTest should be moved 
to that packaged and renamed.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2481) Refactor generation of default configuration properties


 [ 
https://issues.apache.org/jira/browse/GEODE-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2481:
-
Component/s: build

> Refactor generation of default configuration properties
> ---
>
> Key: GEODE-2481
> URL: https://issues.apache.org/jira/browse/GEODE-2481
> Project: Geode
>  Issue Type: Wish
>  Components: build, configuration
>Reporter: Kirk Lund
>
> The build currently invokes DistributionConfigImpl.main to generate the 
> default configuration properties file.
> The test for this is currently named GemFireVersionIntegrationJUnitTest.
> The code for generating the default configuration properties file should be 
> extracted to its own class. GemFireVersionIntegrationJUnitTest should be 
> moved to that packaged and renamed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2481) Refactor generation of default configuration properties


 [ 
https://issues.apache.org/jira/browse/GEODE-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-2481:


Assignee: Kirk Lund

> Refactor generation of default configuration properties
> ---
>
> Key: GEODE-2481
> URL: https://issues.apache.org/jira/browse/GEODE-2481
> Project: Geode
>  Issue Type: Wish
>  Components: build, configuration
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> The build currently invokes DistributionConfigImpl.main to generate the 
> default configuration properties file.
> The test for this is currently named GemFireVersionIntegrationJUnitTest.
> The code for generating the default configuration properties file should be 
> extracted to its own class. GemFireVersionIntegrationJUnitTest should be 
> moved to that packaged and renamed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2481) Refactor generation of default configuration properties


 [ 
https://issues.apache.org/jira/browse/GEODE-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-2481:
-
Component/s: configuration

> Refactor generation of default configuration properties
> ---
>
> Key: GEODE-2481
> URL: https://issues.apache.org/jira/browse/GEODE-2481
> Project: Geode
>  Issue Type: Wish
>  Components: build, configuration
>Reporter: Kirk Lund
>
> The build currently invokes DistributionConfigImpl.main to generate the 
> default configuration properties file.
> The test for this is currently named GemFireVersionIntegrationJUnitTest.
> The code for generating the default configuration properties file should be 
> extracted to its own class. GemFireVersionIntegrationJUnitTest should be 
> moved to that packaged and renamed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-697) A client thread timing out an operation and performing further operations can result in cache inconsistency

2017-02-13 Thread Hitesh Khamesra (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864856#comment-15864856
 ] 

Hitesh Khamesra commented on GEODE-697:
---

I think this  looks resonable  solution[~dschneider]

> A client thread timing out an operation and performing further operations can 
> result in cache inconsistency
> ---
>
> Key: GEODE-697
> URL: https://issues.apache.org/jira/browse/GEODE-697
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Dan Smith
>
> There is a case where the primary and secondary buckets of a partitioned 
> region can become out of sync if a client times out while waiting for a slow 
> operation to finish. Here's the scenario:
> 1. A operation is started by the client and gets stuck on the server, for 
> example by a slow cache writer. That operation is assigned an EventID  with a 
> sequence number of 1.
> 2. The client times out.
> 3. The client performs a second operation. That operation gets assigned an 
> EventID with a sequence number of 2.
> 4. The second operation is applied on all members. The EventTracker records 
> the sequence number 2.
> 5. The original operation continues. It is applied to the primary (because it 
> has passed the EventTracker test).
> 6. The original operation is rejected by the EventTracker on the secondary. 
> The two copies of the bucket are now inconsistent.
> One possible fix is to change the thread id of the thread on the client when 
> the client operation times out. That would ensure that the EventTracker will 
> not reject the original operation when it finally goes through, because it 
> has a different thread id.
> If an operation is delayed on the server, for example by a very slow cache 
> writer, the operation can time out on the client.
> The client can then go on and perform a second operation.
> The problem is that each operation is assigned an event id which is a 
> combination of the clients thread id and a sequence number. That second 
> operation has a higher sequence number.
> Once the second operation is applied to a region on a given member, the event 
> is stored in the EventTracker and that member will reject any lower sequence 
> numbers



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56626: GEODE-2479 Remove docs reference to gemstone.com package

2017-02-13 Thread Hitesh Khamesra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56626/#review165423
---


Ship it!




Ship It!

- Hitesh Khamesra


On Feb. 14, 2017, 12:22 a.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56626/
> ---
> 
> (Updated Feb. 14, 2017, 12:22 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Dave Barnes, Hitesh Khamesra, 
> Joey McAllister, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2479 Remove docs reference to gemstone.com package
> 
> 
> Diffs
> -
> 
>   geode-docs/developing/data_serialization/auto_serialization.html.md.erb 
> cdb63a8fb5f5c5bcf7330bc2d611c3e126618b51 
> 
> Diff: https://reviews.apache.org/r/56626/diff/
> 
> 
> Testing
> ---
> 
> Gradle rat check passes.  I did not build Geode.  I did build the manual, and 
> no errors occur for a manual build.
> 
> Devs with serialization experience should double check that the note changed 
> is now correct with the package name update.
> 
> 
> Thanks,
> 
> Karen Miller
> 
>

[GitHub] geode-native pull request #3: Replace ace calls to standard functions

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/3#discussion_r100942381
  
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const 
xmlChar** atts) {
 throw CacheXmlException(s.c_str());
   }
 
-  ACE_OS::strncpy(libraryFunctionName, (char*)atts[i], len);
+  std::strncpy(libraryFunctionName, (char*)atts[i], len);
--- End diff --

The C++ way to do this now is `reinterpret_cast(atts[i])`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 56626: GEODE-2479 Remove docs reference to gemstone.com package

2017-02-13 Thread Karen Miller



> On Feb. 14, 2017, 12:48 a.m., Hitesh Khamesra wrote:
> > geode-docs/developing/data_serialization/auto_serialization.html.md.erb, 
> > line 133
> > 
> >
> > I thought this info is good to keep; Do we have similar info somewhere 
> > else?

The subsections are still in the manual, and the links to them are in the 
navigation panel.  I only removed the missplaced links within this section.


- Karen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56626/#review165417
---


On Feb. 14, 2017, 12:22 a.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56626/
> ---
> 
> (Updated Feb. 14, 2017, 12:22 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Dave Barnes, Hitesh Khamesra, 
> Joey McAllister, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2479 Remove docs reference to gemstone.com package
> 
> 
> Diffs
> -
> 
>   geode-docs/developing/data_serialization/auto_serialization.html.md.erb 
> cdb63a8fb5f5c5bcf7330bc2d611c3e126618b51 
> 
> Diff: https://reviews.apache.org/r/56626/diff/
> 
> 
> Testing
> ---
> 
> Gradle rat check passes.  I did not build Geode.  I did build the manual, and 
> no errors occur for a manual build.
> 
> Devs with serialization experience should double check that the note changed 
> is now correct with the package name update.
> 
> 
> Thanks,
> 
> Karen Miller
> 
>

[jira] [Commented] (GEODE-2376) Remove stack dump comment from ThinClientPoolDM.cpp


[ 
https://issues.apache.org/jira/browse/GEODE-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864801#comment-15864801
 ] 

ASF GitHub Bot commented on GEODE-2376:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/8


> Remove stack dump comment from ThinClientPoolDM.cpp
> ---
>
> Key: GEODE-2376
> URL: https://issues.apache.org/jira/browse/GEODE-2376
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Michael Dodge
>Priority: Minor
>
> For some strange reason there is a stack dump embedded in the source. There 
> is no comment on the relevance to the section of code.
> See around line 506.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #8: GEODE-2376: Remove low-value comments from Thi...

2017-02-13 Thread ASF subversion and git services (JIRA)

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2376) Remove stack dump comment from ThinClientPoolDM.cpp


[ 
https://issues.apache.org/jira/browse/GEODE-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864800#comment-15864800
 ] 

ASF subversion and git services commented on GEODE-2376:


Commit 62f0e3872ac0fe47c502a825a9e5e0258402c3fb in geode-native's branch 
refs/heads/develop from [~PivotalSarge]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=62f0e38 ]

GEODE-2376: Remove low-value comments from ThinClientPoolDM.cpp.

- Remove the stack trace comment.
- Remove commented-out code that already exists in the history
  of the file in version control.

This closes #8.


> Remove stack dump comment from ThinClientPoolDM.cpp
> ---
>
> Key: GEODE-2376
> URL: https://issues.apache.org/jira/browse/GEODE-2376
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Michael Dodge
>Priority: Minor
>
> For some strange reason there is a stack dump embedded in the source. There 
> is no comment on the relevance to the section of code.
> See around line 506.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #3: Replace ace calls to standard functions

2017-02-13 Thread dgkimura

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/3#discussion_r100938599
  
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const 
xmlChar** atts) {
 throw CacheXmlException(s.c_str());
   }
 
-  ACE_OS::strncpy(libraryFunctionName, (char*)atts[i], len);
+  std::strncpy(libraryFunctionName, (char*)atts[i], len);
--- End diff --

Okay, so `xmlChar` is an `unsigned char` and `strncpy ` requires a `char`, 
hence a c-style cast/hack here.  That seems broken.  A fix may be using 
`std::memcpy`.  However, other calls, like `strlen` seem fundamentally broken.  
I think fixing these calls may be out of scope for this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2462) Unify quick starts and examples

2017-02-13 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864790#comment-15864790
 ] 

ASF subversion and git services commented on GEODE-2462:


Commit b2edccfcc7cf7d16e33bda462873cf02702b7093 in geode-native's branch 
refs/heads/develop from [~PivotalSarge]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=b2edccf ]

GEODE-2462: Remove examples directory.

This closes #5.


> Unify quick starts and examples
> ---
>
> Key: GEODE-2462
> URL: https://issues.apache.org/jira/browse/GEODE-2462
> Project: Geode
>  Issue Type: New Feature
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> Currently, there exists both src/quickstart and examples under the native 
> root. It is unclear what the difference is or what value-add the examples 
> directories brings. The exemplary code under src/quickstart and examples 
> ought to be unified, without duplicates, of course. Given that src/quickstart 
> has more code, it should be the single location of exemplary code for the 
> native libraries.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2462) Unify quick starts and examples


[ 
https://issues.apache.org/jira/browse/GEODE-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864791#comment-15864791
 ] 

ASF GitHub Bot commented on GEODE-2462:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/5


> Unify quick starts and examples
> ---
>
> Key: GEODE-2462
> URL: https://issues.apache.org/jira/browse/GEODE-2462
> Project: Geode
>  Issue Type: New Feature
>  Components: native client
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> Currently, there exists both src/quickstart and examples under the native 
> root. It is unclear what the difference is or what value-add the examples 
> directories brings. The exemplary code under src/quickstart and examples 
> ought to be unified, without duplicates, of course. Given that src/quickstart 
> has more code, it should be the single location of exemplary code for the 
> native libraries.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #5: GEODE-2462: Remove examples directory.

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2446) Remove "c" client


[ 
https://issues.apache.org/jira/browse/GEODE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864788#comment-15864788
 ] 

ASF GitHub Bot commented on GEODE-2446:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/4


> Remove "c" client
> -
>
> Key: GEODE-2446
> URL: https://issues.apache.org/jira/browse/GEODE-2446
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Ernest Burghardt
>Assignee: Michael Dodge
>
> under src/ the "cclient" module is obsolete/old code that should be removed



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #4: GEODE-2446: Remove cclient directory.

2017-02-13 Thread ASF subversion and git services (JIRA)

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2446) Remove "c" client


[ 
https://issues.apache.org/jira/browse/GEODE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864786#comment-15864786
 ] 

ASF subversion and git services commented on GEODE-2446:


Commit c38580a543221c2558a64cbaafc2a871885a4ac9 in geode-native's branch 
refs/heads/develop from [~PivotalSarge]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=c38580a ]

GEODE-2446: Remove cclient directory.

This closes #4.


> Remove "c" client
> -
>
> Key: GEODE-2446
> URL: https://issues.apache.org/jira/browse/GEODE-2446
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Ernest Burghardt
>Assignee: Michael Dodge
>
> under src/ the "cclient" module is obsolete/old code that should be removed



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2052) Docs to segregate types of properties

2017-02-13 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864783#comment-15864783
 ] 

ASF subversion and git services commented on GEODE-2052:


Commit 253579a8ebef8990b9d1a94a6ca137f80ccdeb34 in geode's branch 
refs/heads/feature/GEODE-2052 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=253579a ]

Merge branch 'feature/GEODE-2052' of 
https://git-wip-us.apache.org/repos/asf/geode into feature/GEODE-2052

* 'feature/GEODE-2052' of https://git-wip-us.apache.org/repos/asf/geode:
  GEODE-2052 Docs to segregate types of properties


> Docs to segregate types of properties
> -
>
> Key: GEODE-2052
> URL: https://issues.apache.org/jira/browse/GEODE-2052
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Pulkit Chandra
>Assignee: Dave Barnes
>
> Geode has a lot of properties. But they are not mentioned in context but 
> rather listed as geode properties which can go in geode.properties and 
> gfsecurity.properties.
> It would nice to have a segregation by Locator and Server under 
> geode.properties. The reason for this ask is that some properties do not 
> apply to both locator and server. Currently the only way to know this is by 
> experience or trial and error.
> ~~We also found out that some of the gemfire.properties do not get applied 
> when supplied in geode.properties but rather have to be passed as command 
> line properties. e.g. enabling rest api.
> It would be nice to call that out clearly in docs.~~
> ~~There are example of properties which have to be applied together in order 
> to enable a functionality e.g. rest api needs bind address property and 
> http-service-port. Its not called out clearly in the docs that they are 
> *mandatory*. ~~
> [link to docs 
> section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)
> ~~quote ~~
> ~~To enable the developer REST API service in Apache Geode, set the 
> start-dev-rest-api Geode property to true when starting a data node using 
> either gfsh or the ServerLauncher API. Setting this property to true on a 
> data node will start up an embedded Jetty server and deploy the REST 
> developer API WAR file.~~
> ~~It should highlight that its necessary to have 2 more properties 
> bind-address and http-service-port defined to make it work.~~
> We would be happy to provide further details on this matter if needed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2052) Docs to segregate types of properties

2017-02-13 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864781#comment-15864781
 ] 

ASF subversion and git services commented on GEODE-2052:


Commit 253579a8ebef8990b9d1a94a6ca137f80ccdeb34 in geode's branch 
refs/heads/feature/GEODE-2052 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=253579a ]

Merge branch 'feature/GEODE-2052' of 
https://git-wip-us.apache.org/repos/asf/geode into feature/GEODE-2052

* 'feature/GEODE-2052' of https://git-wip-us.apache.org/repos/asf/geode:
  GEODE-2052 Docs to segregate types of properties


> Docs to segregate types of properties
> -
>
> Key: GEODE-2052
> URL: https://issues.apache.org/jira/browse/GEODE-2052
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Pulkit Chandra
>Assignee: Dave Barnes
>
> Geode has a lot of properties. But they are not mentioned in context but 
> rather listed as geode properties which can go in geode.properties and 
> gfsecurity.properties.
> It would nice to have a segregation by Locator and Server under 
> geode.properties. The reason for this ask is that some properties do not 
> apply to both locator and server. Currently the only way to know this is by 
> experience or trial and error.
> ~~We also found out that some of the gemfire.properties do not get applied 
> when supplied in geode.properties but rather have to be passed as command 
> line properties. e.g. enabling rest api.
> It would be nice to call that out clearly in docs.~~
> ~~There are example of properties which have to be applied together in order 
> to enable a functionality e.g. rest api needs bind address property and 
> http-service-port. Its not called out clearly in the docs that they are 
> *mandatory*. ~~
> [link to docs 
> section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)
> ~~quote ~~
> ~~To enable the developer REST API service in Apache Geode, set the 
> start-dev-rest-api Geode property to true when starting a data node using 
> either gfsh or the ServerLauncher API. Setting this property to true on a 
> data node will start up an embedded Jetty server and deploy the REST 
> developer API WAR file.~~
> ~~It should highlight that its necessary to have 2 more properties 
> bind-address and http-service-port defined to make it work.~~
> We would be happy to provide further details on this matter if needed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2052) Docs to segregate types of properties

2017-02-13 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864778#comment-15864778
 ] 

ASF subversion and git services commented on GEODE-2052:


Commit 7e88f0432028656b9a1b5e3cf0f8e71a7a4159a5 in geode's branch 
refs/heads/feature/GEODE-2052 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=7e88f04 ]

GEODE-2052 Docs to segregate types of properties


> Docs to segregate types of properties
> -
>
> Key: GEODE-2052
> URL: https://issues.apache.org/jira/browse/GEODE-2052
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Pulkit Chandra
>Assignee: Dave Barnes
>
> Geode has a lot of properties. But they are not mentioned in context but 
> rather listed as geode properties which can go in geode.properties and 
> gfsecurity.properties.
> It would nice to have a segregation by Locator and Server under 
> geode.properties. The reason for this ask is that some properties do not 
> apply to both locator and server. Currently the only way to know this is by 
> experience or trial and error.
> ~~We also found out that some of the gemfire.properties do not get applied 
> when supplied in geode.properties but rather have to be passed as command 
> line properties. e.g. enabling rest api.
> It would be nice to call that out clearly in docs.~~
> ~~There are example of properties which have to be applied together in order 
> to enable a functionality e.g. rest api needs bind address property and 
> http-service-port. Its not called out clearly in the docs that they are 
> *mandatory*. ~~
> [link to docs 
> section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)
> ~~quote ~~
> ~~To enable the developer REST API service in Apache Geode, set the 
> start-dev-rest-api Geode property to true when starting a data node using 
> either gfsh or the ServerLauncher API. Setting this property to true on a 
> data node will start up an embedded Jetty server and deploy the REST 
> developer API WAR file.~~
> ~~It should highlight that its necessary to have 2 more properties 
> bind-address and http-service-port defined to make it work.~~
> We would be happy to provide further details on this matter if needed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2052) Docs to segregate types of properties

2017-02-13 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864779#comment-15864779
 ] 

ASF subversion and git services commented on GEODE-2052:


Commit 253579a8ebef8990b9d1a94a6ca137f80ccdeb34 in geode's branch 
refs/heads/feature/GEODE-2052 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=253579a ]

Merge branch 'feature/GEODE-2052' of 
https://git-wip-us.apache.org/repos/asf/geode into feature/GEODE-2052

* 'feature/GEODE-2052' of https://git-wip-us.apache.org/repos/asf/geode:
  GEODE-2052 Docs to segregate types of properties


> Docs to segregate types of properties
> -
>
> Key: GEODE-2052
> URL: https://issues.apache.org/jira/browse/GEODE-2052
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Pulkit Chandra
>Assignee: Dave Barnes
>
> Geode has a lot of properties. But they are not mentioned in context but 
> rather listed as geode properties which can go in geode.properties and 
> gfsecurity.properties.
> It would nice to have a segregation by Locator and Server under 
> geode.properties. The reason for this ask is that some properties do not 
> apply to both locator and server. Currently the only way to know this is by 
> experience or trial and error.
> ~~We also found out that some of the gemfire.properties do not get applied 
> when supplied in geode.properties but rather have to be passed as command 
> line properties. e.g. enabling rest api.
> It would be nice to call that out clearly in docs.~~
> ~~There are example of properties which have to be applied together in order 
> to enable a functionality e.g. rest api needs bind address property and 
> http-service-port. Its not called out clearly in the docs that they are 
> *mandatory*. ~~
> [link to docs 
> section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)
> ~~quote ~~
> ~~To enable the developer REST API service in Apache Geode, set the 
> start-dev-rest-api Geode property to true when starting a data node using 
> either gfsh or the ServerLauncher API. Setting this property to true on a 
> data node will start up an embedded Jetty server and deploy the REST 
> developer API WAR file.~~
> ~~It should highlight that its necessary to have 2 more properties 
> bind-address and http-service-port defined to make it work.~~
> We would be happy to provide further details on this matter if needed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56626: GEODE-2479 Remove docs reference to gemstone.com package

2017-02-13 Thread Hitesh Khamesra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56626/#review165417
---




geode-docs/developing/data_serialization/auto_serialization.html.md.erb 


I thought this info is good to keep; Do we have similar info somewhere else?


- Hitesh Khamesra


On Feb. 14, 2017, 12:22 a.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56626/
> ---
> 
> (Updated Feb. 14, 2017, 12:22 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Dave Barnes, Hitesh Khamesra, 
> Joey McAllister, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2479 Remove docs reference to gemstone.com package
> 
> 
> Diffs
> -
> 
>   geode-docs/developing/data_serialization/auto_serialization.html.md.erb 
> cdb63a8fb5f5c5bcf7330bc2d611c3e126618b51 
> 
> Diff: https://reviews.apache.org/r/56626/diff/
> 
> 
> Testing
> ---
> 
> Gradle rat check passes.  I did not build Geode.  I did build the manual, and 
> no errors occur for a manual build.
> 
> Devs with serialization experience should double check that the note changed 
> is now correct with the package name update.
> 
> 
> Thanks,
> 
> Karen Miller
> 
>

[jira] [Commented] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

2017-02-13 Thread Jacob S. Barrett (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864767#comment-15864767
 ] 

Jacob S. Barrett commented on GEODE-2480:
-

Took me a few times to catch it. The version in the BUILDING.md says *4.3* but 
should be *3.4*.

> Need to specify correct version of CMake required for building Native Client
> 
>
> Key: GEODE-2480
> URL: https://issues.apache.org/jira/browse/GEODE-2480
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Akihiro Kitada
>
> According to the following doc, the version of CMake required for building 
> Native Client is *4.3* or newer.
> https://github.com/apache/geode-native/blob/develop/BUILDING.md
> However, the latest stable version of CMake is 3.7.2 as of now. Please 
> specify the correct version of CMake (it could be "*3.4* or newer" ?).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

2017-02-13 Thread Jacob S. Barrett (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett updated GEODE-2480:

Description: 
According to the following doc, the version of CMake required for building 
Native Client is *4.3* or newer.

https://github.com/apache/geode-native/blob/develop/BUILDING.md

However, the latest stable version of CMake is 3.7.2 as of now. Please specify 
the correct version of CMake (it could be "*3.4* or newer" ?).

  was:
According to the following doc, the version of CMake required for building 
Native Client is 4.3 or newer.

https://github.com/apache/geode-native/blob/develop/BUILDING.md

However, the latest stable version of CMake is 3.7.2 as of now. Please specify 
the correct version of CMake (it could be "3.4 or newer" ?).


> Need to specify correct version of CMake required for building Native Client
> 
>
> Key: GEODE-2480
> URL: https://issues.apache.org/jira/browse/GEODE-2480
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Akihiro Kitada
>
> According to the following doc, the version of CMake required for building 
> Native Client is *4.3* or newer.
> https://github.com/apache/geode-native/blob/develop/BUILDING.md
> However, the latest stable version of CMake is 3.7.2 as of now. Please 
> specify the correct version of CMake (it could be "*3.4* or newer" ?).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56626: GEODE-2479 Remove docs reference to gemstone.com package

2017-02-13 Thread Dave Barnes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56626/#review165415
---


Ship it!




Ship It!

- Dave Barnes


On Feb. 14, 2017, 12:22 a.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56626/
> ---
> 
> (Updated Feb. 14, 2017, 12:22 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Dave Barnes, Hitesh Khamesra, 
> Joey McAllister, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2479 Remove docs reference to gemstone.com package
> 
> 
> Diffs
> -
> 
>   geode-docs/developing/data_serialization/auto_serialization.html.md.erb 
> cdb63a8fb5f5c5bcf7330bc2d611c3e126618b51 
> 
> Diff: https://reviews.apache.org/r/56626/diff/
> 
> 
> Testing
> ---
> 
> Gradle rat check passes.  I did not build Geode.  I did build the manual, and 
> no errors occur for a manual build.
> 
> Devs with serialization experience should double check that the note changed 
> is now correct with the package name update.
> 
> 
> Thanks,
> 
> Karen Miller
> 
>

[jira] [Updated] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

2017-02-13 Thread Akihiro Kitada (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akihiro Kitada updated GEODE-2480:
--
Component/s: native client

> Need to specify correct version of CMake required for building Native Client
> 
>
> Key: GEODE-2480
> URL: https://issues.apache.org/jira/browse/GEODE-2480
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Akihiro Kitada
>
> According to the following doc, the version of CMake required for building 
> Native Client is 4.3 or newer.
> https://github.com/apache/geode-native/blob/develop/BUILDING.md
> However, the latest stable version of CMake is 3.7.2 as of now. Please 
> specify the correct version of CMake (it could be "3.4 or newer" ?).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

2017-02-13 Thread Akihiro Kitada (JIRA)

Akihiro Kitada created GEODE-2480:
-

 Summary: Need to specify correct version of CMake required for 
building Native Client
 Key: GEODE-2480
 URL: https://issues.apache.org/jira/browse/GEODE-2480
 Project: Geode
  Issue Type: Bug
  Components: docs
Reporter: Akihiro Kitada


According to the following doc, the version of CMake required for building 
Native Client is 4.3 or newer.

https://github.com/apache/geode-native/blob/develop/BUILDING.md

However, the latest stable version of CMake is 3.7.2 as of now. Please specify 
the correct version of CMake (it could be "3.4 or newer" ?).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2408) Refactor CacheableDate to use C++ std::chrono

2017-02-13 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864755#comment-15864755
 ] 

ASF subversion and git services commented on GEODE-2408:


Commit ac76aaced574fd36527ceb62979a34e2b5c8e61c in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=ac76aac ]

GEODE-2408: Fixes deprecated attribute detection.


> Refactor CacheableDate to use C++ std::chrono
> -
>
> Key: GEODE-2408
> URL: https://issues.apache.org/jira/browse/GEODE-2408
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-697) A client thread timing out an operation and performing further operations can result in cache inconsistency


[ 
https://issues.apache.org/jira/browse/GEODE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864748#comment-15864748
 ] 

Darrel Schneider commented on GEODE-697:


Anil and I both think the solution to this is that when a client gives up on an 
operation that it times out and is not going to retry that operation, then it 
must change its thread id that is used by the server EventTracker. I think the 
client adds this to every message it sends by getting it from a thread id. So 
it should be pretty easy for it to modify it in the exceptional case of it 
giving up on an in progress operation. This was the solution that Dan suggested 
in the original comment.

I think we only need the EventTracker because clients may retry to same 
operation and we want to not do duplicates on the server side when a client has 
done a retry. So the client only needs to maintain the same EventTracker id if 
it may still retry an operation that may still be in progress.

> A client thread timing out an operation and performing further operations can 
> result in cache inconsistency
> ---
>
> Key: GEODE-697
> URL: https://issues.apache.org/jira/browse/GEODE-697
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Dan Smith
>Assignee: Darrel Schneider
>
> There is a case where the primary and secondary buckets of a partitioned 
> region can become out of sync if a client times out while waiting for a slow 
> operation to finish. Here's the scenario:
> 1. A operation is started by the client and gets stuck on the server, for 
> example by a slow cache writer. That operation is assigned an EventID  with a 
> sequence number of 1.
> 2. The client times out.
> 3. The client performs a second operation. That operation gets assigned an 
> EventID with a sequence number of 2.
> 4. The second operation is applied on all members. The EventTracker records 
> the sequence number 2.
> 5. The original operation continues. It is applied to the primary (because it 
> has passed the EventTracker test).
> 6. The original operation is rejected by the EventTracker on the secondary. 
> The two copies of the bucket are now inconsistent.
> One possible fix is to change the thread id of the thread on the client when 
> the client operation times out. That would ensure that the EventTracker will 
> not reject the original operation when it finally goes through, because it 
> has a different thread id.
> If an operation is delayed on the server, for example by a very slow cache 
> writer, the operation can time out on the client.
> The client can then go on and perform a second operation.
> The problem is that each operation is assigned an event id which is a 
> combination of the clients thread id and a sequence number. That second 
> operation has a higher sequence number.
> Once the second operation is applied to a region on a given member, the event 
> is stored in the EventTracker and that member will reject any lower sequence 
> numbers



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-697) A client thread timing out an operation and performing further operations can result in cache inconsistency


 [ 
https://issues.apache.org/jira/browse/GEODE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-697:
--

Assignee: (was: Darrel Schneider)

> A client thread timing out an operation and performing further operations can 
> result in cache inconsistency
> ---
>
> Key: GEODE-697
> URL: https://issues.apache.org/jira/browse/GEODE-697
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Dan Smith
>
> There is a case where the primary and secondary buckets of a partitioned 
> region can become out of sync if a client times out while waiting for a slow 
> operation to finish. Here's the scenario:
> 1. A operation is started by the client and gets stuck on the server, for 
> example by a slow cache writer. That operation is assigned an EventID  with a 
> sequence number of 1.
> 2. The client times out.
> 3. The client performs a second operation. That operation gets assigned an 
> EventID with a sequence number of 2.
> 4. The second operation is applied on all members. The EventTracker records 
> the sequence number 2.
> 5. The original operation continues. It is applied to the primary (because it 
> has passed the EventTracker test).
> 6. The original operation is rejected by the EventTracker on the secondary. 
> The two copies of the bucket are now inconsistent.
> One possible fix is to change the thread id of the thread on the client when 
> the client operation times out. That would ensure that the EventTracker will 
> not reject the original operation when it finally goes through, because it 
> has a different thread id.
> If an operation is delayed on the server, for example by a very slow cache 
> writer, the operation can time out on the client.
> The client can then go on and perform a second operation.
> The problem is that each operation is assigned an event id which is a 
> combination of the clients thread id and a sequence number. That second 
> operation has a higher sequence number.
> Once the second operation is applied to a region on a given member, the event 
> is stored in the EventTracker and that member will reject any lower sequence 
> numbers



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-697) A client thread timing out an operation and performing further operations can result in cache inconsistency

2017-02-13 Thread ASF subversion and git services (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider updated GEODE-697:
---
Component/s: (was: regions)
 client/server

> A client thread timing out an operation and performing further operations can 
> result in cache inconsistency
> ---
>
> Key: GEODE-697
> URL: https://issues.apache.org/jira/browse/GEODE-697
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Dan Smith
>Assignee: Darrel Schneider
>
> There is a case where the primary and secondary buckets of a partitioned 
> region can become out of sync if a client times out while waiting for a slow 
> operation to finish. Here's the scenario:
> 1. A operation is started by the client and gets stuck on the server, for 
> example by a slow cache writer. That operation is assigned an EventID  with a 
> sequence number of 1.
> 2. The client times out.
> 3. The client performs a second operation. That operation gets assigned an 
> EventID with a sequence number of 2.
> 4. The second operation is applied on all members. The EventTracker records 
> the sequence number 2.
> 5. The original operation continues. It is applied to the primary (because it 
> has passed the EventTracker test).
> 6. The original operation is rejected by the EventTracker on the secondary. 
> The two copies of the bucket are now inconsistent.
> One possible fix is to change the thread id of the thread on the client when 
> the client operation times out. That would ensure that the EventTracker will 
> not reject the original operation when it finally goes through, because it 
> has a different thread id.
> If an operation is delayed on the server, for example by a very slow cache 
> writer, the operation can time out on the client.
> The client can then go on and perform a second operation.
> The problem is that each operation is assigned an event id which is a 
> combination of the clients thread id and a sequence number. That second 
> operation has a higher sequence number.
> Once the second operation is applied to a region on a given member, the event 
> is stored in the EventTracker and that member will reject any lower sequence 
> numbers



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 56626: GEODE-2479 Remove docs reference to gemstone.com package

2017-02-13 Thread Karen Miller


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56626/
---

Review request for geode, Bruce Schuchardt, Dave Barnes, Hitesh Khamesra, Joey 
McAllister, and Udo Kohlmeyer.


Repository: geode


Description
---

GEODE-2479 Remove docs reference to gemstone.com package


Diffs
-

  geode-docs/developing/data_serialization/auto_serialization.html.md.erb 
cdb63a8fb5f5c5bcf7330bc2d611c3e126618b51 

Diff: https://reviews.apache.org/r/56626/diff/


Testing
---

Gradle rat check passes.  I did not build Geode.  I did build the manual, and 
no errors occur for a manual build.

Devs with serialization experience should double check that the note changed is 
now correct with the package name update.


Thanks,

Karen Miller

Re: New Committer And PMC Member: Jared Stewart

2017-02-13 Thread Galen M O'Sullivan

Right on! Congratulations, Jared!


On Mon, Feb 13, 2017 at 1:26 PM, Dan Smith  wrote:

> Sweet! Welcome!
>
> -Dan
>
> On Mon, Feb 13, 2017 at 12:23 PM, Kenneth Howe  wrote:
>
> > Congratulations Jared
> >
> > > On Feb 13, 2017, at 12:07 PM, Joey McAllister 
> > wrote:
> > >
> > > Nice! Congratulations, Jared!
> > >
> > > On Mon, Feb 13, 2017 at 11:59 AM Mark Bretl  wrote:
> > >
> > >> The Apache Geode Project Management Committee has invited Jared
> Stewart
> > to
> > >> be a committer on the project and join the Geode PMC. We are pleased
> to
> > >> announce he has accepted the invitation.
> > >>
> > >> Please join me in welcoming Jared!
> > >>
> > >> Best Regards,
> > >>
> > >> Mark Bretl
> > >> On behalf of the Apache Geode PMC
> > >>
> >
> >
>

[jira] [Commented] (GEODE-2436) Geode doesn't handle byte[] as key

2017-02-13 Thread Hitesh Khamesra (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864689#comment-15864689
 ] 

Hitesh Khamesra commented on GEODE-2436:


This is just another improvement in redisAdapter to reduce the memory 
footprint. We also use ByteArrayWrapper  for values; we should be able to use 
byte[] for that.

> Geode doesn't handle byte[] as key
> --
>
> Key: GEODE-2436
> URL: https://issues.apache.org/jira/browse/GEODE-2436
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Hitesh Khamesra
>
> Geode doesn't handle byte[] as key. "byte[]" doesn't implement 
> hashcode/equals method, it just returns native hashcode. Because of that 
> following code returns  null for key k2;
> {code}
> Cache c = CacheFactory.getAnyInstance();
>
> Region region = c.getRegion("primitiveKVStore");
>byte[] k1 = new byte[] {1,2};
>
> region.put(k1, k1);
> byte[] k2 = new byte[] {1,2};
> System.out.println(">> "  + region.get(k2));
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2479) correct doc reference to a com.gemstone package

2017-02-13 Thread Karen Smoler Miller (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller updated GEODE-2479:
---
Summary: correct doc reference to a com.gemstone package  (was: correct doc 
reference to a com.gemstone packatge)

> correct doc reference to a com.gemstone package
> ---
>
> Key: GEODE-2479
> URL: https://issues.apache.org/jira/browse/GEODE-2479
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>
> File geode-docs/developing/data_serialization/auto_serialization.html still 
> has a spurious reference to a com.gemstone package.  It should be corrected 
> to identify org.apache.geode instead.
> At the same time, remove links to the 2 subsections with headers
> - Customizing Serialization with Class Pattern Strings
> - Extending the ReflectionBasedAutoSerializer
> These are in the navigation bar, so the links server no purpose.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2479) correct doc reference to a com.gemstone packatge

2017-02-13 Thread Karen Smoler Miller (JIRA)

Karen Smoler Miller created GEODE-2479:
--

 Summary: correct doc reference to a com.gemstone packatge
 Key: GEODE-2479
 URL: https://issues.apache.org/jira/browse/GEODE-2479
 Project: Geode
  Issue Type: Bug
  Components: docs
Reporter: Karen Smoler Miller


File geode-docs/developing/data_serialization/auto_serialization.html still has 
a spurious reference to a com.gemstone package.  It should be corrected to 
identify org.apache.geode instead.

At the same time, remove links to the 2 subsections with headers
- Customizing Serialization with Class Pattern Strings
- Extending the ReflectionBasedAutoSerializer

These are in the navigation bar, so the links server no purpose.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2052) Docs to segregate types of properties


[ 
https://issues.apache.org/jira/browse/GEODE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864652#comment-15864652
 ] 

ASF subversion and git services commented on GEODE-2052:


Commit b260cdb783be17e96e6ea9b0d958b490a1fc1e76 in geode's branch 
refs/heads/feature/GEODE-2052 from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b260cdb ]

GEODE-2052 Docs to segregate types of properties


> Docs to segregate types of properties
> -
>
> Key: GEODE-2052
> URL: https://issues.apache.org/jira/browse/GEODE-2052
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Pulkit Chandra
>Assignee: Dave Barnes
>
> Geode has a lot of properties. But they are not mentioned in context but 
> rather listed as geode properties which can go in geode.properties and 
> gfsecurity.properties.
> It would nice to have a segregation by Locator and Server under 
> geode.properties. The reason for this ask is that some properties do not 
> apply to both locator and server. Currently the only way to know this is by 
> experience or trial and error.
> ~~We also found out that some of the gemfire.properties do not get applied 
> when supplied in geode.properties but rather have to be passed as command 
> line properties. e.g. enabling rest api.
> It would be nice to call that out clearly in docs.~~
> ~~There are example of properties which have to be applied together in order 
> to enable a functionality e.g. rest api needs bind address property and 
> http-service-port. Its not called out clearly in the docs that they are 
> *mandatory*. ~~
> [link to docs 
> section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)
> ~~quote ~~
> ~~To enable the developer REST API service in Apache Geode, set the 
> start-dev-rest-api Geode property to true when starting a data node using 
> either gfsh or the ServerLauncher API. Setting this property to true on a 
> data node will start up an embedded Jetty server and deploy the REST 
> developer API WAR file.~~
> ~~It should highlight that its necessary to have 2 more properties 
> bind-address and http-service-port defined to make it work.~~
> We would be happy to provide further details on this matter if needed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2352) Document that REST API requires two properties

2017-02-13 Thread Dave Barnes (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2352:
---
Description: 
Pulkit Chandra wrote in GEODE-2052:

The REST api needs bind address property and http-service-port. Its not called 
out clearly in the docs that they are *mandatory*. 
[link to docs 
section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)

quote 

```
To enable the developer REST API service in Apache Geode, set the 
start-dev-rest-api Geode property to true when starting a data node using 
either gfsh or the ServerLauncher API. Setting this property to true on a data 
node will start up an embedded Jetty server and deploy the REST developer API 
WAR file.

```
We also found out that some of the gemfire.properties do not get applied when 
supplied in geode.properties but rather have to be passed as command line 
properties. e.g. enabling rest api.
It would be nice to call that out clearly in docs.
It should highlight that its necessary to have 2 more properties bind-address 
and http-service-port defined to make it work.

We would be happy to provide further details on this matter if needed.

  was:
Pulkit Chandra wrote in GEODE-2052:

The REST api needs bind address property and http-service-port. Its not called 
out clearly in the docs that they are *mandatory*. 
[link to docs 
section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)

quote 

```
To enable the developer REST API service in Apache Geode, set the 
start-dev-rest-api Geode property to true when starting a data node using 
either gfsh or the ServerLauncher API. Setting this property to true on a data 
node will start up an embedded Jetty server and deploy the REST developer API 
WAR file.

```
It should highlight that its necessary to have 2 more properties bind-address 
and http-service-port defined to make it work.

We would be happy to provide further details on this matter if needed.


> Document that REST API requires two properties
> --
>
> Key: GEODE-2352
> URL: https://issues.apache.org/jira/browse/GEODE-2352
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> Pulkit Chandra wrote in GEODE-2052:
> The REST api needs bind address property and http-service-port. Its not 
> called out clearly in the docs that they are *mandatory*. 
> [link to docs 
> section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)
> quote 
> ```
> To enable the developer REST API service in Apache Geode, set the 
> start-dev-rest-api Geode property to true when starting a data node using 
> either gfsh or the ServerLauncher API. Setting this property to true on a 
> data node will start up an embedded Jetty server and deploy the REST 
> developer API WAR file.
> ```
> We also found out that some of the gemfire.properties do not get applied when 
> supplied in geode.properties but rather have to be passed as command line 
> properties. e.g. enabling rest api.
> It would be nice to call that out clearly in docs.
> It should highlight that its necessary to have 2 more properties bind-address 
> and http-service-port defined to make it work.
> We would be happy to provide further details on this matter if needed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2453) region.create does not honor contract on PROXY region


[ 
https://issues.apache.org/jira/browse/GEODE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864644#comment-15864644
 ] 

Darrel Schneider commented on GEODE-2453:
-

This is actually the expected behavior with how PROXY regions are currently 
specified to behave.
Create is checking if the local PROXY region has an existing entry. Since the 
PROXY is always empty it does not and the create operation is allowed and 
distributed to others.
In the new specification of PROXY regions in which they will always forward the 
operation to be done on the server (see GEODE-1887) create should be changed to 
check the server for an existing key instead of checking the state on the local 
PROXY.

> region.create does not honor contract on PROXY region
> -
>
> Key: GEODE-2453
> URL: https://issues.apache.org/jira/browse/GEODE-2453
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>
> A create(K,V) on a client PROXY region does not throw an 
> {{EntryExistsException}} when the entry already exists on the server.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2052) Docs to segregate types of properties

2017-02-13 Thread Dave Barnes (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2052:
---
Description: 
Geode has a lot of properties. But they are not mentioned in context but rather 
listed as geode properties which can go in geode.properties and 
gfsecurity.properties.

It would nice to have a segregation by Locator and Server under 
geode.properties. The reason for this ask is that some properties do not apply 
to both locator and server. Currently the only way to know this is by 
experience or trial and error.

~~We also found out that some of the gemfire.properties do not get applied when 
supplied in geode.properties but rather have to be passed as command line 
properties. e.g. enabling rest api.
It would be nice to call that out clearly in docs.~~

~~There are example of properties which have to be applied together in order to 
enable a functionality e.g. rest api needs bind address property and 
http-service-port. Its not called out clearly in the docs that they are 
*mandatory*. ~~
[link to docs 
section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)

~~quote ~~

~~To enable the developer REST API service in Apache Geode, set the 
start-dev-rest-api Geode property to true when starting a data node using 
either gfsh or the ServerLauncher API. Setting this property to true on a data 
node will start up an embedded Jetty server and deploy the REST developer API 
WAR file.~~

~~It should highlight that its necessary to have 2 more properties bind-address 
and http-service-port defined to make it work.~~

We would be happy to provide further details on this matter if needed.

  was:
Geode has a lot of properties. But they are not mentioned in context but rather 
listed as geode properties which can go in geode.properties and 
gfsecurity.properties.

It would nice to have a segregation by Locator and Server under 
geode.properties. The reason for this ask is that some properties do not apply 
to both locator and server. Currently the only way to know this is by 
experience or trial and error.

We also found out that some of the gemfire.properties do not get applied when 
supplied in geode.properties but rather have to be passed as command line 
properties. e.g. enabling rest api.
It would be nice to call that out clearly in docs.

There are example of properties which have to be applied together in order to 
enable a functionality e.g. rest api needs bind address property and 
http-service-port. Its not called out clearly in the docs that they are 
*mandatory*. 
[link to docs 
section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)

~~quote ~~

~~To enable the developer REST API service in Apache Geode, set the 
start-dev-rest-api Geode property to true when starting a data node using 
either gfsh or the ServerLauncher API. Setting this property to true on a data 
node will start up an embedded Jetty server and deploy the REST developer API 
WAR file.~~

~~It should highlight that its necessary to have 2 more properties bind-address 
and http-service-port defined to make it work.~~

We would be happy to provide further details on this matter if needed.


> Docs to segregate types of properties
> -
>
> Key: GEODE-2052
> URL: https://issues.apache.org/jira/browse/GEODE-2052
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Pulkit Chandra
>Assignee: Dave Barnes
>
> Geode has a lot of properties. But they are not mentioned in context but 
> rather listed as geode properties which can go in geode.properties and 
> gfsecurity.properties.
> It would nice to have a segregation by Locator and Server under 
> geode.properties. The reason for this ask is that some properties do not 
> apply to both locator and server. Currently the only way to know this is by 
> experience or trial and error.
> ~~We also found out that some of the gemfire.properties do not get applied 
> when supplied in geode.properties but rather have to be passed as command 
> line properties. e.g. enabling rest api.
> It would be nice to call that out clearly in docs.~~
> ~~There are example of properties which have to be applied together in order 
> to enable a functionality e.g. rest api needs bind address property and 
> http-service-port. Its not called out clearly in the docs that they are 
> *mandatory*. ~~
> [link to docs 
> section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)
> ~~quote ~~
> ~~To enable the developer REST API service in Apache Geode, set the 
> start-dev-rest-api Geode property to true when starting a data node using 
> either gfsh or the ServerLauncher API. Setting this property to true on a 
> data node will start up an embedded Jetty server and deploy the REST 
> developer API WAR

[jira] [Updated] (GEODE-2052) Docs to segregate types of properties

2017-02-13 Thread Dave Barnes (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-2052:
---
Description: 
Geode has a lot of properties. But they are not mentioned in context but rather 
listed as geode properties which can go in geode.properties and 
gfsecurity.properties.

It would nice to have a segregation by Locator and Server under 
geode.properties. The reason for this ask is that some properties do not apply 
to both locator and server. Currently the only way to know this is by 
experience or trial and error.

We also found out that some of the gemfire.properties do not get applied when 
supplied in geode.properties but rather have to be passed as command line 
properties. e.g. enabling rest api.
It would be nice to call that out clearly in docs.

There are example of properties which have to be applied together in order to 
enable a functionality e.g. rest api needs bind address property and 
http-service-port. Its not called out clearly in the docs that they are 
*mandatory*. 
[link to docs 
section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)

~~quote ~~

~~To enable the developer REST API service in Apache Geode, set the 
start-dev-rest-api Geode property to true when starting a data node using 
either gfsh or the ServerLauncher API. Setting this property to true on a data 
node will start up an embedded Jetty server and deploy the REST developer API 
WAR file.~~

~~It should highlight that its necessary to have 2 more properties bind-address 
and http-service-port defined to make it work.~~

We would be happy to provide further details on this matter if needed.

  was:
Geode has a lot of properties. But they are not mentioned in context but rather 
listed as geode properties which can go in geode.properties and 
gfsecurity.properties.

It would nice to have a segregation by Locator and Server under 
geode.properties. The reason for this ask is that some properties do not apply 
to both locator and server. Currently the only way to know this is by 
experience or trial and error.

We also found out that some of the gemfire.properties do not get applied when 
supplied in geode.properties but rather have to be passed as command line 
properties. e.g. enabling rest api.
It would be nice to call that out clearly in docs.

There are example of properties which have to be applied together in order to 
enable a functionality e.g. rest api needs bind address property and 
http-service-port. Its not called out clearly in the docs that they are 
*mandatory*. 
[link to docs 
section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)

quote 

```
To enable the developer REST API service in Apache Geode, set the 
start-dev-rest-api Geode property to true when starting a data node using 
either gfsh or the ServerLauncher API. Setting this property to true on a data 
node will start up an embedded Jetty server and deploy the REST developer API 
WAR file.

```
It should highlight that its necessary to have 2 more properties bind-address 
and http-service-port defined to make it work.

We would be happy to provide further details on this matter if needed.


> Docs to segregate types of properties
> -
>
> Key: GEODE-2052
> URL: https://issues.apache.org/jira/browse/GEODE-2052
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Pulkit Chandra
>Assignee: Dave Barnes
>
> Geode has a lot of properties. But they are not mentioned in context but 
> rather listed as geode properties which can go in geode.properties and 
> gfsecurity.properties.
> It would nice to have a segregation by Locator and Server under 
> geode.properties. The reason for this ask is that some properties do not 
> apply to both locator and server. Currently the only way to know this is by 
> experience or trial and error.
> We also found out that some of the gemfire.properties do not get applied when 
> supplied in geode.properties but rather have to be passed as command line 
> properties. e.g. enabling rest api.
> It would be nice to call that out clearly in docs.
> There are example of properties which have to be applied together in order to 
> enable a functionality e.g. rest api needs bind address property and 
> http-service-port. Its not called out clearly in the docs that they are 
> *mandatory*. 
> [link to docs 
> section](http://geode.incubator.apache.org/docs/guide/rest_apps/setup_config.html)
> ~~quote ~~
> ~~To enable the developer REST API service in Apache Geode, set the 
> start-dev-rest-api Geode property to true when starting a data node using 
> either gfsh or the ServerLauncher API. Setting this property to true on a 
> data node will start up an embedded Jetty server and deploy the REST 
> developer API WAR file.~~
> ~~It should

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #471 was SUCCESSFUL (with 1679 tests)

2017-02-13 Thread Spring CI


---
Spring Data GemFire > Nightly-ApacheGeode > #471 was successful.
---
Scheduled
1681 tests in total.

https://build.spring.io/browse/SGF-NAG-471/





--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode-native pull request #3: Replace ace calls to standard functions

2017-02-13 Thread dgkimura

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/3#discussion_r100917160
  
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
 }
 if (compId != expectedPartType) {
   char exMsg[256];
-  ACE_OS::snprintf(exMsg, 255,
+  std::snprintf(exMsg, 255,
--- End diff --

Ah, thanks.  I didn't see that.  I'll update the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #3: Replace ace calls to standard functions

2017-02-13 Thread dgkimura

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/3#discussion_r10091
  
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const 
xmlChar** atts) {
 throw CacheXmlException(s.c_str());
   }
 
-  ACE_OS::strncpy(libraryFunctionName, (char*)atts[i], len);
+  std::strncpy(libraryFunctionName, (char*)atts[i], len);
--- End diff --

Alright.  Thanks for the clang-tidy tip.  I'll add these changes and update 
the pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEODE-2398) Sporadic Oplog corruption due to channel.write failure

2017-02-13 Thread Kenneth Howe (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe resolved GEODE-2398.
-
   Resolution: Fixed
Fix Version/s: 1.2.0

Commits:
fb14e9aab263654ed0176dcc3c9738be1b208a82
9b0f16570aad4abc82b71d0d16167a9774449d41

> Sporadic Oplog corruption due to channel.write failure
> --
>
> Key: GEODE-2398
> URL: https://issues.apache.org/jira/browse/GEODE-2398
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
> Fix For: 1.2.0
>
>
> There have been some occurrences of Oplog corruption during testing that have 
> been traced to failures in writing oplog entries to the .crf file. When it 
> fails, Oplog.flush attempts to write a ByteBuffer to the file channel. The 
> call to channel.write(bb) method returns 0 bytes written, but the source 
> ByteBuffer position is moved to the ByteBuffer limit.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #3: Replace ace calls to standard functions

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/3#discussion_r100912867
  
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
 }
 if (compId != expectedPartType) {
   char exMsg[256];
-  ACE_OS::snprintf(exMsg, 255,
+  std::snprintf(exMsg, 255,
--- End diff --

We don't have a good command to execute. I suggest looking for integration 
into what ever editor you have with clang-format. There appears to be some 
differences between clang-format on mac and windows so limit the formatting to 
files you are editing. 

For example, in Eclipse, I have reformat on save configured. 

The following lines used to be aligned with the changed line's open paren. 
The guide defines specific rules for when to align to the paren or indent.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2423) Remove unused keystore files

2017-02-13 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864559#comment-15864559
 ] 

ASF GitHub Bot commented on GEODE-2423:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/2


> Remove unused keystore files
> 
>
> Key: GEODE-2423
> URL: https://issues.apache.org/jira/browse/GEODE-2423
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Michael Martell
>
> This task is to remove unreferenced files in 
> cppcache/integration-test/keystore folder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2423) Remove unused keystore files


[ 
https://issues.apache.org/jira/browse/GEODE-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864557#comment-15864557
 ] 

ASF subversion and git services commented on GEODE-2423:


Commit 0c5c809bf82e250b395a0a2faff0f5b38d0a76f2 in geode-native's branch 
refs/heads/develop from [~mmartell]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=0c5c809 ]

GEODE-2423: Remove unused keystore files and rename to geode.keystore

This closes #2.


> Remove unused keystore files
> 
>
> Key: GEODE-2423
> URL: https://issues.apache.org/jira/browse/GEODE-2423
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Michael Martell
>
> This task is to remove unreferenced files in 
> cppcache/integration-test/keystore folder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #2: GEODE-2423: Remove unused keystore files and r...

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2357) Update cli quickstarts


[ 
https://issues.apache.org/jira/browse/GEODE-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864553#comment-15864553
 ] 

ASF GitHub Bot commented on GEODE-2357:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/1


> Update cli quickstarts
> --
>
> Key: GEODE-2357
> URL: https://issues.apache.org/jira/browse/GEODE-2357
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Michael Martell
>
> Transform Gemfire => Geode as appropriate



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #1: GEODE-2357: Replace gemfire with geode (all ca...

2017-02-13 Thread ASF subversion and git services (JIRA)

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2357) Update cli quickstarts


[ 
https://issues.apache.org/jira/browse/GEODE-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864551#comment-15864551
 ] 

ASF subversion and git services commented on GEODE-2357:


Commit f0410fbe1fb53113358aed7d93c5f4b5f262f7f7 in geode-native's branch 
refs/heads/develop from [~mmartell]
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=f0410fb ]

GEODE-2357: Replace gemfire with geode (all case variants) in C#
quickstarts

This closes #1


> Update cli quickstarts
> --
>
> Key: GEODE-2357
> URL: https://issues.apache.org/jira/browse/GEODE-2357
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Michael Martell
>
> Transform Gemfire => Geode as appropriate



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2231) Create new partitioning example

2017-02-13 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864542#comment-15864542
 ] 

ASF subversion and git services commented on GEODE-2231:


Commit c22885346b8af173bc4765cf179b0a96d70959bc in geode-examples's branch 
refs/heads/feature/GEODE-2231 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;h=c228853 ]

GEODE-2231 Revise Producer tests and the README.md

- Re-run spotlessApply.
- Clean up unused code and update comments.


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56613: GEODE-2475: Upgrade Lucene version to 6.4.1

2017-02-13 Thread xiaojian zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56613/#review165393
---


Ship it!




Ship It!

- xiaojian zhou


On Feb. 13, 2017, 9:02 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56613/
> ---
> 
> (Updated Feb. 13, 2017, 9:02 p.m.)
> 
> 
> Review request for geode, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Upgrading lucene version to 6.4.1
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/directory/RegionDirectory.java
>  2623e16 
>   gradle/dependency-versions.properties 75b1243 
> 
> Diff: https://reviews.apache.org/r/56613/diff/
> 
> 
> Testing
> ---
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[jira] [Commented] (GEODE-2408) Refactor CacheableDate to use C++ std::chrono

2017-02-13 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864525#comment-15864525
 ] 

ASF subversion and git services commented on GEODE-2408:


Commit e1f99a67b77658178f2d5e3b025ed5f1369060ca in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=e1f99a6 ]

GEODE-2408: Removed non-standard timeval type methods.


> Refactor CacheableDate to use C++ std::chrono
> -
>
> Key: GEODE-2408
> URL: https://issues.apache.org/jira/browse/GEODE-2408
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2423) Remove unused keystore files

2017-02-13 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864527#comment-15864527
 ] 

ASF GitHub Bot commented on GEODE-2423:
---

Github user PivotalSarge commented on the issue:

https://github.com/apache/geode-native/pull/2
  
LGTM


> Remove unused keystore files
> 
>
> Key: GEODE-2423
> URL: https://issues.apache.org/jira/browse/GEODE-2423
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Michael Martell
>
> This task is to remove unreferenced files in 
> cppcache/integration-test/keystore folder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2408) Refactor CacheableDate to use C++ std::chrono


[ 
https://issues.apache.org/jira/browse/GEODE-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864523#comment-15864523
 ] 

ASF subversion and git services commented on GEODE-2408:


Commit 1d16b3be249693b7bd5bf4422445a0635c9d1379 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=1d16b3b ]

GEODE-2408: Refactor CacheableDate with C++11 standards.


> Refactor CacheableDate to use C++ std::chrono
> -
>
> Key: GEODE-2408
> URL: https://issues.apache.org/jira/browse/GEODE-2408
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2408) Refactor CacheableDate to use C++ std::chrono

2017-02-13 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864524#comment-15864524
 ] 

ASF subversion and git services commented on GEODE-2408:


Commit bc1a8faccd7dceb2e37abe632ab809adc23e790a in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=bc1a8fa ]

GEODE-2408: Updated usage of deprecated CacheableDate.


> Refactor CacheableDate to use C++ std::chrono
> -
>
> Key: GEODE-2408
> URL: https://issues.apache.org/jira/browse/GEODE-2408
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2408) Refactor CacheableDate to use C++ std::chrono


[ 
https://issues.apache.org/jira/browse/GEODE-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864526#comment-15864526
 ] 

ASF GitHub Bot commented on GEODE-2408:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/9


> Refactor CacheableDate to use C++ std::chrono
> -
>
> Key: GEODE-2408
> URL: https://issues.apache.org/jira/browse/GEODE-2408
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-1824) CI Failure: LuceneQueriesPeerPRRedundancyDUnitTest.returnCorrectResultsWhenCloseCacheHappensOnPartialIndexWrite

2017-02-13 Thread Dan Smith (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith resolved GEODE-1824.
--
   Resolution: Cannot Reproduce
 Assignee: Dan Smith
Fix Version/s: 1.2.0

I haven't seen this happen after running a few hundred times with 
dbea592cc96f64c9fbc7abf8bbf597a69c5881cd. I am seeing GEODE-2477. The code has 
changed quite a bit since this was filed. Closing this issue in favor that one.

> CI Failure: 
> LuceneQueriesPeerPRRedundancyDUnitTest.returnCorrectResultsWhenCloseCacheHappensOnPartialIndexWrite
> ---
>
> Key: GEODE-1824
> URL: https://issues.apache.org/jira/browse/GEODE-1824
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Anilkumar Gingade
>Assignee: Dan Smith
>  Labels: CI
> Fix For: 1.2.0
>
>
> Build #3764 (Aug 24, 2016 11:09:14 PM) 
> Revision: 98531a16f8844a1028e2e6de293eb080d8ea7a1d
> refs/remotes/origin/develop
> Error Message
> java.lang.AssertionError
> Stacktrace
> java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertTrue(Assert.java:52)
>   at 
> com.gemstone.gemfire.cache.lucene.LuceneQueriesPeerPRRedundancyDUnitTest.putEntriesAndValidateResultsWithRedundancy(LuceneQueriesPeerPRRedundancyDUnitTest.java:114)
>   at 
> com.gemstone.gemfire.cache.lucene.LuceneQueriesPeerPRRedundancyDUnitTest.returnCorrectResultsWhenCloseCacheHappensOnPartialIndexWrite(LuceneQueriesPeerPRRedundancyDUnitTest.java:90)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.GeneratedMethodAccessor166.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)

[GitHub] geode-native pull request #9: [GEODE-2408] Refactor CacheableDate with C++11...