[jira] [Commented] (GEODE-2760) Remove GemFire references from packer scripts

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959962#comment-15959962
 ] 

ASF subversion and git services commented on GEODE-2760:


Commit 731f89fe80de7ab8a33a31d700fd74027a6bf01d in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=731f89f ]

GEODE-2760: Removed hardcoded version.


> Remove GemFire references from packer scripts
> -
>
> Key: GEODE-2760
> URL: https://issues.apache.org/jira/browse/GEODE-2760
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Remove GemFire references from packer scripts



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

[Jinmei Liao]

> On April 6, 2017, 11:07 p.m., Jared Stewart wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
> > Line 56 (original), 53 (patched)
> > 
> >
> > This doesn't relate to your changes per se, but I am curious why ENV 
> > needs to be ThreadLocal while securityService does not.  Do you know how 
> > Spring manages the instances of this class?  I.e. is there a singleton 
> > instance, or one instance per session, or something else?
> 
> Jinmei Liao wrote:
> I believe it's just a singleton instance in the web container. It's 
> defined in the servlet xml:
> 
>   
>  class="org.apache.geode.management.internal.web.controllers.support.LoginHandlerInterceptor"/>
>   
> 
> Jared Stewart wrote:
> Hm, that seems possibly worrisome to me. Maybe you can clarify.  When 
> someone logs in, I believe Shrio sets the subject on the (ThreadLocal) 
> ThreadContext.  But since this is a thread in a web server, can't that thread 
> later potentially server requests from a different user?  What stops this 
> later user from getting the subject set on the thread earlier?

the later user will come in and this interceptor will always call a login() and 
hence sets the subject with the new user on this thread. every request is 
stateless, after request is done, a logout() will get called to clear the 
subject on the thread as well.


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58238/#review171268
---


On April 6, 2017, 9:12 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58238/
> ---
> 
> (Updated April 6, 2017, 9:12 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2756: Do not put security-* properties in the env.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
>  9e051748f48b6d792724706535b120f1f4b0d1be 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorJUnitTest.java
>  63d410f6335d9eabbb2547551e32dab8631c7871 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java
>  118e3853750d7ea3ef9af6ac092664a4dabb0108 
> 
> 
> Diff: https://reviews.apache.org/r/58238/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

[Jared Stewart]

> On April 6, 2017, 11:07 p.m., Jared Stewart wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
> > Line 56 (original), 53 (patched)
> > 
> >
> > This doesn't relate to your changes per se, but I am curious why ENV 
> > needs to be ThreadLocal while securityService does not.  Do you know how 
> > Spring manages the instances of this class?  I.e. is there a singleton 
> > instance, or one instance per session, or something else?
> 
> Jinmei Liao wrote:
> I believe it's just a singleton instance in the web container. It's 
> defined in the servlet xml:
> 
>   
>  class="org.apache.geode.management.internal.web.controllers.support.LoginHandlerInterceptor"/>
>   

Hm, that seems possibly worrisome to me. Maybe you can clarify.  When someone 
logs in, I believe Shrio sets the subject on the (ThreadLocal) ThreadContext.  
But since this is a thread in a web server, can't that thread later potentially 
server requests from a different user?  What stops this later user from getting 
the subject set on the thread earlier?


- Jared


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58238/#review171268
---


On April 6, 2017, 9:12 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58238/
> ---
> 
> (Updated April 6, 2017, 9:12 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2756: Do not put security-* properties in the env.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
>  9e051748f48b6d792724706535b120f1f4b0d1be 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorJUnitTest.java
>  63d410f6335d9eabbb2547551e32dab8631c7871 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java
>  118e3853750d7ea3ef9af6ac092664a4dabb0108 
> 
> 
> Diff: https://reviews.apache.org/r/58238/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

[Jinmei Liao]

> On April 6, 2017, 11:07 p.m., Jared Stewart wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
> > Line 56 (original), 53 (patched)
> > 
> >
> > This doesn't relate to your changes per se, but I am curious why ENV 
> > needs to be ThreadLocal while securityService does not.  Do you know how 
> > Spring manages the instances of this class?  I.e. is there a singleton 
> > instance, or one instance per session, or something else?

I believe it's just a singleton instance in the web container. It's defined in 
the servlet xml:

  

  


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58238/#review171268
---


On April 6, 2017, 9:12 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58238/
> ---
> 
> (Updated April 6, 2017, 9:12 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2756: Do not put security-* properties in the env.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
>  9e051748f48b6d792724706535b120f1f4b0d1be 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorJUnitTest.java
>  63d410f6335d9eabbb2547551e32dab8631c7871 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java
>  118e3853750d7ea3ef9af6ac092664a4dabb0108 
> 
> 
> Diff: https://reviews.apache.org/r/58238/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58238/#review171269
---


Ship it!




Ship It!

- Jared Stewart


On April 6, 2017, 9:12 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58238/
> ---
> 
> (Updated April 6, 2017, 9:12 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2756: Do not put security-* properties in the env.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
>  9e051748f48b6d792724706535b120f1f4b0d1be 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorJUnitTest.java
>  63d410f6335d9eabbb2547551e32dab8631c7871 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java
>  118e3853750d7ea3ef9af6ac092664a4dabb0108 
> 
> 
> Diff: https://reviews.apache.org/r/58238/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58238/#review171268
---




geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
Line 56 (original), 53 (patched)


This doesn't relate to your changes per se, but I am curious why ENV needs 
to be ThreadLocal while securityService does not.  Do you know how Spring 
manages the instances of this class?  I.e. is there a singleton instance, or 
one instance per session, or something else?


- Jared Stewart


On April 6, 2017, 9:12 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58238/
> ---
> 
> (Updated April 6, 2017, 9:12 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2756: Do not put security-* properties in the env.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
>  9e051748f48b6d792724706535b120f1f4b0d1be 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorJUnitTest.java
>  63d410f6335d9eabbb2547551e32dab8631c7871 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java
>  118e3853750d7ea3ef9af6ac092664a4dabb0108 
> 
> 
> Diff: https://reviews.apache.org/r/58238/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[GitHub] geode pull request #442: AEQ being created before region

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/442

AEQ being created before region

@jhuynh1 Please do review , Is there any  window where the redundancy 
failure may occur?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode aeqCreatePreRegion

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #442


commit 13b4c93938fe005c21b4336e91431fbfc539
Author: nabarun 
Date:   2017-04-04T02:06:45Z

AEQ being created before region




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2732) after auto-reconnect a server is restarted on the default port of 40404

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959922#comment-15959922
 ] 

ASF subversion and git services commented on GEODE-2732:


Commit 799548ee4e4d883309f83bf401d6af892b3abfc1 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=799548e ]

GEODE-2732 after auto-reconnect a server is restarted on the default port

Now that gfsh cache server parameters are no longer held in a ThreadLocal
we need to clear the static variables holding the parameters in order
to avoid having one test affect another.


> after auto-reconnect a server is restarted on the default port of 40404
> ---
>
> Key: GEODE-2732
> URL: https://issues.apache.org/jira/browse/GEODE-2732
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
> Fix For: 1.2.0
>
>
> If you start a server using gfsh with the server defined in a cache.xml and 
> you specify the server's port Geode will ignore this setting in the event of 
> an auto-reconnect.  I observed this in a GemFire deployment and the code in 
> this area hasn't changed in Apache Geode.  By chance port 40404 was already 
> in use when the auto-reconnect occurred and an exception was thrown.
> {noformat}
> com.gemstone.gemfire.GemFireIOException: While starting bridge server  
> CacheServer on port=40404 client subscription config policy=none client 
> subscription config capacity=1 client subscription config overflow directory=.
>   at 
> com.gemstone.gemfire.internal.cache.xmlcache.CacheCreation.create(CacheCreation.java:611)
>   at 
> com.gemstone.gemfire.internal.cache.xmlcache.CacheXmlParser.create(CacheXmlParser.java:340)
>   at 
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.loadCacheXml(GemFireCacheImpl.java:4263)
>   at 
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.initializeDeclarativeCache(GemFireCacheImpl.java:1178)
>   at 
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.init(GemFireCacheImpl.java:1020)
>   at 
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:684)
>   at 
> com.gemstone.gemfire.distributed.internal.InternalDistributedSystem.reconnect(InternalDistributedSystem.java:2909)
>   at 
> com.gemstone.gemfire.distributed.internal.InternalDistributedSystem.tryReconnect(InternalDistributedSystem.java:2655)
>   at 
> com.gemstone.gemfire.distributed.internal.InternalDistributedSystem.disconnect(InternalDistributedSystem.java:1058)
>   at 
> com.gemstone.gemfire.distributed.internal.DistributionManager$MyListener.membershipFailure(DistributionManager.java:4822)
>   at 
> com.gemstone.gemfire.distributed.internal.membership.jgroup.JGroupMembershipManager.uncleanShutdown(JGroupMembershipManager.java:2733)
>   at 
> com.gemstone.gemfire.distributed.internal.membership.jgroup.JGroupMembershipManager$Puller.channelClosing(JGroupMembershipManager.java:1213)
>   at 
> com.gemstone.org.jgroups.JChannel$CloserThread.run(JChannel.java:1617)
> Caused by: java.net.BindException: Address already in use
>   at sun.nio.ch.Net.bind0(Native Method)
>   at sun.nio.ch.Net.bind(Net.java:463)
>   at sun.nio.ch.Net.bind(Net.java:455)
>   at 
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
>   at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
>   at 
> com.gemstone.gemfire.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:432)
>   at 
> com.gemstone.gemfire.internal.cache.BridgeServerImpl.start(BridgeServerImpl.java:342)
>   at 
> com.gemstone.gemfire.internal.cache.xmlcache.CacheCreation.create(CacheCreation.java:607)
>   ... 12 more
> {noformat}
> I think the fix is to get rid of the ThreadLocal storage of the port and bind 
> address in CacheServerLauncher.  These variables are used by the XML parser 
> to configure a server.  Gfsh sets them in its thread but they aren't 
> available in the auto-reconnect thread that rebuilds the cache.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #516 has FAILED (1 tests failed)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #516 failed.
---
Scheduled
1/1845 tests failed.

https://build.spring.io/browse/SGF-NAG-516/

-
Currently Responsible
-

No one is responsible for fixing this build.



--
Failing Jobs
--
  - Default Job (Default Stage): 1 of 1845 tests failed.




--
Tests
--
New Test Failures (1)
   - ApacheGeodeSecurityManagerGeodeSecurityIntegrationTests: Authorized user

--
This message is automatically generated by Atlassian Bamboo

Fixed: apache/geode-native#263 (develop - 36fe115)

[Travis CI]

Build Update for apache/geode-native
-

Build: #263
Status: Fixed

Duration: 26 minutes and 5 seconds
Commit: 36fe115 (develop)
Author: Jacob Barrett
Message: GEODE-2759: Updated sqlite download to https,

View the changeset: 
https://github.com/apache/geode-native/compare/90b9da986f9f...36fe1158c9b9

View the full build log and details: 
https://travis-ci.org/apache/geode-native/builds/219436553

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: Build failed in Jenkins: Geode-nightly #799

[Bruce Schuchardt]

This failure may be due to the cache-server port handling changes I 
checked in yesterday.  I'll look into it.



*Revision*: 669d3ed1f2ab7e05edfa15bb19b5782ebc05d753

 * refs/remotes/origin/develop

Test Result
    (14
   failures / +12)

 * org.apache.geode.cache30.CacheXml81DUnitTest.testOneCacheServerGroups
   

 * 
org.apache.geode.cache30.CacheXml81DUnitTest.testBridgeAttributesRelatedToHAOverFlow
   

 * 
org.apache.geode.cache30.CacheXml81DUnitTest.testDefaultCacheServerBindAddress
   

 * org.apache.geode.cache30.CacheXml81DUnitTest.testBridgeLoadProbe
   

 * 
org.apache.geode.cache30.CacheXml81DUnitTest.testCacheServerHostnameForClients
   

 * org.apache.geode.cache30.CacheXml81DUnitTest.testTwoCacheServerGroups
   

 * 
org.apache.geode.cache30.CacheXml81DUnitTest.testClientSubscriptionQueueUsingDefaultDS
   

 * org.apache.geode.cache30.CacheXml81DUnitTest.testBridgeServers
   

 * org.apache.geode.cache30.CacheXml81DUnitTest.testBridgeMaxThreads
   

 * 
org.apache.geode.cache30.CacheXml81DUnitTest.testBridgeAttributesRelatedToClientQueuesHA
   



Le 4/6/2017 à 12:33 PM, Apache Jenkins Server a écrit :

See 


Changes:

[jiliao] GEM-1351: Move a test to the open side and fix the other tests

[jiliao] GEM-1351: Move a test to the open side and fix the other tests -

[bschuchardt] GEODE-2751

[bschuchardt] GEODE-2751

[klund] GEODE-2749: don't ignore bin/ because we have bin/ in src

[bschuchardt] GEODE-2732 after auto-reconnect a server is restarted on the 
default

[bschuchardt] GEODE-2684 Connection & ConnectionTable cleanup

[bschuchardt] GEODE-2684 Connection & ConnectionTable cleanup

[bschuchardt] GEODE-2732 after auto-reconnect a server is restarted on the 
default

--
[...truncated 139.79 KB...]
   
   
   
 

 Caused by:
 java.lang.RuntimeException: cache server BridgeServerCreation on port 
23936 notify by subscription true maximum time between pings 6 socket 
buffer size 32768 maximum connections 800 maximum threads 0 maximum message 
count 23 message time to live 180 groups [] loadProbe ConnectionCountProbe 
loadPollInterval 5000 Eviction policy entry capacity 501 DiskStore Name: 
CacheXml81DUnitTest_testBridgeAttributesRelatedToHAOverFlow65 not found

6847 tests completed, 14 failed, 603 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE

[jira] [Commented] (GEODE-2759) Update sqlite download to https

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959774#comment-15959774
 ] 

ASF subversion and git services commented on GEODE-2759:


Commit ff12c9685cc5317f5aa8ac9bc872ac666435c8d8 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=ff12c96 ]

GEODE-2759: Updated sqlite.net download to https.


> Update sqlite download to https
> ---
>
> Key: GEODE-2759
> URL: https://issues.apache.org/jira/browse/GEODE-2759
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Update sqlite download to https



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2756) export logs integration with security

[Jinmei Liao (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao resolved GEODE-2756.

   Resolution: Fixed
Fix Version/s: 1.2.0

> export logs integration with security
> -
>
> Key: GEODE-2756
> URL: https://issues.apache.org/jira/browse/GEODE-2756
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Swapnil Bawaskar
>Assignee: Jinmei Liao
> Fix For: 1.2.0
>
>
> We need to make sure that a user is able to export logs when a 
> {{security-manager}} has been configured.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2756) export logs integration with security

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959767#comment-15959767
 ] 

ASF subversion and git services commented on GEODE-2756:


Commit 19376d3069a7808481b2ed572ea49e3610dc9df1 in geode's branch 
refs/heads/develop from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=19376d3 ]

GEODE-2756: Do not put security-* properties in the env.


> export logs integration with security
> -
>
> Key: GEODE-2756
> URL: https://issues.apache.org/jira/browse/GEODE-2756
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Swapnil Bawaskar
>Assignee: Jinmei Liao
>
> We need to make sure that a user is able to export logs when a 
> {{security-manager}} has been configured.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58238/
---

(Updated April 6, 2017, 9:12 p.m.)


Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
Rhomberg.


Repository: geode


Description
---

GEODE-2756: Do not put security-* properties in the env.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
 9e051748f48b6d792724706535b120f1f4b0d1be 
  
geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorJUnitTest.java
 63d410f6335d9eabbb2547551e32dab8631c7871 
  
geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java
 118e3853750d7ea3ef9af6ac092664a4dabb0108 


Diff: https://reviews.apache.org/r/58238/diff/1/


Testing (updated)
---

precheckin successful


Thanks,

Jinmei Liao

Broken: apache/geode-native#262 (develop - 90b9da9)

[Travis CI]

Build Update for apache/geode-native
-

Build: #262
Status: Broken

Duration: 4 minutes and 10 seconds
Commit: 90b9da9 (develop)
Author: Jacob Barrett
Message: GEODE-2758: Fixes path to Solaris SPARC assembly source.

View the changeset: 
https://github.com/apache/geode-native/compare/67e50b7598ff...90b9da986f9f

View the full build log and details: 
https://travis-ci.org/apache/geode-native/builds/219431904

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[jira] [Resolved] (GEODE-2759) Update sqlite download to https

[Jacob S. Barrett (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett resolved GEODE-2759.
-
Resolution: Fixed

> Update sqlite download to https
> ---
>
> Key: GEODE-2759
> URL: https://issues.apache.org/jira/browse/GEODE-2759
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Update sqlite download to https



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2759) Update sqlite download to https

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959696#comment-15959696
 ] 

ASF subversion and git services commented on GEODE-2759:


Commit 36fe1158c9b96bf70f2345deb539c97722f737f7 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=36fe115 ]

GEODE-2759: Updated sqlite download to https,

> Update sqlite download to https
> ---
>
> Key: GEODE-2759
> URL: https://issues.apache.org/jira/browse/GEODE-2759
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Update sqlite download to https



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2759) Update sqlite download to https

[Jacob S. Barrett (JIRA)]

Jacob S. Barrett created GEODE-2759:
---

 Summary: Update sqlite download to https
 Key: GEODE-2759
 URL: https://issues.apache.org/jira/browse/GEODE-2759
 Project: Geode
  Issue Type: Task
  Components: native client
Reporter: Jacob S. Barrett


Update sqlite download to https



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2758) Solaris SPARC assembly not found at configure time.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959669#comment-15959669
 ] 

ASF subversion and git services commented on GEODE-2758:


Commit 90b9da986f9fa84a762a7a79f290f3b18ad2579f in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=90b9da9 ]

GEODE-2758: Fixes path to Solaris SPARC assembly source.


> Solaris SPARC assembly not found at configure time.
> ---
>
> Key: GEODE-2758
> URL: https://issues.apache.org/jira/browse/GEODE-2758
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> The path to the SPARC assembly file is incorrect in the CMakeList.txt for 
> cppcache.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: Geode-nightly #799

[Apache Jenkins Server]

See 


Changes:

[jiliao] GEM-1351: Move a test to the open side and fix the other tests

[jiliao] GEM-1351: Move a test to the open side and fix the other tests -

[bschuchardt] GEODE-2751

[bschuchardt] GEODE-2751

[klund] GEODE-2749: don't ignore bin/ because we have bin/ in src

[bschuchardt] GEODE-2732 after auto-reconnect a server is restarted on the 
default

[bschuchardt] GEODE-2684 Connection & ConnectionTable cleanup

[bschuchardt] GEODE-2684 Connection & ConnectionTable cleanup

[bschuchardt] GEODE-2732 after auto-reconnect a server is restarted on the 
default

--
[...truncated 139.79 KB...]
  
  
  


Caused by:
java.lang.RuntimeException: cache server BridgeServerCreation on port 
23936 notify by subscription true maximum time between pings 6 socket 
buffer size 32768 maximum connections 800 maximum threads 0 maximum message 
count 23 message time to live 180 groups [] loadProbe ConnectionCountProbe 
loadPollInterval 5000 Eviction policy entry capacity 501 DiskStore Name: 
CacheXml81DUnitTest_testBridgeAttributesRelatedToHAOverFlow65 not found

6847 tests completed, 14 failed, 603 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

[jira] [Created] (GEODE-2758) Solaris SPARC assembly not found at configure time.

[Jacob S. Barrett (JIRA)]

Jacob S. Barrett created GEODE-2758:
---

 Summary: Solaris SPARC assembly not found at configure time.
 Key: GEODE-2758
 URL: https://issues.apache.org/jira/browse/GEODE-2758
 Project: Geode
  Issue Type: Task
  Components: native client
Reporter: Jacob S. Barrett


The path to the SPARC assembly file is incorrect in the CMakeList.txt for 
cppcache.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2662) Gfsh displays field value on wrong line!

[Kevin Duling (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959481#comment-15959481
 ] 

Kevin Duling commented on GEODE-2662:
-

In {{DataCommandFunction.java}} at line 781 is the following code block:

{code}
  private static String pdxToJson(PdxInstance obj) {
if (obj != null) {
  try {
GfJsonObject json = new GfJsonObject();
for (String field : obj.getFieldNames()) {
  Object fieldValue = obj.getField(field);
  if (fieldValue != null) {
if (JsonUtil.isPrimitiveOrWrapper(fieldValue.getClass())) {
  json.put(field, fieldValue);
} else {
  json.put(field, fieldValue.getClass());
}
  }
}
return json.toString();
  } catch (GfJsonException e) {
return null;
  }
}
return null;
  }
{code}

The issue here is the JSON that is being built for the first two objects lacks 
the phone number because that version of the object doesn't contain the field.  
When we get to the third object, the {{telephone}} field is created.

> Gfsh displays field value on wrong line!
> 
>
> Key: GEODE-2662
> URL: https://issues.apache.org/jira/browse/GEODE-2662
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Eitan Suez
>
> scenario:
> start a locator, a server
> write a client that stores several records of a given type, using pdx 
> serialization
> modify the type in question by adding a field
> write one more record to gemfire, populating all fields, including the new 
> field
> invoke a gfsh query command "select * from /"
> the new field value will display always on the first line of the result set, 
> not on the line associated with the object it actually belongs to.
> example:
> Customer
>  firstName, lastName
> write a customer object:
>  John Doe
> now modify Customer, add telephoneNumber
>  write another customer object:
> Sam Smith, 512.333.
> now run:
> query --query="select c from /Customer c"
> will print:
> firstName | lastName | telephoneNumber
> - |  | ---
> John  | Doe  | 512.333.
> Sam   | Smith| null
> even though the query "select c from /Customer c where c.firstName = 'Sam'" 
> clearly shows the phone number is associated with sam.
> this bug has existed in gemfire at least since v8 and verified to still exist 
> in latest version 9.0.1



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #441: Fix a repetition in the README.

[galen-pivotal]

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/441

Fix a repetition in the README.

and update numbers.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/geode fix-README

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #441


commit 65efe3bbba48a8be9bd427789ca833538e761ceb
Author: Galen OSullivan 
Date:   2017-04-06T17:03:28Z

Fix a repetition in the README.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58238/#review171229
---


Ship it!




Ship It!

- Kirk Lund


On April 6, 2017, 4:52 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58238/
> ---
> 
> (Updated April 6, 2017, 4:52 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2756: Do not put security-* properties in the env.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
>  9e051748f48b6d792724706535b120f1f4b0d1be 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorJUnitTest.java
>  63d410f6335d9eabbb2547551e32dab8631c7871 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java
>  118e3853750d7ea3ef9af6ac092664a4dabb0108 
> 
> 
> Diff: https://reviews.apache.org/r/58238/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[jira] [Commented] (GEODE-2725) export logs does not honor --dir

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959359#comment-15959359
 ] 

ASF GitHub Bot commented on GEODE-2725:
---

Github user jinmeiliao commented on the issue:

https://github.com/apache/geode/pull/438
  
I'll pull this in


> export logs does not honor --dir
> 
>
> Key: GEODE-2725
> URL: https://issues.apache.org/jira/browse/GEODE-2725
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh, logging
>Reporter: Swapnil Bawaskar
>Assignee: Patrick Rhomberg
>
> When connected to locator via jmx, run the following command:
> {noformat}
> gfsh>export logs --dir=tmp
> {noformat}
> Observer that the dir option is ignored:
> {noformat}
> Logs exported to the connected member's file system: 
> /Users/sbawaskar/apache/geode/geode-assembly/build/install/apache-geode/loc1/exportedLogs_1490721273215.zip
> {noformat}
> The --tmp option is honored when connected via http.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #438: GEODE-2725: export logs now honors --dir when connected vi...

[jinmeiliao]

Github user jinmeiliao commented on the issue:

https://github.com/apache/geode/pull/438
  
I'll pull this in


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2716) export logs should honor the log level set on the server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959350#comment-15959350
 ] 

ASF subversion and git services commented on GEODE-2716:


Commit 5430c91f61fdb9ae4b0d11758d2b8e5a18f52163 in geode's branch 
refs/heads/develop from [~prhomberg]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5430c91 ]

GEODE-2716: export logs default behavior changed from filtering at log level 
INFO to ALL.

* Removed reliance on LogService.DEFAULT_LOG_LEVEL, added 
ExportLogCommand.DEFAULT_EXPORT_LOG_LEVEL.
* Added DUnit test that fails under previous behavior.
* this closes #439


> export logs should honor the log level set on the server
> 
>
> Key: GEODE-2716
> URL: https://issues.apache.org/jira/browse/GEODE-2716
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Patrick Rhomberg
>
> When no log level is specified, {{export logs}} gets only the info level 
> logs. This is confusing; export logs should get the entire log file from the 
> server when log level is not specified.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #439: GEODE-2716: export logs default behavior changed fr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/439


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #439: GEODE-2716: export logs default behavior changed from filt...

[jinmeiliao]

Github user jinmeiliao commented on the issue:

https://github.com/apache/geode/pull/439
  
I'll pull this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2716) export logs should honor the log level set on the server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959320#comment-15959320
 ] 

ASF GitHub Bot commented on GEODE-2716:
---

Github user jinmeiliao commented on the issue:

https://github.com/apache/geode/pull/439
  
I'll pull this in.


> export logs should honor the log level set on the server
> 
>
> Key: GEODE-2716
> URL: https://issues.apache.org/jira/browse/GEODE-2716
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Patrick Rhomberg
>
> When no log level is specified, {{export logs}} gets only the info level 
> logs. This is confusing; export logs should get the entire log file from the 
> server when log level is not specified.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2653) GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959311#comment-15959311
 ] 

ASF GitHub Bot commented on GEODE-2653:
---

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/437
  
@bschuchardt this is https://reviews.apache.org/r/58155/


> GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError
> 
>
> Key: GEODE-2653
> URL: https://issues.apache.org/jira/browse/GEODE-2653
> Project: Geode
>  Issue Type: Bug
>  Components: membership, tests
>Reporter: Kirk Lund
>Assignee: Galen O'Sullivan
>  Labels: Flaky
>
> Intermittent failure stack:
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest
>  > testRemoveMember FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testRemoveMember(GMSJoinLeaveJUnitTest.java:337)
> {noformat}
> This test looks like it's flaky due to the Thread sleep:
> {noformat}
>   @Test
>   public void testRemoveMember() throws Exception {
> initMocks();
> prepareAndInstallView(mockMembers[0], createMemberList(mockMembers[0], 
> gmsJoinLeaveMemberId));
> MethodExecuted removeMessageSent = new MethodExecuted();
> 
> when(messenger.send(any(RemoveMemberMessage.class))).thenAnswer(removeMessageSent);
> gmsJoinLeave.remove(mockMembers[0], "removing for test");
> Thread.sleep(ServiceConfig.MEMBER_REQUEST_COLLECTION_INTERVAL * 2);
> assertTrue(removeMessageSent.methodExecuted);
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #437: GEODE-2653: Fix testRemoveMember and remove FlakyTest.

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/437
  
@bschuchardt this is https://reviews.apache.org/r/58155/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (GEODE-2756) export logs integration with security

[Jinmei Liao (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao reassigned GEODE-2756:
--

Assignee: Jinmei Liao

> export logs integration with security
> -
>
> Key: GEODE-2756
> URL: https://issues.apache.org/jira/browse/GEODE-2756
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Swapnil Bawaskar
>Assignee: Jinmei Liao
>
> We need to make sure that a user is able to export logs when a 
> {{security-manager}} has been configured.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

[Avinash Dongre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Avinash Dongre reassigned GEODE-2723:
-

Assignee: Avinash Dongre

> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58238/
---

Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
Rhomberg.


Repository: geode


Description
---

GEODE-2756: Do not put security-* properties in the env.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
 9e051748f48b6d792724706535b120f1f4b0d1be 
  
geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorJUnitTest.java
 63d410f6335d9eabbb2547551e32dab8631c7871 
  
geode-web/src/test/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptorRequestHeaderJUnitTest.java
 118e3853750d7ea3ef9af6ac092664a4dabb0108 


Diff: https://reviews.apache.org/r/58238/diff/1/


Testing
---

precheckin running


Thanks,

Jinmei Liao

[jira] [Commented] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959267#comment-15959267
 ] 

ASF GitHub Bot commented on GEODE-2723:
---

GitHub user davinash opened a pull request:

https://github.com/apache/geode/pull/440

GEODE-2723: Removed localCacheEnabled field, and associated dead code.

- Removed localCacheEnabled field, and associated dead code.
- Ran pre-checkin, no failures.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davinash/geode feature/GEODE-2723

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #440






> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #440: GEODE-2723: Removed localCacheEnabled field, and as...

[davinash]

GitHub user davinash opened a pull request:

https://github.com/apache/geode/pull/440

GEODE-2723: Removed localCacheEnabled field, and associated dead code.

- Removed localCacheEnabled field, and associated dead code.
- Ran pre-checkin, no failures.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davinash/geode feature/GEODE-2723

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #440






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2716) export logs should honor the log level set on the server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959243#comment-15959243
 ] 

ASF GitHub Bot commented on GEODE-2716:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/439
  
Full green precheckin completed.


> export logs should honor the log level set on the server
> 
>
> Key: GEODE-2716
> URL: https://issues.apache.org/jira/browse/GEODE-2716
> Project: Geode
>  Issue Type: Sub-task
>  Components: configuration, gfsh
>Reporter: Swapnil Bawaskar
>Assignee: Patrick Rhomberg
>
> When no log level is specified, {{export logs}} gets only the info level 
> logs. This is confusing; export logs should get the entire log file from the 
> server when log level is not specified.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2725) export logs does not honor --dir

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959246#comment-15959246
 ] 

ASF GitHub Bot commented on GEODE-2725:
---

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/438
  
Full green precheckin completed.


> export logs does not honor --dir
> 
>
> Key: GEODE-2725
> URL: https://issues.apache.org/jira/browse/GEODE-2725
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh, logging
>Reporter: Swapnil Bawaskar
>Assignee: Patrick Rhomberg
>
> When connected to locator via jmx, run the following command:
> {noformat}
> gfsh>export logs --dir=tmp
> {noformat}
> Observer that the dir option is ignored:
> {noformat}
> Logs exported to the connected member's file system: 
> /Users/sbawaskar/apache/geode/geode-assembly/build/install/apache-geode/loc1/exportedLogs_1490721273215.zip
> {noformat}
> The --tmp option is honored when connected via http.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #438: GEODE-2725: export logs now honors --dir when connected vi...

[PurelyApplied]

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/438
  
Full green precheckin completed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #439: GEODE-2716: export logs default behavior changed from filt...

[PurelyApplied]

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/439
  
Full green precheckin completed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 56586: GEODE-1716: refactor JMXMBeanDunitTest

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56586/#review171214
---


Ship it!




Ship It!

- Udo Kohlmeyer


On Feb. 13, 2017, 4:07 a.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56586/
> ---
> 
> (Updated Feb. 13, 2017, 4:07 a.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, 
> and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * refactor MBeanServerConnectRule for easier usage.
> * refactor LocatorServerStartupRule to be able to start up locator/server in 
> VM out of sequence
> 
> 
> Diffs
> -
> 
>   geode-core/src/test/java/org/apache/geode/management/JMXMBeanDUnitTest.java 
> 0feb4c25a957eeeb29a34a90227b01257a92a600 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  6c1b4962f82918118401799aad74f399a7cd3af8 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MBeanServerConnectionRule.java
>  d85975fe7e5bff93ce3fd58a2c1f4e529eff57e0 
> 
> 
> Diff: https://reviews.apache.org/r/56586/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin successful. ..
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 58187: GEODE-2732 after auto-reconnect a server is restarted on the default port of 40404

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58187/#review171213
---


Ship it!




Ship It!

- Udo Kohlmeyer


On April 4, 2017, 8:46 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58187/
> ---
> 
> (Updated April 4, 2017, 8:46 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Gfsh command line parameters were put into ThreadLocals to make them 
> available to the XML parser.  These are now held in non-thread-local 
> variables so that all threads, including the auto-reconnect thread, can see 
> them when building the cache.
> 
> This diff also includes some minor refactoring in 
> org.apache.geode.internal.tcp.  It primarily removes some 
> "this.owner.getConduit().doSomething" with "this.conduit.doSomething" and 
> removes dead code.
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-tomcat8/src/test/java/org/apache/geode/modules/session/Tomcat8SessionsClientServerDUnitTest.java
>  e475f40339e294ad48b403db1afa7aa624d5e80c 
>   geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
> 9435bd8178248c4fa34f6867d15a7cdfdec06d6b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerLauncher.java
>  760abd3d946281d474502a9af2e8fe823a011329 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java
>  1c3c93314841f5623c0e6387500af88f106328d9 
>   geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java 
> a0af24501a5081fe483160c5bf4fc7671545684e 
>   geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java 
> 08a90096c0cf0348c0fa34b7ff8e18806810ab68 
>   
> geode-core/src/main/java/org/apache/geode/internal/tcp/DirectReplySender.java 
> 3872ee98ec24fe95894c0def538e3752136b05c3 
>   geode-core/src/main/java/org/apache/geode/internal/tcp/MsgReader.java 
> fc5627112ac8dd456976139d3750fd951812879b 
>   geode-core/src/main/java/org/apache/geode/internal/tcp/NIOMsgReader.java 
> 50f5faedba056ec4f57124aefd56477dc11c1cf6 
>   
> geode-core/src/test/java/org/apache/geode/cache30/ReconnectWithCacheXMLDUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/cache30/ReconnectWithCacheXMLDUnitTest.xml
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58187/diff/1/
> 
> 
> Testing
> ---
> 
> new test, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 58155: GEODE-2653: fix a flaky test.

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58155/#review171212
---


Ship it!




Ship It!

- Udo Kohlmeyer


On April 5, 2017, 11:44 p.m., Galen O'Sullivan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58155/
> ---
> 
> (Updated April 5, 2017, 11:44 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> And do some cleanup while I'm here:
>  * Change Mockito's `any` to `isA`.
>  * Replace some `Thread.sleep()` calls with Awaitility calls.
>  * Remove our `MethodExecuted` class -- this can be done with Mockito's 
> `verify()`.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  05ab6f7e5 
> 
> 
> Diff: https://reviews.apache.org/r/58155/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin passed.
> 
> Ran the test suite in IntelliJ a few hundred times on my machine.
> 
> 
> Thanks,
> 
> Galen O'Sullivan
> 
>