Build failed in Jenkins: Geode-release #55

[Apache Jenkins Server]

See 


Changes:

[dbarnes] GEODE-1672: When amount of overflowed persisted data exceeds heap size

[dbarnes] GEODE-1672: When amount of overflowed persisted data exceeds heap size

--
[...truncated 909.25 KB...]
at org.jgroups.protocols.UDP.start(UDP.java:266)
at org.jgroups.stack.ProtocolStack.startStack(ProtocolStack.java:966)
at org.jgroups.JChannel.startStack(JChannel.java:889)
at org.jgroups.JChannel._preConnect(JChannel.java:553)
at org.jgroups.JChannel.connect(JChannel.java:288)
at org.jgroups.JChannel.connect(JChannel.java:279)
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.start(JGroupsMessenger.java:342)
at 
org.apache.geode.distributed.internal.membership.gms.Services.start(Services.java:147)
at 
org.apache.geode.distributed.internal.membership.gms.GMSMemberFactory.newMembershipManager(GMSMemberFactory.java:102)
at 
org.apache.geode.distributed.internal.membership.MemberFactory.newMembershipManager(MemberFactory.java:89)
at 
org.apache.geode.distributed.internal.DistributionManager.(DistributionManager.java:1153)
at 
org.apache.geode.distributed.internal.DistributionManager.(DistributionManager.java:1201)
at 
org.apache.geode.distributed.internal.DistributionManager.create(DistributionManager.java:572)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:697)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:305)
at 
org.apache.geode.distributed.DistributedSystem.connect(DistributedSystem.java:205)
at 
org.apache.geode.distributed.internal.InternalLocator.startDistributedSystem(InternalLocator.java:697)
at 
org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:324)
at org.apache.geode.distributed.Locator.startLocator(Locator.java:253)
at 
org.apache.geode.distributed.Locator.startLocatorAndDS(Locator.java:202)
at 
org.apache.geode.cache.client.internal.LocatorTestBase.startLocator(LocatorTestBase.java:131)
at 
org.apache.geode.internal.cache.Bug47667DUnitTest.lambda$testbug47667$7063a21e$1(Bug47667DUnitTest.java:67)
at org.apache.geode.test.dunit.NamedRunnable.run(NamedRunnable.java:31)
at sun.reflect.GeneratedMethodAccessor167.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at hydra.MethExecutor.executeObject(MethExecutor.java:245)
at 
org.apache.geode.test.dunit.standalone.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:70)
at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:346)
at sun.rmi.transport.Transport$1.run(Transport.java:200)
at sun.rmi.transport.Transport$1.run(Transport.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
at 
sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683)
at java.security.AccessController.doPrivileged(Native Method)
at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

org.apache.geode.internal.cache.Bug41091DUnitTest > test FAILED
java.lang.AssertionError: Suspicious strings were written to the log during 
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 359

[error 2017/06/06 13:36:08.556 UTC  
tid=0x13] failed setting interface to /127.0.1.1: java.net.SocketException: bad 
argument for IP_MULTICAST_IF: address not bound to any interface
java.net.SocketException: bad argument for IP_MULTICAST_IF: address not 
bound to any interface
at java.net.PlainDatagramSocketImpl.socketSetOption0(Native Method)
at 
java.net.PlainDatagramSocketImpl.socketSetOption(PlainDatagramSocketImpl.java:74)
   

Re: Review Request 59866: GEODE-2555: Region Management docs page refers to the wrong field (id= should be refid=)

[Karen Miller]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59866/#review177130
---


Ship it!




Ship It!

- Karen Miller


On June 6, 2017, 10:50 p.m., Dave Barnes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59866/
> ---
> 
> (Updated June 6, 2017, 10:50 p.m.)
> 
> 
> Review request for geode and Galen O'Sullivan.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2555: Region Management docs page refers to the wrong field (id= should 
> be refid=)
> 
> 
> Diffs
> -
> 
>   geode-docs/basic_config/data_regions/managing_data_regions.html.md.erb 
> c93f13a845544bcc3c1d3de4747aa7c18054ab6d 
> 
> 
> Diff: https://reviews.apache.org/r/59866/diff/1/
> 
> 
> Testing
> ---
> 
> Found and corrected 3 occurrences.
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>

[GitHub] geode issue #474: GEODE-2788: Add official Socket timeout parameter when con...

[masaki-yamakawa]

Github user masaki-yamakawa commented on the issue:

https://github.com/apache/geode/pull/474
  
@galen-pivotal
Thank you very much. Because there was a conflicting file with the change 
so far, I merged again, then pushed. Travis-CI worked normally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

(Updated June 6, 2017, 11:57 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Changes
---

Updated with review feedback.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 388f838e3c906aaba1e6993051f2fcf2ae3c9e82 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 485ccae143f9897a52e57cf82b1386e709d9e22c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
 6534b68510f5d6c4db4d8cfe23b3adc25b455f61 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
 2cb36cdb4d90a18a0c274f09d8f1bf62dded2430 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
 3feba0d22986600d8f10c84d6e072f790bb4c74f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
 ab199542469ae7c578ef9612d6d789f3d58f8023 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
 cf9c470e79d6a8aaf636de5983abb207250efa12 
  

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

[Kirk Lund]

> On June 6, 2017, 10:23 p.m., Jinmei Liao wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
> > Lines 79 (patched)
> > 
> >
> > this seems like a good utility method to find the security service if 
> > it's not passed down in the method or in the member variable. Should we 
> > make it public and put it in say: GemfireCacheImpl.findSecurityService()?
> 
> Kirk Lund wrote:
> Maybe SecurityService.findSecurityService(). I want to avoid adding more 
> stuff (especially static methods) to GemFireCacheImpl.

I moved this method to SecurityServiceFactory.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177108
---


On June 6, 2017, 10:26 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 10:26 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
> d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  9658f98da808e50b87fe54854df249b28b97662d 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
>  1fb8c8cac62c54b582d40688a423fddcae23b36e 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
>  adf702a1d361ba28f4ebe46695325d23344db756 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
>  fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
>   
> 

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

[Kirk Lund]

> On June 6, 2017, 10:23 p.m., Jinmei Liao wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
> > Lines 84 (patched)
> > 
> >
> > this seems to be added by some merge operation? It was recently 
> > deleted, I think.
> 
> Kirk Lund wrote:
> IndexCommands on develop has this line 235:
> ```java
>   final Set targetMembers = 
> CliUtil.findMembers(group, memberNameOrID);
> ```
> I extracted that to the method which overrides getMembers defined in 
> GfshCommand:
> ```java
>   @Override
>   public Set getMembers(final InternalCache cache) {
> // TODO determine what this does (as it is untested and unmockable!)
> return CliUtil.getAllMembers(cache);
>   }
> ```
> I don't know why they're different, but I wanted to clarify what 
> IndexCommands was really doing. I don't want to change how IndexCommands is 
> getting members in this commit so I'm not going to change this. We could 
> inline it back into the getIndexListing method but I made this change to make 
> it very obvious that IndexCommands is finding members differently from other 
> commands. Maybe they did it to prevent a deadlock or (I don't know) -- I 
> think we should leave it until we decide to delete CliUtil.

I decided to delete it. Line 235 reverted somehow anyway.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177108
---


On June 6, 2017, 10:26 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 10:26 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   

[GitHub] geode issue #563: Add a bunch of .proto definitions to the new protocol.

[mattk-pio]

Github user mattk-pio commented on the issue:

https://github.com/apache/geode/pull/563
  
@kohlmu-pivotal Please merge this when possible. Trying not to switch 
between multiple dev branches while working against the new protocol. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Do you want to Tweet for @ApacheGeode?

[Michael Stolz]

Hey Greg,

I could tweet now and then.

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: +1-631-835-4771

On Tue, Jun 6, 2017 at 12:28 PM, Greg Chase  wrote:

> Greetings Apache Geode community,
> Tweeting for the Apache Geode project in the past has been a community
> effort.
>
> However, our most prolific tweeters are currently not spending much time
> with the project.
>
> As a result @ApacheGeode has fallen silent.
>
> Per ASF recommendations, we manage access to the @ApacheGeode Twitter
> handle through Tweet Deck. Any contributor is welcome to Tweet on behalf of
> the project.  You simply need to ask for access, such as replying to this
> thread.
>
> Presuming no concerns raised by the PMC, access is granted to your personal
> Twitter credentials to access @ApacheGeode using Tweet Deck.
>
> Administrative rights to @ApacheGeode are maintained by several PMC
> members.
>
> The guideline for Tweeting for @ApacheGeode is to promote the project,
> announce any important releases, events or topics, and to help answer
> questions or direct askers to u...@geode.apache.org.
>
> You are also welcome to engage in technical topics of interest to Apache
> Geode users, such as event driven architectures, caching patterns,
> in-memory computing, etc.
>
> We recommend not engaging in bashing other projects or products, or
> engaging in off-topic discussions.
>
> If you are interested in helping Tweet for @ApacheGeode, I invite you to
> volunteer by replying to this thread.
>
> Regards,
>
> -Greg
>

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59850/#review177121
---


Ship it!




Ship It!

- Bruce Schuchardt


On June 6, 2017, 11:21 p.m., Udo Kohlmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59850/
> ---
> 
> (Updated June 6, 2017, 11:21 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh 
> Khamesra.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Moved the socket.setSoTimeout setting to be before the SSL handshake. This is 
> to avoid the timeout to never be set in the case of a SSLException. Added a 
> test to test that the socket timeout is correctly set upon failure within the 
> SSL configuration and handshake.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
>  86fe53261 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TcpServerJUnitTest.java
>  7c7a2b376 
>   
> geode-core/src/test/java/org/apache/geode/internal/net/DelaySocketCreator.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59850/diff/2/
> 
> 
> Testing
> ---
> 
> Junit test - done
> precheckin - in progress
> 
> 
> Thanks,
> 
> Udo Kohlmeyer
> 
>

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59850/
---

(Updated June 6, 2017, 11:21 p.m.)


Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh 
Khamesra.


Changes
---

Removing TODO and System.err


Repository: geode


Description
---

Moved the socket.setSoTimeout setting to be before the SSL handshake. This is 
to avoid the timeout to never be set in the case of a SSLException. Added a 
test to test that the socket timeout is correctly set upon failure within the 
SSL configuration and handshake.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
 86fe53261 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TcpServerJUnitTest.java
 7c7a2b376 
  
geode-core/src/test/java/org/apache/geode/internal/net/DelaySocketCreator.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/59850/diff/2/

Changes: https://reviews.apache.org/r/59850/diff/1-2/


Testing
---

Junit test - done
precheckin - in progress


Thanks,

Udo Kohlmeyer

Review Request 59866: GEODE-2555: Region Management docs page refers to the wrong field (id= should be refid=)

[Dave Barnes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59866/
---

Review request for geode and Galen O'Sullivan.


Repository: geode


Description
---

GEODE-2555: Region Management docs page refers to the wrong field (id= should 
be refid=)


Diffs
-

  geode-docs/basic_config/data_regions/managing_data_regions.html.md.erb 
c93f13a845544bcc3c1d3de4747aa7c18054ab6d 


Diff: https://reviews.apache.org/r/59866/diff/1/


Testing
---

Found and corrected 3 occurrences.


Thanks,

Dave Barnes

Re: Review Request 59811: GEODE-2420: add file-size-limit param to the ExportLogsController

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59811/#review177114
---


Ship it!




Ship It!

- Patrick Rhomberg


On June 5, 2017, 6:09 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59811/
> ---
> 
> (Updated June 5, 2017, 6:09 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, 
> Patrick Rhomberg, and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2420: add file-size-limit param to the ExportLogsController
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
>  0ff780cbf66937d8ececfb3a2d0789ee485b9b62 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/ExportLogController.java
>  a369c6e1ffb330715fbde2cd69d023ed36f133ad 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
>  16549e70bbebf4390bb73a481274e92ca6cad035 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
>  8609b3aaf0a0eb1ba903bd39c64103f9510a6a78 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
>  44a036298e0991c880fc552596d296e104b97ca1 
> 
> 
> Diff: https://reviews.apache.org/r/59811/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin started
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

[Kirk Lund]

> On June 6, 2017, 10:23 p.m., Jinmei Liao wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
> > Lines 79 (patched)
> > 
> >
> > this seems like a good utility method to find the security service if 
> > it's not passed down in the method or in the member variable. Should we 
> > make it public and put it in say: GemfireCacheImpl.findSecurityService()?

Maybe SecurityService.findSecurityService(). I want to avoid adding more stuff 
(especially static methods) to GemFireCacheImpl.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177108
---


On June 6, 2017, 10:26 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 10:26 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
> d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  9658f98da808e50b87fe54854df249b28b97662d 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
>  1fb8c8cac62c54b582d40688a423fddcae23b36e 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
>  adf702a1d361ba28f4ebe46695325d23344db756 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
>  fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
>  

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

[Kirk Lund]

> On June 6, 2017, 10:23 p.m., Jinmei Liao wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
> > Lines 84 (patched)
> > 
> >
> > this seems to be added by some merge operation? It was recently 
> > deleted, I think.

IndexCommands on develop has this line 235:
```java
  final Set targetMembers = CliUtil.findMembers(group, 
memberNameOrID);
```
I extracted that to the method which overrides getMembers defined in 
GfshCommand:
```java
  @Override
  public Set getMembers(final InternalCache cache) {
// TODO determine what this does (as it is untested and unmockable!)
return CliUtil.getAllMembers(cache);
  }
```
I don't know why they're different, but I wanted to clarify what IndexCommands 
was really doing. I don't want to change how IndexCommands is getting members 
in this commit so I'm not going to change this. We could inline it back into 
the getIndexListing method but I made this change to make it very obvious that 
IndexCommands is finding members differently from other commands. Maybe they 
did it to prevent a deadlock or (I don't know) -- I think we should leave it 
until we decide to delete CliUtil.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177108
---


On June 6, 2017, 10:26 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 10:26 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
> d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
>   
> 

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

(Updated June 6, 2017, 10:26 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Changes
---

Add JMH benchmark results (improvement of 882.061 ops/s)


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 388f838e3c906aaba1e6993051f2fcf2ae3c9e82 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 485ccae143f9897a52e57cf82b1386e709d9e22c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
 6534b68510f5d6c4db4d8cfe23b3adc25b455f61 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
 2cb36cdb4d90a18a0c274f09d8f1bf62dded2430 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
 3feba0d22986600d8f10c84d6e072f790bb4c74f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
 ab199542469ae7c578ef9612d6d789f3d58f8023 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
 cf9c470e79d6a8aaf636de5983abb207250efa12 
  

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177108
---




geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
Lines 84 (patched)


this seems to be added by some merge operation? It was recently deleted, I 
think.



geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
Lines 79 (patched)


this seems like a good utility method to find the security service if it's 
not passed down in the method or in the member variable. Should we make it 
public and put it in say: GemfireCacheImpl.findSecurityService()?



geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityService.java
Lines 30 (patched)


this is where that public utility method I mentioned in earlier comment 
would come in handy.



geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/SecurityServiceProvider.java
Lines 17 (patched)


seems like no one is using this class.


- Jinmei Liao


On June 6, 2017, 9:29 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 9:29 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
> d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  9658f98da808e50b87fe54854df249b28b97662d 
>   
> 

Review Request 59863: Removing obsolete SSL handling in `AcceptorImpl.accept` catch block

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59863/
---

Review request for geode, Bruce Schuchardt, Galen O'Sullivan, Hitesh Khamesra, 
and Udo Kohlmeyer.


Repository: geode


Description
---

SSL handshake is now done in a separate thread and will never reach the handler 
code which is being removed.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da 


Diff: https://reviews.apache.org/r/59863/diff/1/


Testing
---

Precheckin started


Thanks,

Brian Rowe

[GitHub] geode pull request #566: GEODE-3044: User Manual: Update Swagger example and...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/566


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #508: GEODE-2908: Adding the new tag as per swagger notification...

[jaredjstewart]

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/508
  
Merged as `ac404ad`.  Thank you for your contribution!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

(Updated June 6, 2017, 9:29 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Changes
---

Fix SecurityServiceWithCustomRealmIntegrationTest


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 388f838e3c906aaba1e6993051f2fcf2ae3c9e82 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 485ccae143f9897a52e57cf82b1386e709d9e22c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
 6534b68510f5d6c4db4d8cfe23b3adc25b455f61 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
 2cb36cdb4d90a18a0c274f09d8f1bf62dded2430 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
 3feba0d22986600d8f10c84d6e072f790bb4c74f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
 ab199542469ae7c578ef9612d6d789f3d58f8023 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
 cf9c470e79d6a8aaf636de5983abb207250efa12 
  

[GitHub] geode issue #566: GEODE-3044: User Manual: Update Swagger example and screen...

[jaredjstewart]

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/566
  
(I also need to file a bug since that command appeared to hang.. But it did 
end up starting the server despite gfsh hanging with an endless ".")


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #566: GEODE-3044: User Manual: Update Swagger example and screen...

[jaredjstewart]

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/566
  
Some more feedback after walking through the example..  Now that we start a 
locator (which starts an http server of its own on 7070) we need to specify a 
different http port for the server to use.  Here is the command that I ended up 
using: 

```
start server --name=server1 --start-rest-api --J=-Dgemfire.jmx-manager=true 
--J=-Dgemfire.jmx-manager-start=true --J=-Dgemfire.http-service-port=8080
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

(Updated June 6, 2017, 9:18 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Changes
---

Test, FlakyTest are GREEN. One IntegrationTest failure so far.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 388f838e3c906aaba1e6993051f2fcf2ae3c9e82 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 485ccae143f9897a52e57cf82b1386e709d9e22c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
 6534b68510f5d6c4db4d8cfe23b3adc25b455f61 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
 2cb36cdb4d90a18a0c274f09d8f1bf62dded2430 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
 3feba0d22986600d8f10c84d6e072f790bb4c74f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
 ab199542469ae7c578ef9612d6d789f3d58f8023 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
 cf9c470e79d6a8aaf636de5983abb207250efa12 
  

Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 388f838e3c906aaba1e6993051f2fcf2ae3c9e82 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 485ccae143f9897a52e57cf82b1386e709d9e22c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
 6534b68510f5d6c4db4d8cfe23b3adc25b455f61 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
 2cb36cdb4d90a18a0c274f09d8f1bf62dded2430 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
 3feba0d22986600d8f10c84d6e072f790bb4c74f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
 ab199542469ae7c578ef9612d6d789f3d58f8023 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
 cf9c470e79d6a8aaf636de5983abb207250efa12 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CloseConnection.java
 21f0cad2055abbf8ca811b36b4d7855cde16a3d3 
  

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59850/#review177094
---




geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java
Lines 147 (patched)


fix or remove TODO


- Bruce Schuchardt


On June 6, 2017, 6:33 p.m., Udo Kohlmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59850/
> ---
> 
> (Updated June 6, 2017, 6:33 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh 
> Khamesra.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Moved the socket.setSoTimeout setting to be before the SSL handshake. This is 
> to avoid the timeout to never be set in the case of a SSLException. Added a 
> test to test that the socket timeout is correctly set upon failure within the 
> SSL configuration and handshake.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
>  86fe53261 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TcpServerJUnitTest.java
>  7c7a2b376 
>   
> geode-core/src/test/java/org/apache/geode/internal/net/DelaySocketCreator.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59850/diff/1/
> 
> 
> Testing
> ---
> 
> Junit test - done
> precheckin - in progress
> 
> 
> Thanks,
> 
> Udo Kohlmeyer
> 
>

[GitHub] geode issue #566: GEODE-3044: User Manual: Update Swagger example and screen...

[jaredjstewart]

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/566
  
I think it would probably be best to omit 
`--J=-Dgemfire.http-service-bind-address=localhost` from the `start server` 
command for the sake of simplicity.  You also might want to consider changing  
`/Users/dbarnes/apache-geode-1.2.0/locator1` to something more generic like 
`/Users/admin/apache-geode-1.2.0/locator1` in the command output.  Looks good 
otherwise!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 59757: GEODE-3024 race condition between server and restarted locator preparing membership views

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59757/#review177093
---


Ship it!




Ship It!

- Hitesh Khamesra


On June 2, 2017, 7:18 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59757/
> ---
> 
> (Updated June 2, 2017, 7:18 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-3024
> https://issues.apache.org/jira/browse/GEODE-3024
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> If a locator is preparing a conflicting membership view we now abandon 
> preparation of a view in a cache server and pause before retrying.  This 
> gives the locator time to gather information from the cache server's view 
> (which it receives in acks while preparing its own view), incorporate them 
> into a new view and send it out.  When the cache server installs the new view 
> from the locator it will shut down its ViewCreator thread.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  478c4e832dd18635d0d66c4b85e2e2ce6ed5ab91 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/messages/ViewAckMessage.java
>  71bd6bcbf60fbcd9e6320195c5d9a5e1cf809e8a 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  49b09cab058e9e68c0e029b048e9c03c585b7fe5 
> 
> 
> Diff: https://reviews.apache.org/r/59757/diff/1/
> 
> 
> Testing
> ---
> 
> new unit test, precheckin, partial regression testing
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 59819: GEODE-3034 java.lang.ArrayIndexOutOfBoundsException: 0 on auto-reconnect attempt with multicast enabled

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59819/#review177091
---


Ship it!




Ship It!

- Hitesh Khamesra


On June 5, 2017, 10:14 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59819/
> ---
> 
> (Updated June 5, 2017, 10:14 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-3034
> https://issues.apache.org/jira/browse/GEODE-3034
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> A bug in JGroups causes this exception.  A workaround is to add a non-usable 
> UUID-based address to the view that we use to reinialize JGroups during an 
> auto-reconnect attempt.  We've sent this issue to the JGroups email list.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/messenger/JGroupsMessenger.java
>  b07aa591ccc4a559f4f8801fae3809a670dd359c 
> 
> 
> Diff: https://reviews.apache.org/r/59819/diff/2/
> 
> 
> Testing
> ---
> 
> Since this involves multicast we can't create a unit test to verify the fix, 
> though we did so on a machine with mcast support to make sure the fix is 
> correct.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] geode-native pull request #100: GEODE-2741: Fixes compilation on Mac

[mhansonp]

GitHub user mhansonp opened a pull request:

https://github.com/apache/geode-native/pull/100

GEODE-2741: Fixes compilation on Mac



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mhansonp/geode-native feature/GEODE-2741

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #100


commit 6dedc5d923abc3973abf00c35eecff13fd0cc437
Author: Mark Hanson 
Date:   2017-06-06T20:30:00Z

GEODE-2741: Fixes compilation on Mac




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #508: GEODE-2908: Adding the new tag as per swagger notification...

[jaredjstewart]

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/508
  
Looks good to me.  I'll merge it in shortly and cherry pick onto the 
release branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #564: GEODE-3023 TcpServer thread can be blocked in processReque...

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/564
  
👍 good catch!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] easy string based partitioning

[Jacob Barrett]

I have to agree. Something this trivial an limiting is better suited for a
blog post or examples somewhere and not a part of the core codebase.

-Jake

On Mon, Jun 5, 2017 at 1:27 PM Udo Kohlmeyer  wrote:

> My concern with this approach is that we provide an implementation that
> might be a white elephant and only used by a 1% user base. In addition
> to that, it does really restrict the user on his keys.
>
> Whereas something a little more configurable, like a SPEL
> implementation, would provide a lot more flexibility. Which means that
> one could easily change the partition resolver expression upon region
> creation/configuration.
>
> --Udo
>
>
> On 6/5/17 08:46, Jens Deppe wrote:
> > I like the idea of keeping the configuration 'conventional' and thus not
> > requiring any server configuration. As soon as you need to define a regex
> > on the server you might as well be writing PartitionResolver code.
> >
> > As an aside I also think that using regexes to parse keys would also
> > introduce a measurable performance hit.
> >
> > --Jens
> >
> > On Mon, Jun 5, 2017 at 8:21 AM, Udo Kohlmeyer 
> wrote:
> >
> >> Whilst I like the idea to make something (and yes,
> >> DelimitedStringPartitionResolver is the simplest), I feel that we might
> >> be able to do one better.
> >>
> >> */Could/* one possibly have an /*SPEL*/  >>
> -framework/docs/current/spring-framework-reference/html/expressions.html>-based
> >> PartitionResolver for this? At least this way, we don't have to rely on
> >> delimiters or a strong knowledge of REGEX.
> >>
> >> IMO, this would provide the greatest bang for buck implementation.
> >>
> >> --Udo
> >>
> >>
> >>
> >>
> >> On 6/2/17 19:15, Jacob Barrett wrote:
> >>
> >>> If you implement as regular expression the user doesn't have to
> reformat
> >>> their key to a specific format (akin to making them implement a
> class). I
> >>> would concat the matching groups for generate the routing key.
> >>>
> >>> Consider RegEx: .*\bcorrelation=(\d+).*\bmaybe-something-else=(\w)
> >>> With Keys:
> >>> A: my,key;with:any-chars;unique=12345;correlation=678/and,maybe
> >>> -something-else=a
> >>> B: my,key;unique=876324;correlation=678;and,maybe-something-else=a,foo
> >>> C:
> somthing;different=988975;correlation=678;then,maybe-something-else=ba
> >>>
> >>> Keys A and B would have routing key '678a'. Key C would have routing
> key
> >>> '678b'.
> >>>
> >>> -Jake
> >>>
> >>>
> >>>
> >>> Consider
> >>>
> >>> On Fri, Jun 2, 2017 at 4:02 PM Darrel Schneider  >
> >>> wrote:
> >>>
> >>> Geode partitioned regions usually partition the data based on the key's
>  hashcode.
>  You can do your own partitioning by implementing the PartitionResolver
>  interface and configuring it on the partitioned region.
> 
>  In some use cases needing to deploy your class that implements
>  PartitionResolver can be problematic so we would like to find a way to
>  offer partitioning based on a portion of the key (instead of the
> default
>  which uses the entire key) that does not require you to implement your
>  own
>  PartitionResolver and does not require you to deploy your own code to
> do
>  the custom partitioning.
> 
>  Another group of users that do not want to implement PartitionResolver
>  are
>  non-java clients. So the solution is required to be usable by non-java
>  geode clients without needing to reimplement the client to support a
> new
>  feature.
> 
>  Another constraint on the solution is for it to be both easy to use
> and
>  easy to implement.
> 
>  The proposed solution is to provide a class named:
>    org.apache.geode.cache.StringPrefixPartitionResolver
>  This class will implement PartitionResolver and have a default
>  constructor.
>  To use it you need to configure a partitioned region's
> PartitionResolver
>  using the already existing mechanism for this (api, gfsh, or xml).
>  The StringPrefixPartitionResolver will require all keys on its region
> to
>  be
>  of type String.
>  It also requires that the string key contains at least one ':'
> character.
>  The substring of the key that precedes the first ':' is the prefix
> that
>  will be returned from "getRoutingObject".
> 
>  An example of doing this in gfsh is:
>    create region --name=r1 --type=PARTITION
>  --partition-resolver=org.apache.geode.cache.StringPrefixPart
>  itionResolver
> 
>  Note that attempting to use a key that is not a String or does not
>  contain
>  a ':' will throw an exception. This is to help developers realize they
>  made
>  a mistake.
> 
>  Note that the delimiter is always a ':'. It would be easy to made the
>  delimiter configurable when using apis or xml but currently gfsh does
> not
>  provide a way to pass parameters 

Re: Review Request 59819: GEODE-3034 java.lang.ArrayIndexOutOfBoundsException: 0 on auto-reconnect attempt with multicast enabled

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59819/#review177085
---


Ship it!




Ship It!

- Udo Kohlmeyer


On June 5, 2017, 10:14 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59819/
> ---
> 
> (Updated June 5, 2017, 10:14 p.m.)
> 
> 
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Bugs: GEODE-3034
> https://issues.apache.org/jira/browse/GEODE-3034
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> A bug in JGroups causes this exception.  A workaround is to add a non-usable 
> UUID-based address to the view that we use to reinialize JGroups during an 
> auto-reconnect attempt.  We've sent this issue to the JGroups email list.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/messenger/JGroupsMessenger.java
>  b07aa591ccc4a559f4f8801fae3809a670dd359c 
> 
> 
> Diff: https://reviews.apache.org/r/59819/diff/2/
> 
> 
> Testing
> ---
> 
> Since this involves multicast we can't create a unit test to verify the fix, 
> though we did so on a machine with mcast support to make sure the fix is 
> correct.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 59757: GEODE-3024 race condition between server and restarted locator preparing membership views

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59757/#review177084
---


Ship it!




Ship It!

- Udo Kohlmeyer


On June 2, 2017, 7:18 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59757/
> ---
> 
> (Updated June 2, 2017, 7:18 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-3024
> https://issues.apache.org/jira/browse/GEODE-3024
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> If a locator is preparing a conflicting membership view we now abandon 
> preparation of a view in a cache server and pause before retrying.  This 
> gives the locator time to gather information from the cache server's view 
> (which it receives in acks while preparing its own view), incorporate them 
> into a new view and send it out.  When the cache server installs the new view 
> from the locator it will shut down its ViewCreator thread.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  478c4e832dd18635d0d66c4b85e2e2ce6ed5ab91 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/messages/ViewAckMessage.java
>  71bd6bcbf60fbcd9e6320195c5d9a5e1cf809e8a 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  49b09cab058e9e68c0e029b048e9c03c585b7fe5 
> 
> 
> Diff: https://reviews.apache.org/r/59757/diff/1/
> 
> 
> Testing
> ---
> 
> new unit test, precheckin, partial regression testing
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

[Udo Kohlmeyer]

> On June 6, 2017, 6:54 p.m., Anthony Baker wrote:
> > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
> > Line 354 (original), 356 (patched)
> > 
> >
> > Did you mean to leave in prinln's?  Shouldn't this be a log statement?

I did not.. thank you.


- Udo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59850/#review177068
---


On June 6, 2017, 6:33 p.m., Udo Kohlmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59850/
> ---
> 
> (Updated June 6, 2017, 6:33 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh 
> Khamesra.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Moved the socket.setSoTimeout setting to be before the SSL handshake. This is 
> to avoid the timeout to never be set in the case of a SSLException. Added a 
> test to test that the socket timeout is correctly set upon failure within the 
> SSL configuration and handshake.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
>  86fe53261 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TcpServerJUnitTest.java
>  7c7a2b376 
>   
> geode-core/src/test/java/org/apache/geode/internal/net/DelaySocketCreator.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59850/diff/1/
> 
> 
> Testing
> ---
> 
> Junit test - done
> precheckin - in progress
> 
> 
> Thanks,
> 
> Udo Kohlmeyer
> 
>

Broken: apache/geode-native#319 (develop - 11467dd)

[Travis CI]

Build Update for apache/geode-native
-

Build: #319
Status: Broken

Duration: 7 minutes and 41 seconds
Commit: 11467dd (develop)
Author: Jacob Barrett
Message: GEODE-2741: Code cleanup to move to std::shared_ptr

- Removed the following custom objects:
 - HashMapT
 - VectorT
 - HashMapOfSharedBase
 - HashSetT

View the changeset: 
https://github.com/apache/geode-native/compare/09843302c616...11467dd9bb59

View the full build log and details: 
https://travis-ci.org/apache/geode-native/builds/240069759?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: Review Request 59849: add StringPrefixPartitionResolver

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59849/#review177074
---


Ship it!




Ship It!

- Eric Shu


On June 6, 2017, 6:54 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59849/
> ---
> 
> (Updated June 6, 2017, 6:54 p.m.)
> 
> 
> Review request for geode, Eric Shu and Lynn Gallinat.
> 
> 
> Bugs: GEODE-3027
> https://issues.apache.org/jira/browse/GEODE-3027
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The new resolver uses a fixed delimiter of "|".
> In this version of the resolver you can not configure the delimiter.
> "|" was chosen over ":" because it seemed less likely that the desired prefix 
> string would contain it.
> Since the delimiter can not be configured it is important that it would not 
> be a common one to occur in a key string.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache/partition/StringPrefixPartitionResolverJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59849/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Do you want to Tweet for @ApacheGeode?

[Greg Chase]

Greetings Apache Geode community,
Tweeting for the Apache Geode project in the past has been a community
effort.

However, our most prolific tweeters are currently not spending much time
with the project.

As a result @ApacheGeode has fallen silent.

Per ASF recommendations, we manage access to the @ApacheGeode Twitter
handle through Tweet Deck. Any contributor is welcome to Tweet on behalf of
the project.  You simply need to ask for access, such as replying to this
thread.

Presuming no concerns raised by the PMC, access is granted to your personal
Twitter credentials to access @ApacheGeode using Tweet Deck.

Administrative rights to @ApacheGeode are maintained by several PMC members.

The guideline for Tweeting for @ApacheGeode is to promote the project,
announce any important releases, events or topics, and to help answer
questions or direct askers to u...@geode.apache.org.

You are also welcome to engage in technical topics of interest to Apache
Geode users, such as event driven architectures, caching patterns,
in-memory computing, etc.

We recommend not engaging in bashing other projects or products, or
engaging in off-topic discussions.

If you are interested in helping Tweet for @ApacheGeode, I invite you to
volunteer by replying to this thread.

Regards,

-Greg

[GitHub] geode pull request #566: GEODE-3044: User Manual: Update Swagger example and...

[davebarnes97]

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/566

GEODE-3044: User Manual: Update Swagger example and screen shots

Updates Swagger screen shots and the example command lines that create the 
screens.

Request reviews from @karensmolermiller  and @jaredjstewart. Thanks!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-3044

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/566.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #566


commit 417a8ddcd479fdce09335d48fb0a86041fa23ffb
Author: Dave Barnes 
Date:   2017-06-06T18:51:23Z

GEODE-3044: User Manual: Update Swagger example and screen shots




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 59849: add StringPrefixPartitionResolver

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59849/
---

(Updated June 6, 2017, 11:54 a.m.)


Review request for geode, Eric Shu and Lynn Gallinat.


Changes
---

removed delimiter from getName


Bugs: GEODE-3027
https://issues.apache.org/jira/browse/GEODE-3027


Repository: geode


Description
---

The new resolver uses a fixed delimiter of "|".
In this version of the resolver you can not configure the delimiter.
"|" was chosen over ":" because it seemed less likely that the desired prefix 
string would contain it.
Since the delimiter can not be configured it is important that it would not be 
a common one to occur in a key string.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/cache/partition/StringPrefixPartitionResolverJUnitTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/59849/diff/2/

Changes: https://reviews.apache.org/r/59849/diff/1-2/


Testing
---

precheckin


Thanks,

Darrel Schneider

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

[Anthony Baker]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59850/#review177068
---




geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
Line 354 (original), 356 (patched)


Did you mean to leave in prinln's?  Shouldn't this be a log statement?


- Anthony Baker


On June 6, 2017, 6:33 p.m., Udo Kohlmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59850/
> ---
> 
> (Updated June 6, 2017, 6:33 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh 
> Khamesra.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Moved the socket.setSoTimeout setting to be before the SSL handshake. This is 
> to avoid the timeout to never be set in the case of a SSLException. Added a 
> test to test that the socket timeout is correctly set upon failure within the 
> SSL configuration and handshake.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
>  86fe53261 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TcpServerJUnitTest.java
>  7c7a2b376 
>   
> geode-core/src/test/java/org/apache/geode/internal/net/DelaySocketCreator.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59850/diff/1/
> 
> 
> Testing
> ---
> 
> Junit test - done
> precheckin - in progress
> 
> 
> Thanks,
> 
> Udo Kohlmeyer
> 
>

[GitHub] geode issue #508: GEODE-2908: Adding the new tag as per swagger notification...

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/508
  
@jaredjstewart any thoughts on this change?  If it's good I'd like to merge 
it since we need it for 1.2.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59850/
---

Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh 
Khamesra.


Repository: geode


Description
---

Moved the socket.setSoTimeout setting to be before the SSL handshake. This is 
to avoid the timeout to never be set in the case of a SSLException. Added a 
test to test that the socket timeout is correctly set upon failure within the 
SSL configuration and handshake.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
 86fe53261 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TcpServerJUnitTest.java
 7c7a2b376 
  
geode-core/src/test/java/org/apache/geode/internal/net/DelaySocketCreator.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/59850/diff/1/


Testing
---

Junit test - done
precheckin - in progress


Thanks,

Udo Kohlmeyer

Re: Review Request 59849: add StringPrefixPartitionResolver

[Darrel Schneider]

> On June 6, 2017, 11:17 a.m., Eric Shu wrote:
> > geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
> > Lines 60 (patched)
> > 
> >
> > Does getName() needs the Delimiter being included? If it is used in the 
> > equals(), can we just check getDelimiter() in the equals method?

I thought it did but I reviewed how the product uses getName and it seems like 
it expects it to be just the class name of the resolver.
So I will change getName to not include it and change equals and hashCode to 
also call getDelimiter.
Thanks for the review.


- Darrel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59849/#review177064
---


On June 6, 2017, 10:44 a.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59849/
> ---
> 
> (Updated June 6, 2017, 10:44 a.m.)
> 
> 
> Review request for geode, Eric Shu and Lynn Gallinat.
> 
> 
> Bugs: GEODE-3027
> https://issues.apache.org/jira/browse/GEODE-3027
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The new resolver uses a fixed delimiter of "|".
> In this version of the resolver you can not configure the delimiter.
> "|" was chosen over ":" because it seemed less likely that the desired prefix 
> string would contain it.
> Since the delimiter can not be configured it is important that it would not 
> be a common one to occur in a key string.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache/partition/StringPrefixPartitionResolverJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59849/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 59849: add StringPrefixPartitionResolver

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59849/#review177064
---




geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
Lines 60 (patched)


Does getName() needs the Delimiter being included? If it is used in the 
equals(), can we just check getDelimiter() in the equals method?


- Eric Shu


On June 6, 2017, 5:44 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59849/
> ---
> 
> (Updated June 6, 2017, 5:44 p.m.)
> 
> 
> Review request for geode, Eric Shu and Lynn Gallinat.
> 
> 
> Bugs: GEODE-3027
> https://issues.apache.org/jira/browse/GEODE-3027
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The new resolver uses a fixed delimiter of "|".
> In this version of the resolver you can not configure the delimiter.
> "|" was chosen over ":" because it seemed less likely that the desired prefix 
> string would contain it.
> Since the delimiter can not be configured it is important that it would not 
> be a common one to occur in a key string.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache/partition/StringPrefixPartitionResolverJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59849/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Review Request 59849: add StringPrefixPartitionResolver

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59849/
---

Review request for geode, Eric Shu and Lynn Gallinat.


Bugs: GEODE-3027
https://issues.apache.org/jira/browse/GEODE-3027


Repository: geode


Description
---

The new resolver uses a fixed delimiter of "|".
In this version of the resolver you can not configure the delimiter.
"|" was chosen over ":" because it seemed less likely that the desired prefix 
string would contain it.
Since the delimiter can not be configured it is important that it would not be 
a common one to occur in a key string.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/cache/partition/StringPrefixPartitionResolverJUnitTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/59849/diff/1/


Testing
---

precheckin


Thanks,

Darrel Schneider

[GitHub] geode pull request #565: GEODE-3021: Any call after the first to setPdxStrin...

[jhuynh1]

GitHub user jhuynh1 opened a pull request:

https://github.com/apache/geode/pull/565

GEODE-3021: Any call after the first to setPdxStringFlag should no-op

  * The flag isIndexedPdxKeysFlagSet is now checked before setting pdx 
string flag

@nabarunnag @ladyVader 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3021

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/565.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #565


commit c2943a4acb9c9325662a4cbee14823e0a1c05061
Author: Jason Huynh 
Date:   2017-06-01T20:52:41Z

GEODE-3021: Any call after the first to setPdxStringFlag should no-op

  * The flag isIndexedPdxKeysFlagSet is now checked before setting pdx 
string flag




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Geode versions

[Anthony Baker]

I would expect it to be under a month (hopefully much less), based on the 
remaining JIRA issues [1].  The community hasn’t begun discussing a release 
scope for 1.3.0 yet.  Your participation in this process is encouraged!

Anthony

[1] 
https://issues.apache.org/jira/browse/GEODE-2908?jql=project%20%3D%20GEODE%20AND%20fixVersion%20%3D%201.2.0%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
 



> On Jun 6, 2017, at 4:15 AM, Roi Apelker  wrote:
> 
> Thanks Anthony,
> 
> Can you estimate, whether this will be a week/month/3 months for the release 
> of 1.2?
> 
> What about 1.3?
> 
> -Roi
> 
> -Original Message-
> From: Anthony Baker [mailto:aba...@pivotal.io] 
> Sent: Monday, June 05, 2017 7:34 PM
> To: dev@geode.apache.org
> Subject: Re: Geode versions
> 
> Hi Roi,
> 
> We have cut a release branch for 1.2.0.  Once we have fixed the remaining 
> bugs we will vote on releasing.  We don’t published expected release dates 
> but I expect that it won’t be too much longer.
> 
> Thanks,
> Anthony
> 
>> On Jun 5, 2017, at 2:49 AM, Roi Apelker  wrote:
>> 
>> Hello,
>> 
>> Where can I find information on up-coming GEODE versions, release dates etc.?
>> The last released version I know if is 1.1.1,
>> 
>> There is already a reference for 1.2 in the release notes here:
>> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes
>> 
>> Also, reference for 1.3 here:
>> https://issues.apache.org/jira/browse/GEODE/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel
>> 
>> 
>> But no dates... :(
>> 
>> Anyone knows?
>> 
>> Thanks,
>> Roi
>> 
>> This message and the information contained herein is proprietary and 
>> confidential and subject to the Amdocs policy statement,
>> 
>> you may review at https://www.amdocs.com/about/email-disclaimer 
>> 
> 
> This message and the information contained herein is proprietary and 
> confidential and subject to the Amdocs policy statement,
> 
> you may review at https://www.amdocs.com/about/email-disclaimer 
> 

[GitHub] geode pull request #561: GEODE-3033: Fixing NPE when jarFileNames is null in...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/561


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: GEODE and GEODE-native compatibility

[Roi Apelker]

Thanks Jake :-)

-Original Message-
From: Jacob Barrett [mailto:jbarr...@pivotal.io] 
Sent: Monday, June 05, 2017 4:07 PM
To: dev@geode.apache.org
Subject: Re: GEODE and GEODE-native compatibility

You asked the same question on the user list on 5/21. In case you didn't get my 
reply I'll send the same answer.

There have been no official Geode release of Geode Native but the current 
development branch is known to work with Geode server 1.0 and 1.1.

-Jake


Sent from my iPhone

> On Jun 5, 2017, at 2:49 AM, Roi Apelker  wrote:
> 
> Hi,
> 
> I am using both the GEODE and GEODE native libraries, and since the native 
> library has no numbered version I am wondering if there are any compatibility 
> issues.
> 
> Will the native library work with versions 1.0.0 and 1.1.1 seamlessly?
> 
> Thanks,
> 
> Roi
> 
> This message and the information contained herein is proprietary and 
> confidential and subject to the Amdocs policy statement,
> 
> you may review at https://www.amdocs.com/about/email-disclaimer 
> 
This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at https://www.amdocs.com/about/email-disclaimer 

RE: Geode versions

[Roi Apelker]

Thanks Anthony,

Can you estimate, whether this will be a week/month/3 months for the release of 
1.2?

What about 1.3?

-Roi

-Original Message-
From: Anthony Baker [mailto:aba...@pivotal.io] 
Sent: Monday, June 05, 2017 7:34 PM
To: dev@geode.apache.org
Subject: Re: Geode versions

Hi Roi,

We have cut a release branch for 1.2.0.  Once we have fixed the remaining bugs 
we will vote on releasing.  We don’t published expected release dates but I 
expect that it won’t be too much longer.

Thanks,
Anthony

> On Jun 5, 2017, at 2:49 AM, Roi Apelker  wrote:
> 
> Hello,
> 
> Where can I find information on up-coming GEODE versions, release dates etc.?
> The last released version I know if is 1.1.1,
> 
> There is already a reference for 1.2 in the release notes here:
> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes
> 
> Also, reference for 1.3 here:
> https://issues.apache.org/jira/browse/GEODE/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel
> 
> 
> But no dates... :(
> 
> Anyone knows?
> 
> Thanks,
> Roi
> 
> This message and the information contained herein is proprietary and 
> confidential and subject to the Amdocs policy statement,
> 
> you may review at https://www.amdocs.com/about/email-disclaimer 
> 

This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at https://www.amdocs.com/about/email-disclaimer 

[GitHub] geode pull request #564: GEODE-3023 TcpServer thread can be blocked in proce...

[vahrama]

GitHub user vahrama opened a pull request:

https://github.com/apache/geode/pull/564

GEODE-3023 TcpServer thread can be blocked in processRequest

Move socket timeout setting before configureServerSSLSocket to ensure
that SSL handshake will return in the allotted time and will not wait
forever if other side is unresponsive.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
Yes, https://issues.apache.org/jira/browse/GEODE-3023
- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
No
- [ ] Is your initial contribution a single, squashed commit?
Yes
- [ ] Does `gradlew build` run cleanly?
Actually build is sucessfull, but there are 12 test failures. But this is 
not related to the fix done with this commit. Same is reported even on clean 
tree.
Here are failing tests:
HelpBlockUnitTest. testToString
HelperUnitTest. testGetLongHelp
HelperUnitTest. testGetShortHelp
HelperUnitTest. testGetSyntaxStringWithDefaultAndStringArray
HelperUnitTest. testGetSyntaxStringWithMandatory
HelperUnitTest. testGetSyntaxStringWithOptionalSecondaryOptionName
HelperUnitTest. testGetSyntaxStringWithOutMandatory
HelperUnitTest. testGetSyntaxStringWithSecondaryOptionName
HelperUnitTest. testGetSyntaxStringWithSecondaryOptionNameIgnored
HelperUnitTest. testGetSyntaxStringWithSpecifiedDefault
HelperUnitTest. testGetSyntaxStringWithStringArray
GfshJunitTest. testWrapTest

- [ ] Have you written or updated unit tests to verify your changes?
No
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vahrama/geode feature/GEODE-3023

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/564.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #564


commit c7d3761891aa0c72a8a7a6600f653f754b38efab
Author: Vahram Aharonyan 
Date:   2017-06-05T14:27:42Z

GEODE-3023 TcpServer thread can be blocked in processRequest

Move socket timeout setting before configureServerSSLSocket to ensure
that SSL handshake will return in the allotted time and will not wait
forever if other side is unresponsive.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---