[GitHub] geode pull request #573: GEODE-2622: Fix test failures caused by upgrade to ...

[smanvi-pivotal]

GitHub user smanvi-pivotal opened a pull request:

https://github.com/apache/geode/pull/573

GEODE-2622: Fix test failures caused by upgrade to Mockito 2.7.11

- Fix 4 test failures in GMSMembershipManagerJUnitTest

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/smanvi-pivotal/geode feature/GEODE-2622

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #573


commit d3dca7ce2df5dca12a4f82a0e4289c5106c0a6c9
Author: Srikanth Manvi 
Date:   2017-06-11T04:40:57Z

GEODE-2622: Fix test failures caused by upgrade to Mockito 2.7.11

- Fix 4 test failures in GMSMembershipManagerJUnitTest




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: release 1.2

[Udo Kohlmeyer]

I thought we had moved GEODE-3052 to a later release, given that we have 
a work around for this.


--Udo


On 6/10/17 10:15, Anthony Baker wrote:

Status update:

We have 2 issues left:  GEODE-3054 and GEODE-3052.  We also had a clean run of 
the Geode-release jenkins job.  So as soon as we can finish off these issues 
and get another clean run through Jenkins I’ll create a release candidate.  How 
does early next week sound?

Anthony


On Jun 8, 2017, at 5:38 PM, Anthony Baker  wrote:

Sounds good.  Please cherry-pick these changes onto release/1.2.0 when ready.

Anthony



On Jun 8, 2017, at 3:15 PM, Jared Stewart  wrote:

I think we probably ought to include GEODE-3045 
 as well.


On Jun 8, 2017, at 3:12 PM, Kenneth Howe  wrote:

I think we should also include the fix for GEODE-3054 in 1.2. This is a bug 
that was introduced in the recent changes to the Gfsh parser, and affects 
Windows pathnames specified in options to gfsh commands.

https://issues.apache.org/jira/browse/GEODE-3054 


The fix is currently in testing.



On Jun 8, 2017, at 2:23 PM, Bruce Schuchardt  wrote:

I'd like to include the fix for GEODE-3052 in the 1.2 release. It's under 
review now and has passed new tests and is in precheckin testing.


https://issues.apache.org/jira/browse/GEODE-3052

"Restarting 2 locators within 1s of each other causes potential locator split 
brain"

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #581 was SUCCESSFUL (with 1868 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #581 was successful.
---
Scheduled
1870 tests in total.

https://build.spring.io/browse/SGF-NAG-581/





--
This message is automatically generated by Atlassian Bamboo

Re: release 1.2

[Jared Stewart]

Sounds good.  I believe GEODE-3054 is already fixed on develop and 
release/1.2.0.

- Jared 
> On Jun 10, 2017, at 10:15 AM, Anthony Baker  wrote:
> 
> Status update:
> 
> We have 2 issues left:  GEODE-3054 and GEODE-3052.  We also had a clean run 
> of the Geode-release jenkins job.  So as soon as we can finish off these 
> issues and get another clean run through Jenkins I’ll create a release 
> candidate.  How does early next week sound?
> 
> Anthony
> 

Re: release 1.2

[Anthony Baker]

Status update:

We have 2 issues left:  GEODE-3054 and GEODE-3052.  We also had a clean run of 
the Geode-release jenkins job.  So as soon as we can finish off these issues 
and get another clean run through Jenkins I’ll create a release candidate.  How 
does early next week sound?

Anthony

> On Jun 8, 2017, at 5:38 PM, Anthony Baker  wrote:
> 
> Sounds good.  Please cherry-pick these changes onto release/1.2.0 when ready.
> 
> Anthony
> 
> 
>> On Jun 8, 2017, at 3:15 PM, Jared Stewart  wrote:
>> 
>> I think we probably ought to include GEODE-3045 
>>  as well.  
>> 
>>> On Jun 8, 2017, at 3:12 PM, Kenneth Howe  wrote:
>>> 
>>> I think we should also include the fix for GEODE-3054 in 1.2. This is a bug 
>>> that was introduced in the recent changes to the Gfsh parser, and affects 
>>> Windows pathnames specified in options to gfsh commands.
>>> 
>>> https://issues.apache.org/jira/browse/GEODE-3054 
>>>  
>>> 
>>> The fix is currently in testing.
>>> 
>>> 
 On Jun 8, 2017, at 2:23 PM, Bruce Schuchardt  
 wrote:
 
 I'd like to include the fix for GEODE-3052 in the 1.2 release. It's under 
 review now and has passed new tests and is in precheckin testing.
 
 
 https://issues.apache.org/jira/browse/GEODE-3052
 
 "Restarting 2 locators within 1s of each other causes potential locator 
 split brain"
 
>>> 
>> 
> 

Jenkins build is back to normal : Geode-release #61

[Apache Jenkins Server]

See 

[GitHub] geode issue #568: GEODE-290: Removed deprecated methods from Launcher classe...

[deepakddixit]

Github user deepakddixit commented on the issue:

https://github.com/apache/geode/pull/568
  
@kirklund Thanks for review. As noted, I missed following commit 
guidelines. I have amended git message. Also updated PR title and description. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #862

[Apache Jenkins Server]

See 


Changes:

[khowe] GEODE-2420: add file-size-limit param to the ExportLogsController

[huynhja] GEODE-3021: Any call after the first to setPdxStringFlag should no-op

[bschuchardt] GEODE-2542 LocatorDUnitTest and LocatorUDPSecurityDUnitTest flaky

[klund] GEODE-2632: use immutable SecurityService impls to improve performance

[jiliao] GEODE-3054: escaping the escape character in the command string before

[nnag] GEODE-3025: Lucene queries are not allowed withing a transaction.

[dbarnes] GEODE-3044: User Manual: Update Swagger screen shots to match latest

[ukohlmeyer] GEODE-3023: TcpServer move soTimout for the socket for SSL Locators

[jstewart] Fix spotless failure

[jstewart] Add GfshParserRule to facilitate command unit tests

[jstewart] GEODE-2933: Add jmx-manager-hostname-for-clients for startLocator

[dbarnes] GEODE-2420: Warn a user if they try to export too much data, update 
gfsh

[kmiller] GEODE-3042: Quick doc of new string-based partition resolver

[ukohlmeyer] GEODE-2788: Add official Socket timeout parameter when connecting 
to

--
[...truncated 95.16 KB...]
:geode-core:checkMissedTests
:geode-core:spotlessJavaCheck
:geode-core:spotlessCheck
:geode-core:test
:geode-core:check
:geode-core:build
:geode-core:distributedTest
:geode-core:integrationTest

org.apache.geode.distributed.internal.tcpserver.TCPServerSSLJUnitTest > 
testSSLSocketTimeOut FAILED
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at 
org.apache.geode.distributed.internal.tcpserver.TCPServerSSLJUnitTest.testSSLSocketTimeOut(TCPServerSSLJUnitTest.java:102)

3582 tests completed, 1 failed, 163 skipped
:geode-core:integrationTest FAILED
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-ver

Jenkins build is back to normal : Geode-release-flaky #11

[Apache Jenkins Server]

See