Build failed in Jenkins: Geode-nightly #865

[Apache Jenkins Server]

See 


Changes:

[jiliao] GEODE-2925: add target for resource operation for finer grained 
security

[dbarnes] Update geode-book README instructions

[klund] GEODE-290: Remove deprecated methods from launcher classes

[jiliao] GEODE-2928: get rid of the isGfshVM static variable

[jiliao] GEODE-2928: get rid of the isGfshVM static variable - fix merge issues

[nnag] GEODE-3066: Test tweaks to stabilize it.

[jstewart] GEODE-3048: Introduce a rule to identify tests that require 
GEODE_HOME

[klund] GEODE-3068: fix alphabetic ordering

--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on mesos2 (mesos s390x) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/geode.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/geode.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/geode.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/develop^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/develop^{commit} # timeout=10
Checking out Revision 65471c1174df161c46237f87145d81d27a1663a9 
(refs/remotes/origin/develop)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 65471c1174df161c46237f87145d81d27a1663a9
 > git branch -a -v --no-abbrev # timeout=10
 > git branch -D develop # timeout=10
 > git checkout -b develop 65471c1174df161c46237f87145d81d27a1663a9
 > git rev-list 122b07afde7cd56898fae354fadc78fdd5dc721d # timeout=10
[Geode-nightly] $ /bin/bash -xe /tmp/hudson4018735290081826255.sh
+ git clean -d -f gemfire-pulse/src/main/resources/
[Gradle] - Launching build.
[Geode-nightly] $  
--no-daemon clean precheckin distTar distZip uploadArchives -xflakyTest

ERROR: JAVA_HOME is set to an invalid directory: 
/home/jenkins/tools/java/latest1.8

Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.

Build step 'Invoke Gradle script' changed build result to FAILURE
Build step 'Invoke Gradle script' marked build as failure
Archiving artifacts
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Not sending mail to unregistered user ukohlme...@pivotal.io
Not sending mail to unregistered user huyn...@gmail.com
Not sending mail to unregistered user jil...@pivotal.io

[GitHub] geode pull request #577: Feature/geode 3049

[nreich]

GitHub user nreich opened a pull request:

https://github.com/apache/geode/pull/577

Feature/geode 3049

This request attempts to add logging for when the last copy of a bucket in 
a PartitionedRegion is lost (we already log on loss of consistency and on every 
drop in number of copies, except zero). To better be able to test this code, 
the surrounding logic was refactored into new classes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nreich/geode feature/GEODE-3049

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/577.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #577


commit 8683108dd1ec21bb83001618f493c4eca6438f00
Author: Nick Reich 
Date:   2017-06-13T00:29:16Z

GEODE-3049: Add warning on loss of all buckets in region

  * Add statistics for count of buckets that have no copies remaining
  * Refactor logic for keeping track of redundancy statistics into
separate classes
  * Remove dependency of tracking on the PartitionRegionStatistics
(since this can be turned off), but continue recording statistics
to that location

commit f116c545b78e0b92601988af93f1ed900c4ea844
Author: Nick Reich 
Date:   2017-06-13T00:48:06Z

GEODE-3049: fix formatting




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #573: GEODE-2622: Fix test failures caused by upgrade to Mockito...

[kirklund]

Github user kirklund commented on the issue:

https://github.com/apache/geode/pull/573
  
Your PR is safely committed to feature/GEODE-2558. I also rebased 
feature/GEODE-2558 on develop. Normally asfgit (an Apache bot) would close this 
PR but it won't do that until I merge feature/GEODE-2558 to develop. The new 
Travis errors are caused by the rebase and can be ignored. You can also safely 
close this PR now if you want or asfgit will do so eventually when I merge to 
develop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Using Pull Requests over Review Board

[Jens Deppe]

We can always set up a bit of automation so that committers are notified if
a PR sits unattended for a period of time.

--Jens

On Mon, Jun 12, 2017 at 4:20 PM, Udo Kohlmeyer 
wrote:

> 0 for PR - I feel that both have their benefits and downsides.
>
>  * +1 for PR: As Naba stated, the integration is simplified and using
>Intellij there is even support to create a PR. Single system to rule
>them all.
>  * -1 for PR: I fear that given the huge amount of incoming PR's we
>might loose sight/oversight of any PR's that need to be approved
>from external submitters. It is impossible for external submitters
>to know who needs to be mentioned in order to have the PR looked at.
>With the Reviewboard + Apache Geode PR system, those can be kept
>separate and some oversight is possible.
>
>
>
> On 6/12/17 11:13, Nabarun Nag wrote:
>
>> +1 On using PR. I feel using github PR is more convenient because of the
>> following reasons
>>   a. Commit messages are automatically made into the header and
>> description
>> in PR, whereas in reviewboard, you upload the patch and do all the writing
>> - manually. It feels redundant.
>>   b. After changing the code as per some review comments, we need to
>> upload
>> the new patch back to  reviewboard but in case of a PR we just need to do
>> a
>> git push.
>>   c. A single system for review for all types of contributors - committers
>> and non committers.
>>   d. Travis CI runs on the PR - detects missed out spotlessApply or merge
>> issues.
>>   e. Also in case someone is AFK for a long time, one can request a fellow
>> committer to merge the PR without losing commit credit.
>>
>>
>>
>> After some google search, I could see that a lot of projects are moving to
>> Github PR system over Review Board. Apache Spark, Apache CloudStack ,
>> Apache SystemML are a few examples.
>> Regards
>> Nabarun
>>
>> On Mon, Jun 12, 2017 at 9:37 AM Dave Barnes  wrote:
>>
>> +0
>>> Proposal as written says "...for changes that would require peer review
>>> before committing...".
>>> If this means that minor changes (in my case, typo repairs are the common
>>> case) can be checked in without going through a PR process, I can go with
>>> the group decision.
>>> Still see no compelling need to retire the Review Board, which (as
>>> pointed
>>> out in the discussion thread) has its uses and advantages.
>>>
>>>
>>>
>>> On Mon, Jun 12, 2017 at 7:57 AM, Bruce Schuchardt <
>>> bschucha...@pivotal.io>
>>> wrote:
>>>
>>> -1

 It places an unnecessary burden on committers and git history is the
 definitive record of changes to the code so github pr history isn't

>>> really
>>>
 very useful.  Also, Review Board is a much better tool for reviewing
 code
 than a github PR.



 On 6/11/17 9:51 AM, Jacob Barrett wrote:

 After a few days of discussion [1] this thread has quieted down so I
>
 would
>>>
 like to take it to a vote. The proposal is to modify the workflow of
> committers to match that of non-committers such that committers shall:
>
> * Perform all work in progress on branches in their personal forks on
> GitHub rather than directly on the ASF Geode repositories.
>
> * Submit GitHub pull requests, following all current rules for pull
> requests, for changes that would require peer review before committing
>
 to
>>>
 the production branches.
>
> * Register their GitHub accounts with the ASF so that committers can be
> identified in the GitHub mirror repositories.
>
>
> Please cast your vote.
>
> [   ] +1  Approve
> [   ] +0  No opinion
> [   ] -1  Disapprove (and reason why)
>
>
> [1] [DISCUSS] Using Pull Requests over Review Board
>  org%2Eapache%2Egeode%2Edev+discuss+pull>
>
> -Jake
>
>
>
>

[GitHub] geode issue #573: GEODE-2622: Fix test failures caused by upgrade to Mockito...

[kirklund]

Github user kirklund commented on the issue:

https://github.com/apache/geode/pull/573
  
I just pulled this in to feature/GEODE-2558. I changed the git commit 
message to:

GEODE-2622: Fix GMSMembershipManagerJUnitTest use of Mockito 2.7.11

- Fix 4 test failures in GMSMembershipManagerJUnitTest

This closes #573


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #576: Geode 2920, 2921, 2922, 2924

[PurelyApplied]

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/576

Geode 2920, 2921, 2922, 2924

This PR is intended for initial review, not to be actively considered for 
acceptance.  Sufficient testing is still required and `develop` shifted enough 
today that I need to rebase again.

This currently addresses most of the finer-grained security as listed 
[here](https://cwiki.apache.org/confluence/display/GEODE/Finer+grained+security).
  As yet unaddressed remains:

* alter disk-store
* disconnect
* echo
* encrypt password
* execute function
* import cluster-configuration
* DistributedSystemMXBean.backupAllMembers

Additional points of concern:
* compact offline-disk-store is not actually updated? [None -> None]
* Should destroy region also require CLUSTER:WRITE:DISK if persistent?
* These do not exist:
*GatewayReceiverMXBean.pauseDATA:MANAGE CLUSTER:MANAGE:GATEWAY
*GatewayReceiverMXBean.rebalanceDATA:MANAGE 
CLUSTER:MANAGE:GATEWAY
*GatewayReceiverMXBean.resume   DATA:MANAGE CLUSTER:MANAGE:GATEWAY
* `execute function` is listed twice, with different "original" 
permissions.  Do these refer to different executions?

For your convenience, the functional diff is the second commit.  The first 
commit only resolves `imports`, and the third commit is a general cleanup of 
touched files.

==
Current commit log:

GEODE-292*: Migration of security from DATA:MANAGE

* DATA:MANAGE -> CLUSTER:MANAGE
*
* configure pdx
* LockServiceMXBean.becomeLockGrantor
*
* DATA:MANAGE -> CLUSTER:MANAGE:DISK
*
* compact disk-store
* create disk-store
* destroy disk-store
* revoke missing-disk-store
* DiskStoreMXBean.forceRoll
* DiskStoreMXBean.forceCompaction
* DiskStoreMXBean.flush
* DiskStoreMXBean.setDiskUsageWarningPercentage
* DiskStoreMXBean.setDiskUsageCriticalPercentage
* DistributedSystemMXBean.revokeMissingDiskStores
* MemberMXBean.compactAllDistStores
*
* DATA:MANAGE -> CLUSTER:MANAGE:GATEWAY
*
* create gateway-receiver
* create gateway-sender
* destroy gateway-sender
* load-balance gateway-sender
* pause gateway-sender
* resume gateway-sender
* start gateway-receiver
* start gateway-sender
* stop gateway-receiver
* stop gateway-sender
* GatewayReceiverMXBean.start
* GatewayReceiverMXBean.stop
* GatewaySenderMXBean.start
* GatewaySenderMXBean.stop
* GatewaySenderMXBean.pause
* GatewaySenderMXBean.resume
* GatewaySenderMXBean.rebalance
*
* DATA:MANAGE -> CLUSTER:MANAGE:JAR
*
* create async-event-queue (Requires CLUSTER:WRITE:DISK if persistent)
* destroy function
* undeploy
*
* DATA:MANAGE -> CLUSTER:MANAGE:QUERY
*
* clear defined indexes
* close durable-client
* close durable-cq
* create defined indexes
* stop continuous-query
* CacheServerMXBean.closeAllContinuousQuery
* CacheServerMXBean.closeContinuousQuery
* DistributedSystemMXBean.setQueryResultSetLimit
* DistributedSystemMXBean.setQueryCollectionsDepth
*
* DATA:READ -> CLUSTER:READ
*
* list region
*
* DATA:MANAGE -> [None]
*
* pdx rename
*
* DATA:READ -> DATA:READ and CLUSTER:WRITE:DISK
*
* backup disk-store
*
* DATA:MANAGE:RegionName -> CLUSTER:MANAGE:QUERY
*
* create index
* create lucene index (also requires CLUSTER:WRITE:DISK)
* define index
* destroy lucene index
*
* DATA:MANAGE, DATA:WRITE, CLUSTER:MANAGE, and CLUSTER:WRITE -> 
CLUSTER:MANAGE:JAR
*
* deploy
*
* DATA:MANAGE or DATA:MANAGE:RegionName -> CLUSTER:MANAGE:QUERY
*
* destroy index
*
* CLUSTER:READ -> CLUSTER:READ:QUERY
*
* describe lucene index
* list lucene indexes
*
* DATA:WRITE -> DATA:READ:Region
*
* search lucene index
*
* DATA:MANAGE -> DATA:MANAGE and CLUSTER:WRITE:DISK if persistent
* create region

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-2924

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/576.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #576


commit d8155ae44e767890790566b66cb7cc5ed7ea0cbc
Author: Patrick 

Re: [VOTE] Using Pull Requests over Review Board

[Udo Kohlmeyer]

0 for PR - I feel that both have their benefits and downsides.

 * +1 for PR: As Naba stated, the integration is simplified and using
   Intellij there is even support to create a PR. Single system to rule
   them all.
 * -1 for PR: I fear that given the huge amount of incoming PR's we
   might loose sight/oversight of any PR's that need to be approved
   from external submitters. It is impossible for external submitters
   to know who needs to be mentioned in order to have the PR looked at.
   With the Reviewboard + Apache Geode PR system, those can be kept
   separate and some oversight is possible.


On 6/12/17 11:13, Nabarun Nag wrote:

+1 On using PR. I feel using github PR is more convenient because of the
following reasons
  a. Commit messages are automatically made into the header and description
in PR, whereas in reviewboard, you upload the patch and do all the writing
- manually. It feels redundant.
  b. After changing the code as per some review comments, we need to upload
the new patch back to  reviewboard but in case of a PR we just need to do a
git push.
  c. A single system for review for all types of contributors - committers
and non committers.
  d. Travis CI runs on the PR - detects missed out spotlessApply or merge
issues.
  e. Also in case someone is AFK for a long time, one can request a fellow
committer to merge the PR without losing commit credit.



After some google search, I could see that a lot of projects are moving to
Github PR system over Review Board. Apache Spark, Apache CloudStack ,
Apache SystemML are a few examples.
Regards
Nabarun

On Mon, Jun 12, 2017 at 9:37 AM Dave Barnes  wrote:


+0
Proposal as written says "...for changes that would require peer review
before committing...".
If this means that minor changes (in my case, typo repairs are the common
case) can be checked in without going through a PR process, I can go with
the group decision.
Still see no compelling need to retire the Review Board, which (as pointed
out in the discussion thread) has its uses and advantages.



On Mon, Jun 12, 2017 at 7:57 AM, Bruce Schuchardt 
wrote:


-1

It places an unnecessary burden on committers and git history is the
definitive record of changes to the code so github pr history isn't

really

very useful.  Also, Review Board is a much better tool for reviewing code
than a github PR.



On 6/11/17 9:51 AM, Jacob Barrett wrote:


After a few days of discussion [1] this thread has quieted down so I

would

like to take it to a vote. The proposal is to modify the workflow of
committers to match that of non-committers such that committers shall:

* Perform all work in progress on branches in their personal forks on
GitHub rather than directly on the ASF Geode repositories.

* Submit GitHub pull requests, following all current rules for pull
requests, for changes that would require peer review before committing

to

the production branches.

* Register their GitHub accounts with the ASF so that committers can be
identified in the GitHub mirror repositories.


Please cast your vote.

[   ] +1  Approve
[   ] +0  No opinion
[   ] -1  Disapprove (and reason why)


[1] [DISCUSS] Using Pull Requests over Review Board


-Jake

[GitHub] geode issue #575: GEODE-3048: Editing tests requiring Gradle test runner to ...

[YehEmily]

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/575
  
Precheckin in progress!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #575: GEODE-3048: Editing tests requiring Gradle test run...

[YehEmily]

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/575

GEODE-3048: Editing tests requiring Gradle test runner to fail 
descriptively in IntelliJ

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3048

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/575.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #575


commit 9ba574244450766b2fa2e843719eb4a51a344b7d
Author: YehEmily 
Date:   2017-06-08T19:09:14Z

GEODE-3048: Editing tests that require the Gradle test runner to fail 
descriptively when run through IntelliJ




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #583 was SUCCESSFUL (with 1868 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #583 was successful.
---
Scheduled
1870 tests in total.

https://build.spring.io/browse/SGF-NAG-583/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60025/#review177679
---


Ship it!




Ship It!

- Jinmei Liao


On June 12, 2017, 9:50 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60025/
> ---
> 
> (Updated June 12, 2017, 9:50 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60025/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60025/
---

(Updated June 12, 2017, 9:50 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
 PRE-CREATION 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
 PRE-CREATION 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60025/diff/2/

Changes: https://reviews.apache.org/r/60025/diff/1-2/


Testing
---

Precheckin started (still running)


Thanks,

Jared Stewart

Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59961/#review177674
---


Ship it!




Ship It!

- Jinmei Liao


On June 12, 2017, 9:19 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59961/
> ---
> 
> (Updated June 12, 2017, 9:19 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME
> 
> - A subsequent commit will add this rule to all of the relevant tests.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/RequiresGeodeHome.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59961/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59961/
---

(Updated June 12, 2017, 9:19 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Add method to get a File that points to GEODE_HOME.


Repository: geode


Description
---

GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

- A subsequent commit will add this rule to all of the relevant tests.


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/RequiresGeodeHome.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/59961/diff/3/

Changes: https://reviews.apache.org/r/59961/diff/2-3/


Testing
---


Thanks,

Jared Stewart

[GitHub] geode pull request #574: GEODE-3066: Test tweaks to stabilize it.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/574


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

[Emily Yeh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59961/#review177671
---


Ship it!




Ship It!

- Emily Yeh


On June 9, 2017, 11:35 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59961/
> ---
> 
> (Updated June 9, 2017, 11:35 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME
> 
> - A subsequent commit will add this rule to all of the relevant tests.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/RequiresGeodeHome.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59961/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Review Request 60030: GEODE-2925: finer security for disk management

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60030/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-2925: finer security for disk management

changes that are needed to apply the finer grained security for disk management 
after the latest security changes.


Diffs
-

  geode-core/src/main/java/org/apache/geode/management/DiskStoreMXBean.java 
cca6272610517d75c877945872e1b9e77efae230 
  
geode-core/src/main/java/org/apache/geode/management/DistributedSystemMXBean.java
 f6f701e1faad30839574d8b20fbba31032755e80 
  geode-core/src/main/java/org/apache/geode/management/MemberMXBean.java 
e2de400601075af880a04b4521898280249d3e99 
  
geode-core/src/main/java/org/apache/geode/management/internal/beans/DistributedSystemMBean.java
 c45da73b4aabfc389b31f9a1092f2abd883813f7 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
 b2f1d561f9ef30dd2c02680b0a1075296719cd61 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
 ef2c3dd5db5f193de1ef307813b02f2ef60a4715 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java
 0f407e7d3273f4ec6206e24bbc064e207335ee11 
  
geode-core/src/main/java/org/apache/geode/management/internal/security/MBeanServerWrapper.java
 47260bc855025864d0def5855eff33d0cdfd6617 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
 e6502c0e4e94b2cea09ff78ea39ebcf02a7197f7 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/DistributedSystemMXBeanSecurityTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60030/diff/1/


Testing
---

precheckin running


Thanks,

Jinmei Liao

Re: Errored: apache/geode#2843 (develop - f85d216)

[Jinmei Liao]

my bad. This should be fixed now.

On Mon, Jun 12, 2017 at 2:07 PM, Travis CI  wrote:

> Build Update for apache/geode
> -
>
> Build: #2843
> Status: Errored
>
> Duration: 4 minutes and 25 seconds
> Commit: f85d216 (develop)
> Author: Jinmei Liao
> Message: GEODE-2928: get rid of the isGfshVM static variable
>
> * consolidate the availability indicators
> * remove the isGfshVM and isGfshVM() method
> * enhance the MultiStepCommand to include info on shellOnly commands to
> enhance command validation
> * remove the SUPPORT_MULTIPLE_GFSH static flag and properly remove the
> gfsh instance at the end of each test
>
> View the changeset: https://github.com/apache/
> geode/compare/d1db2f02d2ce...f85d216341f4
>
> View the full build log and details: https://travis-ci.org/apache/
> geode/builds/242182459?utm_source=email_medium=notification
>
> --
>
> You can configure recipients for build notifications in your .travis.yml
> file. See https://docs.travis-ci.com/user/notifications
>
>


-- 
Cheers

Jinmei

Errored: apache/geode#2843 (develop - f85d216)

[Travis CI]

Build Update for apache/geode
-

Build: #2843
Status: Errored

Duration: 4 minutes and 25 seconds
Commit: f85d216 (develop)
Author: Jinmei Liao
Message: GEODE-2928: get rid of the isGfshVM static variable

* consolidate the availability indicators
* remove the isGfshVM and isGfshVM() method
* enhance the MultiStepCommand to include info on shellOnly commands to enhance 
command validation
* remove the SUPPORT_MULTIPLE_GFSH static flag and properly remove the gfsh 
instance at the end of each test

View the changeset: 
https://github.com/apache/geode/compare/d1db2f02d2ce...f85d216341f4

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/242182459?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[GitHub] geode issue #574: GEODE-3066: Test tweaks to stabilize it.

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/574
  
@jhuynh1 , Last when we experimented with this function in WANTestBase 
tests, the listener is destroyed once the vm is closed, which I believe that 
happens at the end of each test.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60025/#review177670
---




geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
Lines 30 (patched)


would be a good idea for that GEODE_HOME rule to provide this.



geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
Lines 28 (patched)


would be a good idea to provide a javadoc for this.



geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
Lines 29 (patched)


would the user of this rule also require that GEODE_HOME rule you wrote as 
well? Can this rule implies that rule so that user doesn't need to have both 
rules in place?


- Jinmei Liao


On June 12, 2017, 7:53 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60025/
> ---
> 
> (Updated June 12, 2017, 7:53 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
>  PRE-CREATION 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60025/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Review Request 60028: GEODE-2632: consolidate different types of SecurityService

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60028/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

* combine EnabledSecurityService and CustomSecurityService into 
IntegratedSecurityService
* combine DisabledSecurityService and LegacySecurityService
* provide default impelementations of SecurityService
* consolidate SecurityService creation.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 22edb6f06c7791929cc9a033ca1a1bfed5751a47 
  
geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java
 3ff632d3857189513243959ee96da89da66d5a27 
  
geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
 0ba1cb62468f15fda60a94dac9c781fe1793b28f 
  
geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java
 b50569036db1acac927f08ee5c1771c72ede3c1d 
  
geode-core/src/main/java/org/apache/geode/internal/security/EnabledSecurityService.java
 f0568c0ebc2b17c47b5059c60aa4f8bd500c5d6c 
  
geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java
 44562537bc426e47a42d680bb410dc59bf9bd854 
  
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
 a4041e198f1a9a4961915504c51256d0b03aa7c2 
  
geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java
 02f34f15617f7bf4ad9ee7fa51f32be4db3c198a 
  
geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java
 8ae76d22b628b3175db45116b80dfcfbe34aba1d 
  
geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java
 60f014b9c33732a4ea134a654e666a9439b210bb 
  
geode-core/src/main/java/org/apache/geode/internal/security/shiro/CustomAuthRealm.java
 51449fdd5570494f3cf91325985a5eb9fc9f6d57 
  
geode-core/src/main/java/org/apache/geode/internal/security/shiro/RealmInitializer.java
 978c4dd0ab92afde53972f7feb9d8f018d0bf662 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java
 a0c3cf3074051990cc50755131f8024db0b1faad 
  
geode-core/src/test/java/org/apache/geode/internal/security/DisabledSecurityServiceTest.java
 cacbeed957c3b87d08c93db74e38e0134565f699 
  
geode-core/src/test/java/org/apache/geode/internal/security/EnabledSecurityServiceTest.java
 fca7eae9413cee98d351db5349fd950d3aa56180 
  
geode-core/src/test/java/org/apache/geode/internal/security/FakePostProcessor.java
 70823443b5c4f776c86bb28ed49a73e690c5c872 
  
geode-core/src/test/java/org/apache/geode/internal/security/FakeSecurityManager.java
 ca4e6b7fb462bb4e3fefbc5db8a9503c6b13a865 
  
geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceConstructorTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/security/LegacySecurityServiceTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryShiroIntegrationTest.java
 89070123978c22c4cfa8684fbb5b033dc9d83ffa 
  
geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryTest.java
 f027a4367b38681f83dad2d4c4add67759633644 
  
geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceTest.java
 44893520962331bcd41e972afa661538c28d4fb2 
  
geode-core/src/test/java/org/apache/geode/internal/security/shiro/ConfigInitializerIntegrationTest.java
 857c0be8940b4acde2aa4992fac0122b687391c2 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
 c551ca9104a85dcf54c0bebbc4178fce4114a416 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithCustomRealmIntegrationTest.java
 01d6bb6488e76fb3cf652ad211e9f7e2fac51389 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithShiroIniIntegrationTest.java
 1caedbcede239d6a96640381cc6941948637b442 
  
geode-core/src/test/java/org/apache/geode/security/CacheFactoryWithSecurityObjectTest.java
 cdb90f1b580edaf6a2762883d4159a45d69c4728 
  
geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
 e90bc0a69222998322e02fcfad1b6bad3c97f4d1 
  
geode-core/src/test/java/org/apache/geode/security/SecurityManagerLifecycleDistributedTest.java
 a9048b9219a494f61e3873ee3f2908da04bf6154 
  geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/Server.java 
63f907cb007846626a9a66dc6b1ef28e0bb6db45 
  
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ServerRule.java
 767588d3717fccbb0b9c7dec7c5439e16d5381aa 


Diff: https://reviews.apache.org/r/60028/diff/1/


Testing
---

precheckin running


Thanks,

Jinmei Liao

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60010/#review177668
---




geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
Lines 327 (patched)


Are you sure that we want to keep this response around as a member 
variable?  I'm afraid that it might be stale (in the sense that the cluster 
config has since been changed) if this response is referred to later on.


- Jared Stewart


On June 12, 2017, 5:40 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60010/
> ---
> 
> (Updated June 12, 2017, 5:40 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-3062
> https://issues.apache.org/jira/browse/GEODE-3062
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug 
> GEODE-3062.
> 
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can 
> be called during Cache construction.
> 
> Move cluster config request to Cache construction and handle jars and 
> properties there. Create new SecurityService in constructor and overwrite the 
> SecurityService in InternalDistributedSystem.
> 
> NOTE: We will later have to fix GEODE-3061 by moving cluster config request 
> from Cache to InternalDistributedSystem construction so that IDS can be 
> created with gemfire.properties from cluster config. At that time we would 
> rip out both cluster config request and creation of security service from 
> Cache construction and pass both into Cache construction.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  22edb6f06c7791929cc9a033ca1a1bfed5751a47 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
>  4f4881fe39116faa505bc2fbec74efd669efe0ef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  40df0c7dcac8827a381c268c1f90e6acfb97a7f1 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
>  c551ca9104a85dcf54c0bebbc4178fce4114a416 
> 
> 
> Diff: https://reviews.apache.org/r/60010/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60025/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
 PRE-CREATION 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
 PRE-CREATION 
  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60025/diff/1/


Testing
---

Precheckin started (still running)


Thanks,

Jared Stewart

[GitHub] geode pull request #571: GEODE-2601: Fixing banner being logged twice during...

[YehEmily]

Github user YehEmily closed the pull request at:

https://github.com/apache/geode/pull/571


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #571: GEODE-2601: Fixing banner being logged twice during...

[YehEmily]

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/571#discussion_r121499647
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/logging/LogWriterFactory.java
 ---
@@ -87,19 +87,19 @@ public static InternalLogWriter 
createLogWriterLogger(final boolean isLoner,
 // LOG:CONFIG:
 logger.info(LogMarker.CONFIG, Banner.getString(null));
   }
+  System.setProperty(InternalLocator.INHIBIT_DM_BANNER, "true"); // 
Ensure no more banners will
--- End diff --

Yes, I had a suspicion that this would be an issue - do you have any 
suggestions concerning how to do this without changing a system property? I was 
considering just checking the log for whether it contains the banner, but this 
seems inefficient.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #571: GEODE-2601: Fixing banner being logged twice during...

[YehEmily]

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/571#discussion_r121498978
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
 ---
@@ -478,9 +478,8 @@ private InternalLocator(int port, File logF, File 
stateF, InternalLogWriter logW
 if (logWriter == null) {
   logWriter = LogWriterFactory.createLogWriterLogger(false, false, 
this.config,
   !startDistributedSystem);
-  if (logger.isDebugEnabled()) {
+  if (logger.isDebugEnabled())
--- End diff --

Oh, okay! I'll add the brackets back in!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #574: GEODE-3066: Test tweaks to stabilize it.

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/574

GEODE-3066: Test tweaks to stabilize it.

* Regions created before senders and receivers are started.
* Added a listener to slow down the puts so that when the remote region 
is destroyed, the put operation is still ongoing.

Potential reviewers
@jhuynh1 @upthewaterspout @boglesby @ladyVader @gesterzhou 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3066

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/574.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #574


commit d7565767794697ae231b3702903e001aa9cf4dc4
Author: nabarun 
Date:   2017-06-12T18:33:37Z

GEODE-3066: Test tweaks to stabilize it.

* Regions created before senders and receivers are started.
* Added a listener to slow down the puts so that when the remote region 
is destroyed, the put operation is still ongoing.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #568: GEODE-290: Removed deprecated methods from Launcher...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/568


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Using Pull Requests over Review Board

[Nabarun Nag]

+1 On using PR. I feel using github PR is more convenient because of the
following reasons
 a. Commit messages are automatically made into the header and description
in PR, whereas in reviewboard, you upload the patch and do all the writing
- manually. It feels redundant.
 b. After changing the code as per some review comments, we need to upload
the new patch back to  reviewboard but in case of a PR we just need to do a
git push.
 c. A single system for review for all types of contributors - committers
and non committers.
 d. Travis CI runs on the PR - detects missed out spotlessApply or merge
issues.
 e. Also in case someone is AFK for a long time, one can request a fellow
committer to merge the PR without losing commit credit.



After some google search, I could see that a lot of projects are moving to
Github PR system over Review Board. Apache Spark, Apache CloudStack ,
Apache SystemML are a few examples.
Regards
Nabarun

On Mon, Jun 12, 2017 at 9:37 AM Dave Barnes  wrote:

> +0
> Proposal as written says "...for changes that would require peer review
> before committing...".
> If this means that minor changes (in my case, typo repairs are the common
> case) can be checked in without going through a PR process, I can go with
> the group decision.
> Still see no compelling need to retire the Review Board, which (as pointed
> out in the discussion thread) has its uses and advantages.
>
>
>
> On Mon, Jun 12, 2017 at 7:57 AM, Bruce Schuchardt 
> wrote:
>
> > -1
> >
> > It places an unnecessary burden on committers and git history is the
> > definitive record of changes to the code so github pr history isn't
> really
> > very useful.  Also, Review Board is a much better tool for reviewing code
> > than a github PR.
> >
> >
> >
> > On 6/11/17 9:51 AM, Jacob Barrett wrote:
> >
> >> After a few days of discussion [1] this thread has quieted down so I
> would
> >> like to take it to a vote. The proposal is to modify the workflow of
> >> committers to match that of non-committers such that committers shall:
> >>
> >> * Perform all work in progress on branches in their personal forks on
> >> GitHub rather than directly on the ASF Geode repositories.
> >>
> >> * Submit GitHub pull requests, following all current rules for pull
> >> requests, for changes that would require peer review before committing
> to
> >> the production branches.
> >>
> >> * Register their GitHub accounts with the ASF so that committers can be
> >> identified in the GitHub mirror repositories.
> >>
> >>
> >> Please cast your vote.
> >>
> >> [   ] +1  Approve
> >> [   ] +0  No opinion
> >> [   ] -1  Disapprove (and reason why)
> >>
> >>
> >> [1] [DISCUSS] Using Pull Requests over Review Board
> >>  >> org%2Eapache%2Egeode%2Edev+discuss+pull>
> >>
> >> -Jake
> >>
> >>
> >
>

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60010/#review177650
---


Ship it!




Ship It!

- Jinmei Liao


On June 12, 2017, 5:40 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60010/
> ---
> 
> (Updated June 12, 2017, 5:40 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-3062
> https://issues.apache.org/jira/browse/GEODE-3062
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug 
> GEODE-3062.
> 
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can 
> be called during Cache construction.
> 
> Move cluster config request to Cache construction and handle jars and 
> properties there. Create new SecurityService in constructor and overwrite the 
> SecurityService in InternalDistributedSystem.
> 
> NOTE: We will later have to fix GEODE-3061 by moving cluster config request 
> from Cache to InternalDistributedSystem construction so that IDS can be 
> created with gemfire.properties from cluster config. At that time we would 
> rip out both cluster config request and creation of security service from 
> Cache construction and pass both into Cache construction.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  22edb6f06c7791929cc9a033ca1a1bfed5751a47 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
>  4f4881fe39116faa505bc2fbec74efd669efe0ef 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  40df0c7dcac8827a381c268c1f90e6acfb97a7f1 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
>  c551ca9104a85dcf54c0bebbc4178fce4114a416 
> 
> 
> Diff: https://reviews.apache.org/r/60010/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60010/
---

Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Bugs: GEODE-3062
https://issues.apache.org/jira/browse/GEODE-3062


Repository: geode


Description
---

Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug 
GEODE-3062.

Remove unused Cache param from applyClusterPropertiesConfiguration so it can be 
called during Cache construction.

Move cluster config request to Cache construction and handle jars and 
properties there. Create new SecurityService in constructor and overwrite the 
SecurityService in InternalDistributedSystem.

NOTE: We will later have to fix GEODE-3061 by moving cluster config request 
from Cache to InternalDistributedSystem construction so that IDS can be created 
with gemfire.properties from cluster config. At that time we would rip out both 
cluster config request and creation of security service from Cache construction 
and pass both into Cache construction.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 22edb6f06c7791929cc9a033ca1a1bfed5751a47 
  
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
 4f4881fe39116faa505bc2fbec74efd669efe0ef 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
40df0c7dcac8827a381c268c1f90e6acfb97a7f1 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
 c551ca9104a85dcf54c0bebbc4178fce4114a416 


Diff: https://reviews.apache.org/r/60010/diff/1/


Testing
---

Precheckin passes


Thanks,

Kirk Lund

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

[Jinmei Liao]

> On June 12, 2017, 5 p.m., Kirk Lund wrote:
> > I recommend pulling out the changes to SecurityService creation. The 
> > changes I have on the feature branch prevent a Locator from allowing 
> > unsecured joins before the Locator creates its Cache.

Sounds good. I will rebase my change on top of yours then.


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59692/#review177641
---


On June 12, 2017, 2:44 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59692/
> ---
> 
> (Updated June 12, 2017, 2:44 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2925: add target for resource operation for finer grained security
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 9b23f6c1a8ed3449d8a49029d6364f1e989e367c 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  2988ffd43ae1985c527a1082d91b2782b03eced0 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  22edb6f06c7791929cc9a033ca1a1bfed5751a47 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  deea55ff085762a2dd91ebdc57475e42724dee04 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  b682d93fd5c4b5340e2c30be72c5572e031e26ed 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  c52ccbc1cc5a293d70b177e38f03dc17c7db 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  01d99951bc70547fb311f2edbfec8dde1be799f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  2d6af1a22644d427ec2d17863cef27a8d8961491 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  f895b964794f99127f1f0c9564f3f85213e0af22 
>   
> geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
>  84f97de565a8301168f13e1917ea739a8879162c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  40df0c7dcac8827a381c268c1f90e6acfb97a7f1 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java
>  3ff632d3857189513243959ee96da89da66d5a27 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
>  c4946e768ee70db00030defa76da7d21d33c6e0c 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java
>  d328946632c1d0defc86aa0527208a841b9b45ba 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/EnabledSecurityService.java
>  f971deef0807534a014236d37ba48bafa307c56b 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java
>  ef92bb7415c05ae09511e38d8a850f386de23033 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
>  be81582b74a4359f74d483ca64c6e42f6b081738 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java
>  02f34f15617f7bf4ad9ee7fa51f32be4db3c198a 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java
>  8ae76d22b628b3175db45116b80dfcfbe34aba1d 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java
>  60f014b9c33732a4ea134a654e666a9439b210bb 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/CustomAuthRealm.java
>  51449fdd5570494f3cf91325985a5eb9fc9f6d57 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/RealmInitializer.java
>  978c4dd0ab92afde53972f7feb9d8f018d0bf662 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
>  64fafda8437e06de818ead40731818f937c3aef5 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java
>  7ec7699821c9f5572aebeb0936ad3617e802c07e 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/security/AccessControlMBean.java
>  365c6ae01994cd0d5c06e523c42b6bec19c14c5d 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/security/MBeanServerWrapper.java
>  345d688c10c0477904ceb4c5a52302b7bd3eaec9 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/security/ResourceOperation.java
>  db3a1872a87b558772902cf14580f3e14fca97b3 
>   

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59692/#review177641
---



I recommend pulling out the changes to SecurityService creation. The changes I 
have on the feature branch prevent a Locator from allowing unsecured joins 
before the Locator creates its Cache.

- Kirk Lund


On June 12, 2017, 2:44 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59692/
> ---
> 
> (Updated June 12, 2017, 2:44 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2925: add target for resource operation for finer grained security
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 9b23f6c1a8ed3449d8a49029d6364f1e989e367c 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  2988ffd43ae1985c527a1082d91b2782b03eced0 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  22edb6f06c7791929cc9a033ca1a1bfed5751a47 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  deea55ff085762a2dd91ebdc57475e42724dee04 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  b682d93fd5c4b5340e2c30be72c5572e031e26ed 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  c52ccbc1cc5a293d70b177e38f03dc17c7db 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  01d99951bc70547fb311f2edbfec8dde1be799f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  2d6af1a22644d427ec2d17863cef27a8d8961491 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  f895b964794f99127f1f0c9564f3f85213e0af22 
>   
> geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
>  84f97de565a8301168f13e1917ea739a8879162c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  40df0c7dcac8827a381c268c1f90e6acfb97a7f1 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java
>  3ff632d3857189513243959ee96da89da66d5a27 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
>  c4946e768ee70db00030defa76da7d21d33c6e0c 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java
>  d328946632c1d0defc86aa0527208a841b9b45ba 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/EnabledSecurityService.java
>  f971deef0807534a014236d37ba48bafa307c56b 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java
>  ef92bb7415c05ae09511e38d8a850f386de23033 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
>  be81582b74a4359f74d483ca64c6e42f6b081738 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java
>  02f34f15617f7bf4ad9ee7fa51f32be4db3c198a 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java
>  8ae76d22b628b3175db45116b80dfcfbe34aba1d 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java
>  60f014b9c33732a4ea134a654e666a9439b210bb 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/CustomAuthRealm.java
>  51449fdd5570494f3cf91325985a5eb9fc9f6d57 
>   
> geode-core/src/main/java/org/apache/geode/internal/security/shiro/RealmInitializer.java
>  978c4dd0ab92afde53972f7feb9d8f018d0bf662 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
>  64fafda8437e06de818ead40731818f937c3aef5 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java
>  7ec7699821c9f5572aebeb0936ad3617e802c07e 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/security/AccessControlMBean.java
>  365c6ae01994cd0d5c06e523c42b6bec19c14c5d 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/security/MBeanServerWrapper.java
>  345d688c10c0477904ceb4c5a52302b7bd3eaec9 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/security/ResourceOperation.java
>  db3a1872a87b558772902cf14580f3e14fca97b3 
>   geode-core/src/main/java/org/apache/geode/security/ResourcePermission.java 
> 45da464419779773c9116d824fcf11774bafbd79 
>   
> 

Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59961/#review177640
---


Ship it!




Ship It!

- Kirk Lund


On June 9, 2017, 11:35 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59961/
> ---
> 
> (Updated June 9, 2017, 11:35 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME
> 
> - A subsequent commit will add this rule to all of the relevant tests.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/RequiresGeodeHome.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59961/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

RE: release 1.2

[Vahram Aharonyan]

Hi All,

We really think fix done for GEODE-3023 should be considered for 1.2 version as 
well. Especially since similar fix(GEODE-2898) has been already made it to 1.2 
version. So shipping a partial/incomplete fix in 1.2 version for the same kind 
of problem does not really provide value, and still leaves the system exposed 
with a resiliency problem in case of network problems.

The problem is indeed critical, it is hitting on nearly every meaningfully 
large environment which has reasonable amount of network issues. It turns out 
that this problem is impacting entire Geode cluster, whenever there is Geode 
client with let say imperfect quality of network connectivity.  To overcome 
this SSL should be disabled for the cluster, which is not the best way to 
proceed.

Thanks,
Vahram.

-Original Message-
From: Anthony Baker [mailto:aba...@pivotal.io] 
Sent: Monday, June 12, 2017 7:42 PM
To: dev@geode.apache.org
Subject: Re: release 1.2

Got it, thanks!

Anthony

> On Jun 10, 2017, at 7:15 PM, Udo Kohlmeyer  wrote:
> 
> I thought we had moved GEODE-3052 to a later release, given that we have a 
> work around for this.
> 
> --Udo
> 
> 
> On 6/10/17 10:15, Anthony Baker wrote:
>> Status update:
>> 
>> We have 2 issues left:  GEODE-3054 and GEODE-3052.  We also had a clean run 
>> of the Geode-release jenkins job.  So as soon as we can finish off these 
>> issues and get another clean run through Jenkins I’ll create a release 
>> candidate.  How does early next week sound?
>> 
>> Anthony
>> 
>>> On Jun 8, 2017, at 5:38 PM, Anthony Baker  wrote:
>>> 
>>> Sounds good.  Please cherry-pick these changes onto release/1.2.0 when 
>>> ready.
>>> 
>>> Anthony
>>> 
>>> 
 On Jun 8, 2017, at 3:15 PM, Jared Stewart  wrote:
 
 I think we probably ought to include GEODE-3045 
  as well.
 
> On Jun 8, 2017, at 3:12 PM, Kenneth Howe  wrote:
> 
> I think we should also include the fix for GEODE-3054 in 1.2. This is a 
> bug that was introduced in the recent changes to the Gfsh parser, and 
> affects Windows pathnames specified in options to gfsh commands.
> 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_GEODE-2D3054=DwIFaQ=uilaK90D4TOVoH58JNXRgQ=wpTWSXVvcGFCkFEMePbOecdHHTbyiIj9aWq7oqKb0J8=3eSDKrOEyEHtI5Oe9-iROOP-AWX9d-a1B-s9UX41yU4=jSeNlEnjklIGLNnCF8I6cG0t06n2NT5xLBe86ewSmXc=
>   
>   >
> 
> The fix is currently in testing.
> 
> 
>> On Jun 8, 2017, at 2:23 PM, Bruce Schuchardt  
>> wrote:
>> 
>> I'd like to include the fix for GEODE-3052 in the 1.2 release. It's 
>> under review now and has passed new tests and is in precheckin testing.
>> 
>> 
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_GEODE-2D3052=DwIFaQ=uilaK90D4TOVoH58JNXRgQ=wpTWSXVvcGFCkFEMePbOecdHHTbyiIj9aWq7oqKb0J8=3eSDKrOEyEHtI5Oe9-iROOP-AWX9d-a1B-s9UX41yU4=T_2Qx57Vhl2-Z_X8qw8OOSwcKYzGBg0IFafSWdbIMPs=
>>  
>> 
>> "Restarting 2 locators within 1s of each other causes potential locator 
>> split brain"
>> 
> 

Re: [VOTE] Using Pull Requests over Review Board

[Dave Barnes]

+0
Proposal as written says "...for changes that would require peer review
before committing...".
If this means that minor changes (in my case, typo repairs are the common
case) can be checked in without going through a PR process, I can go with
the group decision.
Still see no compelling need to retire the Review Board, which (as pointed
out in the discussion thread) has its uses and advantages.



On Mon, Jun 12, 2017 at 7:57 AM, Bruce Schuchardt 
wrote:

> -1
>
> It places an unnecessary burden on committers and git history is the
> definitive record of changes to the code so github pr history isn't really
> very useful.  Also, Review Board is a much better tool for reviewing code
> than a github PR.
>
>
>
> On 6/11/17 9:51 AM, Jacob Barrett wrote:
>
>> After a few days of discussion [1] this thread has quieted down so I would
>> like to take it to a vote. The proposal is to modify the workflow of
>> committers to match that of non-committers such that committers shall:
>>
>> * Perform all work in progress on branches in their personal forks on
>> GitHub rather than directly on the ASF Geode repositories.
>>
>> * Submit GitHub pull requests, following all current rules for pull
>> requests, for changes that would require peer review before committing to
>> the production branches.
>>
>> * Register their GitHub accounts with the ASF so that committers can be
>> identified in the GitHub mirror repositories.
>>
>>
>> Please cast your vote.
>>
>> [   ] +1  Approve
>> [   ] +0  No opinion
>> [   ] -1  Disapprove (and reason why)
>>
>>
>> [1] [DISCUSS] Using Pull Requests over Review Board
>> > org%2Eapache%2Egeode%2Edev+discuss+pull>
>>
>> -Jake
>>
>>
>

Re: Build failed in Jenkins: Geode-nightly #864

[Jason Huynh]

I've created a ticket for the failing wan test: GEODE-3066


On Mon, Jun 12, 2017 at 8:34 AM Apache Jenkins Server <
jenk...@builds.apache.org> wrote:

> See 
>
> --
> [...truncated 96.86 KB...]
> :geode-cq:assemble
> :geode-cq:compileTestJavaNote: Some input files use or override a
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
>
> :geode-cq:processTestResources
> :geode-cq:testClasses
> :geode-cq:checkMissedTests
> :geode-cq:spotlessJavaCheck
> :geode-cq:spotlessCheck
> :geode-cq:test
> :geode-cq:check
> :geode-cq:build
> :geode-cq:distributedTest
> :geode-cq:integrationTest
> :geode-json:assemble
> :geode-json:compileTestJava UP-TO-DATE
> :geode-json:processTestResources
> :geode-json:testClasses
> :geode-json:checkMissedTests UP-TO-DATE
> :geode-json:spotlessJavaCheck
> :geode-json:spotlessCheck
> :geode-json:test UP-TO-DATE
> :geode-json:check
> :geode-json:build
> :geode-json:distributedTest UP-TO-DATE
> :geode-json:integrationTest UP-TO-DATE
> :geode-junit:javadoc
> :geode-junit:javadocJar
> :geode-junit:sourcesJar
> :geode-junit:signArchives SKIPPED
> :geode-junit:assemble
> :geode-junit:compileTestJava
> :geode-junit:processTestResources UP-TO-DATE
> :geode-junit:testClasses
> :geode-junit:checkMissedTests
> :geode-junit:spotlessJavaCheck
> :geode-junit:spotlessCheck
> :geode-junit:test
> :geode-junit:check
> :geode-junit:build
> :geode-junit:distributedTest
> :geode-junit:integrationTest
> :geode-lucene:assemble
> :geode-lucene:compileTestJavaNote: Some input files use or override a
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
>
> :geode-lucene:processTestResources
> :geode-lucene:testClasses
> :geode-lucene:checkMissedTests
> :geode-lucene:spotlessJavaCheck
> :geode-lucene:spotlessCheck
> :geode-lucene:test
> :geode-lucene:check
> :geode-lucene:build
> :geode-lucene:distributedTest
> :geode-lucene:integrationTest
> :geode-old-client-support:assemble
> :geode-old-client-support:compileTestJavaNote: <
> https://builds.apache.org/job/Geode-nightly/ws/geode-old-client-support/src/test/java/com/gemstone/gemfire/cache/execute/FunctionExceptionTest.java>
> uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
>
> :geode-old-client-support:processTestResources UP-TO-DATE
> :geode-old-client-support:testClasses
> :geode-old-client-support:checkMissedTests
> :geode-old-client-support:spotlessJavaCheck
> :geode-old-client-support:spotlessCheck
> :geode-old-client-support:test
> :geode-old-client-support:check
> :geode-old-client-support:build
> :geode-old-client-support:distributedTest
> :geode-old-client-support:integrationTest
> :geode-old-versions:javadoc UP-TO-DATE
> :geode-old-versions:javadocJar
> :geode-old-versions:sourcesJar
> :geode-old-versions:signArchives SKIPPED
> :geode-old-versions:assemble
> :geode-old-versions:compileTestJava UP-TO-DATE
> :geode-old-versions:processTestResources UP-TO-DATE
> :geode-old-versions:testClasses UP-TO-DATE
> :geode-old-versions:checkMissedTests UP-TO-DATE
> :geode-old-versions:spotlessJavaCheck
> :geode-old-versions:spotlessCheck
> :geode-old-versions:test UP-TO-DATE
> :geode-old-versions:check
> :geode-old-versions:build
> :geode-old-versions:distributedTest UP-TO-DATE
> :geode-old-versions:integrationTest UP-TO-DATE
> :geode-pulse:assemble
> :geode-pulse:compileTestJavaNote: <
> https://builds.apache.org/job/Geode-nightly/ws/geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/ui/PulseBase.java>
> uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: <
> https://builds.apache.org/job/Geode-nightly/ws/geode-pulse/src/test/java/org/apache/geode/tools/pulse/controllers/PulseControllerJUnitTest.java>
> uses unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
>
> :geode-pulse:processTestResources
> :geode-pulse:testClasses
> :geode-pulse:checkMissedTests
> :geode-pulse:spotlessJavaCheck
> :geode-pulse:spotlessCheck
> :geode-pulse:test
> :geode-pulse:check
> :geode-pulse:build
> :geode-pulse:distributedTest
> :geode-pulse:integrationTest
> :geode-rebalancer:assemble
> :geode-rebalancer:compileTestJava
> :geode-rebalancer:processTestResources UP-TO-DATE
> :geode-rebalancer:testClasses
> :geode-rebalancer:checkMissedTests
> :geode-rebalancer:spotlessJavaCheck
> :geode-rebalancer:spotlessCheck
> :geode-rebalancer:test
> :geode-rebalancer:check
> :geode-rebalancer:build
> :geode-rebalancer:distributedTest
> :geode-rebalancer:integrationTest
> :geode-wan:assemble
> :geode-wan:compileTestJavaNote: Some input files use 

Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59961/#review177620
---


Ship it!





geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/RequiresGeodeHome.java
Lines 28 (patched)


Many of us are in the habit of putting '\n' in message strings, but I think 
using LINE_SEPARATOR would be better.


- Ken Howe


On June 9, 2017, 11:35 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59961/
> ---
> 
> (Updated June 9, 2017, 11:35 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME
> 
> - A subsequent commit will add this rule to all of the relevant tests.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/RequiresGeodeHome.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59961/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: [VOTE] Using Pull Requests over Review Board

[Bruce Schuchardt]

-1

It places an unnecessary burden on committers and git history is the 
definitive record of changes to the code so github pr history isn't 
really very useful.  Also, Review Board is a much better tool for 
reviewing code than a github PR.



On 6/11/17 9:51 AM, Jacob Barrett wrote:

After a few days of discussion [1] this thread has quieted down so I would
like to take it to a vote. The proposal is to modify the workflow of
committers to match that of non-committers such that committers shall:

* Perform all work in progress on branches in their personal forks on
GitHub rather than directly on the ASF Geode repositories.

* Submit GitHub pull requests, following all current rules for pull
requests, for changes that would require peer review before committing to
the production branches.

* Register their GitHub accounts with the ASF so that committers can be
identified in the GitHub mirror repositories.


Please cast your vote.

[   ] +1  Approve
[   ] +0  No opinion
[   ] -1  Disapprove (and reason why)


[1] [DISCUSS] Using Pull Requests over Review Board


-Jake

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59692/
---

(Updated June 12, 2017, 2:44 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

While rebasing this changeset to develop to pick up Kirk's security work, I got 
a bit carried away in refactoring. Below are the main points of this changeset:

1) move the creation of the security service back to GemfireCacheImpl, so that 
the security manager property recevied in the cluster configuration will take 
effect. (mainly reverted the changes under distributed.internal.membership 
package)
2) consolidate the implementation of SecurityService into two: 
IntegratedSecurityService and LegacySecurityService to avoid code duplication.
3) added default implemenation of SecurityService (debateble)
4) reworked SecurityServicefactory and add more tests.


Repository: geode


Description
---

GEODE-2925: add target for resource operation for finer grained security


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
9b23f6c1a8ed3449d8a49029d6364f1e989e367c 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 2988ffd43ae1985c527a1082d91b2782b03eced0 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 22edb6f06c7791929cc9a033ca1a1bfed5751a47 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 deea55ff085762a2dd91ebdc57475e42724dee04 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 b682d93fd5c4b5340e2c30be72c5572e031e26ed 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 c52ccbc1cc5a293d70b177e38f03dc17c7db 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 01d99951bc70547fb311f2edbfec8dde1be799f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 2d6af1a22644d427ec2d17863cef27a8d8961491 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 f895b964794f99127f1f0c9564f3f85213e0af22 
  
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
 84f97de565a8301168f13e1917ea739a8879162c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
40df0c7dcac8827a381c268c1f90e6acfb97a7f1 
  
geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java
 3ff632d3857189513243959ee96da89da66d5a27 
  
geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
 c4946e768ee70db00030defa76da7d21d33c6e0c 
  
geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java
 d328946632c1d0defc86aa0527208a841b9b45ba 
  
geode-core/src/main/java/org/apache/geode/internal/security/EnabledSecurityService.java
 f971deef0807534a014236d37ba48bafa307c56b 
  
geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java
 ef92bb7415c05ae09511e38d8a850f386de23033 
  
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
 be81582b74a4359f74d483ca64c6e42f6b081738 
  
geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java
 02f34f15617f7bf4ad9ee7fa51f32be4db3c198a 
  
geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java
 8ae76d22b628b3175db45116b80dfcfbe34aba1d 
  
geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java
 60f014b9c33732a4ea134a654e666a9439b210bb 
  
geode-core/src/main/java/org/apache/geode/internal/security/shiro/CustomAuthRealm.java
 51449fdd5570494f3cf91325985a5eb9fc9f6d57 
  
geode-core/src/main/java/org/apache/geode/internal/security/shiro/RealmInitializer.java
 978c4dd0ab92afde53972f7feb9d8f018d0bf662 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
 64fafda8437e06de818ead40731818f937c3aef5 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java
 7ec7699821c9f5572aebeb0936ad3617e802c07e 
  
geode-core/src/main/java/org/apache/geode/management/internal/security/AccessControlMBean.java
 365c6ae01994cd0d5c06e523c42b6bec19c14c5d 
  
geode-core/src/main/java/org/apache/geode/management/internal/security/MBeanServerWrapper.java
 345d688c10c0477904ceb4c5a52302b7bd3eaec9 
  
geode-core/src/main/java/org/apache/geode/management/internal/security/ResourceOperation.java
 db3a1872a87b558772902cf14580f3e14fca97b3 
  geode-core/src/main/java/org/apache/geode/security/ResourcePermission.java 
45da464419779773c9116d824fcf11774bafbd79