Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/#review179219
---




geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Lines 255 (patched)


What does `la` mean in this context? could we possibly use more a more 
meaningful variable name?



geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Line 243 (original), 282 (patched)


`la` is not a meaningful variable name



geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
Line 274 (original), 312 (patched)


`la` not a meaningful variable name



geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
Line 389 (original), 390 (patched)


I know this is legacy code, but what does `others` represent here? Not 
clear what this method is doing by just reading the method name



geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java
Lines 269 (patched)


could we not just inline `isa` with `getInetSocketAddress(host,port)`



geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java
Line 298 (original), 305 (patched)


`l` is not a meaningful variable name. Maybe `locator` is more meaningful?


- Udo Kohlmeyer


On June 28, 2017, 6:48 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60312/
> ---
> 
> (Updated June 28, 2017, 6:48 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen 
> O'Sullivan.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2804 Cache InetAddress if configure host as ip string.
> 
> 1. We keep configure host string in HostAddress class
> 2. We reuse InetsocketAddress if it is ipString.
> 3. Client has logic to retry thus we keep InetsocketAddress even if 
>it is not ip string.
> 
> GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.
> 
> GEODE-2940 Now we don't validate configure host string on start. As
> there is possibility that host may not available.
> 
> 1. Earlier wan config were failing because of that. Now we just keep
> those configure host string. And try this later.
> 
> Added unit tests for it.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 39bb542 
>   geode-assembly/src/test/resources/expected_jars.txt 6260167 
>   geode-core/build.gradle 7f34b4a 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java
>  c1bfc93 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
>  53d401a 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 
> 3ded54a 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java
>  01c6157 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  a4b3a50 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java
>  da295ab 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
>  aff1938 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  bc3d708 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java
>  6b54170 
>   
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
>  5ab1bed 
>   
> geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java
>  1dc2fd1 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
>  92cfd96 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java 
> d4fdbd0 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java
>  0efba01 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
>  88832ba 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java
>  789d326 
>   
> geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
>  3cc3cfc 
>   
> 

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60523/#review179218
---




geode-protobuf/src/main/proto/region_API.proto
Lines 117 (patched)


What does this service do? Just check if a region exists? If so, should we 
not rename it to `RegionExistsRequest` and `RegionExistsResponse`.
If this is supposed to do more than just true/false, should we maybe have 
some extra info that we return? Maybe a `Region` object that contains some 
region information


- Udo Kohlmeyer


On June 28, 2017, 11:06 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60523/
> ---
> 
> (Updated June 28, 2017, 11:06 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3141
> https://issues.apache.org/jira/browse/GEODE-3141
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added a GetRegion(regionName) API.  More details about the server region can 
> be added if needed.  This implementation just has a success flag and flag 
> saying whether the region is destroyed.
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
>  4318fb444dd0eb5f5d07175a466e26f03933cc4d 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  4e76de4a15d1ff0cfeddcc2c7115c7c18c2e14ba 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java
>  PRE-CREATION 
>   geode-protobuf/src/main/proto/clientProtocol.proto 
> 0c192950a4e750f7c55e186c18a79a6c52716bf0 
>   geode-protobuf/src/main/proto/region_API.proto 
> d3af17acb1ee45c134837c321b2009c8532817cc 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> dc897241fc229da53a5ff7a0e2df1678b8bceb6d 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  77b984f7e28a7bfa21b8e1c8c6a83467e9a37242 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java
>  e8f1e651a71240474a793d005164df1ba5d4cda7 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60523/diff/1/
> 
> 
> Testing
> ---
> 
> new unit tests
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60523/#review179217
---




geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java
Lines 42 (patched)


Does this not muddy the implementation? What can a destroyed region return? 
Surely a region exists or it does not...



geode-protobuf/src/main/proto/region_API.proto
Lines 118 (patched)


What does this field mean? How do we represent a failure?


- Udo Kohlmeyer


On June 28, 2017, 11:06 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60523/
> ---
> 
> (Updated June 28, 2017, 11:06 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3141
> https://issues.apache.org/jira/browse/GEODE-3141
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added a GetRegion(regionName) API.  More details about the server region can 
> be added if needed.  This implementation just has a success flag and flag 
> saying whether the region is destroyed.
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
>  4318fb444dd0eb5f5d07175a466e26f03933cc4d 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  4e76de4a15d1ff0cfeddcc2c7115c7c18c2e14ba 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java
>  PRE-CREATION 
>   geode-protobuf/src/main/proto/clientProtocol.proto 
> 0c192950a4e750f7c55e186c18a79a6c52716bf0 
>   geode-protobuf/src/main/proto/region_API.proto 
> d3af17acb1ee45c134837c321b2009c8532817cc 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> dc897241fc229da53a5ff7a0e2df1678b8bceb6d 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  77b984f7e28a7bfa21b8e1c8c6a83467e9a37242 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java
>  e8f1e651a71240474a793d005164df1ba5d4cda7 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60523/diff/1/
> 
> 
> Testing
> ---
> 
> new unit tests
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60513/#review179216
---




geode-core/src/main/java/org/apache/geode/internal/cache/TXSynchronizationRunnable.java
Lines 42 (patched)


make "acceptor" final



geode-core/src/main/java/org/apache/geode/internal/cache/TXSynchronizationRunnable.java
Line 42 (original), 44 (patched)


I think it would be nice if you introduced a new interface named 
"CommBufferPool" that just has two methods on it (takeCommBuffer and 
releaseCommBuffer).
Change AcceptorImpl to extend this new interface and change this 
constructor to take a CommBufferPool instead of an AcceptorImpl.



geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
Line 145 (original), 145 (patched)


I think this would be easier to understand:
AcceptorImpl acceptor = serverConnection.getAcceptor();
if (!acceptor.isSelector()) {
  acceptor = null;
}
new TXSynchronizationRunnable(beforeCompletion, acceptor);


- Darrel Schneider


On June 28, 2017, 5:20 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60513/
> ---
> 
> (Updated June 28, 2017, 5:20 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
> Gallinat.
> 
> 
> Bugs: GEODE-3147
> https://issues.apache.org/jira/browse/GEODE-3147
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Set byte buffer for the threads that need to send reply to clients when 
> Max_Threads are set.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/TXSynchronizationRunnable.java
>  35b0e75 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
>  b1b0cfb 
>   
> geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
>  51ef44a 
> 
> 
> Diff: https://reviews.apache.org/r/60513/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 60451: GEODE-2996: adding Put handler

[Brian Rowe]

> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
> > Lines 68 (patched)
> > 
> >
> > This has nothing to do with the ProtobufOpsProcessor. Maybe the builder 
> > can be passed in.

Hmm, I'm not sure I agree. The ProtobufOpsProcessor has to generate the 
ClientProtocol.Response containing the response from the operation handler. It 
seems reasonable for it to know how to build this object. Having the builder 
needing to be passed into this seems similar to requiring this class to pass 
the builder for the operation response down to the operation handler.


> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
> > Line 42 (original), 39 (patched)
> > 
> >
> > Maybe we do this before the key is decoded. After line 34 if possible.

Good call.


> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
> > Lines 42 (patched)
> > 
> >
> > Maybe this should be replaced with an errorMessage, stating this region 
> > does not exist.

Agreed, we actually have a story to add this in and apparently there's been a 
discussion with the PDD team about how they want these formatted.  All of this 
error handling will be revisited when that story is picked up (should be in the 
next few days).


> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
> > Lines 54 (patched)
> > 
> >
> > `encoding` should start with capitol

Fixed.


> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
> > Lines 56 (patched)
> > 
> >
> > `codec` should start with capitol

Fixed.


> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
> > Lines 62 (patched)
> > 
> >
> > Maybe this should return an empty list.

I'm going to talk with the team tomorrow and see if we can't come up with some 
way to indicate optional arguments.


> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
> > Lines 66 (patched)
> > 
> >
> > This provides no information about the failure... An `ErrorMessage` 
> > should be a more suitable replacement

Yes, once we have an error message we'll hopefully not even return a 
GetResponse here (which will make things more complicated in the OpsProcessor).


> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
> > Line 59 (original), 78 (patched)
> > 
> >
> > Can I have a `success=false` and `keyExists=true`? What does 
> > `keyExists` provide me in functionality above and beyond `success` or an 
> > `ErrorMessage`?

keyExists was supposed to differentiate between not present vs. nulled keys. 
However in talking through this with Galen it's clear that we need to think 
through this a bit more.


> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/main/proto/region_API.proto
> > Line 35 (original), 35 (patched)
> > 
> >
> > not sure `success` or `keyExists` provides any value here `result` 
> > should either have a value or not. 
> > What does `keyExists` denote? 
> > What counts as a `failure`?

Unfortunately the protobuf protocol doesn't really give us a way to not have a 
result. keyExists is supposed to denote whether the key was found independant 
of whether or not it had a value, but we still need to figure out how to encode 
a lack of value. A failure would be anything that kept us from even running the 
query. An error decoding the key would be an example.


> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote:
> > geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java
> > Line 20 (original), 31 (patched)
> > 

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

[Eric Shu]

> On June 28, 2017, 11:09 p.m., Darrel Schneider wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
> > Lines 223 (patched)
> > 
> >
> > How about moving all these changes to TXSynchronizationRunnable?
> > When you construct it give it the serverConnection and then it can have 
> > needTLCommBuffer and do the setTLCommBuffer and releaseCommBuffer.
> > 
> > That way you do not need to make a bunch of changes to this class and 
> > it will be much easier to review.

Thanks for the suggestion, the new fix only acquire and release the comm buffer 
once now.


- Eric


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60513/#review179198
---


On June 29, 2017, 12:20 a.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60513/
> ---
> 
> (Updated June 29, 2017, 12:20 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
> Gallinat.
> 
> 
> Bugs: GEODE-3147
> https://issues.apache.org/jira/browse/GEODE-3147
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Set byte buffer for the threads that need to send reply to clients when 
> Max_Threads are set.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/TXSynchronizationRunnable.java
>  35b0e75 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
>  b1b0cfb 
>   
> geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
>  51ef44a 
> 
> 
> Diff: https://reviews.apache.org/r/60513/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

[Eric Shu]

> On June 28, 2017, 7:31 p.m., anilkumar gingade wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
> > Lines 106 (patched)
> > 
> >
> > Can we move this to doBeforeCompletion() as done in 
> > createAfterCompletionRunnable() which returns the runnable.

Only need to set condition once for the two synchronization call now with 
Darrel's review.


- Eric


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60513/#review179156
---


On June 29, 2017, 12:20 a.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60513/
> ---
> 
> (Updated June 29, 2017, 12:20 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
> Gallinat.
> 
> 
> Bugs: GEODE-3147
> https://issues.apache.org/jira/browse/GEODE-3147
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Set byte buffer for the threads that need to send reply to clients when 
> Max_Threads are set.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/TXSynchronizationRunnable.java
>  35b0e75 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
>  b1b0cfb 
>   
> geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
>  51ef44a 
> 
> 
> Diff: https://reviews.apache.org/r/60513/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60513/
---

(Updated June 29, 2017, 12:20 a.m.)


Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
Gallinat.


Changes
---

Fix review comments


Bugs: GEODE-3147
https://issues.apache.org/jira/browse/GEODE-3147


Repository: geode


Description
---

Set byte buffer for the threads that need to send reply to clients when 
Max_Threads are set.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/TXSynchronizationRunnable.java
 35b0e75 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
 b1b0cfb 
  
geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
 51ef44a 


Diff: https://reviews.apache.org/r/60513/diff/2/

Changes: https://reviews.apache.org/r/60513/diff/1-2/


Testing
---

precheckin.


Thanks,

Eric Shu

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60523/#review179202
---




geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java
Lines 39 (patched)


If the region legitimately doesn't exist, is this really a failure?  Maybe 
we should rename the 'success' field to something like 'found'.



geode-protobuf/src/main/proto/region_API.proto
Lines 119 (patched)


I think it'd be cleaner to add these fields to the Region protobuf object 
(we'd also need to change the GetRegionsResponse to contain strings instead of 
Regions, which also seems like an improvement).


- Brian Rowe


On June 28, 2017, 11:06 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60523/
> ---
> 
> (Updated June 28, 2017, 11:06 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3141
> https://issues.apache.org/jira/browse/GEODE-3141
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added a GetRegion(regionName) API.  More details about the server region can 
> be added if needed.  This implementation just has a success flag and flag 
> saying whether the region is destroyed.
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
>  4318fb444dd0eb5f5d07175a466e26f03933cc4d 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  4e76de4a15d1ff0cfeddcc2c7115c7c18c2e14ba 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java
>  PRE-CREATION 
>   geode-protobuf/src/main/proto/clientProtocol.proto 
> 0c192950a4e750f7c55e186c18a79a6c52716bf0 
>   geode-protobuf/src/main/proto/region_API.proto 
> d3af17acb1ee45c134837c321b2009c8532817cc 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> dc897241fc229da53a5ff7a0e2df1678b8bceb6d 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  77b984f7e28a7bfa21b8e1c8c6a83467e9a37242 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java
>  e8f1e651a71240474a793d005164df1ba5d4cda7 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60523/diff/1/
> 
> 
> Testing
> ---
> 
> new unit tests
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] geode pull request #612: GEODE-3121: ensure that the protobuf protocol works...

[WireBaron]

GitHub user WireBaron opened a pull request:

https://github.com/apache/geode/pull/612

GEODE-3121: ensure that the protobuf protocol works over SSL

This just introduces a new test where we run the put/get integration test 
of the protocol module, but sets up a SSL cache and socket.

Signed-off-by: Brian Rowe 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/WireBaron/geode feature/GEODE-3121

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #612


commit e0f1dce7872196ce194fea80c88ddcd58fe95b6f
Author: Hitesh Khamesra 
Date:   2017-06-28T23:10:31Z

GEODE-3121: ensure that the protobuf protocol works over SSL

This just introduces a new test where we run the put/get integration test 
of the protocol module, but sets up a SSL cache and socket.

Signed-off-by: Brian Rowe 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60526/
---

Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-3121
https://issues.apache.org/jira/browse/GEODE-3121


Repository: geode


Description
---

Adding a new test to run the protobuf integration test over a SSL connection.


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java 
844b48413 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 77b984f7e 
  geode-protobuf/src/test/resources/org/apache/geode/protocol/default.keystore 
PRE-CREATION 


Diff: https://reviews.apache.org/r/60526/diff/1/


Testing
---

This change is just adding a test.


Thanks,

Brian Rowe

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

[Alexander Murmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60523/#review179201
---


Ship it!




Ship It!

- Alexander Murmann


On June 28, 2017, 11:06 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60523/
> ---
> 
> (Updated June 28, 2017, 11:06 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3141
> https://issues.apache.org/jira/browse/GEODE-3141
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added a GetRegion(regionName) API.  More details about the server region can 
> be added if needed.  This implementation just has a success flag and flag 
> saying whether the region is destroyed.
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
>  4318fb444dd0eb5f5d07175a466e26f03933cc4d 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  4e76de4a15d1ff0cfeddcc2c7115c7c18c2e14ba 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java
>  PRE-CREATION 
>   geode-protobuf/src/main/proto/clientProtocol.proto 
> 0c192950a4e750f7c55e186c18a79a6c52716bf0 
>   geode-protobuf/src/main/proto/region_API.proto 
> d3af17acb1ee45c134837c321b2009c8532817cc 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> dc897241fc229da53a5ff7a0e2df1678b8bceb6d 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  77b984f7e28a7bfa21b8e1c8c6a83467e9a37242 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java
>  e8f1e651a71240474a793d005164df1ba5d4cda7 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60523/diff/1/
> 
> 
> Testing
> ---
> 
> new unit tests
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60513/#review179198
---




geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
Lines 223 (patched)


How about moving all these changes to TXSynchronizationRunnable?
When you construct it give it the serverConnection and then it can have 
needTLCommBuffer and do the setTLCommBuffer and releaseCommBuffer.

That way you do not need to make a bunch of changes to this class and it 
will be much easier to review.


- Darrel Schneider


On June 28, 2017, 11:58 a.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60513/
> ---
> 
> (Updated June 28, 2017, 11:58 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
> Gallinat.
> 
> 
> Bugs: GEODE-3147
> https://issues.apache.org/jira/browse/GEODE-3147
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Set byte buffer for the threads that need to send reply to clients when 
> Max_Threads are set.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
>  b1b0cfb 
>   
> geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
>  51ef44a 
> 
> 
> Diff: https://reviews.apache.org/r/60513/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Review Request 60523: GEODE-3141 New flow: GetRegion

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60523/
---

Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra, 
Udo Kohlmeyer, and Brian Rowe.


Bugs: GEODE-3141
https://issues.apache.org/jira/browse/GEODE-3141


Repository: geode


Description
---

Added a GetRegion(regionName) API.  More details about the server region can be 
added if needed.  This implementation just has a success flag and flag saying 
whether the region is destroyed.


Diffs
-

  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
 4318fb444dd0eb5f5d07175a466e26f03933cc4d 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
 4e76de4a15d1ff0cfeddcc2c7115c7c18c2e14ba 
  
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java
 PRE-CREATION 
  geode-protobuf/src/main/proto/clientProtocol.proto 
0c192950a4e750f7c55e186c18a79a6c52716bf0 
  geode-protobuf/src/main/proto/region_API.proto 
d3af17acb1ee45c134837c321b2009c8532817cc 
  geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
dc897241fc229da53a5ff7a0e2df1678b8bceb6d 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 77b984f7e28a7bfa21b8e1c8c6a83467e9a37242 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java
 e8f1e651a71240474a793d005164df1ba5d4cda7 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandlerJUnitTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60523/diff/1/


Testing
---

new unit tests


Thanks,

Bruce Schuchardt

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #600 was SUCCESSFUL (with 1908 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #600 was successful.
---
Scheduled
1910 tests in total.

https://build.spring.io/browse/SGF-NAG-600/





--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode pull request #610: GEODE-3146 Remove doc reference to GemFire 8.2

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/610


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #610: GEODE-3146 Remove doc reference to GemFire 8.2

[dschneider-pivotal]

Github user dschneider-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/610#discussion_r124667734
  
--- Diff: 
geode-docs/developing/partitioned_regions/set_join_redundancy_recovery.html.md.erb
 ---
@@ -19,23 +19,38 @@ See the License for the specific language governing 
permissions and
 limitations under the License.
 -->
 
-Configure whether and how redundancy is recovered in a partition region 
after a member joins.
+This section covers configuring whether and how redundancy is
+recovered in a partitioned region, after a member joins.
 
 
 Use the partition attribute `startup-recovery-delay` to specify member 
join redundancy recovery.
 
-| startup-recovery-delay partition attribute | Effect following a member 
join

   |
+| value of `startup-recovery-delay`| Effect following a member 
join

   |
 
||--|
-| -1 | No automatic recovery of 
redundancy after a new member comes online. If you use this and the default 
`recovery-delay` setting, you can only recover redundancy by kicking off 
rebalancing through a cacheserver or API call. |
-| long greater than or equal to **0**| Number of milliseconds to 
wait after a member joins before before recovering redundancy. The default is 0 
(zero), which causes immediate redundancy recovery whenever a new partitioned 
region host joins.   |
-
-Setting this to a value higher than the default of 0 allows multiple new 
members to join before redundancy recovery kicks in. With the multiple members 
present during recovery, the system will spread redundancy recovery among them. 
With no delay, if multiple members are started in close succession, the system 
may choose only the first member started for most or all of the redundancy 
recovery.
-
-**Note:**
-Satisfying redundancy is not the same as adding capacity. If redundancy is 
satisfied, new members do not take buckets until you invoke a rebalance.
+| -1 | No automatic recovery of 
redundancy after a new member comes online. With this value and the default 
`recovery-delay` setting, redundancy recovery is only achieved by a rebalance 
operation. |
+| long integer greater than or equal to **0** | Number of milliseconds to 
wait after a member joins before recovering redundancy. The default is 0 
(zero), which causes immediate redundancy recovery whenever a member that hosts 
the partitioned region joins. |
--- End diff --

I find "long integer greater" more confusing than the old "long greater". 
"long" and "integer" can both be used to indicate a specific Java ordinal type 
so having both of them is confusing.

In this context I think ">=0" would work. If you want to keep it verbose 
perhaps changing the old "long" to something more generic like "number" or 
"value" would be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Errored: jinmeiliao/geode#3 (refactor-day3 - 486d663)

[Travis CI]

Build Update for jinmeiliao/geode
-

Build: #3
Status: Errored

Duration: 14 minutes and 53 seconds
Commit: 486d663 (refactor-day3)
Author: Jinmei Liao
Message: wip

View the changeset: 
https://github.com/jinmeiliao/geode/compare/3aa990531554^...486d6634223f

View the full build log and details: 
https://travis-ci.org/jinmeiliao/geode/builds/248138023?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Fixed: apache/geode#3043 (develop - b0fafd3)

[Travis CI]

Build Update for apache/geode
-

Build: #3043
Status: Fixed

Duration: 22 minutes and 23 seconds
Commit: b0fafd3 (develop)
Author: Brian Rowe
Message: GEODE-3105: adding GetRegions handler for protobuf protocol

Added a handler which will catch incoming getRegion requests and will call into 
the cache's rootRegion and return the names of the region it finds.
Added unit test verifying hanlder behavior.
Added integration test verifying module correctness for getRegion.

This closes #607

Signed-off-by: Brian Rowe 
Signed-off-by: Hitesh Khamesra 

View the changeset: 
https://github.com/apache/geode/compare/61075610e7c0...b0fafd3da240

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/248117467?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Fixed: apache/geode#3042 (develop - 6107561)

[Travis CI]

Build Update for apache/geode
-

Build: #3042
Status: Fixed

Duration: 24 minutes and 45 seconds
Commit: 6107561 (develop)
Author: Jared Stewart
Message: Fix spotless failure

View the changeset: 
https://github.com/apache/geode/compare/1a8848974dd6...61075610e7c0

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/248112068?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[GitHub] geode pull request #611: GEODE-3145 Add new protocol to Geode JAR

[pivotal-amurmann]

GitHub user pivotal-amurmann opened a pull request:

https://github.com/apache/geode/pull/611

GEODE-3145 Add new protocol to Geode JAR

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
GEODE-3145

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-amurmann/geode feature/GEODE-3145

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/611.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #611


commit 3c19ea2a5ac3d5265b94aa55c453acadb198e340
Author: Alexander Murmann 
Date:   2017-06-28T20:59:43Z

GEODE-3145 Add new protocol to Geode JAR




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60507: GEODE-3145: add geode-protobuf code to the geode jar

[Alexander Murmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60507/#review179170
---


Ship it!




Ship It!

- Alexander Murmann


On June 28, 2017, 5:26 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60507/
> ---
> 
> (Updated June 28, 2017, 5:26 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-3145
> https://issues.apache.org/jira/browse/GEODE-3145
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This change ensures that the protobuf handling code we've been working on is 
> actually available to geode users.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 39bb54215 
> 
> 
> Diff: https://reviews.apache.org/r/60507/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

[GitHub] geode issue #610: GEODE-3146 Remove doc reference to GemFire 8.2

[karensmolermiller]

Github user karensmolermiller commented on the issue:

https://github.com/apache/geode/pull/610
  
Reviewers, please consider this PR despite the failed build.  From the 
detail, the failure was from a spotless failure in an unrelated code commit 
(copied here):

FAILURE: Build failed with an exception.
 * What went wrong:
 Execution failed for task ':geode-core:spotlessJavaCheck'.
 > Format violations were found. Run 'gradlew spotlessApply' to fix them.
  geode-
 
core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #607: GEODE-3105: adding GetRegion handler for protobuf p...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/607


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #610: GEODE-3146 Remove doc reference to GemFire 8.2

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/610

GEODE-3146 Remove doc reference to GemFire 8.2

@lgallinat @dschneider-pivotal @nreich @pivotal-eshu @agingade  
@joeymcallister @davebarnes97 plus any others who care, please review this PR.
 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3146

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/610.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #610


commit 9c49660313883a8150a710421c035d71ca3c90c9
Author: Karen Miller 
Date:   2017-06-28T18:28:01Z

GEODE-3146 Remove doc reference to GemFire 8.2




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60451: GEODE-2996: adding Put handler

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60451/#review179145
---



Remove the use of getLogger().  The rest looks okay to me.


geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
Lines 54 (patched)


New classes should use a Log4j Logger instead of the cache's LogWriter.  
Create a static Logger for this class and in other classes that are using 
cache.getLogger().



geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
Lines 56 (patched)


ditto & anyplace else getLogger() is being used.



geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
Lines 43 (patched)


create a Logger for the class


- Bruce Schuchardt


On June 26, 2017, 6:20 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60451/
> ---
> 
> (Updated June 26, 2017, 6:20 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2996
> https://issues.apache.org/jira/browse/GEODE-2996
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This is a continuation of the review Alex submitted this morning with the 
> following changes:
> 
> Addresses review feedback for GEODE-2996, mainly refactoring 
> getOpertionHandler to handle failures like the putOperationHandler
> Adding put operations to the RoundTripCacheConnectionJUnitTest, which is the 
> integration test for the protobuf module
> Removing service loading for protobuf operations and instead have the 
> ProtobufStreamProcessor populate its OperationHandlerRegistry
> Remove exception throwing from OperationHandler.process calls and remove 
> TypeEncodingException
> Fixing ProtobufOpsProcessor to handle responses for types other than get
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
>  7683e3bf3 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
>  8e3a33149 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
>  d426149e4 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  d7b5d4bd2 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
>  d76366298 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
>  d9c14752f 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
>  PRE-CREATION 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/exception/TypeEncodingException.java
>  f3145a774 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/exception/UnsupportedEncodingTypeException.java
>  c577e768a 
>   
> geode-protobuf/src/main/java/org/apache/geode/serialization/registry/exception/CodecNotRegisteredForTypeException.java
>  5c923a520 
>   geode-protobuf/src/main/proto/region_API.proto 52291c451 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> f0b0b417b 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  b9faca3c9 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessorJUnitTest.java
>  fc980aec9 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
>  daa5870ed 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60451/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests, whole module test, precheckin in progress.
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

[GitHub] geode issue #584: GEODE-2901: Adding integration tests of session replicatio...

[DivineEnder]

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/584
  
Single successful run on course when only running the Distributed tests in 
geode-assembly. Testing again with fully concourse run. 🤞 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60513/#review179156
---




geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
Lines 106 (patched)


Can we move this to doBeforeCompletion() as done in 
createAfterCompletionRunnable() which returns the runnable.


- anilkumar gingade


On June 28, 2017, 6:58 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60513/
> ---
> 
> (Updated June 28, 2017, 6:58 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
> Gallinat.
> 
> 
> Bugs: GEODE-3147
> https://issues.apache.org/jira/browse/GEODE-3147
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Set byte buffer for the threads that need to send reply to clients when 
> Max_Threads are set.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
>  b1b0cfb 
>   
> geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
>  51ef44a 
> 
> 
> Diff: https://reviews.apache.org/r/60513/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Review Request 60513: GEODE-3147 Set TLCommBuffer threadLocal for threads executing TXSynchronization

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60513/
---

Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
Gallinat.


Bugs: GEODE-3147
https://issues.apache.org/jira/browse/GEODE-3147


Repository: geode


Description
---

Set byte buffer for the threads that need to send reply to clients when 
Max_Threads are set.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/TXSynchronizationCommand.java
 b1b0cfb 
  
geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
 51ef44a 


Diff: https://reviews.apache.org/r/60513/diff/1/


Testing
---

precheckin.


Thanks,

Eric Shu

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60312/
---

(Updated June 28, 2017, 6:48 p.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen 
O'Sullivan.


Changes
---

Updated revied feedback


Repository: geode


Description
---

GEODE-2804 Cache InetAddress if configure host as ip string.

1. We keep configure host string in HostAddress class
2. We reuse InetsocketAddress if it is ipString.
3. Client has logic to retry thus we keep InetsocketAddress even if 
   it is not ip string.

GEODE-3017 IPv6 issue on windows. Above changes fixed this issue.

GEODE-2940 Now we don't validate configure host string on start. As
there is possibility that host may not available.

1. Earlier wan config were failing because of that. Now we just keep
those configure host string. And try this later.

Added unit tests for it.


Diffs (updated)
-

  geode-assembly/build.gradle 39bb542 
  geode-assembly/src/test/resources/expected_jars.txt 6260167 
  geode-core/build.gradle 7f34b4a 
  
geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java
 c1bfc93 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java
 53d401a 
  geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 
3ded54a 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java
 01c6157 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 a4b3a50 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java
 da295ab 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
 aff1938 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 bc3d708 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java
 6b54170 
  
geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java
 5ab1bed 
  
geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java
 1dc2fd1 
  
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
 92cfd96 
  geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java 
d4fdbd0 
  
geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java
 0efba01 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 88832ba 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java
 789d326 
  
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
 3cc3cfc 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java
 9f6c5fb 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java
 9d63050 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
 a31fa8d 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 
6a6e0c1 
  
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java
 f5a8fcf 
  
geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java
 d6d5d7c 
  
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java
 dbc2cc6 
  
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java
 6d75064 
  gradle/dependency-versions.properties 6a730a4 


Diff: https://reviews.apache.org/r/60312/diff/3/

Changes: https://reviews.apache.org/r/60312/diff/2-3/


Testing
---


Thanks,

Hitesh Khamesra

[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...

[DivineEnder]

Github user DivineEnder commented on a diff in the pull request:

https://github.com/apache/geode/pull/608#discussion_r124621529
  
--- Diff: 
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java
 ---
@@ -48,13 +49,13 @@
 public class LuceneQueriesPersistenceIntegrationTest extends 
LuceneIntegrationTest {
 
   @Rule
-  public DiskDirRule diskDirRule = new DiskDirRule();
+  public TemporaryFolder tempFolderRule = new TemporaryFolder(new 
File("."));
--- End diff --

Yeah. That's a good idea. Turns out there is an empty TemporaryFolder 
constructor, so I'll make that change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Broken: apache/geode#3036 (develop - 0254a60)

[Travis CI]

Build Update for apache/geode
-

Build: #3036
Status: Broken

Duration: 21 minutes and 41 seconds
Commit: 0254a60 (develop)
Author: Bruce Schuchardt
Message: GEODE-3052 Restarting 2 locators together causes potential locator 
split brain

The fix for this issue introduced different timing in GMSJoinLeave's
discovery process that affected one of the unit tests for that class,
causing periodic failures.  I've added an Awaitility.await() to stabilize
the test.

View the changeset: 
https://github.com/apache/geode/compare/d08a75bedb5f...0254a60f5939

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/248045117?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: Review Request 60507: GEODE-3145: add geode-protobuf code to the geode jar

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60507/#review179135
---


Ship it!




Ship It!

- Hitesh Khamesra


On June 28, 2017, 5:26 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60507/
> ---
> 
> (Updated June 28, 2017, 5:26 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-3145
> https://issues.apache.org/jira/browse/GEODE-3145
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This change ensures that the protobuf handling code we've been working on is 
> actually available to geode users.
> 
> 
> Diffs
> -
> 
>   geode-assembly/build.gradle 39bb54215 
> 
> 
> Diff: https://reviews.apache.org/r/60507/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

Re: Review Request 60447: GEODE-3132 EndBucketCreationMessage should not partitcipate in a transaction

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60447/#review179130
---


Ship it!




Ship It!

- Darrel Schneider


On June 26, 2017, 2:51 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60447/
> ---
> 
> (Updated June 26, 2017, 2:51 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
> Gallinat.
> 
> 
> Bugs: GEODE-3132
> https://issues.apache.org/jira/browse/GEODE-3132
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Overrides EndBucketCreationMessage.canParticipateInTransaction to return 
> false.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/EndBucketCreationMessage.java
>  355c3b5 
> 
> 
> Diff: https://reviews.apache.org/r/60447/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Build failed in Jenkins: Geode-nightly #880

[Apache Jenkins Server]

See 


Changes:

[jiliao] GEODE-2919: fix lucene security tests

[jiliao] GEODE-2919: revert: fix lucene security tests

[bschuchardt] GEODE-3072: Events do not get removed from the client queue for 
1.0

[hkhamesra] GEODE-3130: Refactoring AcceptorImpl

[hkhamesra] GEODE-2996: incorporating review feedback and adding integration 
test

--
[...truncated 104.37 KB...]
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-protobuf:jar
:geode-protobuf:javadoc
:geode-protobuf:javadocJar
:geode-protobuf:sourcesJar
:geode-protobuf:signArchives SKIPPED
:geode-protobuf:assemble
:geode-protobuf:extractIncludeTestProto
Download 
https://repo1.maven.org/maven2/org/powermock/powermock-api-mockito/1.7.0RC4/powermock-api-mockito-1.7.0RC4.pom
Download 
https://repo1.maven.org/maven2/org/powermock/powermock-api-mockito/1.7.0RC4/powermock-api-mockito-1.7.0RC4.jar
:geode-protobuf:extractTestProto
:geode-protobuf:generateTestProto UP-TO-DATE
:geode-protobuf:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-protobuf:processTestResources UP-TO-DATE
:geode-protobuf:testClasses
:geode-protobuf:checkMissedTests
:geode-protobuf:spotlessJavaCheck
:geode-protobuf:spotlessCheck
:geode-protobuf:test
:geode-protobuf:check
:geode-protobuf:build
:geode-protobuf:distributedTest
:geode-protobuf:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest

Re: want to encrypt default username/password in properties files or xml with default encrypted values.

[Jinmei Liao]

Hi, if you are using the Geode1.1, Pulse uses the integrated security from
your cluster now instead of having to resort to its own security. So the
admin/admin username/password is only used when your cluster is not
secured. If your cluster has a security manager, when logging into Pulse,
you should use whatever username/password that can be authenticated by that
security manager.

On Wed, Jun 28, 2017 at 1:27 AM, Dinesh Akhand  wrote:

> Hi team,
>
>
> Is there any way to encrypted default username/password  in
> pulse.properties:
>
> # JMX User Properties
> pulse.jmxUserName=admin
> pulse.jmxUserPassword=admin
>
> spring-security.xml:
>
> 
> 
> 
> 
> 
> 
>   authorities="ROLE_CLUSTER:READ,ROLE_DATA:READ"/>
> 
> 
> 
> I want to set default username/password to be in encrypted from in above
> file.
> Please suggest.
>
> Thanks,
> Dinesh Akhand
>
>
> -Original Message-
> From: Dinesh Akhand
> Sent: Tuesday, June 27, 2017 12:34 PM
> To: dev@geode.apache.org
> Subject: want to encrypt default username/password in properties files or
> xml with default encrypted values.
>
> Hi Team,
>
> Default user name /password are defined in spring-security.xml  and
> pulse.properties file.
> As below.
>
> ./geode/locator0/GemFire_anmuser/services/http/0.0.0.0_
> 20248_pulse/webapp/WEB-INF/spring-security.xml:
>  ./geode/locator0/GemFire_anmuser/services/http/0.0.0.0_
> 20248_pulse/webapp/WEB-INF/classes/pulse.properties:
> pulse.jmxUserPassword=admin
>
> What is the correct way to set the default encrypted username/password in
> these config files.
>
> Please suggest.
>
> Thanks,
> Dinesh Akhand
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
>
>


-- 
Cheers

Jinmei

[GitHub] geode-native issue #104: GEODE-3143 : close socket before deteting

[fdaniel7]

Github user fdaniel7 commented on the issue:

https://github.com/apache/geode-native/pull/104
  
When connect() is invoked from one of TcpConn::TcpConn the TcpConn object 
is not created since the exception is thrown from the constructor, so ~TcpConn 
will not be invoked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #104: Develop

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/104
  
Please open a JIRA and include it in your commit message.

GEODE-1234: blah blah


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #104: Develop

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/104
  
@fdaniel7  What is the GEODE ticket you are working on?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #104: Develop

[fdaniel7]

Github user fdaniel7 commented on the issue:

https://github.com/apache/geode-native/pull/104
  
There's no ticket for this as far as I know. I'm fixing this as part of 
reviewing geode client code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #104: Develop

[fdaniel7]

Github user fdaniel7 commented on the issue:

https://github.com/apache/geode-native/pull/104
  
Hi I'm still new with github, it is indeed a small change. On next 
contributions I'll pay more attention.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #104: Develop

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/104
  
It looks like your reverts were to undo changes to .gitignore. I'd suggest 
not building from within the source tree at all. If you do there is an ignore 
already for "build" that you can use as your build directory. CMake promotes 
building outside the source directory, you can generate your project files from 
any location.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-release-flaky #19

[Apache Jenkins Server]

See 


Changes:

[bschuchardt] GEODE-3072: Events do not get removed from the client queue for 
1.0

--
[...truncated 98.55 KB...]
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-models/1.5.10/swagger-models-1.5.10.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spi/2.6.1/springfox-spi-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-schema/2.6.1/springfox-schema-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-common/2.6.1/springfox-swagger-common-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spring-web/2.6.1/springfox-spring-web-2.6.1.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/classmate/1.3.1/classmate-1.3.1.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-core/1.2.0.RELEASE/spring-plugin-core-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin/1.2.0.RELEASE/spring-plugin-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-metadata/1.2.0.RELEASE/spring-plugin-metadata-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct/1.0.0.Final/mapstruct-1.0.0.Final.pom
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct-parent/1.0.0.Final/mapstruct-parent-1.0.0.Final.pom
Download 
https://repo1.maven.org/maven2/com/thoughtworks/paranamer/paranamer/2.8/paranamer-2.8.pom
Download 
https://repo1.maven.org/maven2/com/thoughtworks/paranamer/paranamer-parent/2.8/paranamer-parent-2.8.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-core/2.6.1/springfox-core-2.6.1.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-scala_2.10/2.8.6/jackson-module-scala_2.10-2.8.6.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger2/2.6.1/springfox-swagger2-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-ui/2.6.1/springfox-swagger-ui-2.6.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/hateoas/spring-hateoas/0.23.0.RELEASE/spring-hateoas-0.23.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/scala-lang/scala-library/2.10.6/scala-library-2.10.6.jar
Download 
https://repo1.maven.org/maven2/org/scala-lang/scala-reflect/2.10.6/scala-reflect-2.10.6.jar
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-paranamer/2.8.6/jackson-module-paranamer-2.8.6.jar
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-annotations/1.5.10/swagger-annotations-1.5.10.jar
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-models/1.5.10/swagger-models-1.5.10.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spi/2.6.1/springfox-spi-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-schema/2.6.1/springfox-schema-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-common/2.6.1/springfox-swagger-common-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spring-web/2.6.1/springfox-spring-web-2.6.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-core/1.2.0.RELEASE/spring-plugin-core-1.2.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-metadata/1.2.0.RELEASE/spring-plugin-metadata-1.2.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct/1.0.0.Final/mapstruct-1.0.0.Final.jar
Download 
https://repo1.maven.org/maven2/com/thoughtworks/paranamer/paranamer/2.8/paranamer-2.8.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-core/2.6.1/springfox-core-2.6.1.jar
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-web-api:processResources
:geode-web-api:classes
:geode-assembly:docs
:geode-assembly:gfshDepsJar
:geode-common:javadocJar
:geode-common:sourcesJar
:geode-common:signArchives SKIPPED
:geode-core:javadocJar
:geode-core:raJar
:geode-core:jcaJar
:geode-core:sourcesJar
:geode-core:signArchives SKIPPED
:geode-core:webJar
:geode-cq:jar
:geode-cq:javadoc
:geode-cq:javadocJar
:geode-cq:sourcesJar
:geode-cq:signArchives SKIPPED
:geode-json:javadocJar
:geode-json:sourcesJar
:geode-json:signArchives SKIPPED
:geode-lucene:jar
:geode-lucene:javadoc
:geode-lucene:javadocJar
:geode-lucene:sourcesJar
:geode-lucene:signArchives SKIPPED
:geode-old-client-support:jar
:geode-old-client-support:javadoc
:geode-old-client-support:javadocJar
:geode-old-client-support:sourcesJar
:geode-old-client-support:signArchives SKIPPED
:geode-pulse:javadoc
:geode-pulse:javadocJar
:geode-pulse:sourcesJar
:geode-pulse:war
:geode-pulse:signArchives SKIPPED
:geode-rebalancer:jar
:geode-rebalancer:javadoc

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

[ameybarve15]

GitHub user ameybarve15 opened a pull request:

https://github.com/apache/geode/pull/609

GEODE-2886 : sent IllegalStateException instead of throwing 
IllegalArgumentException inside WaitUntilFlushedFunction

1. sent IllegalStateException instead of throwing IllegalArgumentException 
inside WaitUntilFlushedFunction
2. Added dunit test with invalid indexName to get IllegalStateException
to the caller of the WaitUntilFlushedFunction.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ameybarve15/incubator-geode feature/GEODE-2886

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/609.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #609


commit f9c81c20fdb033ac5d90baae0f8a22aba5952a8b
Author: Amey Barve 
Date:   2017-06-23T10:48:33Z

GEODE-2886 : 1. sent IllegalStateException instead of throwing
IllegalArgumentException inside WaitUntilFlushedFunction.
2. Added dunit test with invalid indexName to get IllegalStateException
to the caller of the WaitUntilFlushedFunction.

commit 6057e5b66c301b0034861639e80889c210559a3c
Author: Amey Barve 
Date:   2017-06-28T08:52:39Z

Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/geode 
into feature/GEODE-2886




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-release #70

[Apache Jenkins Server]

See 


Changes:

[bschuchardt] GEODE-3072: Events do not get removed from the client queue for 
1.0

--
[...truncated 103.44 KB...]
:geode-common:check
:geode-common:build
:geode-common:distributedTest
:geode-common:integrationTest
:geode-core:assemble
:geode-core:checkMissedTests
:geode-core:spotlessJavaCheck
:geode-core:spotlessCheck
:geode-core:test
:geode-core:check
:geode-core:build
:geode-core:distributedTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.

RE: want to encrypt default username/password in properties files or xml with default encrypted values.

[Dinesh Akhand]

Hi team,


Is there any way to encrypted default username/password  in 
pulse.properties:

# JMX User Properties
pulse.jmxUserName=admin
pulse.jmxUserPassword=admin

spring-security.xml:










I want to set default username/password to be in encrypted from in above file.
Please suggest.

Thanks,
Dinesh Akhand


-Original Message-
From: Dinesh Akhand 
Sent: Tuesday, June 27, 2017 12:34 PM
To: dev@geode.apache.org
Subject: want to encrypt default username/password in properties files or xml 
with default encrypted values.

Hi Team,

Default user name /password are defined in spring-security.xml  and 
pulse.properties file.
As below.

./geode/locator0/GemFire_anmuser/services/http/0.0.0.0_20248_pulse/webapp/WEB-INF/spring-security.xml:
https://www.amdocs.com/about/email-disclaimer 

This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at https://www.amdocs.com/about/email-disclaimer 

[GitHub] geode-native pull request #104: Develop

[fdaniel7]

GitHub user fdaniel7 opened a pull request:

https://github.com/apache/geode-native/pull/104

Develop

Closing socket before deleting it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fdaniel7/geode-native develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #104


commit 5554c8a37cdcea874ba823e134f9b5bb586c3fba
Author: fdaniel7 
Date:   2017-06-28T07:33:14Z

Close socket before deleting it.

commit 25255eb3ab8afc161f26dd35ed96bd46b1805505
Author: fdaniel7 
Date:   2017-06-28T08:00:29Z

Revert "Close socket before deleting it."

This reverts commit 5554c8a37cdcea874ba823e134f9b5bb586c3fba.

commit 1896744d6f6d0fa25ca62b8b9b060c28398e1f02
Author: fdaniel7 
Date:   2017-06-28T08:04:24Z

Close ACE_SOCK_Stream before deleting it

GF_SAFE_DELETE will delete the ACE_SOCK_Stream but the socket will still
be open.

commit 0b31ccc12382ed4cd365c77f4dc89437abf3449b
Author: fdaniel7 
Date:   2017-06-28T08:08:29Z

Revert "Close ACE_SOCK_Stream before deleting it"

This reverts commit 1896744d6f6d0fa25ca62b8b9b060c28398e1f02.

commit 9ca823f889c53d5603d3e3ecf866a8fe085fc012
Author: fdaniel7 
Date:   2017-06-28T08:10:34Z

Close ACE_SOCK_Stream before deleting it

GF_SAFE_DELETE will delete the ACE_SOCK_Stream object but the socket
will still be open.

commit 4fe58136309737f2d3ca8a17b1c3e7c21a04a0a6
Author: fdaniel7 
Date:   2017-06-28T08:11:58Z

Revert "Close ACE_SOCK_Stream before deleting it"

This reverts commit 9ca823f889c53d5603d3e3ecf866a8fe085fc012.

commit 97c265eef15f17deb312cda051c20a62bbb4c30b
Author: fdaniel7 
Date:   2017-06-28T08:13:53Z

Close socket before deleting it.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---