date:20170713

Re: PING message is "Mischief Managed"

2017-07-13 Thread Vishal Rao

+1 to the WarGames reference.

On Fri, Jul 14, 2017 at 2:37 AM, Joey McAllister 
wrote:

> + * for "pong."
>
> Alternatively: "Wouldn't you prefer a nice game of chess?"
>
> *[Unicode character U+1F3D3]
>
> On Thu, Jul 13, 2017 at 1:54 PM Michael William Dodge 
> wrote:
>
> > +1 for "pong".
> >
> > > On 13 Jul, 2017, at 13:45, Kirk Lund  wrote:
> > >
> > > I'm really boring... I would've just had it reply "PONG" ;)
> > >
> > > On Thu, Jul 13, 2017 at 11:57 AM, John Blum  wrote:
> > >
> > >> Here you go...
> > >>
> > >> https://github.com/apache/geode/blob/rel/v1.1.1/geode-
> > >> core/src/main/java/org/apache/geode/management/internal/web/shell/
> > >> RestHttpOperationInvoker.java#L151-L204
> > >>
> > >>
> > >> On Thu, Jul 13, 2017 at 10:51 AM, John Blum  wrote:
> > >>
> > >>> Corrections below (apologies)...
> > >>>
> > >>> On Thu, Jul 13, 2017 at 10:44 AM, John Blum 
> wrote:
> > >>>
> >  Yeah, that was my doing. :)
> > 
> >  I thought it would be more fun to return a special message than the
> >  typical "Alive".  "Mischief Managed" comes from *Harry Potter*.
> > 
> >  This endpoint is of course benign/idempotent and was purely meant to
> > >> test
> >  the Management REST API's availability, or rather that the
> > >> Manage/Locator
> >  was still "online".
> > 
> >  Unlike JMX RMI, HTTP is stateless.  When a JMX RMI connection is
> made,
> > >> it
> >  is persistent and constantly "connected", where as each HTTP request
> > to
> > >> the
> >  Management REST API opens and closes a connection.  Therefore, you
> > have
> > >> no
> >  idea whether *Gfsh* is still connected to the Manager between
> requests
> >  unlike the JMX RMI connection.
> > 
> >  So, I run a background Thread that "polls" this endpoint every 500
> ms.
> >  It might even test the message; I don't remember.  Once the response
> > is
> >  anything other than 200 OK, then we know there is a problem and that
> > the
> >  connection was most likely terminated.
> > 
> >  Therefore, it keeps the behavior of the HTTP connection between
> *Gfsh*
> >  and the Manager similar to the JMX RMI connection by returning...
> > 
> >  No longer connected to 10.99.199.10[1099].
> > 
> >  gfsh>
> > 
> > 
> >  On Thu, Jul 13, 2017 at 10:36 AM, Jacob Barrett <
> jbarr...@pivotal.io>
> >  wrote:
> > 
> > > For the older crowed I would have rather it replied:
> > >
> > > Ah, I see you have the machine that goes 'ping!'.
> > >
> > > Sent from my iPhone
> > >
> > >> On Jul 13, 2017, at 10:23 AM, Jared Stewart 
> > > wrote:
> > >>
> > >> I'm young enough to recognize it as a Harry Potter reference, but
> I
> > > have no
> > >> idea what it's doing in our product code.
> > >>
> > >> - Jared
> > >>
> > >>> On Jul 13, 2017 10:14 AM, "Kirk Lund"  wrote:
> > >>>
> > >>> Anyone know why the response to a REST service PING returns
> > >> "Mischief
> > >>> Managed!?
> > >>>
> > >>> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD},
> > > value =
> > >>> "/ping")
> > >>> public ResponseEntity ping() {
> > >>> return new ResponseEntity("Mischief
> > >>> Managed!",
> > >>> HttpStatus.OK);
> > >>> }
> > >>>
> > >>> /Users/klund/dev/geode [949]$ git grep
> > > 'Mischief
> > >>> Managed'
> > >>> geode-core/src/main/java/org/apache/geode/management/
> > >>> internal/web/controllers/ShellCommandsController.java:
> > >>>  return new ResponseEntity("Mischief
> > >>> Managed!",
> > >>>
> > >
> > 
> > 
> > 
> >  --
> >  -John
> >  john.blum10101 (skype)
> > 
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> -John
> > >>> john.blum10101 (skype)
> > >>>
> > >>
> > >>
> > >>
> > >> --
> > >> -John
> > >> john.blum10101 (skype)
> > >>
> >
> >
>



-- 
"The World is a book, and those who do not travel read only a page." - St.
Augustine.

Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

2017-07-13 Thread Brian Rowe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/#review180500
---


Ship it!




Ship It!

- Brian Rowe


On July 13, 2017, 11:28 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60856/
> ---
> 
> (Updated July 13, 2017, 11:28 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> isCoordinator flag ensures that this process is becoming the
> coordinator thus other process should join this process. But
> when network parttion happens, we were not resetting this flag.
> 
> Now we reset isCoordinator flag when viewCreator thread shutdowns.
> 
> added unit test for it.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
>  2c56f5b 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  9591673 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  d8c12e2 
> 
> 
> Diff: https://reviews.apache.org/r/60856/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

2017-07-13 Thread Bruce Schuchardt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/#review180497
---



Fix the logging statement & you're good to go


geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
Lines 288 (patched)


remove debug logging or set to debug/trace level.  If you keep it you 
should use info("GMSLocator has coordinator flag {}", isCoordinator)


- Bruce Schuchardt


On July 13, 2017, 4:28 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60856/
> ---
> 
> (Updated July 13, 2017, 4:28 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> isCoordinator flag ensures that this process is becoming the
> coordinator thus other process should join this process. But
> when network parttion happens, we were not resetting this flag.
> 
> Now we reset isCoordinator flag when viewCreator thread shutdowns.
> 
> added unit test for it.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
>  2c56f5b 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  9591673 
>   
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
>  d8c12e2 
> 
> 
> Diff: https://reviews.apache.org/r/60856/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

2017-07-13 Thread Hitesh Khamesra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/
---

Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
O'Sullivan, and Udo Kohlmeyer.


Repository: geode


Description
---

isCoordinator flag ensures that this process is becoming the
coordinator thus other process should join this process. But
when network parttion happens, we were not resetting this flag.

Now we reset isCoordinator flag when viewCreator thread shutdowns.

added unit test for it.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
 2c56f5b 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 9591673 
  
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
 d8c12e2 


Diff: https://reviews.apache.org/r/60856/diff/1/


Testing
---


Thanks,

Hitesh Khamesra

[GitHub] geode pull request #634: Feature/geode 3175

2017-07-13 Thread bschuchardt

GitHub user bschuchardt opened a pull request:

https://github.com/apache/geode/pull/634

Feature/geode 3175

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ x] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3175

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/634.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #634


commit 66f2268230ef19be9ad9c6cc61eba9b9a0eb8542
Author: Bruce Schuchardt 
Date:   2017-07-13T17:49:02Z

GEODE-3175 backward-compatibility tests fail with bad classpath

Checking in changes on a feature branch that remove current-version
product classes from the classpaths of JVMs running old versions
of Geode.

commit f6ff39145d5ed83e5729f82ab1c6681c9ae14aa8
Author: Bruce Schuchardt 
Date:   2017-07-13T20:40:53Z

GEODE-3175 backward-compatibility tests fail with bad classpath

Attempt restart of a VM if it is unavailable.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #615 was SUCCESSFUL (with 1953 tests)

2017-07-13 Thread Spring CI


---
Spring Data GemFire > Nightly-ApacheGeode > #615 was successful.
---
Scheduled
1955 tests in total.

https://build.spring.io/browse/SGF-NAG-615/





--
This message is automatically generated by Atlassian Bamboo

No nulls

2017-07-13 Thread Kirk Lund

Please try to imagine a world of no nulls.

https://www.oracle.com/corporate/features/library-in-java-best-practices.html?evite=WWMK170414P4

[GitHub] geode pull request #633: GEODE-3170: Closed socket doesn't result in an infi...

2017-07-13 Thread galen-pivotal

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/633

GEODE-3170: Closed socket doesn't result in an infinite loop.

* Protobuf deserialization returning null is handled.
* IOException causes GenericProtocolServerConnection to close.
* Added a couple of JUnit tests.

Signed-off-by: Hitesh Khamesra 
Signed-off-by: Galen O'Sullivan 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/geode feature/GEODE-3170

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/633.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #633


commit c13797630d4a7825e8ab7c668a521fd3a3aeff77
Author: Galen O'Sullivan 
Date:   2017-07-13T18:26:09Z

GEODE-3170: Closed socket doesn't result in an infinite loop.

* Protobuf deserialization returning null is handled.
* IOException causes GenericProtocolServerConnection to close.
* Added a couple of JUnit tests.

Signed-off-by: Hitesh Khamesra 
Signed-off-by: Galen O'Sullivan 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #632: GEODE-3203: fixing protobuf build.gradle to respect...

2017-07-13 Thread WireBaron

GitHub user WireBaron opened a pull request:

https://github.com/apache/geode/pull/632

GEODE-3203: fixing protobuf build.gradle to respect buildRoot

Signed-off-by: Bruce Schuchardt 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/WireBaron/geode feature/GEODE-3203

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/632.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #632


commit 9322e6dfdf3d62e14d2c2f97a83ced558333883e
Author: Brian Rowe 
Date:   2017-07-13T21:41:43Z

GEODE-3203: fixing protobuf build.gradle to respect buildRoot

Signed-off-by: Bruce Schuchardt 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Proposal: Lucene indexing/searching for nested objects

2017-07-13 Thread Dan Smith

On Thu, Jul 13, 2017 at 11:26 AM, Jacob Barrett  wrote:

> Collections are really tough in Lucene because you have to flatten the
> document. I struggled against it for some time on a project a few years ago
> and ultimately decided to index the relationships separately and then merge
> the results.
>

Yeah, this is part of the motivation for providing the LuceneSerializer
API. We can provide a built in serializer that just flattens all nested
collections into a single field, but users could also write their own
implementation that converts the nested objects into separate lucene
documents and use some of query classes in org.apache.lucene.search.join if
they really need to.

It's not part of the goal here, but I think this LuceneSerializer API could
also make it easier to do spatial indexing, because users could create a
serializer that converts their gemfire object into a Lucene document with
GeoPointFields.

-Dan

Re: PING message is "Mischief Managed"

2017-07-13 Thread Joey McAllister

+ * for "pong."

Alternatively: "Wouldn't you prefer a nice game of chess?"

*[Unicode character U+1F3D3]

On Thu, Jul 13, 2017 at 1:54 PM Michael William Dodge 
wrote:

> +1 for "pong".
>
> > On 13 Jul, 2017, at 13:45, Kirk Lund  wrote:
> >
> > I'm really boring... I would've just had it reply "PONG" ;)
> >
> > On Thu, Jul 13, 2017 at 11:57 AM, John Blum  wrote:
> >
> >> Here you go...
> >>
> >> https://github.com/apache/geode/blob/rel/v1.1.1/geode-
> >> core/src/main/java/org/apache/geode/management/internal/web/shell/
> >> RestHttpOperationInvoker.java#L151-L204
> >>
> >>
> >> On Thu, Jul 13, 2017 at 10:51 AM, John Blum  wrote:
> >>
> >>> Corrections below (apologies)...
> >>>
> >>> On Thu, Jul 13, 2017 at 10:44 AM, John Blum  wrote:
> >>>
>  Yeah, that was my doing. :)
> 
>  I thought it would be more fun to return a special message than the
>  typical "Alive".  "Mischief Managed" comes from *Harry Potter*.
> 
>  This endpoint is of course benign/idempotent and was purely meant to
> >> test
>  the Management REST API's availability, or rather that the
> >> Manage/Locator
>  was still "online".
> 
>  Unlike JMX RMI, HTTP is stateless.  When a JMX RMI connection is made,
> >> it
>  is persistent and constantly "connected", where as each HTTP request
> to
> >> the
>  Management REST API opens and closes a connection.  Therefore, you
> have
> >> no
>  idea whether *Gfsh* is still connected to the Manager between requests
>  unlike the JMX RMI connection.
> 
>  So, I run a background Thread that "polls" this endpoint every 500 ms.
>  It might even test the message; I don't remember.  Once the response
> is
>  anything other than 200 OK, then we know there is a problem and that
> the
>  connection was most likely terminated.
> 
>  Therefore, it keeps the behavior of the HTTP connection between *Gfsh*
>  and the Manager similar to the JMX RMI connection by returning...
> 
>  No longer connected to 10.99.199.10[1099].
> 
>  gfsh>
> 
> 
>  On Thu, Jul 13, 2017 at 10:36 AM, Jacob Barrett 
>  wrote:
> 
> > For the older crowed I would have rather it replied:
> >
> > Ah, I see you have the machine that goes 'ping!'.
> >
> > Sent from my iPhone
> >
> >> On Jul 13, 2017, at 10:23 AM, Jared Stewart 
> > wrote:
> >>
> >> I'm young enough to recognize it as a Harry Potter reference, but I
> > have no
> >> idea what it's doing in our product code.
> >>
> >> - Jared
> >>
> >>> On Jul 13, 2017 10:14 AM, "Kirk Lund"  wrote:
> >>>
> >>> Anyone know why the response to a REST service PING returns
> >> "Mischief
> >>> Managed!?
> >>>
> >>> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD},
> > value =
> >>> "/ping")
> >>> public ResponseEntity ping() {
> >>> return new ResponseEntity("Mischief
> >>> Managed!",
> >>> HttpStatus.OK);
> >>> }
> >>>
> >>> /Users/klund/dev/geode [949]$ git grep
> > 'Mischief
> >>> Managed'
> >>> geode-core/src/main/java/org/apache/geode/management/
> >>> internal/web/controllers/ShellCommandsController.java:
> >>>  return new ResponseEntity("Mischief
> >>> Managed!",
> >>>
> >
> 
> 
> 
>  --
>  -John
>  john.blum10101 (skype)
> 
> >>>
> >>>
> >>>
> >>> --
> >>> -John
> >>> john.blum10101 (skype)
> >>>
> >>
> >>
> >>
> >> --
> >> -John
> >> john.blum10101 (skype)
> >>
>
>

RE: Stored procedures on Apache Geode.

2017-07-13 Thread marios390

Hi John,
Thank you so much for your advise. I will go through the links you provided
and get back to you if I have a question.

I really appreciate it!
Marios

From: John Blum [via Apache Geode (Incubating) Developers Forum] 
[ml+s70738n24325...@n6.nabble.com]
Sent: Thursday, July 13, 2017 11:33 PM
To: Marios Sofocleous/IT/CREDITSAFE
Subject: Re: Stored procedures on Apache Geode.

Hi Marios-

It seems you and your team could be / mostly are likely dealing with a
high-volume of sensitive information, but without knowing a lot about your
UC(s) or particular application requirements/SLAs, I would recommend
starting small, simple and scale based on need.

Geode is a highly concurrent and distributed system with strong consistency
guarantees.  Prematurely breaking the logic down into many individual
microservices early (especially for individual Stored Procedures... how
complex are these?) might unduly add complexity to your application and
system architecture.

So my advice is to really evaluate the need to create individual
microservices first (which usually involves a platform like [Pivotal's]
CloudFoundry on an IaaS (or private infra) to manage effectively) vs.
starting small and just converting the Stored Procs into Geode Functions.

Geode Function executions can be distributed across the cluster (similarly
to Map-Reduce, but far more robust) in a highly available and reliable
fashion.

You might want to also read up on Geode's Partitioned Regions [1] for
effectively managing (partitioning and distributing/arranging your data).

Hope this helps.

-John

[1]
http://gemfire90.docs.pivotal.io/geode/developing/partitioned_regions/chapter_overview.html

On Thu, Jul 13, 2017 at 1:09 PM, marios390 <[hidden email]
> wrote:

>
> 
> From: John Blum [via Apache Geode (Incubating) Developers Forum] [
> [hidden email]]
> Sent: Thursday, July 13, 2017 9:16 PM
> To: Marios Sofocleous/IT/CREDITSAFE
> Subject: Re: Stored procedures on Apache Geode.
>
> Right.
>
> You can also review the Apache Geode documentation on Function Execution
> [1].  And if you are a *Spring* user, you can use *Spring Data Geode's*
> convenient Function annotation support for both Function implementation as
> well as execution, here [2].
>
> NOTE: you will probably notice the link [2] refers to *Spring Data
> GemFire's* docs.  *Spring Data GemFire* and *Spring Data Geode* are
> virtually the same with no differences.  Eventually *Spring Data Geode*
> will have its own home with its own doc locations since it is finally
> becoming a top-level SD module [3].
>
> -j
>
> [1]
> http://geode.apache.org/docs/guide/11/developing/function_
> exec/chapter_overview.html
> j7nn2bxZOwcngUOelB5ZmyW7oHpBqfFPnKkha5eWJQ=http%3a%2f%
> 2fgeode%2eapache%2eorg%2fdocs%2fguide%2f11%2fdeveloping%
> 2ffunction%5fexec%2fchapter%5foverview%2ehtml>
> [2]
> http://docs.spring.io/spring-data-gemfire/docs/current/
> reference/html/#function-annotations.
> trustwave.com/?c=7422=j7nn2bxZOwcngUOelB5ZmyW7oHpBqf
> FPnPsrbJ3BIQ=http%3a%2f%2fdocs%2espring%2eio%2fspring-
> data-gemfire%2fdocs%2fcurrent%2freference%2fhtml%2f%23function-annotations
> >
> [3] 
>

Re: PING message is "Mischief Managed"

2017-07-13 Thread John Blum

Of course, *ping()* could always return... *"you've got to ask
yourself one question: "Do I feel lucky?" Well, do ya, punk?"*

;-)

https://en.wikiquote.org/wiki/Dirty_Harry


On Thu, Jul 13, 2017 at 1:54 PM, Michael William Dodge 
wrote:

> +1 for "pong".
>
> > On 13 Jul, 2017, at 13:45, Kirk Lund  wrote:
> >
> > I'm really boring... I would've just had it reply "PONG" ;)
> >
> > On Thu, Jul 13, 2017 at 11:57 AM, John Blum  wrote:
> >
> >> Here you go...
> >>
> >> https://github.com/apache/geode/blob/rel/v1.1.1/geode-
> >> core/src/main/java/org/apache/geode/management/internal/web/shell/
> >> RestHttpOperationInvoker.java#L151-L204
> >>
> >>
> >> On Thu, Jul 13, 2017 at 10:51 AM, John Blum  wrote:
> >>
> >>> Corrections below (apologies)...
> >>>
> >>> On Thu, Jul 13, 2017 at 10:44 AM, John Blum  wrote:
> >>>
>  Yeah, that was my doing. :)
> 
>  I thought it would be more fun to return a special message than the
>  typical "Alive".  "Mischief Managed" comes from *Harry Potter*.
> 
>  This endpoint is of course benign/idempotent and was purely meant to
> >> test
>  the Management REST API's availability, or rather that the
> >> Manage/Locator
>  was still "online".
> 
>  Unlike JMX RMI, HTTP is stateless.  When a JMX RMI connection is made,
> >> it
>  is persistent and constantly "connected", where as each HTTP request
> to
> >> the
>  Management REST API opens and closes a connection.  Therefore, you
> have
> >> no
>  idea whether *Gfsh* is still connected to the Manager between requests
>  unlike the JMX RMI connection.
> 
>  So, I run a background Thread that "polls" this endpoint every 500 ms.
>  It might even test the message; I don't remember.  Once the response
> is
>  anything other than 200 OK, then we know there is a problem and that
> the
>  connection was most likely terminated.
> 
>  Therefore, it keeps the behavior of the HTTP connection between *Gfsh*
>  and the Manager similar to the JMX RMI connection by returning...
> 
>  No longer connected to 10.99.199.10[1099].
> 
>  gfsh>
> 
> 
>  On Thu, Jul 13, 2017 at 10:36 AM, Jacob Barrett 
>  wrote:
> 
> > For the older crowed I would have rather it replied:
> >
> > Ah, I see you have the machine that goes 'ping!'.
> >
> > Sent from my iPhone
> >
> >> On Jul 13, 2017, at 10:23 AM, Jared Stewart 
> > wrote:
> >>
> >> I'm young enough to recognize it as a Harry Potter reference, but I
> > have no
> >> idea what it's doing in our product code.
> >>
> >> - Jared
> >>
> >>> On Jul 13, 2017 10:14 AM, "Kirk Lund"  wrote:
> >>>
> >>> Anyone know why the response to a REST service PING returns
> >> "Mischief
> >>> Managed!?
> >>>
> >>> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD},
> > value =
> >>> "/ping")
> >>> public ResponseEntity ping() {
> >>> return new ResponseEntity("Mischief
> >>> Managed!",
> >>> HttpStatus.OK);
> >>> }
> >>>
> >>> /Users/klund/dev/geode [949]$ git grep
> > 'Mischief
> >>> Managed'
> >>> geode-core/src/main/java/org/apache/geode/management/
> >>> internal/web/controllers/ShellCommandsController.java:
> >>>  return new ResponseEntity("Mischief
> >>> Managed!",
> >>>
> >
> 
> 
> 
>  --
>  -John
>  john.blum10101 (skype)
> 
> >>>
> >>>
> >>>
> >>> --
> >>> -John
> >>> john.blum10101 (skype)
> >>>
> >>
> >>
> >>
> >> --
> >> -John
> >> john.blum10101 (skype)
> >>
>
>


-- 
-John
john.blum10101 (skype)

Re: PING message is "Mischief Managed"

2017-07-13 Thread Michael William Dodge

+1 for "pong".

> On 13 Jul, 2017, at 13:45, Kirk Lund  wrote:
> 
> I'm really boring... I would've just had it reply "PONG" ;)
> 
> On Thu, Jul 13, 2017 at 11:57 AM, John Blum  wrote:
> 
>> Here you go...
>> 
>> https://github.com/apache/geode/blob/rel/v1.1.1/geode-
>> core/src/main/java/org/apache/geode/management/internal/web/shell/
>> RestHttpOperationInvoker.java#L151-L204
>> 
>> 
>> On Thu, Jul 13, 2017 at 10:51 AM, John Blum  wrote:
>> 
>>> Corrections below (apologies)...
>>> 
>>> On Thu, Jul 13, 2017 at 10:44 AM, John Blum  wrote:
>>> 
 Yeah, that was my doing. :)
 
 I thought it would be more fun to return a special message than the
 typical "Alive".  "Mischief Managed" comes from *Harry Potter*.
 
 This endpoint is of course benign/idempotent and was purely meant to
>> test
 the Management REST API's availability, or rather that the
>> Manage/Locator
 was still "online".
 
 Unlike JMX RMI, HTTP is stateless.  When a JMX RMI connection is made,
>> it
 is persistent and constantly "connected", where as each HTTP request to
>> the
 Management REST API opens and closes a connection.  Therefore, you have
>> no
 idea whether *Gfsh* is still connected to the Manager between requests
 unlike the JMX RMI connection.
 
 So, I run a background Thread that "polls" this endpoint every 500 ms.
 It might even test the message; I don't remember.  Once the response is
 anything other than 200 OK, then we know there is a problem and that the
 connection was most likely terminated.
 
 Therefore, it keeps the behavior of the HTTP connection between *Gfsh*
 and the Manager similar to the JMX RMI connection by returning...
 
 No longer connected to 10.99.199.10[1099].
 
 gfsh>
 
 
 On Thu, Jul 13, 2017 at 10:36 AM, Jacob Barrett 
 wrote:
 
> For the older crowed I would have rather it replied:
> 
> Ah, I see you have the machine that goes 'ping!'.
> 
> Sent from my iPhone
> 
>> On Jul 13, 2017, at 10:23 AM, Jared Stewart 
> wrote:
>> 
>> I'm young enough to recognize it as a Harry Potter reference, but I
> have no
>> idea what it's doing in our product code.
>> 
>> - Jared
>> 
>>> On Jul 13, 2017 10:14 AM, "Kirk Lund"  wrote:
>>> 
>>> Anyone know why the response to a REST service PING returns
>> "Mischief
>>> Managed!?
>>> 
>>> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD},
> value =
>>> "/ping")
>>> public ResponseEntity ping() {
>>> return new ResponseEntity("Mischief
>>> Managed!",
>>> HttpStatus.OK);
>>> }
>>> 
>>> /Users/klund/dev/geode [949]$ git grep
> 'Mischief
>>> Managed'
>>> geode-core/src/main/java/org/apache/geode/management/
>>> internal/web/controllers/ShellCommandsController.java:
>>>  return new ResponseEntity("Mischief
>>> Managed!",
>>> 
> 
 
 
 
 --
 -John
 john.blum10101 (skype)
 
>>> 
>>> 
>>> 
>>> --
>>> -John
>>> john.blum10101 (skype)
>>> 
>> 
>> 
>> 
>> --
>> -John
>> john.blum10101 (skype)
>>

Re: PING message is "Mischief Managed"

2017-07-13 Thread John Blum

LOL, I thought about that too.

Actually, most of my ping service endpoints I write now (whether HTTP or
other... TCP/IP) just respond with "PONG", as you said.

I don't think that is boring at all.

On Thu, Jul 13, 2017 at 1:45 PM, Kirk Lund  wrote:

> I'm really boring... I would've just had it reply "PONG" ;)
>
> On Thu, Jul 13, 2017 at 11:57 AM, John Blum  wrote:
>
> > Here you go...
> >
> > https://github.com/apache/geode/blob/rel/v1.1.1/geode-
> > core/src/main/java/org/apache/geode/management/internal/web/shell/
> > RestHttpOperationInvoker.java#L151-L204
> >
> >
> > On Thu, Jul 13, 2017 at 10:51 AM, John Blum  wrote:
> >
> > > Corrections below (apologies)...
> > >
> > > On Thu, Jul 13, 2017 at 10:44 AM, John Blum  wrote:
> > >
> > >> Yeah, that was my doing. :)
> > >>
> > >> I thought it would be more fun to return a special message than the
> > >> typical "Alive".  "Mischief Managed" comes from *Harry Potter*.
> > >>
> > >> This endpoint is of course benign/idempotent and was purely meant to
> > test
> > >> the Management REST API's availability, or rather that the
> > Manage/Locator
> > >> was still "online".
> > >>
> > >> Unlike JMX RMI, HTTP is stateless.  When a JMX RMI connection is made,
> > it
> > >> is persistent and constantly "connected", where as each HTTP request
> to
> > the
> > >> Management REST API opens and closes a connection.  Therefore, you
> have
> > no
> > >> idea whether *Gfsh* is still connected to the Manager between requests
> > >> unlike the JMX RMI connection.
> > >>
> > >> So, I run a background Thread that "polls" this endpoint every 500 ms.
> > >> It might even test the message; I don't remember.  Once the response
> is
> > >> anything other than 200 OK, then we know there is a problem and that
> the
> > >> connection was most likely terminated.
> > >>
> > >> Therefore, it keeps the behavior of the HTTP connection between *Gfsh*
> > >> and the Manager similar to the JMX RMI connection by returning...
> > >>
> > >> No longer connected to 10.99.199.10[1099].
> > >>
> > >> gfsh>
> > >>
> > >>
> > >> On Thu, Jul 13, 2017 at 10:36 AM, Jacob Barrett 
> > >> wrote:
> > >>
> > >>> For the older crowed I would have rather it replied:
> > >>>
> > >>> Ah, I see you have the machine that goes 'ping!'.
> > >>>
> > >>> Sent from my iPhone
> > >>>
> > >>> > On Jul 13, 2017, at 10:23 AM, Jared Stewart 
> > >>> wrote:
> > >>> >
> > >>> > I'm young enough to recognize it as a Harry Potter reference, but I
> > >>> have no
> > >>> > idea what it's doing in our product code.
> > >>> >
> > >>> > - Jared
> > >>> >
> > >>> >> On Jul 13, 2017 10:14 AM, "Kirk Lund"  wrote:
> > >>> >>
> > >>> >> Anyone know why the response to a REST service PING returns
> > "Mischief
> > >>> >> Managed!?
> > >>> >>
> > >>> >> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD},
> > >>> value =
> > >>> >> "/ping")
> > >>> >> public ResponseEntity ping() {
> > >>> >>  return new ResponseEntity("Mischief
> > >>> >> Managed!",
> > >>> >>  HttpStatus.OK);
> > >>> >> }
> > >>> >>
> > >>> >> /Users/klund/dev/geode [949]$ git grep
> > >>> 'Mischief
> > >>> >> Managed'
> > >>> >> geode-core/src/main/java/org/apache/geode/management/
> > >>> >> internal/web/controllers/ShellCommandsController.java:
> > >>> >>   return new ResponseEntity("Mischief
> > >>> >> Managed!",
> > >>> >>
> > >>>
> > >>
> > >>
> > >>
> > >> --
> > >> -John
> > >> john.blum10101 (skype)
> > >>
> > >
> > >
> > >
> > > --
> > > -John
> > > john.blum10101 (skype)
> > >
> >
> >
> >
> > --
> > -John
> > john.blum10101 (skype)
> >
>



-- 
-John
john.blum10101 (skype)

Re: PING message is "Mischief Managed"

2017-07-13 Thread Kirk Lund

I'm really boring... I would've just had it reply "PONG" ;)

On Thu, Jul 13, 2017 at 11:57 AM, John Blum  wrote:

> Here you go...
>
> https://github.com/apache/geode/blob/rel/v1.1.1/geode-
> core/src/main/java/org/apache/geode/management/internal/web/shell/
> RestHttpOperationInvoker.java#L151-L204
>
>
> On Thu, Jul 13, 2017 at 10:51 AM, John Blum  wrote:
>
> > Corrections below (apologies)...
> >
> > On Thu, Jul 13, 2017 at 10:44 AM, John Blum  wrote:
> >
> >> Yeah, that was my doing. :)
> >>
> >> I thought it would be more fun to return a special message than the
> >> typical "Alive".  "Mischief Managed" comes from *Harry Potter*.
> >>
> >> This endpoint is of course benign/idempotent and was purely meant to
> test
> >> the Management REST API's availability, or rather that the
> Manage/Locator
> >> was still "online".
> >>
> >> Unlike JMX RMI, HTTP is stateless.  When a JMX RMI connection is made,
> it
> >> is persistent and constantly "connected", where as each HTTP request to
> the
> >> Management REST API opens and closes a connection.  Therefore, you have
> no
> >> idea whether *Gfsh* is still connected to the Manager between requests
> >> unlike the JMX RMI connection.
> >>
> >> So, I run a background Thread that "polls" this endpoint every 500 ms.
> >> It might even test the message; I don't remember.  Once the response is
> >> anything other than 200 OK, then we know there is a problem and that the
> >> connection was most likely terminated.
> >>
> >> Therefore, it keeps the behavior of the HTTP connection between *Gfsh*
> >> and the Manager similar to the JMX RMI connection by returning...
> >>
> >> No longer connected to 10.99.199.10[1099].
> >>
> >> gfsh>
> >>
> >>
> >> On Thu, Jul 13, 2017 at 10:36 AM, Jacob Barrett 
> >> wrote:
> >>
> >>> For the older crowed I would have rather it replied:
> >>>
> >>> Ah, I see you have the machine that goes 'ping!'.
> >>>
> >>> Sent from my iPhone
> >>>
> >>> > On Jul 13, 2017, at 10:23 AM, Jared Stewart 
> >>> wrote:
> >>> >
> >>> > I'm young enough to recognize it as a Harry Potter reference, but I
> >>> have no
> >>> > idea what it's doing in our product code.
> >>> >
> >>> > - Jared
> >>> >
> >>> >> On Jul 13, 2017 10:14 AM, "Kirk Lund"  wrote:
> >>> >>
> >>> >> Anyone know why the response to a REST service PING returns
> "Mischief
> >>> >> Managed!?
> >>> >>
> >>> >> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD},
> >>> value =
> >>> >> "/ping")
> >>> >> public ResponseEntity ping() {
> >>> >>  return new ResponseEntity("Mischief
> >>> >> Managed!",
> >>> >>  HttpStatus.OK);
> >>> >> }
> >>> >>
> >>> >> /Users/klund/dev/geode [949]$ git grep
> >>> 'Mischief
> >>> >> Managed'
> >>> >> geode-core/src/main/java/org/apache/geode/management/
> >>> >> internal/web/controllers/ShellCommandsController.java:
> >>> >>   return new ResponseEntity("Mischief
> >>> >> Managed!",
> >>> >>
> >>>
> >>
> >>
> >>
> >> --
> >> -John
> >> john.blum10101 (skype)
> >>
> >
> >
> >
> > --
> > -John
> > john.blum10101 (skype)
> >
>
>
>
> --
> -John
> john.blum10101 (skype)
>

[GitHub] geode-examples pull request #10: Feature/geode 3202

2017-07-13 Thread dihardman

GitHub user dihardman opened a pull request:

https://github.com/apache/geode-examples/pull/10

Feature/geode 3202

Here is a new simple example that uses Lucene indexes and searching. Please 
review and comment.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dihardman/geode-examples feature/GEODE-3202

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-examples/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10


commit 5167d9a51642dc4270c1485257fe1ccf807ceb80
Author: Diane Hardman 
Date:   2017-07-03T22:04:46Z

First commit of simple Lucene example to be added to geode-examples.
More features and the Readme.md needs to be updated.

commit 8a062c500468aa41a17394b40876359469d32128
Author: Diane Hardman 
Date:   2017-07-04T00:26:24Z

Updated the README.md file to describe the changes and operations for 
Lucene indexing and text searches.

commit 13312d8b850eaefbe59aef16aad742f19e17ba18
Author: Diane Hardman 
Date:   2017-07-04T00:57:58Z

Added firstName to Lucene simpleIndex in start.gfsh script and added a 
Lucene compound search for first and last name in the README.md file.

commit d61ebaca8ca00b546e250a8c200830c92e5aa49c
Author: Diane Hardman 
Date:   2017-07-13T20:03:47Z

Included changes to match Karen's query example and added the analyzerIndex.

commit 1269d07994fb4273cf8c3ac8227837f1d80636d9
Author: Diane Hardman 
Date:   2017-07-13T20:07:16Z

Merge branch 'develop' of https://github.com/apache/geode-examples into 
develop

commit 3304f60206f11e46d48d7d17340d7544498b5d86
Author: Diane Hardman 
Date:   2017-07-13T20:26:24Z

GEODE-3202 Adding new lucene example.

commit 0cc316a6b78d2352f1666735e77427274e373458
Author: Diane Hardman 
Date:   2017-07-13T20:32:16Z

GEODE_3202 Removed unused import of SoundEx library




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Stored procedures on Apache Geode.

2017-07-13 Thread marios390

From: John Blum [via Apache Geode (Incubating) Developers Forum] 
[ml+s70738n24312...@n6.nabble.com]
Sent: Thursday, July 13, 2017 9:16 PM
To: Marios Sofocleous/IT/CREDITSAFE
Subject: Re: Stored procedures on Apache Geode.

Right.

You can also review the Apache Geode documentation on Function Execution
[1].  And if you are a *Spring* user, you can use *Spring Data Geode's*
convenient Function annotation support for both Function implementation as
well as execution, here [2].

NOTE: you will probably notice the link [2] refers to *Spring Data
GemFire's* docs.  *Spring Data GemFire* and *Spring Data Geode* are
virtually the same with no differences.  Eventually *Spring Data Geode*
will have its own home with its own doc locations since it is finally
becoming a top-level SD module [3].

-j

[1]
http://geode.apache.org/docs/guide/11/developing/function_exec/chapter_overview.html
[2]
http://docs.spring.io/spring-data-gemfire/docs/current/reference/html/#function-annotations
[3] 
http://projects.spring.io/spring-data/

On Thu, Jul 13, 2017 at 6:04 AM, Anthony Baker <[hidden 
email]> wrote:

> A geode Function is conceptually similar to a stored proc but the
> implementation is different. It's a java class that would use geode apis to
> execute logic within the cluster.
>
> Anthony
>
> > On Jul 12, 2017, at 11:13 PM, marios390  com> wrote:
> >
> > Hi,
> >
> > I noticed that Apache Geode supports stored procedures as functions
> running
> > on nodes.
> > Could you please elaborate on that since I am confused a little a bit.
> > Can I run for example Oracle SP directly on cache servers (nodes) or do I
> > have to transform them somehow into microservices ( i.e spring boot)
> which
> > expose functions on nodes.
> >
> >
> >
> > --
> > View this message in context: http://apache-geode-
> incubating-developers-forum.70738.x6.nabble.com/Stored-
> procedures-on-Apache-Geode-tp24279.html
> > Sent from the Apache Geode (Incubating) Developers Forum mailing list
> archive at 
> Nabble.com.
>

Hi John

I really appreciate it for getting back to me. I will check it out.
We are basically having a bunch of stored procedures and thinking to create as 
many microservices as the SPs in order to load them in geode. I know that this 
makes nosense. How  would you suggest resolving this?

--
-John
john.blum10101 (skype)

If you reply to this email, your message will be added to the discussion below:
http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/Stored-procedures-on-Apache-Geode-tp24279p24312.html
To unsubscribe from Stored procedures on Apache Geode., click 
here.
NAML
Notes:
Terms and Conditions: 'All quotes, offers, contracts and agreements verbal or 
written are subject to our Standard Terms and Conditions as displayed on our 
website www.creditsafeuk.com and detailed in the Order Confirmation, quotation 
or invoice. Nothing in this correspondence shall be taken to vary our standard 
Terms and Conditions unless

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

2017-07-13 Thread pivotal-jbarrett

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/107#discussion_r127312259
  
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,12 @@ int32_t StructSetImpl::getFieldIndex(const char* 
fieldname) {
   }
 }
 
-const char* StructSetImpl::getFieldName(int32_t index) {
-  for (std::map::iterator iter =
-   m_fieldNameIndexMap.begin();
-   iter != m_fieldNameIndexMap.end(); ++iter) {
-if (iter->second == index) return iter->first.c_str();
+const std::string& StructSetImpl::getFieldName(int32_t index) {
+  for (const auto& iter : m_fieldNameIndexMap) {
+if (iter.second == index) return (iter.first);
   }
-  return nullptr;
+
+  throw OutOfRangeException("Struct: fieldName not found.");
--- End diff --

I am more keen myself on using `std::exception`s rather than our own.

Thoughts?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PING message is "Mischief Managed"

2017-07-13 Thread John Blum

Here you go...

https://github.com/apache/geode/blob/rel/v1.1.1/geode-core/src/main/java/org/apache/geode/management/internal/web/shell/RestHttpOperationInvoker.java#L151-L204


On Thu, Jul 13, 2017 at 10:51 AM, John Blum  wrote:

> Corrections below (apologies)...
>
> On Thu, Jul 13, 2017 at 10:44 AM, John Blum  wrote:
>
>> Yeah, that was my doing. :)
>>
>> I thought it would be more fun to return a special message than the
>> typical "Alive".  "Mischief Managed" comes from *Harry Potter*.
>>
>> This endpoint is of course benign/idempotent and was purely meant to test
>> the Management REST API's availability, or rather that the Manage/Locator
>> was still "online".
>>
>> Unlike JMX RMI, HTTP is stateless.  When a JMX RMI connection is made, it
>> is persistent and constantly "connected", where as each HTTP request to the
>> Management REST API opens and closes a connection.  Therefore, you have no
>> idea whether *Gfsh* is still connected to the Manager between requests
>> unlike the JMX RMI connection.
>>
>> So, I run a background Thread that "polls" this endpoint every 500 ms.
>> It might even test the message; I don't remember.  Once the response is
>> anything other than 200 OK, then we know there is a problem and that the
>> connection was most likely terminated.
>>
>> Therefore, it keeps the behavior of the HTTP connection between *Gfsh*
>> and the Manager similar to the JMX RMI connection by returning...
>>
>> No longer connected to 10.99.199.10[1099].
>>
>> gfsh>
>>
>>
>> On Thu, Jul 13, 2017 at 10:36 AM, Jacob Barrett 
>> wrote:
>>
>>> For the older crowed I would have rather it replied:
>>>
>>> Ah, I see you have the machine that goes 'ping!'.
>>>
>>> Sent from my iPhone
>>>
>>> > On Jul 13, 2017, at 10:23 AM, Jared Stewart 
>>> wrote:
>>> >
>>> > I'm young enough to recognize it as a Harry Potter reference, but I
>>> have no
>>> > idea what it's doing in our product code.
>>> >
>>> > - Jared
>>> >
>>> >> On Jul 13, 2017 10:14 AM, "Kirk Lund"  wrote:
>>> >>
>>> >> Anyone know why the response to a REST service PING returns "Mischief
>>> >> Managed!?
>>> >>
>>> >> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD},
>>> value =
>>> >> "/ping")
>>> >> public ResponseEntity ping() {
>>> >>  return new ResponseEntity("Mischief
>>> >> Managed!",
>>> >>  HttpStatus.OK);
>>> >> }
>>> >>
>>> >> /Users/klund/dev/geode [949]$ git grep
>>> 'Mischief
>>> >> Managed'
>>> >> geode-core/src/main/java/org/apache/geode/management/
>>> >> internal/web/controllers/ShellCommandsController.java:
>>> >>   return new ResponseEntity("Mischief
>>> >> Managed!",
>>> >>
>>>
>>
>>
>>
>> --
>> -John
>> john.blum10101 (skype)
>>
>
>
>
> --
> -John
> john.blum10101 (skype)
>



-- 
-John
john.blum10101 (skype)

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

2017-07-13 Thread WireBaron

Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/630#discussion_r127299289
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
 ---
@@ -14,6 +14,14 @@
  */
 package org.apache.geode.protocol.protobuf.operations;
 
+import static org.mockito.Mockito.any;
--- End diff --

spotlessApply doesn't seem to care about the import order, however IntelliJ 
will reorder according the style guide every time you run "optimize imports".  
Patrick was flagging every pull request with the outdated order for a while.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Proposal: Lucene indexing/searching for nested objects

2017-07-13 Thread Jacob Barrett

Collections are really tough in Lucene because you have to flatten the 
document. I struggled against it for some time on a project a few years ago and 
ultimately decided to index the relationships separately and then merge the 
results.


Sent from my iPhone

> On Jul 13, 2017, at 11:13 AM, Dan Smith  wrote:
> 
> +1 Looks good. I think we should consider adding support for collections as
> well, but that doesn't have to be in the first cut.
> 
> -Dan
> 
>> On Wed, Jul 12, 2017 at 10:37 AM, Diane Hardman  wrote:
>> 
>> The Geode 1.2.0 release includes Lucene text search fully integrated and
>> tested (no longer experimental). We are now proposing enhancements to
>> improve Lucene usability in Geode.
>> 
>> Some Geode users create data models that include nested and complex
>> objects. The current Geode Lucene integration supports indexing and
>> querying only the top-level fields in the data object. The objective of
>> this proposal is to support indexing and querying an arbitrary depth of
>> nested objects.
>> 
>> 
>> Please review the proposal in the following wiki page and give us your
>> feedback.
>> 
>> https://cwiki.apache.org/confluence/display/GEODE/
>> Lucene+Text+Search+on+Nested+Object
>>

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

2017-07-13 Thread kohlmu-pivotal

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/630#discussion_r127294137
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 ---
@@ -278,6 +278,31 @@ public void 
useSSL_testNewProtocolHeaderLeadsToNewProtocolServerConnection() thr
 testNewProtocolHeaderLeadsToNewProtocolServerConnection();
   }
 
+  @Test
+  public void testNewProtocolGetRegionCallSucceeds() throws Exception {
+System.setProperty("geode.feature-protobuf-protocol", "true");
+
+Socket socket = new Socket("localhost", cacheServerPort);
+Awaitility.await().atMost(5, 
TimeUnit.SECONDS).until(socket::isConnected);
+OutputStream outputStream = socket.getOutputStream();
+outputStream.write(110);
+
+
+ProtobufProtocolSerializer protobufProtocolSerializer = new 
ProtobufProtocolSerializer();
+ClientProtocol.Message getRegionMessage =
+MessageUtil.makeGetRegionRequestMessage(TEST_REGION, 
ClientProtocol.MessageHeader.newBuilder().build());
+protobufProtocolSerializer.serialize(getRegionMessage, outputStream);
+
+ClientProtocol.Message message =
+protobufProtocolSerializer.deserialize(socket.getInputStream());
+assertEquals(ClientProtocol.Message.MessageTypeCase.RESPONSE, 
message.getMessageTypeCase());
+ClientProtocol.Response response = message.getResponse();
+assertEquals(ClientProtocol.Response.ResponseAPICase.GETREGIONRESPONSE,
+response.getResponseAPICase());
+response.getGetRegionResponse();
+//TODO add some assertions for Region data
--- End diff --

Resolved


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

2017-07-13 Thread kohlmu-pivotal

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/630#discussion_r127294096
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
 ---
@@ -133,21 +134,38 @@
 
   /**
* This will return the object encoded in a protobuf EncodedValue
-   *
* @param serializationService - object which knows how to encode 
objects for the protobuf
-   *protocol {@link ProtobufSerializationService}
+   * protocol {@link ProtobufSerializationService}
* @param encodedValue - The value to be decoded
* @return the object encoded in the passed encodedValue
* @throws UnsupportedEncodingTypeException - There isn't a 
SerializationType matching the
-   * encodedValues type
+   * encodedValues type
* @throws CodecNotRegisteredForTypeException - There isn't a protobuf 
codec for the
-   * SerializationType matching the encodedValues type
+   * SerializationType matching the encodedValues type
*/
   public static Object decodeValue(SerializationService 
serializationService,
-  BasicTypes.EncodedValue encodedValue)
+   BasicTypes.EncodedValue encodedValue)
   throws UnsupportedEncodingTypeException, 
CodecNotRegisteredForTypeException {
 BasicTypes.EncodingType encoding = encodedValue.getEncodingType();
 byte[] bytes = encodedValue.getValue().toByteArray();
 return serializationService.decode(encoding, bytes);
   }
+
+  public static BasicTypes.Region createRegionMessageFromRegion(Region 
region) {
+RegionAttributes regionAttributes = region.getAttributes();
+BasicTypes.Region.Builder protoRegionBuilder = 
BasicTypes.Region.newBuilder();
+
+protoRegionBuilder.setName(region.getName());
+protoRegionBuilder.setSize(region.size());
+
+
protoRegionBuilder.setPersisted(regionAttributes.getDataPolicy().withPersistence());
+
protoRegionBuilder.setKeyConstraint(regionAttributes.getKeyConstraint() == null 
? ""
--- End diff --

Correct. Amended according for both Key and Value constraint


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Geode release - v1.2.0 RC2

2017-07-13 Thread Nabarun Nag

+1 based on following sanity tests

- started gfsh , created locator, server , region and executed few 
basic queries.
- Using the libs in a project , created a server , filled it with 
objects , executed DISTINCT, ORDER BY queries.
- Executed "./gradlew clean build -Dskip.test= true" on the source 
files.

Regards
Nabarun Nag
> On Jul 12, 2017, at 7:58 AM, Anthony Baker  wrote:
> 
> This is the second release candidate for Apache Geode, version 1.2.0.
> Thanks to all the community members for their contributions to this
> release!  This release candidate fixes a number of backwards compatibility
> and rolling upgrade issues found in RC1.
> 
> *** Please download, test and vote by Saturday, July 15, 0800 hrs
> US Pacific. ***
> 
> It fixes the following issues:
> 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12339257
> 
> Note that we are voting upon the source tags:  rel/v1.2.0.RC2
> 
> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=964f2749065ce9c6898fd27983b43f1bd9fc77d0
> 
> https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;a=commit;h=7f93d95ad06a6f2afee54312585f48435fff11e8
> 
> Commit ID:
>  7f93d95ad06a6f2afee54312585f48435fff11e8 (geode)
>  7f93d95ad06a6f2afee54312585f48435fff11e8 (geode-examples)
> 
> Source and binary files:
>  https://dist.apache.org/repos/dist/dev/geode/1.2.0.RC2
> 
> Maven staging repo:
>  https://repository.apache.org/content/repositories/orgapachegeode-1020
> 
> Geode's KEYS file containing PGP keys we use to sign the release:
> 
> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_plain;f=KEYS;hb=HEAD
> 
> pub  4096R/C72CFB64 2015-10-01
>  Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64
> 
> Anthony

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

2017-07-13 Thread WireBaron

Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/630#discussion_r127292855
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
 ---
@@ -14,6 +14,14 @@
  */
 package org.apache.geode.protocol.protobuf.operations;
 
+import static org.mockito.Mockito.any;
--- End diff --

Have you updated your IntelliJ style guide file with the June 13 version?  
They've modified the order of imports somewhat.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #895

2017-07-13 Thread Apache Jenkins Server

See 


Changes:

[boglesby] GEODE-3181: Added wan backward compatibility unit tests

[eshu] GEODE-3178: Fix a flaky JTA test by adding retry.

[dschneider] GEODE-3194: cleanup disk store on failed initial recovery

[upthewaterspout] GEODE-3179: Changed extract directory of the Tomcat module

[nnag] GEODE-1988: Increased the readTimeout

[nnag] GEODE-3128: Changed the batch size to 1000 when creating AEQFactory

[nnag] GEODE-3131: Replaced Thread.sleep

[ukohlmeyer] GEODE-2997: New flow getAll/putAll. This now closes #629

--
[...truncated 182.62 KB...]
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-protobuf:assemble
:geode-protobuf:extractIncludeTestProto
:geode-protobuf:extractTestProto UP-TO-DATE
:geode-protobuf:generateTestProto UP-TO-DATE
:geode-protobuf:compileTestJavaNote: Some input files use unchecked or unsafe 
operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-protobuf:processTestResources
:geode-protobuf:testClasses
:geode-protobuf:checkMissedTests
:geode-protobuf:spotlessJavaCheck
:geode-protobuf:spotlessCheck
:geode-protobuf:test
:geode-protobuf:check
:geode-protobuf:build
:geode-protobuf:distributedTest
:geode-protobuf:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:checkMissedTests
:geode-wan:spotlessJavaCheck
:geode-wan:spotlessCheck
:geode-wan:test
:geode-wan:check
:geode-wan:build
:geode-wan:distributedTest
:geode-wan:integrationTest
:geode-web:assemble
:geode-web:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note:

Re: Proposal: Lucene indexing/searching for nested objects

2017-07-13 Thread Dan Smith

+1 Looks good. I think we should consider adding support for collections as
well, but that doesn't have to be in the first cut.

-Dan

On Wed, Jul 12, 2017 at 10:37 AM, Diane Hardman  wrote:

> The Geode 1.2.0 release includes Lucene text search fully integrated and
> tested (no longer experimental). We are now proposing enhancements to
> improve Lucene usability in Geode.
>
> Some Geode users create data models that include nested and complex
> objects. The current Geode Lucene integration supports indexing and
> querying only the top-level fields in the data object. The objective of
> this proposal is to support indexing and querying an arbitrary depth of
> nested objects.
>
>
> Please review the proposal in the following wiki page and give us your
> feedback.
>
> https://cwiki.apache.org/confluence/display/GEODE/
> Lucene+Text+Search+on+Nested+Object
>

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

2017-07-13 Thread WireBaron

Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/630#discussion_r127290974
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 ---
@@ -278,6 +278,31 @@ public void 
useSSL_testNewProtocolHeaderLeadsToNewProtocolServerConnection() thr
 testNewProtocolHeaderLeadsToNewProtocolServerConnection();
   }
 
+  @Test
+  public void testNewProtocolGetRegionCallSucceeds() throws Exception {
+System.setProperty("geode.feature-protobuf-protocol", "true");
+
+Socket socket = new Socket("localhost", cacheServerPort);
+Awaitility.await().atMost(5, 
TimeUnit.SECONDS).until(socket::isConnected);
+OutputStream outputStream = socket.getOutputStream();
+outputStream.write(110);
+
+
+ProtobufProtocolSerializer protobufProtocolSerializer = new 
ProtobufProtocolSerializer();
+ClientProtocol.Message getRegionMessage =
+MessageUtil.makeGetRegionRequestMessage(TEST_REGION, 
ClientProtocol.MessageHeader.newBuilder().build());
+protobufProtocolSerializer.serialize(getRegionMessage, outputStream);
+
+ClientProtocol.Message message =
+protobufProtocolSerializer.deserialize(socket.getInputStream());
+assertEquals(ClientProtocol.Message.MessageTypeCase.RESPONSE, 
message.getMessageTypeCase());
+ClientProtocol.Response response = message.getResponse();
+assertEquals(ClientProtocol.Response.ResponseAPICase.GETREGIONRESPONSE,
+response.getResponseAPICase());
+response.getGetRegionResponse();
+//TODO add some assertions for Region data
--- End diff --

Can we resolve this TODO before pushing this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Apache Geode + Narayana JTA = Global Transactions with Last-Resource Optimization

2017-07-13 Thread John Blum

Hi Christian-

Certainly, if you like, I would be happy to help you out with the new Repo,
where I can.

@Geode Community-

As an FYI, I also just completed DATAGEODE-16 [1] for *Spring Data Geode*
(as well as SGF-636 [2] for *Spring Data GemFire*) which includes support
for Apache Geode in CMT/JTA Transactions initiated from *Spring's*
Transaction Management infrastructure when demarcating your transactional,
application service endpoints with *Spring's* @Transactional annotation,
thereby wrapping Geode data access interactions with other transactional,
XA-compliant resources in an atomic operation successfully.

In a nutshell, this includes handling steps 5-8 in the documentation on
behalf of a *Spring* user interfacing with Geode as specified here [3].
Additionally, it handles the downstream operations as well, after the
transaction completes.

Anyway, more details will be available in the *Spring Data Geode* User
Guide, once available (I have attached the raw documentation for everyone's
early access/preview).

As a reminder, once Apache Geode *1.2* is released, Spring Data Geode *2.0*
will join the *Spring Data Release Train* (as of *Kay RC1*) and follow a
regular release cadence.

Cheers,
John


[1] https://jira.spring.io/browse/DATAGEODE-16
[2] https://jira.spring.io/browse/SGF-636
[3]
http://geode.apache.org/docs/guide/11/developing/transactions/JTA_transactions.html#task_sln_x3b_wk


On Thu, Jul 13, 2017 at 2:56 AM, Christian Tzolov 
wrote:

> Hi
>
> As suggested i've added related wiki page here:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=71764563#
>
> Feel free to review and edit!
>
> @Swapnil, @John, since this is an external, optional utility it might
> useful to add you as github (
> https://github.com/tzolov/narayana-jta-geode-support) project owners too?
> As an attempt to keep the code in synch with the core Geode/SDG projects?
>
> Cheers,
> Christain
>
> On 4 July 2017 at 22:59, John Blum  wrote:
>
> > 1 additional note...
> >
> > As a follow up to what *Christian* has provided here (which is highly
> > appreciated), I am also adding formal support for using Geode as a Last
> > Resource in a CMT/JTA transaction initiated by a *Spring*
> > managed/demarcated transaction in...
> >
> > DATAGEODE-16 - "*Add support for Geode JCA ResourceAdapter*
> > " [1]
> >
> > The work being done in DATAGEODE-16 is based on POC work we did for a
> > Pivotal customer and will benefit the entire community.
> >
> > Cheers,
> > John
> >
> >
> > [1] https://jira.spring.io/browse/DATAGEODE-16
> >
> >
> > On Tue, Jul 4, 2017 at 1:53 PM, John Blum  wrote:
> >
> > > Well done Christian!  Thank you for the hard work and contributions.
> > >
> > > Cheers,
> > > -j
> > >
> > > On Mon, Jul 3, 2017 at 12:43 PM, Swapnil Bawaskar <
> sbawas...@pivotal.io>
> > > wrote:
> > >
> > >> Great work Christian!
> > >> Can you add a page about this on the wiki
> > >>  as well, so
> > >> that
> > >> your work is not lost.
> > >>
> > >> On Mon, Jul 3, 2017 at 10:58 AM Dan Smith  wrote:
> > >>
> > >> > Awesome!
> > >> >
> > >> > -Dan
> > >> >
> > >> > On Mon, Jul 3, 2017 at 6:08 AM, Christian Tzolov <
> ctzo...@pivotal.io>
> > >> > wrote:
> > >> >
> > >> > > Recent experience of setting up Geode as a last-resource inside
> > >> WebSphere
> > >> > > JTA, has motivated me to find a simpler way to integrate with JTA.
> > >> > >
> > >> > > The https://github.com/tzolov/narayana-jta-geode-support provides
> > >> > > utilities
> > >> > > to integrate Geode with Narayana JTA. This enables global
> > transactions
> > >> > > using the embeddable, standalone, open-source Narayana JTA and
> > >> implements
> > >> > > the Last-Resource Commit Optimization (LRCO) to preserve the ACID
> > >> > > properties.  (e.g. Geode is registered as last-resource in the
> > global
> > >> > > transactions).
> > >> > >
> > >> > > With narayana-geode-core you can use it with the plain Geode API:
> > >> > > http://bit.ly/2tByAr5
> > >> > > or use narayana-geode-springboot for seamless integration with
> > Spring
> > >> > Boot
> > >> > > and SpringDataGemfire. See the http://bit.ly/2siBEof example
> > >> > >
> > >> > > All dependencies are resolved from maven central.
> > >> > >
> > >> > > So if you build a SpringBoot app you only need to add the maven
> > >> > > dependencies and set a single annotation @EnableGeodeNarayanaJta.
> No
> > >> need
> > >> > > for obsolete, commercial  Application Servers no accidental
> > >> complexity.
> > >> > >
> > >> > > I’ve tried to explain the problem and the solution in my blog
> here:
> > >> > > http://blog.tzolov.net/2017/07/apache-geode-gemfire-
> > >> > > narayana-jta.html?view=sidebar
> > >> > >
> > >> > > Because Narayana uses LGPL it is not compatible for distribution
> > with
> > >> > ASF,
> > >> > > but it can be referred

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

2017-07-13 Thread kohlmu-pivotal

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/630#discussion_r127289532
  
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -52,7 +52,12 @@ message CallbackArguments {
 
 message Region {
 string name = 1;
-// TODO: key, value types?
+string type = 2;
--- End diff --

I like that idea. Will amend


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

2017-07-13 Thread kohlmu-pivotal

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/630#discussion_r127289486
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 ---
@@ -278,6 +278,31 @@ public void 
useSSL_testNewProtocolHeaderLeadsToNewProtocolServerConnection() thr
 testNewProtocolHeaderLeadsToNewProtocolServerConnection();
   }
 
+  @Test
+  public void testNewProtocolGetRegionCallSucceeds() throws Exception {
+System.setProperty("geode.feature-protobuf-protocol", "true");
+
+Socket socket = new Socket("localhost", cacheServerPort);
+Awaitility.await().atMost(5, 
TimeUnit.SECONDS).until(socket::isConnected);
+OutputStream outputStream = socket.getOutputStream();
+outputStream.write(110);
+
+
+ProtobufProtocolSerializer protobufProtocolSerializer = new 
ProtobufProtocolSerializer();
+ClientProtocol.Message getRegionMessage =
+MessageUtil.makeGetRegionRequestMessage(TEST_REGION, 
ClientProtocol.MessageHeader.newBuilder().build());
+protobufProtocolSerializer.serialize(getRegionMessage, outputStream);
+
+ClientProtocol.Message message =
+protobufProtocolSerializer.deserialize(socket.getInputStream());
+assertEquals(ClientProtocol.Message.MessageTypeCase.RESPONSE, 
message.getMessageTypeCase());
+ClientProtocol.Response response = message.getResponse();
+assertEquals(ClientProtocol.Response.ResponseAPICase.GETREGIONRESPONSE,
+response.getResponseAPICase());
+response.getGetRegionResponse();
+//TODO add some assertions for Region data
--- End diff --

I'll amend and add the checks now, rather than later


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

2017-07-13 Thread kohlmu-pivotal

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/630#discussion_r127289396
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
 ---
@@ -33,7 +33,7 @@
 
   @Override
   public ClientProtocol.Response process(SerializationService 
serializationService,
-  ClientProtocol.Request request, Cache cache) {
+ ClientProtocol.Request request, 
Cache cache) {
--- End diff --

I forgot to run spotlessApply. Travis confirms the the failure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

2017-07-13 Thread echobravopapa

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/107#discussion_r127285583
  
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,8 +66,8 @@ SelectResultsIterator StructSetImpl::getIterator() {
   return SelectResultsIterator(m_structVector, shared_from_this());
 }
 
-int32_t StructSetImpl::getFieldIndex(const char* fieldname) {
-  std::map::iterator iter =
+int32_t StructSetImpl::getFieldIndex(const std::string& fieldname) {
+  const auto& iter =
   m_fieldNameIndexMap.find(fieldname);
   if (iter != m_fieldNameIndexMap.end()) {
 return iter->second;
--- End diff --

will do


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PING message is "Mischief Managed"

2017-07-13 Thread John Blum

Corrections below (apologies)...

On Thu, Jul 13, 2017 at 10:44 AM, John Blum  wrote:

> Yeah, that was my doing. :)
>
> I thought it would be more fun to return a special message than the
> typical "Alive".  "Mischief Managed" comes from *Harry Potter*.
>
> This endpoint is of course benign/idempotent and was purely meant to test
> the Management REST API's availability, or rather that the Manage/Locator
> was still "online".
>
> Unlike JMX RMI, HTTP is stateless.  When a JMX RMI connection is made, it
> is persistent and constantly "connected", where as each HTTP request to the
> Management REST API opens and closes a connection.  Therefore, you have no
> idea whether *Gfsh* is still connected to the Manager between requests
> unlike the JMX RMI connection.
>
> So, I run a background Thread that "polls" this endpoint every 500 ms.  It
> might even test the message; I don't remember.  Once the response is
> anything other than 200 OK, then we know there is a problem and that the
> connection was most likely terminated.
>
> Therefore, it keeps the behavior of the HTTP connection between *Gfsh*
> and the Manager similar to the JMX RMI connection by returning...
>
> No longer connected to 10.99.199.10[1099].
>
> gfsh>
>
>
> On Thu, Jul 13, 2017 at 10:36 AM, Jacob Barrett 
> wrote:
>
>> For the older crowed I would have rather it replied:
>>
>> Ah, I see you have the machine that goes 'ping!'.
>>
>> Sent from my iPhone
>>
>> > On Jul 13, 2017, at 10:23 AM, Jared Stewart 
>> wrote:
>> >
>> > I'm young enough to recognize it as a Harry Potter reference, but I
>> have no
>> > idea what it's doing in our product code.
>> >
>> > - Jared
>> >
>> >> On Jul 13, 2017 10:14 AM, "Kirk Lund"  wrote:
>> >>
>> >> Anyone know why the response to a REST service PING returns "Mischief
>> >> Managed!?
>> >>
>> >> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD},
>> value =
>> >> "/ping")
>> >> public ResponseEntity ping() {
>> >>  return new ResponseEntity("Mischief
>> >> Managed!",
>> >>  HttpStatus.OK);
>> >> }
>> >>
>> >> /Users/klund/dev/geode [949]$ git grep
>> 'Mischief
>> >> Managed'
>> >> geode-core/src/main/java/org/apache/geode/management/
>> >> internal/web/controllers/ShellCommandsController.java:
>> >>   return new ResponseEntity("Mischief
>> >> Managed!",
>> >>
>>
>
>
>
> --
> -John
> john.blum10101 (skype)
>



-- 
-John
john.blum10101 (skype)

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

2017-07-13 Thread echobravopapa

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/107#discussion_r127285563
  
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,12 @@ int32_t StructSetImpl::getFieldIndex(const char* 
fieldname) {
   }
 }
 
-const char* StructSetImpl::getFieldName(int32_t index) {
-  for (std::map::iterator iter =
-   m_fieldNameIndexMap.begin();
-   iter != m_fieldNameIndexMap.end(); ++iter) {
-if (iter->second == index) return iter->first.c_str();
+const std::string& StructSetImpl::getFieldName(int32_t index) {
+  for (const auto& iter : m_fieldNameIndexMap) {
+if (iter.second == index) return (iter.first);
   }
-  return nullptr;
+
+  throw OutOfRangeException("Struct: fieldName not found.");
--- End diff --

we can do that, I was just using our existing exception



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

2017-07-13 Thread WireBaron

Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/630#discussion_r127285451
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
 ---
@@ -33,7 +33,7 @@
 
   @Override
   public ClientProtocol.Response process(SerializationService 
serializationService,
-  ClientProtocol.Request request, Cache cache) {
+ ClientProtocol.Request request, 
Cache cache) {
--- End diff --

Does this pass spotless?  I thought all of these wonky indentations were 
actually introduced by spotlessApply?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

2017-07-13 Thread pivotal-amurmann

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/630#discussion_r127285154
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 ---
@@ -278,6 +278,31 @@ public void 
useSSL_testNewProtocolHeaderLeadsToNewProtocolServerConnection() thr
 testNewProtocolHeaderLeadsToNewProtocolServerConnection();
   }
 
+  @Test
+  public void testNewProtocolGetRegionCallSucceeds() throws Exception {
+System.setProperty("geode.feature-protobuf-protocol", "true");
+
+Socket socket = new Socket("localhost", cacheServerPort);
+Awaitility.await().atMost(5, 
TimeUnit.SECONDS).until(socket::isConnected);
+OutputStream outputStream = socket.getOutputStream();
+outputStream.write(110);
+
+
+ProtobufProtocolSerializer protobufProtocolSerializer = new 
ProtobufProtocolSerializer();
+ClientProtocol.Message getRegionMessage =
+MessageUtil.makeGetRegionRequestMessage(TEST_REGION, 
ClientProtocol.MessageHeader.newBuilder().build());
+protobufProtocolSerializer.serialize(getRegionMessage, outputStream);
+
+ClientProtocol.Message message =
+protobufProtocolSerializer.deserialize(socket.getInputStream());
+assertEquals(ClientProtocol.Message.MessageTypeCase.RESPONSE, 
message.getMessageTypeCase());
+ClientProtocol.Response response = message.getResponse();
+assertEquals(ClientProtocol.Response.ResponseAPICase.GETREGIONRESPONSE,
+response.getResponseAPICase());
+response.getGetRegionResponse();
+//TODO add some assertions for Region data
--- End diff --

Can we either add the assertions or put a chore in the backlog to backfill 
this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PING message is "Mischief Managed"

2017-07-13 Thread John Blum

Yeah, that is my doing. :)

I thought it would be more fun to return a special message than the typical
"Alive".  "Mischief Managed" comes from Harry Potter.

This endpoint is of course benign/idempotent and was purely meant to test
the Management REST API's availability, or rather that the Manage/Locator
was still online.

Unlike JMX RMI, HTTP is stateless.  When a JMX RMI connection is made, it
is persistent and constantly "connected", where as each HTTP request to the
Management REST API is opens and closes a connection each request.
Therefore, you have no idea whether *Gfsh* is still connected to the
Manager between requests unlike the JMX RMI connection.

So, I ran a background Thread that "polls" this endpoint every 500 ms.  It
might even test the message; I don't remember.  Once the response is
anything other than 200 OK, then we no there is a problem and that the
connection was most likely terminated.

Therefore, it keeps the behavior of the HTTP connection similar to the JMX
RMI connection by returning...

No longer connected to 10.99.199.10[1099].

gfsh>

On Thu, Jul 13, 2017 at 10:36 AM, Jacob Barrett  wrote:

> For the older crowed I would have rather it replied:
>
> Ah, I see you have the machine that goes 'ping!'.
>
> Sent from my iPhone
>
> > On Jul 13, 2017, at 10:23 AM, Jared Stewart  wrote:
> >
> > I'm young enough to recognize it as a Harry Potter reference, but I have
> no
> > idea what it's doing in our product code.
> >
> > - Jared
> >
> >> On Jul 13, 2017 10:14 AM, "Kirk Lund"  wrote:
> >>
> >> Anyone know why the response to a REST service PING returns "Mischief
> >> Managed!?
> >>
> >> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD}, value
> =
> >> "/ping")
> >> public ResponseEntity ping() {
> >>  return new ResponseEntity("Mischief
> >> Managed!",
> >>  HttpStatus.OK);
> >> }
> >>
> >> /Users/klund/dev/geode [949]$ git grep
> 'Mischief
> >> Managed'
> >> geode-core/src/main/java/org/apache/geode/management/
> >> internal/web/controllers/ShellCommandsController.java:
> >>   return new ResponseEntity("Mischief
> >> Managed!",
> >>
>

-- 
-John
john.blum10101 (skype)

Re: Review Request 60523: GEODE-3141 New flow: GetRegion

2017-07-13 Thread Alexander Murmann


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60523/#review180447
---




geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java
Lines 46 (patched)


weren't we getting rid of these?



geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java
Line 104 (original), 89 (patched)


How do you feel about splitting the different test cases into different 
test examples? That way we get more information even on a failed run and it's 
easier to see what cases exist.



geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandlerJUnitTest.java
Lines 92 (patched)


could this be more elegantly expressed by checking membership in a list of 
test regions? Would be a little more DRY and might read better.


- Alexander Murmann


On June 28, 2017, 11:06 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60523/
> ---
> 
> (Updated June 28, 2017, 11:06 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3141
> https://issues.apache.org/jira/browse/GEODE-3141
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added a GetRegion(regionName) API.  More details about the server region can 
> be added if needed.  This implementation just has a success flag and flag 
> saying whether the region is destroyed.
> 
> 
> Diffs
> -
> 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
>  4318fb444dd0eb5f5d07175a466e26f03933cc4d 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
>  4e76de4a15d1ff0cfeddcc2c7115c7c18c2e14ba 
>   
> geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java
>  PRE-CREATION 
>   geode-protobuf/src/main/proto/clientProtocol.proto 
> 0c192950a4e750f7c55e186c18a79a6c52716bf0 
>   geode-protobuf/src/main/proto/region_API.proto 
> d3af17acb1ee45c134837c321b2009c8532817cc 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java 
> dc897241fc229da53a5ff7a0e2df1678b8bceb6d 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  77b984f7e28a7bfa21b8e1c8c6a83467e9a37242 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java
>  e8f1e651a71240474a793d005164df1ba5d4cda7 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandlerJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60523/diff/1/
> 
> 
> Testing
> ---
> 
> new unit tests
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented

2017-07-13 Thread bschuchardt

Github user bschuchardt commented on a diff in the pull request:

https://github.com/apache/geode/pull/630#discussion_r127276853
  
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -52,7 +52,12 @@ message CallbackArguments {
 
 message Region {
 string name = 1;
-// TODO: key, value types?
+string type = 2;
--- End diff --

While I don't really like the name "dataPolicy" it seems like renaming it 
could cause confusion.  Geode docs don't mention a Region "type".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PING message is "Mischief Managed"

2017-07-13 Thread Jacob Barrett

For the older crowed I would have rather it replied:

Ah, I see you have the machine that goes 'ping!'.

Sent from my iPhone

> On Jul 13, 2017, at 10:23 AM, Jared Stewart  wrote:
> 
> I'm young enough to recognize it as a Harry Potter reference, but I have no
> idea what it's doing in our product code.
> 
> - Jared
> 
>> On Jul 13, 2017 10:14 AM, "Kirk Lund"  wrote:
>> 
>> Anyone know why the response to a REST service PING returns "Mischief
>> Managed!?
>> 
>> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD}, value =
>> "/ping")
>> public ResponseEntity ping() {
>>  return new ResponseEntity("Mischief
>> Managed!",
>>  HttpStatus.OK);
>> }
>> 
>> /Users/klund/dev/geode [949]$ git grep 'Mischief
>> Managed'
>> geode-core/src/main/java/org/apache/geode/management/
>> internal/web/controllers/ShellCommandsController.java:
>>   return new ResponseEntity("Mischief
>> Managed!",
>>

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

2017-07-13 Thread pivotal-jbarrett

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/107#discussion_r127278256
  
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,8 +66,8 @@ SelectResultsIterator StructSetImpl::getIterator() {
   return SelectResultsIterator(m_structVector, shared_from_this());
 }
 
-int32_t StructSetImpl::getFieldIndex(const char* fieldname) {
-  std::map::iterator iter =
+int32_t StructSetImpl::getFieldIndex(const std::string& fieldname) {
--- End diff --

should this method be a const method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PING message is "Mischief Managed"

2017-07-13 Thread Jared Stewart

I'm young enough to recognize it as a Harry Potter reference, but I have no
idea what it's doing in our product code.

- Jared

On Jul 13, 2017 10:14 AM, "Kirk Lund"  wrote:

> Anyone know why the response to a REST service PING returns "Mischief
> Managed!?
>
> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD}, value =
> "/ping")
> public ResponseEntity ping() {
>   return new ResponseEntity("Mischief
> Managed!",
>   HttpStatus.OK);
> }
>
> /Users/klund/dev/geode [949]$ git grep 'Mischief
> Managed'
> geode-core/src/main/java/org/apache/geode/management/
> internal/web/controllers/ShellCommandsController.java:
>return new ResponseEntity("Mischief
> Managed!",
>

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

2017-07-13 Thread pivotal-jbarrett

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/107#discussion_r127278443
  
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,8 +66,8 @@ SelectResultsIterator StructSetImpl::getIterator() {
   return SelectResultsIterator(m_structVector, shared_from_this());
 }
 
-int32_t StructSetImpl::getFieldIndex(const char* fieldname) {
-  std::map::iterator iter =
+int32_t StructSetImpl::getFieldIndex(const std::string& fieldname) {
+  const auto& iter =
   m_fieldNameIndexMap.find(fieldname);
   if (iter != m_fieldNameIndexMap.end()) {
 return iter->second;
--- End diff --

We should clear out commented sources.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

2017-07-13 Thread pivotal-jbarrett

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/107#discussion_r127278631
  
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,12 @@ int32_t StructSetImpl::getFieldIndex(const char* 
fieldname) {
   }
 }
 
-const char* StructSetImpl::getFieldName(int32_t index) {
-  for (std::map::iterator iter =
-   m_fieldNameIndexMap.begin();
-   iter != m_fieldNameIndexMap.end(); ++iter) {
-if (iter->second == index) return iter->first.c_str();
+const std::string& StructSetImpl::getFieldName(int32_t index) {
+  for (const auto& iter : m_fieldNameIndexMap) {
+if (iter.second == index) return (iter.first);
   }
-  return nullptr;
+
+  throw OutOfRangeException("Struct: fieldName not found.");
--- End diff --

why not `std::out_of_range`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

PING message is "Mischief Managed"

2017-07-13 Thread Kirk Lund

Anyone know why the response to a REST service PING returns "Mischief
Managed!?

@RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD}, value =
"/ping")
public ResponseEntity ping() {
  return new ResponseEntity("Mischief
Managed!",
  HttpStatus.OK);
}

/Users/klund/dev/geode [949]$ git grep 'Mischief
Managed'
geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/ShellCommandsController.java:
   return new ResponseEntity("Mischief
Managed!",

Re: Review Request 60834: GEODE-3051: Remove unreachable exception handling in AcceptorImpl.accept

2017-07-13 Thread Bruce Schuchardt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60834/#review180441
---


Ship it!




Ship It!

- Bruce Schuchardt


On July 12, 2017, 5:35 p.m., Brian Rowe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60834/
> ---
> 
> (Updated July 12, 2017, 5:35 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-3051
> https://issues.apache.org/jira/browse/GEODE-3051
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This removes handling of SSL exceptions from the AccepterImpl.accept call, as 
> the SSL handling code is now all done in another thread.
> The exception handling being done in the other thread appears to be correct, 
> as validated by CacheServerSSLConnectionDUnitTest.testNonSSLClient
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  3c424d397 
> 
> 
> Diff: https://reviews.apache.org/r/60834/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>

[GitHub] geode-native issue #107: GEODE-3019: Refactor Struct class

2017-07-13 Thread echobravopapa

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/107
  
@dgkimura @pivotal-jbarrett added unit tests and throwing an exception for 
out of range now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #631: GEODE-3051: Remove unreachable exception handling in Accep...

2017-07-13 Thread WireBaron

Github user WireBaron commented on the issue:

https://github.com/apache/geode/pull/631
  
Isn't it the same code handling the SSL handshake for both protocols right
now? If it's a different code path, then we should probably add a new test
for it.

On Thu, Jul 13, 2017 at 8:37 AM, galen-pivotal 
wrote:

> *@galen-pivotal* approved this pull request.
>
> It looks like CacheServerSSLConnectionDUnitTest.testNonSSLClient tests
> that a client using the old client protocol gets an SSL exception. Do you
> think it's worth making a test for the new protocol as well?
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Geode-Native Windows build

2017-07-13 Thread Jacob Barrett

Yup! It should match the the minimum requirements mentioned at the very least. 
It should also compile fine under 2017 though I don't believe anyone has yet.

Sent from my iPhone

> On Jul 13, 2017, at 6:08 AM, Daniel Farcovich  
> wrote:
> 
> From BUILDING.md:
> 
> Windows Generator
> 
> The recommended generator on Windows is Visual Studio 12 2013 Win64:
> 
> $ cmake -G "Visual Studio 12 2013 Win64" ../src
> 
> 
> Should we change that?
> 
> Daniel
> 
> -Original Message-
> From: Jacob Barrett [mailto:jbarr...@pivotal.io] 
> Sent: Thursday, July 13, 2017 3:06 PM
> To: dev@geode.apache.org
> Subject: Re: Geode-Native Windows build
> 
> VS 2013 is not fully C++11 compliant. The minimum compiler on windows is VS 
> 2015.
> 
> Sent from my iPhone
> 
>> On Jul 13, 2017, at 4:32 AM, Daniel Farcovich  
>> wrote:
>> 
>> As I mentioned in the first email I receive compilation errors, for example:
>> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
>>  error C2144: syntax error : 'bool' should be preceded by ';' 
>> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>> 
>> The root cause of this error is in the use of "constexpr" in utils.hpp and 
>> build in VS2013.
>> There are features of c++11 which are not implemented in various VS versions.
>> Here is a table with the unsupported features, where constexpr is one of 
>> them:
>> https://msdn.microsoft.com/en-us/library/hh567368.aspx#featurelist
>> 
>> I assume the rest of the errors are of the same reason.
>> 
>> Although boost has already macros to workaround constexpr (BOOST_CONSTEXPR), 
>> my suggestion is to add a macro to geode_base.hpp for removing constexpr 
>> when it's not supported:
>> #ifdef _WIN32
>> #if _MSC_VER > 1800 //VS2015 and higher #define GF_CONSTEXPR constexpr 
>> #else #define GF_CONSTEXPR #endif #else #define GF_CONSTEXPR constexpr 
>> #endif
>> 
>> Daniel
>> 
>> -Original Message-
>> From: Daniel Farcovich
>> Sent: Thursday, July 13, 2017 10:07 AM
>> To: 'dev@geode.apache.org' 
>> Subject: RE: Geode-Native Windows build
>> 
>> Hi Jake and Ernest,
>> 
>> I tried to build from c:\build
>> Here is the config command and output:
>> 
>> c:\build>cmake  -DCMAKE_INSTALL_PREFIX=C:\build\out -G "Visual Studio 
>> 12 2013 Win64" -Thost=x64 
>> C:\Users\Fdaniel\Source\Repos\geode-native2\src
>> -- The C compiler identification is MSVC 18.0.21005.1
>> -- The CXX compiler identification is MSVC 18.0.21005.1
>> -- Check for working C compiler: C:/Program Files (x86)/Microsoft 
>> Visual Studio 12.0/VC/bin/amd64/cl.exe
>> -- Check for working C compiler: C:/Program Files (x86)/Microsoft 
>> Visual Studio 12.0/VC/bin/amd64/cl.exe -- works
>> -- Detecting C compiler ABI info
>> -- Detecting C compiler ABI info - done
>> -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft 
>> Visual Studio 12.0/VC/bin/amd64/cl.exe
>> -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft 
>> Visual Studio 12.0/VC/bin/amd64/cl.exe -- works
>> -- Detecting CXX compiler ABI info
>> -- Detecting CXX compiler ABI info - done
>> -- Detecting CXX compile features
>> -- Detecting CXX compile features - done
>> -- Performing Test CFLAGS_M64_ALLOWED
>> -- Performing Test CFLAGS_M64_ALLOWED - Failed
>> -- Performing Test CXXFLAGS_M64_ALLOWED
>> -- Performing Test CXXFLAGS_M64_ALLOWED - Failed
>> -- Performing Test CFLAGS_mt_ALLOWED
>> -- Performing Test CFLAGS_mt_ALLOWED - Failed
>> -- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found 
>> suitable version "1.8.0.74", minimum required is "1.8.0.60") found 
>> components:  Development
>> -- Found Geode: 
>> C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apach
>> e-geode\bin\gfsh.bat (found suitable version "1.1.1", minimum required 
>> is "1.0")
>> -- Found Doxygen: C:/Program Files/doxygen/bin/doxygen.exe (found 
>> suitable version "1.8.13", minimum required is "1.6")
>> -- Found Git: C:/Program Files/Git/cmd/git.exe (found suitable version 
>> "2.10.2.windows.1", minimum required is "1.7")
>> -- Looking for include files sys/param.h, sys/mount.h
>> -- Looking for include files sys/param.h, sys/mount.h - not found
>> -- Looking for SIGSTKFLT
>> -- Looking for SIGSTKFLT - not found
>> -- Looking for SIGPWR
>> -- Looking for SIGPWR - not found
>> -- Found Geode: 
>> C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apach
>> e-geode\bin\gfsh.bat (found version "1.1.1")
>> -- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found 
>> version "1.8.0.74")
>> -- Found Doxygen: C:/Program Files/doxygen/bin/doxygen.exe (found 
>> version "1.8.13")
>> -- Configuring done
>> -- Generating done
>> 
>> -- Build files have been written to: C:/build
>> 
>> 
>> PFA CMakeError.log and CMakeOutput.log after "cmake --build . -- /m"
>> 
>> Thanks,
>> Daniel
>> 
>> -Original Message-
>>

RE: Geode-Native Windows build

2017-07-13 Thread Daniel Farcovich

>From BUILDING.md:

Windows Generator

The recommended generator on Windows is Visual Studio 12 2013 Win64:

$ cmake -G "Visual Studio 12 2013 Win64" ../src


Should we change that?

Daniel

-Original Message-
From: Jacob Barrett [mailto:jbarr...@pivotal.io] 
Sent: Thursday, July 13, 2017 3:06 PM
To: dev@geode.apache.org
Subject: Re: Geode-Native Windows build

VS 2013 is not fully C++11 compliant. The minimum compiler on windows is VS 
2015.

Sent from my iPhone

> On Jul 13, 2017, at 4:32 AM, Daniel Farcovich  
> wrote:
> 
> As I mentioned in the first email I receive compilation errors, for example:
> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
>  error C2144: syntax error : 'bool' should be preceded by ';' 
> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
> 
> The root cause of this error is in the use of "constexpr" in utils.hpp and 
> build in VS2013.
> There are features of c++11 which are not implemented in various VS versions.
> Here is a table with the unsupported features, where constexpr is one of them:
> https://msdn.microsoft.com/en-us/library/hh567368.aspx#featurelist
> 
> I assume the rest of the errors are of the same reason.
> 
> Although boost has already macros to workaround constexpr (BOOST_CONSTEXPR), 
> my suggestion is to add a macro to geode_base.hpp for removing constexpr when 
> it's not supported:
> #ifdef _WIN32
> #if _MSC_VER > 1800 //VS2015 and higher #define GF_CONSTEXPR constexpr 
> #else #define GF_CONSTEXPR #endif #else #define GF_CONSTEXPR constexpr 
> #endif
> 
> Daniel
> 
> -Original Message-
> From: Daniel Farcovich
> Sent: Thursday, July 13, 2017 10:07 AM
> To: 'dev@geode.apache.org' 
> Subject: RE: Geode-Native Windows build
> 
> Hi Jake and Ernest,
> 
> I tried to build from c:\build
> Here is the config command and output:
> 
> c:\build>cmake  -DCMAKE_INSTALL_PREFIX=C:\build\out -G "Visual Studio 
> 12 2013 Win64" -Thost=x64 
> C:\Users\Fdaniel\Source\Repos\geode-native2\src
> -- The C compiler identification is MSVC 18.0.21005.1
> -- The CXX compiler identification is MSVC 18.0.21005.1
> -- Check for working C compiler: C:/Program Files (x86)/Microsoft 
> Visual Studio 12.0/VC/bin/amd64/cl.exe
> -- Check for working C compiler: C:/Program Files (x86)/Microsoft 
> Visual Studio 12.0/VC/bin/amd64/cl.exe -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft 
> Visual Studio 12.0/VC/bin/amd64/cl.exe
> -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft 
> Visual Studio 12.0/VC/bin/amd64/cl.exe -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> -- Performing Test CFLAGS_M64_ALLOWED
> -- Performing Test CFLAGS_M64_ALLOWED - Failed
> -- Performing Test CXXFLAGS_M64_ALLOWED
> -- Performing Test CXXFLAGS_M64_ALLOWED - Failed
> -- Performing Test CFLAGS_mt_ALLOWED
> -- Performing Test CFLAGS_mt_ALLOWED - Failed
> -- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found 
> suitable version "1.8.0.74", minimum required is "1.8.0.60") found 
> components:  Development
> -- Found Geode: 
> C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apach
> e-geode\bin\gfsh.bat (found suitable version "1.1.1", minimum required 
> is "1.0")
> -- Found Doxygen: C:/Program Files/doxygen/bin/doxygen.exe (found 
> suitable version "1.8.13", minimum required is "1.6")
> -- Found Git: C:/Program Files/Git/cmd/git.exe (found suitable version 
> "2.10.2.windows.1", minimum required is "1.7")
> -- Looking for include files sys/param.h, sys/mount.h
> -- Looking for include files sys/param.h, sys/mount.h - not found
> -- Looking for SIGSTKFLT
> -- Looking for SIGSTKFLT - not found
> -- Looking for SIGPWR
> -- Looking for SIGPWR - not found
> -- Found Geode: 
> C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apach
> e-geode\bin\gfsh.bat (found version "1.1.1")
> -- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found 
> version "1.8.0.74")
> -- Found Doxygen: C:/Program Files/doxygen/bin/doxygen.exe (found 
> version "1.8.13")
> -- Configuring done
> -- Generating done
> 
> -- Build files have been written to: C:/build
> 
> 
> PFA CMakeError.log and CMakeOutput.log after "cmake --build . -- /m"
> 
> Thanks,
> Daniel
> 
> -Original Message-
> From: Jacob Barrett [mailto:jbarr...@pivotal.io]
> Sent: Wednesday, July 12, 2017 5:11 PM
> To: dev@geode.apache.org
> Subject: Re: Geode-Native Windows build
> 
> While we wait for your config output there is something else that might bite 
> you if it isn't what is biting you now. Some of the third part libraries 
> built as part of Geode native have deep directory structures. Your deep 
> directory structure to your

Re: Stored procedures on Apache Geode.

2017-07-13 Thread Anthony Baker

A geode Function is conceptually similar to a stored proc but the 
implementation is different. It's a java class that would use geode apis to 
execute logic within the cluster. 

Anthony

> On Jul 12, 2017, at 11:13 PM, marios390  
> wrote:
> 
> Hi,
> 
> I noticed that Apache Geode supports stored procedures as functions running
> on nodes.
> Could you please elaborate on that since I am confused a little a bit.
> Can I run for example Oracle SP directly on cache servers (nodes) or do I
> have to transform them somehow into microservices ( i.e spring boot) which
> expose functions on nodes.
> 
> 
> 
> --
> View this message in context: 
> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/Stored-procedures-on-Apache-Geode-tp24279.html
> Sent from the Apache Geode (Incubating) Developers Forum mailing list archive 
> at Nabble.com.

Re: Geode-Native Windows build

2017-07-13 Thread Jacob Barrett

VS 2013 is not fully C++11 compliant. The minimum compiler on windows is VS 
2015.

Sent from my iPhone

> On Jul 13, 2017, at 4:32 AM, Daniel Farcovich  
> wrote:
> 
> As I mentioned in the first email I receive compilation errors, for example:
> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
>  error C2144: syntax error : 'bool' should be preceded by ';' 
> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
> 
> The root cause of this error is in the use of "constexpr" in utils.hpp and 
> build in VS2013.
> There are features of c++11 which are not implemented in various VS versions.
> Here is a table with the unsupported features, where constexpr is one of them:
> https://msdn.microsoft.com/en-us/library/hh567368.aspx#featurelist
> 
> I assume the rest of the errors are of the same reason.
> 
> Although boost has already macros to workaround constexpr (BOOST_CONSTEXPR), 
> my suggestion is to add a macro to geode_base.hpp for removing constexpr when 
> it's not supported:
> #ifdef _WIN32
> #if _MSC_VER > 1800 //VS2015 and higher
> #define GF_CONSTEXPR constexpr
> #else
> #define GF_CONSTEXPR
> #endif
> #else
> #define GF_CONSTEXPR constexpr
> #endif
> 
> Daniel
> 
> -Original Message-
> From: Daniel Farcovich 
> Sent: Thursday, July 13, 2017 10:07 AM
> To: 'dev@geode.apache.org' 
> Subject: RE: Geode-Native Windows build
> 
> Hi Jake and Ernest,
> 
> I tried to build from c:\build
> Here is the config command and output:
> 
> c:\build>cmake  -DCMAKE_INSTALL_PREFIX=C:\build\out -G "Visual Studio 12 2013 
> Win64" -Thost=x64 C:\Users\Fdaniel\Source\Repos\geode-native2\src
> -- The C compiler identification is MSVC 18.0.21005.1
> -- The CXX compiler identification is MSVC 18.0.21005.1
> -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual 
> Studio 12.0/VC/bin/amd64/cl.exe
> -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual 
> Studio 12.0/VC/bin/amd64/cl.exe -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual 
> Studio 12.0/VC/bin/amd64/cl.exe
> -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual 
> Studio 12.0/VC/bin/amd64/cl.exe -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> -- Performing Test CFLAGS_M64_ALLOWED
> -- Performing Test CFLAGS_M64_ALLOWED - Failed
> -- Performing Test CXXFLAGS_M64_ALLOWED
> -- Performing Test CXXFLAGS_M64_ALLOWED - Failed
> -- Performing Test CFLAGS_mt_ALLOWED
> -- Performing Test CFLAGS_mt_ALLOWED - Failed
> -- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found suitable 
> version "1.8.0.74", minimum required is "1.8.0.60") found components:  
> Development
> -- Found Geode: 
> C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apache-geode\bin\gfsh.bat
>  (found suitable version "1.1.1", minimum required is "1.0")
> -- Found Doxygen: C:/Program Files/doxygen/bin/doxygen.exe (found suitable 
> version "1.8.13", minimum required is "1.6")
> -- Found Git: C:/Program Files/Git/cmd/git.exe (found suitable version 
> "2.10.2.windows.1", minimum required is "1.7")
> -- Looking for include files sys/param.h, sys/mount.h
> -- Looking for include files sys/param.h, sys/mount.h - not found
> -- Looking for SIGSTKFLT
> -- Looking for SIGSTKFLT - not found
> -- Looking for SIGPWR
> -- Looking for SIGPWR - not found
> -- Found Geode: 
> C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apache-geode\bin\gfsh.bat
>  (found version "1.1.1")
> -- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found version 
> "1.8.0.74")
> -- Found Doxygen: C:/Program Files/doxygen/bin/doxygen.exe (found version 
> "1.8.13")
> -- Configuring done
> -- Generating done
> 
> -- Build files have been written to: C:/build
> 
> 
> PFA CMakeError.log and CMakeOutput.log after "cmake --build . -- /m"
> 
> Thanks,
> Daniel
> 
> -Original Message-
> From: Jacob Barrett [mailto:jbarr...@pivotal.io]
> Sent: Wednesday, July 12, 2017 5:11 PM
> To: dev@geode.apache.org
> Subject: Re: Geode-Native Windows build
> 
> While we wait for your config output there is something else that might bite 
> you if it isn't what is biting you now. Some of the third part libraries 
> built as part of Geode native have deep directory structures. Your deep 
> directory structure to your sources combine with that may result in paths 
> over the windows limit. 
> 
> Consider using something more shallow on windows, like C:\build. Your source 
> can be anywhere since CMake builds are outside the source tree.
> 
> -Jake
> 
> 
> Sent from my iPhone
> 
>> On Jul 12, 2017, at 6:52 AM, Daniel Farcovich  
>> wrote:
>> 
>> Hi,
>>

RE: Geode-Native Windows build

2017-07-13 Thread Daniel Farcovich

As I mentioned in the first email I receive compilation errors, for example:
31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
 error C2144: syntax error : 'bool' should be preceded by ';' 
(C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.

The root cause of this error is in the use of "constexpr" in utils.hpp and 
build in VS2013.
There are features of c++11 which are not implemented in various VS versions.
Here is a table with the unsupported features, where constexpr is one of them:
https://msdn.microsoft.com/en-us/library/hh567368.aspx#featurelist

I assume the rest of the errors are of the same reason.

Although boost has already macros to workaround constexpr (BOOST_CONSTEXPR), my 
suggestion is to add a macro to geode_base.hpp for removing constexpr when it's 
not supported:
#ifdef _WIN32
#if _MSC_VER > 1800 //VS2015 and higher
#define GF_CONSTEXPR constexpr
#else
#define GF_CONSTEXPR
#endif
#else
#define GF_CONSTEXPR constexpr
#endif

Daniel

-Original Message-
From: Daniel Farcovich 
Sent: Thursday, July 13, 2017 10:07 AM
To: 'dev@geode.apache.org' 
Subject: RE: Geode-Native Windows build

Hi Jake and Ernest,

I tried to build from c:\build
Here is the config command and output:

c:\build>cmake  -DCMAKE_INSTALL_PREFIX=C:\build\out -G "Visual Studio 12 2013 
Win64" -Thost=x64 C:\Users\Fdaniel\Source\Repos\geode-native2\src
-- The C compiler identification is MSVC 18.0.21005.1
-- The CXX compiler identification is MSVC 18.0.21005.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 
12.0/VC/bin/amd64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 
12.0/VC/bin/amd64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual 
Studio 12.0/VC/bin/amd64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual 
Studio 12.0/VC/bin/amd64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CFLAGS_M64_ALLOWED
-- Performing Test CFLAGS_M64_ALLOWED - Failed
-- Performing Test CXXFLAGS_M64_ALLOWED
-- Performing Test CXXFLAGS_M64_ALLOWED - Failed
-- Performing Test CFLAGS_mt_ALLOWED
-- Performing Test CFLAGS_mt_ALLOWED - Failed
-- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found suitable 
version "1.8.0.74", minimum required is "1.8.0.60") found components:  
Development
-- Found Geode: 
C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apache-geode\bin\gfsh.bat
 (found suitable version "1.1.1", minimum required is "1.0")
-- Found Doxygen: C:/Program Files/doxygen/bin/doxygen.exe (found suitable 
version "1.8.13", minimum required is "1.6")
-- Found Git: C:/Program Files/Git/cmd/git.exe (found suitable version 
"2.10.2.windows.1", minimum required is "1.7")
-- Looking for include files sys/param.h, sys/mount.h
-- Looking for include files sys/param.h, sys/mount.h - not found
-- Looking for SIGSTKFLT
-- Looking for SIGSTKFLT - not found
-- Looking for SIGPWR
-- Looking for SIGPWR - not found
-- Found Geode: 
C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apache-geode\bin\gfsh.bat
 (found version "1.1.1")
-- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found version 
"1.8.0.74")
-- Found Doxygen: C:/Program Files/doxygen/bin/doxygen.exe (found version 
"1.8.13")
-- Configuring done
-- Generating done

-- Build files have been written to: C:/build


PFA CMakeError.log and CMakeOutput.log after "cmake --build . -- /m"

Thanks,
Daniel

-Original Message-
From: Jacob Barrett [mailto:jbarr...@pivotal.io]
Sent: Wednesday, July 12, 2017 5:11 PM
To: dev@geode.apache.org
Subject: Re: Geode-Native Windows build

While we wait for your config output there is something else that might bite 
you if it isn't what is biting you now. Some of the third part libraries built 
as part of Geode native have deep directory structures. Your deep directory 
structure to your sources combine with that may result in paths over the 
windows limit. 

Consider using something more shallow on windows, like C:\build. Your source 
can be anywhere since CMake builds are outside the source tree.

-Jake


Sent from my iPhone

> On Jul 12, 2017, at 6:52 AM, Daniel Farcovich  
> wrote:
> 
> Hi,
> I'm failing to build geode native cpp client on windows, although 
> followed the instructions on BUILDING.md Looks like there are slash/backslash 
> fixes should be done in the paths in cmake files.
> After overcoming cmake  failures the build fails on stage "cmake --build . -- 
> /m" with compilation errors for example:
> 
> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
>  error C2144:

Re: Apache Geode + Narayana JTA = Global Transactions with Last-Resource Optimization

2017-07-13 Thread Christian Tzolov

Hi

As suggested i've added related wiki page here:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=71764563#

Feel free to review and edit!

@Swapnil, @John, since this is an external, optional utility it might
useful to add you as github (
https://github.com/tzolov/narayana-jta-geode-support) project owners too?
As an attempt to keep the code in synch with the core Geode/SDG projects?

Cheers,
Christain

On 4 July 2017 at 22:59, John Blum  wrote:

> 1 additional note...
>
> As a follow up to what *Christian* has provided here (which is highly
> appreciated), I am also adding formal support for using Geode as a Last
> Resource in a CMT/JTA transaction initiated by a *Spring*
> managed/demarcated transaction in...
>
> DATAGEODE-16 - "*Add support for Geode JCA ResourceAdapter*
> " [1]
>
> The work being done in DATAGEODE-16 is based on POC work we did for a
> Pivotal customer and will benefit the entire community.
>
> Cheers,
> John
>
>
> [1] https://jira.spring.io/browse/DATAGEODE-16
>
>
> On Tue, Jul 4, 2017 at 1:53 PM, John Blum  wrote:
>
> > Well done Christian!  Thank you for the hard work and contributions.
> >
> > Cheers,
> > -j
> >
> > On Mon, Jul 3, 2017 at 12:43 PM, Swapnil Bawaskar 
> > wrote:
> >
> >> Great work Christian!
> >> Can you add a page about this on the wiki
> >>  as well, so
> >> that
> >> your work is not lost.
> >>
> >> On Mon, Jul 3, 2017 at 10:58 AM Dan Smith  wrote:
> >>
> >> > Awesome!
> >> >
> >> > -Dan
> >> >
> >> > On Mon, Jul 3, 2017 at 6:08 AM, Christian Tzolov 
> >> > wrote:
> >> >
> >> > > Recent experience of setting up Geode as a last-resource inside
> >> WebSphere
> >> > > JTA, has motivated me to find a simpler way to integrate with JTA.
> >> > >
> >> > > The https://github.com/tzolov/narayana-jta-geode-support provides
> >> > > utilities
> >> > > to integrate Geode with Narayana JTA. This enables global
> transactions
> >> > > using the embeddable, standalone, open-source Narayana JTA and
> >> implements
> >> > > the Last-Resource Commit Optimization (LRCO) to preserve the ACID
> >> > > properties.  (e.g. Geode is registered as last-resource in the
> global
> >> > > transactions).
> >> > >
> >> > > With narayana-geode-core you can use it with the plain Geode API:
> >> > > http://bit.ly/2tByAr5
> >> > > or use narayana-geode-springboot for seamless integration with
> Spring
> >> > Boot
> >> > > and SpringDataGemfire. See the http://bit.ly/2siBEof example
> >> > >
> >> > > All dependencies are resolved from maven central.
> >> > >
> >> > > So if you build a SpringBoot app you only need to add the maven
> >> > > dependencies and set a single annotation @EnableGeodeNarayanaJta. No
> >> need
> >> > > for obsolete, commercial  Application Servers no accidental
> >> complexity.
> >> > >
> >> > > I’ve tried to explain the problem and the solution in my blog here:
> >> > > http://blog.tzolov.net/2017/07/apache-geode-gemfire-
> >> > > narayana-jta.html?view=sidebar
> >> > >
> >> > > Because Narayana uses LGPL it is not compatible for distribution
> with
> >> > ASF,
> >> > > but it can be referred as optional component.
> >> > >
> >> > > Cheers,
> >> > > Christian
> >> > >
> >> > > P.S. the implementation uses code and ideas from the Geode
> engineering
> >> > team
> >> > > and from John Blum ;)
> >> > > --
> >> > > Christian Tzolov  | Data
> Engineer,
> >> > EMEA
> >> > > | Pivotal  | ctzo...@pivotal.io |+31610285517
> >> > <+31%206%2010285517>
> >> > >
> >> >
> >>
> >
> >
> >
> > --
> > -John
> > john.blum10101 (skype)
> >
>
>
>
> --
> -John
> john.blum10101 (skype)
>



-- 
Christian Tzolov  | Data Engineer, EMEA
| Pivotal  | ctzo...@pivotal.io |+31610285517

RE: Geode-Native Windows build

2017-07-13 Thread Daniel Farcovich

Hi Jake and Ernest,

I tried to build from c:\build
Here is the config command and output:

c:\build>cmake  -DCMAKE_INSTALL_PREFIX=C:\build\out -G "Visual Studio 12 2013 
Win64" -Thost=x64 C:\Users\Fdaniel\Source\Repos\geode-native2\src
-- The C compiler identification is MSVC 18.0.21005.1
-- The CXX compiler identification is MSVC 18.0.21005.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 
12.0/VC/bin/amd64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 
12.0/VC/bin/amd64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual 
Studio 12.0/VC/bin/amd64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual 
Studio 12.0/VC/bin/amd64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CFLAGS_M64_ALLOWED
-- Performing Test CFLAGS_M64_ALLOWED - Failed
-- Performing Test CXXFLAGS_M64_ALLOWED
-- Performing Test CXXFLAGS_M64_ALLOWED - Failed
-- Performing Test CFLAGS_mt_ALLOWED
-- Performing Test CFLAGS_mt_ALLOWED - Failed
-- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found suitable 
version "1.8.0.74", minimum required is "1.8.0.60") found components:  
Development
-- Found Geode: 
C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apache-geode\bin\gfsh.bat
 (found suitable version "1.1.1", minimum required is "1.0")
-- Found Doxygen: C:/Program Files/doxygen/bin/doxygen.exe (found suitable 
version "1.8.13", minimum required is "1.6")
-- Found Git: C:/Program Files/Git/cmd/git.exe (found suitable version 
"2.10.2.windows.1", minimum required is "1.7")
-- Looking for include files sys/param.h, sys/mount.h
-- Looking for include files sys/param.h, sys/mount.h - not found
-- Looking for SIGSTKFLT
-- Looking for SIGSTKFLT - not found
-- Looking for SIGPWR
-- Looking for SIGPWR - not found
-- Found Geode: 
C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apache-geode\bin\gfsh.bat
 (found version "1.1.1")
-- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found version 
"1.8.0.74")
-- Found Doxygen: C:/Program Files/doxygen/bin/doxygen.exe (found version 
"1.8.13")
-- Configuring done
-- Generating done

-- Build files have been written to: C:/build


PFA CMakeError.log and CMakeOutput.log after "cmake --build . -- /m"

Thanks,
Daniel

-Original Message-
From: Jacob Barrett [mailto:jbarr...@pivotal.io] 
Sent: Wednesday, July 12, 2017 5:11 PM
To: dev@geode.apache.org
Subject: Re: Geode-Native Windows build

While we wait for your config output there is something else that might bite 
you if it isn't what is biting you now. Some of the third part libraries built 
as part of Geode native have deep directory structures. Your deep directory 
structure to your sources combine with that may result in paths over the 
windows limit. 

Consider using something more shallow on windows, like C:\build. Your source 
can be anywhere since CMake builds are outside the source tree.

-Jake


Sent from my iPhone

> On Jul 12, 2017, at 6:52 AM, Daniel Farcovich  
> wrote:
> 
> Hi,
> I'm failing to build geode native cpp client on windows, although 
> followed the instructions on BUILDING.md Looks like there are slash/backslash 
> fixes should be done in the paths in cmake files.
> After overcoming cmake  failures the build fails on stage "cmake --build . -- 
> /m" with compilation errors for example:
> 
> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
>  error C2144: syntax error : 'bool' should be preceded by ';' 
> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>   cpp) 
> [C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode-static.vcxproj]
> 
> 4>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
>  error C2144: syntax error : 'bool' should be preceded by ';' 
> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>   cpp) 
> [C:\Users\Fdaniel\Source\Repos\geode-native2\build\cppcache\src\apache-geode.vcxproj]
>31>ClCompile:
> 
> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(61)
>  : see reference to class template instantiation 
> 'apache::geode::client::dereference_equal_to>' being 
> compiled
> 4>ClCompile:
> 
> C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(61)
>  : see reference to class template instantiation 
> 'apache::geode::client::dereference_equal_to>' being 
> compiled
>
> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):

Stored procedures on Apache Geode.

2017-07-13 Thread marios390

Hi,

I noticed that Apache Geode supports stored procedures as functions running
on nodes.
Could you please elaborate on that since I am confused a little a bit.
Can I run for example Oracle SP directly on cache servers (nodes) or do I
have to transform them somehow into microservices ( i.e spring boot) which
expose functions on nodes.



--
View this message in context: 
http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/Stored-procedures-on-Apache-Geode-tp24279.html
Sent from the Apache Geode (Incubating) Developers Forum mailing list archive 
at Nabble.com.

58 matches

Mail list logo