[GitHub] geode pull request #325: merge new version

[zmyer]

Github user zmyer closed the pull request at:

https://github.com/apache/geode/pull/325


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #744: GEODE-3522: create via load needs to add event to A...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/744


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Passed: apache/geode#3695 (rel/v1.2.1.RC1 - 1bb1cae)

[Travis CI]

Build Update for apache/geode
-

Build: #3695
Status: Passed

Duration: 22 minutes and 19 seconds
Commit: 1bb1cae (rel/v1.2.1.RC1)
Author: Karen Miller
Message: GEODE-3249 Document geode.allow-internal-messages-without-credentials

This closes #735

(cherry picked from commit d83ba36e8143054f8ce1fab4eec08641de8384f5)

View the changeset: https://github.com/apache/geode/compare/rel/v1.2.1.RC1

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/268529671?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

[GitHub] geode pull request #741: GEODE-3512 Doc removal of gfsh encrypt password

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/741


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #733: Keeping old versions around even during a clean

[upthewaterspout]

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/733
  
Closing this PR, it seems like this isn't the right change. I'm a little 
short on time to mess with this, so if someone else wants to tackle handling 
the download in a nicer way please do. 

Regarding my attempt to use the ivy hack - it looks like what was getting 
in my way was using apache's redirect to the mirrors, but I'm not sure how to 
get around that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #733: Keeping old versions around even during a clean

[upthewaterspout]

Github user upthewaterspout closed the pull request at:

https://github.com/apache/geode/pull/733


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #731: GEODE-2842: Removed redundant default annotation pa...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/731


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #738: GEODE-3506: improve validation/error checking for p...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/738


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #658 was SUCCESSFUL (with 2027 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #658 was successful.
---
Scheduled
2029 tests in total.

https://build.spring.io/browse/SGF-NAG-658/





--
This message is automatically generated by Atlassian Bamboo

Re: [Discuss] Enable region set operations to start JTA transactions

[Anilkumar Gingade]

+1 Having a consistent behavior for set operation within the transaction
(wherever its invoked). And having a gemfire property to allow old way.

On Fri, Aug 25, 2017 at 2:49 PM, Eric Shu  wrote:

> Hi Team,
>
> Currently in GEODE JTA implementation, if GEODE transaction is not yet
> bootstrapped (there is no TXState created yet for the transaction), region
> set operations will not bootstrap the JTA transaction. In other word, if
> the first operation of the JTA transaction is region set operation, the set
> is not in a transactional view (TXState). However, if the JTA
> UserTransaction has been bootstrapped (first operation is a get or put
> operation, etc), the following region set operation is transactional (in
> TXState). To some users, this seems to be a bug. Please see the GEODE
> ticket (https://issues.apache.org/jira/browse/GEODE-3521).
>
> Although we intentionally implemented this way to alleviate the memory
> requirements for users (each transaction will have a new copy of region
> data put into TXState but not if the set op is the first op), we think the
> new user has a valid point as well. We propose to allow region set op to
> bootstrap the transaction. To allow backward compatibility, we will
> introduce a new GemFire property to allow the old behavior.
>
> The question is what should be a default behavior. Do we allow region set
> op to bootstrap transaction as default? If so, existing customers need to
> set the new property to get the old behavior. Or we maintain the old
> behavior, and require the new users to set the property.
>
> Please comment if you have any suggestions.
>
> Thanks,
> Eric
>

[VOTE] Apache Geode release - v1.2.1 RC1

[Anthony Baker]

This is the first release candidate for Apache Geode, version 1.2.1.
Thanks to all the community members for their contributions to this
release!

*** Please download, test and vote by Wednesday, August 25, 0800 hrs
US Pacific. ***

It fixes the following issues:
  
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420=12341124

Note that we are voting upon the source tags:  rel/v1.2.1.RC1
  
https://git-wip-us.apache.org/repos/asf?p=geode.git;a=commit;h=1bb1cae34814bdca298e476f8b88d19e4bc0dd51
  
https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;a=commit;h=5d034de588a43cdefb8fbb3a6259579785768340

Commit ID:
  1bb1cae34814bdca298e476f8b88d19e4bc0dd51 (geode)
  5d034de588a43cdefb8fbb3a6259579785768340 (geode-examples)

Source and binary files:
  https://dist.apache.org/repos/dist/dev/geode/1.2.1.RC1

Maven staging repo:
  https://repository.apache.org/content/repositories/orgapachegeode-1021

Geode's KEYS file containing PGP keys we use to sign the release:
  
https://git-wip-us.apache.org/repos/asf?p=geode.git;a=blob_plain;f=KEYS;hb=HEAD

pub  4096R/C72CFB64 2015-10-01
  Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64

Anthony

[GitHub] geode pull request #744: GEODE-3522: create via load needs to add event to A...

[ladyVader]

GitHub user ladyVader opened a pull request:

https://github.com/apache/geode/pull/744

GEODE-3522: create via load needs to add event to AEQ under same lock…

… as update to local region

* create via load was invoking handleWANEvent prior to obtaining a lock, 
which allowed rebalance to
  shift the primary between AEQ update and data region update.
* moved call to handleWANEvent from DistributedRegion to BucketRegion to 
synchronize these two actions.

@upthewaterspout, @boglesby

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #744


commit afbfd708185cc7ed82490699c033c40263e4aa76
Author: Lynn Hughes-Godfrey 
Date:   2017-08-25T21:46:17Z

GEODE-3522: create via load needs to add event to AEQ under same lock as 
update to local region

* create via load was invoking handleWANEvent prior to obtaining a lock, 
which allowed rebalance to
  shift the primary between AEQ update and data region update.
* moved call to handleWANEvent from DistributedRegion to BucketRegion to 
synchronize these two actions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Discuss] Enable region set operations to start JTA transactions

[Eric Shu]

Hi Team,

Currently in GEODE JTA implementation, if GEODE transaction is not yet
bootstrapped (there is no TXState created yet for the transaction), region
set operations will not bootstrap the JTA transaction. In other word, if
the first operation of the JTA transaction is region set operation, the set
is not in a transactional view (TXState). However, if the JTA
UserTransaction has been bootstrapped (first operation is a get or put
operation, etc), the following region set operation is transactional (in
TXState). To some users, this seems to be a bug. Please see the GEODE
ticket (https://issues.apache.org/jira/browse/GEODE-3521).

Although we intentionally implemented this way to alleviate the memory
requirements for users (each transaction will have a new copy of region
data put into TXState but not if the set op is the first op), we think the
new user has a valid point as well. We propose to allow region set op to
bootstrap the transaction. To allow backward compatibility, we will
introduce a new GemFire property to allow the old behavior.

The question is what should be a default behavior. Do we allow region set
op to bootstrap transaction as default? If so, existing customers need to
set the new property to get the old behavior. Or we maintain the old
behavior, and require the new users to set the property.

Please comment if you have any suggestions.

Thanks,
Eric

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61701/#review183875
---


Ship it!




Ship It!

- Kirk Lund


On Aug. 24, 2017, 10:02 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61701/
> ---
> 
> (Updated Aug. 24, 2017, 10:02 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Updated tests for changes in the error constructors for ServerState and
> LocatorState.
> 
> Minor spelling corrections.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
>  3a98373938e3de21da6badcf460dae3648218ac6 
>   geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
> 83c1ab533e3dea323a8a99f7002b9464a54dfc25 
>   geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
> ae64691605130c9b212a3a33bb65ae37b28af02b 
>   
> geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
>  409a96dbe416a6f96c2389356b9d823d1adb793f 
>   
> geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherRemoteIntegrationTest.java
>  cc42a53772f3064b800ca1ac1ae894be6c715399 
>   
> geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTest.java
>  733a1082ae9993fbdb646712380af7dcc1cca560 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/GfshStatusCommandsIntegrationTest.java
>  dd5841f4cffca38da07a11f381cf4174d7264349 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  e7f17ef208a1708f385c7c4041affb70fd309a4c 
> 
> 
> Diff: https://reviews.apache.org/r/61701/diff/5/
> 
> 
> Testing
> ---
> 
> Precheckin from earlier ran green.
> 
> 8/23/17: Re-running precheckin with this additional refactoring.
> 
> 8/24/17: Once more around the precheckin merry-go-round
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

Re: Review Request 61860: GEODE-3510: GfshRule displays output from StdError

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61860/
---

(Updated Aug. 25, 2017, 9:12 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Remove getAllOutputLines() and remove an unused file.


Repository: geode


Description
---

GEODE-3510: GfshRule displays output from StdError


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
 47f0304 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsAbstractFunction.java
 cf7c7a2 


Diff: https://reviews.apache.org/r/61860/diff/2/

Changes: https://reviews.apache.org/r/61860/diff/1-2/


Testing
---

Precheckin running


Thanks,

Jared Stewart

[GitHub] geode issue #719: GEODE-3447 Implement client authorization for the new prot...

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/719
  
I'm not suggesting changing the protobuf message.  That seems ok to me.

Since the `StreamAuthenticator` is part of protobuf messaging I think it 
should remain in the `geode-protobuf` module.  Putting it in a public API 
package for RBAC seems like we're leaking abstractions into other parts of the 
codebase.

Am I missing something?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #739: GEODE-3385: Change GetAllRequest to return list of ...

[galen-pivotal]

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/739#discussion_r135351811
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
 ---
@@ -50,26 +53,52 @@
   .makeErrorResponse(ProtocolErrorCode.REGION_NOT_FOUND.codeValue, 
"Region not found"));
 }
 
-try {
-  Set keys = new HashSet<>();
-  for (BasicTypes.EncodedValue key : request.getKeyList()) {
-keys.add(ProtobufUtilities.decodeValue(serializationService, key));
-  }
-  Map results = region.getAll(keys);
-  Set entries = new HashSet<>();
-  for (Map.Entry entry : results.entrySet()) {
-entries.add(
-ProtobufUtilities.createEntry(serializationService, 
entry.getKey(), entry.getValue()));
-  }
-  return 
Success.of(RegionAPI.GetAllResponse.newBuilder().addAllEntries(entries).build());
-} catch (UnsupportedEncodingTypeException ex) {
-  return Failure.of(ProtobufResponseUtilities.makeErrorResponse(
-  ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue, "Encoding not 
supported."));
-} catch (CodecNotRegisteredForTypeException ex) {
-  return Failure.of(ProtobufResponseUtilities.makeErrorResponse(
-  ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue,
-  "Codec error in protobuf deserialization."));
+Map resultsCollection = 
request.getKeyList().stream()
+.map((key) -> processOneMessage(serializationService, region, key))
+.collect(Collectors.partitioningBy(x -> x instanceof 
BasicTypes.Entry));
+RegionAPI.GetAllResponse.Builder responseBuilder = 
RegionAPI.GetAllResponse.newBuilder();
+
+for (Object entry : resultsCollection.get(true)) {
+  responseBuilder.addEntries((BasicTypes.Entry) entry);
+}
+
+for (Object entry : resultsCollection.get(false)) {
+  responseBuilder.addFailures((BasicTypes.KeyedError) entry);
 }
+
+return Success.of(responseBuilder.build());
   }
 
+  private Object processOneMessage(SerializationService 
serializationService, Region region,
+  BasicTypes.EncodedValue key) {
+try {
+  Object decodedKey = 
ProtobufUtilities.decodeValue(serializationService, key);
+  Object value = region.get(decodedKey);
+  return ProtobufUtilities.createEntry(serializationService, 
decodedKey, value);
+} catch (CodecNotRegisteredForTypeException | 
UnsupportedEncodingTypeException ex) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  
.setErrorCode(ProtocolErrorCode.VALUE_ENCODING_ERROR.codeValue)
+  .setMessage("Encoding not supported."))
+  .build();
+} catch (org.apache.geode.distributed.LeaseExpiredException | 
TimeoutException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  .setErrorCode(ProtocolErrorCode.OPERATION_TIMEOUT.codeValue)
+  .setMessage("Operation timed out: " + e.getMessage()))
+  .build();
+} catch (CacheLoaderException | PartitionedRegionStorageException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  .setErrorCode(ProtocolErrorCode.DATA_UNREACHABLE.codeValue)
+  .setMessage("Data unreachable: " + e.getMessage()))
+  .build();
+} catch (NullPointerException | IllegalArgumentException e) {
+  return BasicTypes.KeyedError.newBuilder().setKey(key)
+  .setError(BasicTypes.Error.newBuilder()
+  
.setErrorCode(ProtocolErrorCode.CONSTRAINT_VIOLATION.codeValue)
+  .setMessage("Invalid input: " + e.getMessage()))
+  .build();
--- End diff --

👍 I think we should do this as part of a bigger refactor commit. Most of 
the message handlers build manually rather than using 
`ProtobufResponseUtilities.createAndLogErrorResponse`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #719: GEODE-3447 Implement client authorization for the new prot...

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/719
  
@metatype We need the `StreamAuthenticator` to receive and send 
(Protobuf-encoded) messages containing the credentials that get passed to the 
`SecurityManager`. I would think that ideally it's nothing more than this.

I wonder if it would be better to send a hash that gets put into the 
Properties that SecurityManager uses, rather than having a message that 
explicitly contains username and password.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61860: GEODE-3510: GfshRule displays output from StdError

[Jared Stewart]

> On Aug. 24, 2017, 9:29 p.m., Kirk Lund wrote:
> > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
> > Lines 96 (patched)
> > 
> >
> > I'm curious, what's the result of this method? Does in interleave 
> > stdout and stderr in someway?
> > 
> > Another alternative is to use ProcessBuilder.redirectErrorStream so 
> > they become interleaved chronologically. The downside is you can't 
> > differentiate between the two. But there's probably some other way to 
> > synchronize the two chronologically using a stream tee or union.

I'll remove this method for now until I have a better implementation.


- Jared


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61860/#review183798
---


On Aug. 23, 2017, 8:18 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61860/
> ---
> 
> (Updated Aug. 23, 2017, 8:18 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3510: GfshRule displays output from StdError
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
>  47f030471a988055400a71e5b564f3b24397c2e8 
> 
> 
> Diff: https://reviews.apache.org/r/61860/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 61895: GEDOE-3516: TXManagerImpl.tryResume call may add itself again into the waiting thread queue

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61895/#review183871
---




geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java
Line 1302 (original), 1302 (patched)


Lets not make this package protection for unit test access. Instead keep it 
private and add an accessor for the unit tests. Also try to not expose the 
whole map to unit tests. For example in this case the unit test just needs to 
check that no threads are still waiting for a particular txid.



geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java
Lines 1346 (patched)


Instead of fixing this in the finally block we decided it would be best to 
keep this thread from adding itself multiple times to the queue. Also we think 
other race conditions exist in which the while loop that calls tryResume does 
not recheck if the tx still exists. Also it seems like a race exists in which 
suspend unparks a tryResume call that ends up not resuming because of the 
timeout but does not poll the queue again and unpark the next waiter.


- Darrel Schneider


On Aug. 25, 2017, 9:53 a.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61895/
> ---
> 
> (Updated Aug. 25, 2017, 9:53 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Nick Reich.
> 
> 
> Bugs: GEODE-3516
> https://issues.apache.org/jira/browse/GEODE-3516
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Remove the thread from waiting thread queue after successfully resumed the 
> transaction
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java 
> a0a4d7c 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/TXManagerImplJUnitTest.java
>  a2c1e70 
> 
> 
> Diff: https://reviews.apache.org/r/61895/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Broken: apache/geode#3691 (develop - 4ea83c3)

[Travis CI]

Build Update for apache/geode
-

Build: #3691
Status: Broken

Duration: 9 minutes and 57 seconds
Commit: 4ea83c3 (develop)
Author: Kirk Lund
Message: GEODE-3461: GEODE-3505: mark test with FlakyTest category

* also increase timeout to wait for process to die

View the changeset: 
https://github.com/apache/geode/compare/d775dfb3b68e...4ea83c373ac6

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/268450421?utm_source=email_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: Review Request 61895: GEDOE-3516: TXManagerImpl.tryResume call may add itself again into the waiting thread queue

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61895/
---

(Updated Aug. 25, 2017, 4:53 p.m.)


Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
and Nick Reich.


Changes
---

Add a unit test for the fix


Bugs: GEODE-3516
https://issues.apache.org/jira/browse/GEODE-3516


Repository: geode


Description
---

Remove the thread from waiting thread queue after successfully resumed the 
transaction


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java 
a0a4d7c 
  
geode-core/src/test/java/org/apache/geode/internal/cache/TXManagerImplJUnitTest.java
 a2c1e70 


Diff: https://reviews.apache.org/r/61895/diff/2/

Changes: https://reviews.apache.org/r/61895/diff/1-2/


Testing
---

precheckin.


Thanks,

Eric Shu

Jenkins build is back to normal : Geode-nightly-flaky #102

[Apache Jenkins Server]

See