[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #1044 was SUCCESSFUL (with 2456 tests)

2018-09-18 Thread Spring CI 

---
Spring Data GemFire > Nightly-ApacheGeode > #1044 was successful.
---
Scheduled
2458 tests in total.

https://build.spring.io/browse/SGF-NAG-1044/





--
This message is automatically generated by Atlassian Bamboo

Re: [VOTE] Apache Geode 1.7.0 RC1

2018-09-18 Thread Dan Smith 
+0

I noticed that someone added some files called "out" to the repo that
aren't included in the source distribution:

./ci/resource-types/gce-instances-resource/out
./ci/resource-types/concourse-metadata-resource/files/out

These aren't included in the source distribution because we are explicitly
excluding anything called "out." Presumably we thought anything called out
is an output directory ("out" is also in .gitignore). So the ci directory
in the source distribution is incomplete. But maybe that doesn't matter
because it is just CI configuration?

Everything else looks good.

-Dan

On Mon, Sep 17, 2018 at 5:06 PM, Nabarun Nag  wrote:

> *DEADLINE :* Kindly complete your vote by Wednesday, 19th September 2018.
> End of day PDT.
>
> Following checks completed:
>
> - checked signatures
> - checked sha’s
> - builds from source
> - run gfsh - start locator, server - create region - do put and get -
> execute OQL query
> - examples run cleanly
>
>  @John Blum  , I was looking into the mail chain for
> Apache Geode 1.5.0 RC and I saw that you had some concerns regarding SD
> Geode's behavior with the changes made to Log4j in Apache Geode. In this
> release, too we have made some upgrades to log4j and we would to hear your
> feedback / get a green light on these changes.
>
> Regards
> Nabarun Nag
>
>
>
> On Fri, Sep 14, 2018 at 2:50 PM Nabarun Nag  wrote:
>
> > Correction :
> > Please note that we are voting upon the source tags: rel/v1.7.0.RC1
> >
> > On Fri, Sep 14, 2018 at 2:49 PM Nabarun Nag  wrote:
> >
> >> This is the first release candidate for Apache Geode, version 1.7.0.
> >> Thanks to all the community members for their contributions to this
> >> release!
> >>
> >> Please do review and give your feedback.
> >>
> >> It resolves 351 issues on Apache Geode JIRA system. Release notes can be
> >> found at:
> >> https://cwiki.apache.org/confluence/display/GEODE/
> >> Release+Notes#ReleaseNotes-1.7.0
> >>
> >>
> >> Please note that we are voting upon the source tags: rel/v1.6.0.RC1
> >> Apache Geode:
> >> https://github.com/apache/geode/tree/rel/v1.7.0.RC1
> >> Apache Geode examples:
> >> https://github.com/apache/geode-examples/tree/rel/v1.7.0.RC1
> >>
> >> Commit ID:
> >> Apache Geode:
> >> f9abdeb489c9278f96afd37f72a7a9d14cb0f154
> >> Apache Geode Examples:
> >> 9dca29c7c10fa8d44abc893271420476cfc0808f
> >>
> >>
> >> Source and binary files:
> >> https://dist.apache.org/repos/dist/dev/geode/1.7.0.RC1/
> >>
> >> Maven staging repo:
> >> https://repository.apache.org/content/repositories/orgapachegeode-1042
> >>
> >> Geode's KEYS file containing PGP keys we use to sign the release:
> >> https://github.com/apache/geode/blob/develop/KEYS
> >>
> >> Signed the release with fingerprint:
> >> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
> >> CE6CD0A89480B1B9FCB98699274C66710770C135
> >>
> >> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
> >>
> >> I do apologize if there was an oversight.
> >>
> >> Regards
> >> Nabarun Nag
> >>
> >
>

Re: [VOTE] Apache Geode 1.7.0 RC1

2018-09-18 Thread Dave Barnes 
+1
Downloaded, ran some gfsh commands, opened & browsed javadocs.

On Tue, Sep 18, 2018 at 2:16 PM, Jinmei Liao  wrote:

> +1 downloaded the distribution, ran gfsh and execute random gfsh commands
> and verified pulse.
>
> On Tue, Sep 18, 2018 at 1:36 PM Ryan McMahon  wrote:
>
> > +1
> >
> > - Read release notes and verified no incorrect/misspelled content
> > - Verified clean build from source
> > - Built and ran all geode-examples
> >
> > Ryan
> >
> >
> >
> > On Mon, Sep 17, 2018 at 5:33 PM, Anthony Baker 
> wrote:
> >
> > > +1
> > >
> > > Reviewed LICENSE and NOTICE*
> > > Verified signatures and hashes
> > > Checked source releases for binaries
> > > Verified that source releases build successfully
> > > Confirmed that geode-examples run correctly
> > > Verified GitHub tag
> > >
> > > Anthony
> > >
> > > * I found a few places that need copyright date updates and will tweak
> > > those for the next release
> > >
> > >
> > > > On Sep 17, 2018, at 5:06 PM, Nabarun Nag  wrote:
> > > >
> > > > *DEADLINE :* Kindly complete your vote by Wednesday, 19th September
> > 2018.
> > > > End of day PDT.
> > > >
> > > > Following checks completed:
> > > >
> > > > - checked signatures
> > > > - checked sha’s
> > > > - builds from source
> > > > - run gfsh - start locator, server - create region - do put and get -
> > > > execute OQL query
> > > > - examples run cleanly
> > > >
> > > > @John Blum  , I was looking into the mail chain
> for
> > > > Apache Geode 1.5.0 RC and I saw that you had some concerns regarding
> SD
> > > > Geode's behavior with the changes made to Log4j in Apache Geode. In
> > this
> > > > release, too we have made some upgrades to log4j and we would to hear
> > > your
> > > > feedback / get a green light on these changes.
> > > >
> > > > Regards
> > > > Nabarun Nag
> > > >
> > > >
> > > >
> > > > On Fri, Sep 14, 2018 at 2:50 PM Nabarun Nag  wrote:
> > > >
> > > >> Correction :
> > > >> Please note that we are voting upon the source tags: rel/v1.7.0.RC1
> > > >>
> > > >> On Fri, Sep 14, 2018 at 2:49 PM Nabarun Nag 
> wrote:
> > > >>
> > > >>> This is the first release candidate for Apache Geode, version
> 1.7.0.
> > > >>> Thanks to all the community members for their contributions to this
> > > >>> release!
> > > >>>
> > > >>> Please do review and give your feedback.
> > > >>>
> > > >>> It resolves 351 issues on Apache Geode JIRA system. Release notes
> can
> > > be
> > > >>> found at:
> > > >>> https://cwiki.apache.org/confluence/display/GEODE/
> > > >>> Release+Notes#ReleaseNotes-1.7.0
> > > >>>
> > > >>>
> > > >>> Please note that we are voting upon the source tags: rel/v1.6.0.RC1
> > > >>> Apache Geode:
> > > >>> https://github.com/apache/geode/tree/rel/v1.7.0.RC1
> > > >>> Apache Geode examples:
> > > >>> https://github.com/apache/geode-examples/tree/rel/v1.7.0.RC1
> > > >>>
> > > >>> Commit ID:
> > > >>> Apache Geode:
> > > >>> f9abdeb489c9278f96afd37f72a7a9d14cb0f154
> > > >>> Apache Geode Examples:
> > > >>> 9dca29c7c10fa8d44abc893271420476cfc0808f
> > > >>>
> > > >>>
> > > >>> Source and binary files:
> > > >>> https://dist.apache.org/repos/dist/dev/geode/1.7.0.RC1/
> > > >>>
> > > >>> Maven staging repo:
> > > >>>
> > https://repository.apache.org/content/repositories/orgapachegeode-1042
> > > >>>
> > > >>> Geode's KEYS file containing PGP keys we use to sign the release:
> > > >>> https://github.com/apache/geode/blob/develop/KEYS
> > > >>>
> > > >>> Signed the release with fingerprint:
> > > >>> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
> > > >>> CE6CD0A89480B1B9FCB98699274C66710770C135
> > > >>>
> > > >>> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
> > > >>>
> > > >>> I do apologize if there was an oversight.
> > > >>>
> > > >>> Regards
> > > >>> Nabarun Nag
> > > >>>
> > > >>
> > >
> > >
> >
>
>
> --
> Cheers
>
> Jinmei
>

Re: [VOTE] Apache Geode 1.7.0 RC1

2018-09-18 Thread Jinmei Liao 
+1 downloaded the distribution, ran gfsh and execute random gfsh commands
and verified pulse.

On Tue, Sep 18, 2018 at 1:36 PM Ryan McMahon  wrote:

> +1
>
> - Read release notes and verified no incorrect/misspelled content
> - Verified clean build from source
> - Built and ran all geode-examples
>
> Ryan
>
>
>
> On Mon, Sep 17, 2018 at 5:33 PM, Anthony Baker  wrote:
>
> > +1
> >
> > Reviewed LICENSE and NOTICE*
> > Verified signatures and hashes
> > Checked source releases for binaries
> > Verified that source releases build successfully
> > Confirmed that geode-examples run correctly
> > Verified GitHub tag
> >
> > Anthony
> >
> > * I found a few places that need copyright date updates and will tweak
> > those for the next release
> >
> >
> > > On Sep 17, 2018, at 5:06 PM, Nabarun Nag  wrote:
> > >
> > > *DEADLINE :* Kindly complete your vote by Wednesday, 19th September
> 2018.
> > > End of day PDT.
> > >
> > > Following checks completed:
> > >
> > > - checked signatures
> > > - checked sha’s
> > > - builds from source
> > > - run gfsh - start locator, server - create region - do put and get -
> > > execute OQL query
> > > - examples run cleanly
> > >
> > > @John Blum  , I was looking into the mail chain for
> > > Apache Geode 1.5.0 RC and I saw that you had some concerns regarding SD
> > > Geode's behavior with the changes made to Log4j in Apache Geode. In
> this
> > > release, too we have made some upgrades to log4j and we would to hear
> > your
> > > feedback / get a green light on these changes.
> > >
> > > Regards
> > > Nabarun Nag
> > >
> > >
> > >
> > > On Fri, Sep 14, 2018 at 2:50 PM Nabarun Nag  wrote:
> > >
> > >> Correction :
> > >> Please note that we are voting upon the source tags: rel/v1.7.0.RC1
> > >>
> > >> On Fri, Sep 14, 2018 at 2:49 PM Nabarun Nag  wrote:
> > >>
> > >>> This is the first release candidate for Apache Geode, version 1.7.0.
> > >>> Thanks to all the community members for their contributions to this
> > >>> release!
> > >>>
> > >>> Please do review and give your feedback.
> > >>>
> > >>> It resolves 351 issues on Apache Geode JIRA system. Release notes can
> > be
> > >>> found at:
> > >>> https://cwiki.apache.org/confluence/display/GEODE/
> > >>> Release+Notes#ReleaseNotes-1.7.0
> > >>>
> > >>>
> > >>> Please note that we are voting upon the source tags: rel/v1.6.0.RC1
> > >>> Apache Geode:
> > >>> https://github.com/apache/geode/tree/rel/v1.7.0.RC1
> > >>> Apache Geode examples:
> > >>> https://github.com/apache/geode-examples/tree/rel/v1.7.0.RC1
> > >>>
> > >>> Commit ID:
> > >>> Apache Geode:
> > >>> f9abdeb489c9278f96afd37f72a7a9d14cb0f154
> > >>> Apache Geode Examples:
> > >>> 9dca29c7c10fa8d44abc893271420476cfc0808f
> > >>>
> > >>>
> > >>> Source and binary files:
> > >>> https://dist.apache.org/repos/dist/dev/geode/1.7.0.RC1/
> > >>>
> > >>> Maven staging repo:
> > >>>
> https://repository.apache.org/content/repositories/orgapachegeode-1042
> > >>>
> > >>> Geode's KEYS file containing PGP keys we use to sign the release:
> > >>> https://github.com/apache/geode/blob/develop/KEYS
> > >>>
> > >>> Signed the release with fingerprint:
> > >>> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
> > >>> CE6CD0A89480B1B9FCB98699274C66710770C135
> > >>>
> > >>> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
> > >>>
> > >>> I do apologize if there was an oversight.
> > >>>
> > >>> Regards
> > >>> Nabarun Nag
> > >>>
> > >>
> >
> >
>


-- 
Cheers

Jinmei

Re: [VOTE] Apache Geode 1.7.0 RC1

2018-09-18 Thread Ryan McMahon 
+1

- Read release notes and verified no incorrect/misspelled content
- Verified clean build from source
- Built and ran all geode-examples

Ryan



On Mon, Sep 17, 2018 at 5:33 PM, Anthony Baker  wrote:

> +1
>
> Reviewed LICENSE and NOTICE*
> Verified signatures and hashes
> Checked source releases for binaries
> Verified that source releases build successfully
> Confirmed that geode-examples run correctly
> Verified GitHub tag
>
> Anthony
>
> * I found a few places that need copyright date updates and will tweak
> those for the next release
>
>
> > On Sep 17, 2018, at 5:06 PM, Nabarun Nag  wrote:
> >
> > *DEADLINE :* Kindly complete your vote by Wednesday, 19th September 2018.
> > End of day PDT.
> >
> > Following checks completed:
> >
> > - checked signatures
> > - checked sha’s
> > - builds from source
> > - run gfsh - start locator, server - create region - do put and get -
> > execute OQL query
> > - examples run cleanly
> >
> > @John Blum  , I was looking into the mail chain for
> > Apache Geode 1.5.0 RC and I saw that you had some concerns regarding SD
> > Geode's behavior with the changes made to Log4j in Apache Geode. In this
> > release, too we have made some upgrades to log4j and we would to hear
> your
> > feedback / get a green light on these changes.
> >
> > Regards
> > Nabarun Nag
> >
> >
> >
> > On Fri, Sep 14, 2018 at 2:50 PM Nabarun Nag  wrote:
> >
> >> Correction :
> >> Please note that we are voting upon the source tags: rel/v1.7.0.RC1
> >>
> >> On Fri, Sep 14, 2018 at 2:49 PM Nabarun Nag  wrote:
> >>
> >>> This is the first release candidate for Apache Geode, version 1.7.0.
> >>> Thanks to all the community members for their contributions to this
> >>> release!
> >>>
> >>> Please do review and give your feedback.
> >>>
> >>> It resolves 351 issues on Apache Geode JIRA system. Release notes can
> be
> >>> found at:
> >>> https://cwiki.apache.org/confluence/display/GEODE/
> >>> Release+Notes#ReleaseNotes-1.7.0
> >>>
> >>>
> >>> Please note that we are voting upon the source tags: rel/v1.6.0.RC1
> >>> Apache Geode:
> >>> https://github.com/apache/geode/tree/rel/v1.7.0.RC1
> >>> Apache Geode examples:
> >>> https://github.com/apache/geode-examples/tree/rel/v1.7.0.RC1
> >>>
> >>> Commit ID:
> >>> Apache Geode:
> >>> f9abdeb489c9278f96afd37f72a7a9d14cb0f154
> >>> Apache Geode Examples:
> >>> 9dca29c7c10fa8d44abc893271420476cfc0808f
> >>>
> >>>
> >>> Source and binary files:
> >>> https://dist.apache.org/repos/dist/dev/geode/1.7.0.RC1/
> >>>
> >>> Maven staging repo:
> >>> https://repository.apache.org/content/repositories/orgapachegeode-1042
> >>>
> >>> Geode's KEYS file containing PGP keys we use to sign the release:
> >>> https://github.com/apache/geode/blob/develop/KEYS
> >>>
> >>> Signed the release with fingerprint:
> >>> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
> >>> CE6CD0A89480B1B9FCB98699274C66710770C135
> >>>
> >>> rsa4096 2018-01-04 [SC] [expires: 2022-01-04]
> >>>
> >>> I do apologize if there was an oversight.
> >>>
> >>> Regards
> >>> Nabarun Nag
> >>>
> >>
>
>

Re: Need gradle help

2018-09-18 Thread Kirk Lund 
It's working now, thanks! I also added test-sources so it's easier to link
the source code for studying their code while working on it:

+  integrationTestCompile 'org.apache.logging.log4j:log4j-core:' +
project.'log4j.version' + ':tests'

+  integrationTestCompile 'org.apache.logging.log4j:log4j-core:' +
project.'log4j.version' + ':test-sources'

The gradle classifier isn't quite the same as maven type. Gradle doesn't
seem to have dependency types, and maven seems to provide a type to string
mapping which is defined in the pom for the project.


On Mon, Sep 17, 2018 at 9:36 AM, Sai Boorlagadda 
wrote:

> It looks[1] like it is been renamed as 'tests', so you can try
>
> testCompile 'org.apache.logging.log4j:log4j-core:' +
> project.'log4j.version' + ':tests'
>
> [1]
> https://repo.maven.apache.org/maven2/org/apache/logging/
> log4j/log4j-core/2.11.0/
>
> On Fri, Sep 14, 2018 at 5:17 PM Jacob Barrett  wrote:
>
> > The concatenation is missing a : in front of the test-jar.
> >
> > > On Sep 14, 2018, at 4:10 PM, Kirk Lund  wrote:
> > >
> > > Log4j2 publishes a test jar for log4j-core. The jar includes useful
> > things
> > > like LoggerContextRule.
> > >
> > > This blog post shows how to add the dependency for testing to maven:
> > > https://relentlesscoding.com/2018/04/21/unit-test-log4j2-log-output/
> > >
> > > This results look like this:
> > >
> > > 
> > >org.apache.logging.log4j
> > >log4j-core
> > >2.11.0
> > >test-jar
> > > 
> > >
> > > And these various stackoverflow questions talk about using Gradle's "
> > > classifier" instead of "type":
> > > *
> > >
> > https://stackoverflow.com/questions/20224260/how-do-i-
> pull-maven-test-jars-using-gradle
> > > *
> > >
> > https://stackoverflow.com/questions/13188438/how-to-
> specify-a-classifier-in-a-gradle-dependencys-dependency
> > >
> > > This gradle man page discusses the "classifier" further:
> > > *
> > >
> > https://docs.gradle.org/current/userguide/declaring_
> dependencies.html#sub:resolve_specific_artifacts_from_dependency
> > >
> > > I've tried adding:
> > >
> > > +  compile 'org.apache.logging.log4j:log4j-core:' +
> > project.'log4j.version'
> > > + 'test-jar'
> > >
> > > +  testCompile 'org.apache.logging.log4j:log4j-core:' +
> > > project.'log4j.version' + 'test-jar'
> > >
> > > +  integrationTestCompile 'org.apache.logging.log4j:log4j-core:' +
> > > project.'log4j.version' + 'test-jar'
> > >
> > > ...too geode-core/build.gradle. The result builds but if I then try to
> > use
> > > any classes from the test jar I have no luck. If I check Project
> > Structure
> > > in IntelliJ after making sure that my project re synced from gradle,
> sure
> > > enough the test jar is still missing from the dependencies.
> > >
> > > According to Gradle and SO, this should work. Is the problem our gradle
> > > mess? Does anyone know how to get this working in the Geode gradle
> build?
> >
>

Re: Steps to follow after becoming a Geode committer

2018-09-18 Thread Kirk Lund 
I reviewed your changes and added approval. Thanks Juan!

On Tue, Sep 18, 2018 at 12:46 AM, Juan José Ramos  wrote:

> Hello Jinmei and Dan,
>
> Thanks both for the reply!!.
> Regarding pull 2250, I think the changes requested by Galen are outdated
> now, but I'll ping him directly in the *pull request * anyway to be sure.
> Best regards.
>
>
> On Mon, Sep 17, 2018 at 5:37 PM Dan Smith  wrote:
>
> > Hi Juan,
> >
> > Great questions! I agree with what Jinmei said - go ahead and merge if
> you
> > have:
> >
> > 1) at least one approval
> > 2) No changes requested
> > 3) Checks are passing
> >
> > The "at least one review" part is somewhat subjective, if you feel the PR
> > is complicated and you want more reviews, feel free to ask the list for
> > more feedback.
> >
> > I see https://github.com/apache/geode/pull/2250 has one reviewer
> > requesting
> > changes. You should look into the suggestions, or maybe just poke Galen
> if
> > he needs to review your fixes and approve them?
> >
> > -Dan
> >
> > On Mon, Sep 17, 2018 at 6:45 AM, Jinmei Liao  wrote:
> >
> > > I believe you can go ahead. :-)
> > >
> > > The way I see it, you can merge a PR when all three are satisfied:
> > > 1) you have the privilege to merge it (the button is activated for you
> to
> > > push).
> > > 2) The PR is approved by a least one reviewer.
> > > 3) all checks passed.
> > >
> > > Thanks!
> > >
> > >
> > > On Mon, Sep 17, 2018, 3:48 AM Ju@N  wrote:
> > >
> > > > Hello all,
> > > >
> > > > My apache account is already created and everything seems to be
> working
> > > > just fine, I've already linked my account through
> > > > https://gitbox.apache.org/setup/ and I can see the option *Merge
> pull
> > > > request* in the *GitHub* interface (disabled in the past when I
> didn't
> > > have
> > > > commit privileges on the project).
> > > > I have two old pull requests (2376
> > > >  for GEODE-5353
> > > >  and 2250
> > > >  for GEODE-5314
> > > > ) already approved
> > by
> > > > other committers, am I ready to go and merge them myself?, or should
> I
> > > wait
> > > > for an announcement or something else?. I've already gone through
> > > Becoming
> > > > a Committer
> > > > <
> > https://cwiki.apache.org/confluence/display/GEODE/Becoming+a+committer>
> > > >  and Code Contributions
> > > >  contributions>
> > > but
> > > > couldn't find a definitive answer about how/when to merge a *pull
> > > > request* opened
> > > > by yourself when you're a committer, how does this process work?,
> > should
> > > I
> > > > ask in this list for reviews before merging the changes?, should I
> > wait X
> > > > amount of days before asking for reviewers?, etc.
> > > > As a side note, I've received an email from *r...@apache.org
> > > > * with a link to the vote reference in the
> > > > *private.apache.geode.org
> > > > * list. I believe that list is
> only
> > > for
> > > > *PMC* members, so I don't (and won't) have access to that list, am I
> > > > right?.
> > > > Sorry for the long email and the amount of questions, just trying to
> > make
> > > > sure I get things right from the very beginning :-).
> > > > Best regards.
> > > >
> > > > --
> > > > Ju@N
> > > >
> > >
> >
>
>
> --
> Juan José Ramos Cassella
> Senior Technical Support Engineer
> Email: jra...@pivotal.io
> Office#: +353 21 4238611
> Mobile#: +353 87 2074066
> After Hours Contact#: +1 877 477 2269
> Office Hours: Mon - Thu 08:30 - 17:00 GMT. Fri 08:30 - 16:00 GMT
> How to upload artifacts:
> https://support.pivotal.io/hc/en-us/articles/204369073
> How to escalate a ticket:
> https://support.pivotal.io/hc/en-us/articles/203809556
>
> [image: support]  [image: twitter]
>  [image: linkedin]
>  [image: facebook]
>  [image: google plus]
>  [image: youtube]
> 
>

Re: Steps to follow after becoming a Geode committer

2018-09-18 Thread Juan José Ramos 
Hello Jinmei and Dan,

Thanks both for the reply!!.
Regarding pull 2250, I think the changes requested by Galen are outdated
now, but I'll ping him directly in the *pull request * anyway to be sure.
Best regards.


On Mon, Sep 17, 2018 at 5:37 PM Dan Smith  wrote:

> Hi Juan,
>
> Great questions! I agree with what Jinmei said - go ahead and merge if you
> have:
>
> 1) at least one approval
> 2) No changes requested
> 3) Checks are passing
>
> The "at least one review" part is somewhat subjective, if you feel the PR
> is complicated and you want more reviews, feel free to ask the list for
> more feedback.
>
> I see https://github.com/apache/geode/pull/2250 has one reviewer
> requesting
> changes. You should look into the suggestions, or maybe just poke Galen if
> he needs to review your fixes and approve them?
>
> -Dan
>
> On Mon, Sep 17, 2018 at 6:45 AM, Jinmei Liao  wrote:
>
> > I believe you can go ahead. :-)
> >
> > The way I see it, you can merge a PR when all three are satisfied:
> > 1) you have the privilege to merge it (the button is activated for you to
> > push).
> > 2) The PR is approved by a least one reviewer.
> > 3) all checks passed.
> >
> > Thanks!
> >
> >
> > On Mon, Sep 17, 2018, 3:48 AM Ju@N  wrote:
> >
> > > Hello all,
> > >
> > > My apache account is already created and everything seems to be working
> > > just fine, I've already linked my account through
> > > https://gitbox.apache.org/setup/ and I can see the option *Merge pull
> > > request* in the *GitHub* interface (disabled in the past when I didn't
> > have
> > > commit privileges on the project).
> > > I have two old pull requests (2376
> > >  for GEODE-5353
> > >  and 2250
> > >  for GEODE-5314
> > > ) already approved
> by
> > > other committers, am I ready to go and merge them myself?, or should I
> > wait
> > > for an announcement or something else?. I've already gone through
> > Becoming
> > > a Committer
> > > <
> https://cwiki.apache.org/confluence/display/GEODE/Becoming+a+committer>
> > >  and Code Contributions
> > > 
> > but
> > > couldn't find a definitive answer about how/when to merge a *pull
> > > request* opened
> > > by yourself when you're a committer, how does this process work?,
> should
> > I
> > > ask in this list for reviews before merging the changes?, should I
> wait X
> > > amount of days before asking for reviewers?, etc.
> > > As a side note, I've received an email from *r...@apache.org
> > > * with a link to the vote reference in the
> > > *private.apache.geode.org
> > > * list. I believe that list is only
> > for
> > > *PMC* members, so I don't (and won't) have access to that list, am I
> > > right?.
> > > Sorry for the long email and the amount of questions, just trying to
> make
> > > sure I get things right from the very beginning :-).
> > > Best regards.
> > >
> > > --
> > > Ju@N
> > >
> >
>


-- 
Juan José Ramos Cassella
Senior Technical Support Engineer
Email: jra...@pivotal.io
Office#: +353 21 4238611
Mobile#: +353 87 2074066
After Hours Contact#: +1 877 477 2269
Office Hours: Mon - Thu 08:30 - 17:00 GMT. Fri 08:30 - 16:00 GMT
How to upload artifacts:
https://support.pivotal.io/hc/en-us/articles/204369073
How to escalate a ticket:
https://support.pivotal.io/hc/en-us/articles/203809556

[image: support]  [image: twitter]
 [image: linkedin]
 [image: facebook]
 [image: google plus]
 [image: youtube]