Re: [PROPOSAL] RFC for migrating from springfox to springdoc

[Jinmei Liao]

>Does this inactivity demonstrate maturity (i.e. maybe we should remove the 
>@Experimental annotation) or does it indicate a failed or abandoned experiment
Neither, I believe k8s is using the feature, but the inactivity simply means we 
haven’t allocated people to work on it.

From: Owen Nichols 
Date: Thursday, May 5, 2022 at 5:12 PM
To: dev@geode.apache.org 
Subject: Re: [PROPOSAL] RFC for migrating from springfox to springdoc
It would be great to make the switch to springdoc.  If you are willing, go for 
it!

Slightly outside the scope of this RFC:
Swagger was added as part of the @Experimental manageability REST API [1] and 
is used to generate API docs for each minor [2]. It looks like the API hasn’t 
changed much between the last few minors.  Does this inactivity demonstrate 
maturity (i.e. maybe we should remove the @Experimental annotation) or does it 
indicate a failed or abandoned experiment (i.e. should we consider entirely 
removing all code for this feature, following the same reasoning cited for 
removing @Experimental protobuf [3] and @Experimental redis [4])?

[1] 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FGEODE%2FCluster%2BManagement%2BService&data=05%7C01%7Cjiliao%40vmware.com%7Cae01e2275b3a40d5c70d08da2ef50cc9%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637873927270426055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HDE%2BUwR17%2BK5Sf4JqSTjxEwNXmOOVuB7rLN228s4lJc%3D&reserved=0
[2] 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FGEODE%2FCluster%2BManagement%2BService%2BRest%2BAPI&data=05%7C01%7Cjiliao%40vmware.com%7Cae01e2275b3a40d5c70d08da2ef50cc9%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637873927270426055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VQBnhqeSuCBjzx6ltZ0XaRWTlNwNldALSEzYiUj5ZrE%3D&reserved=0
[3] 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apache.org%2Fthread%2Fzt7jphfjqqgkgjn010clq2wqo9vv2z6n&data=05%7C01%7Cjiliao%40vmware.com%7Cae01e2275b3a40d5c70d08da2ef50cc9%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637873927270426055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=sZRbISzjXccpc8t%2FPHh15mFnrsl8vhgkV9%2FUZAhdGK4%3D&reserved=0
[4] 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apache.org%2Fthread%2F7m23h9r0tf536g414bwjsplqh1qv2ct0&data=05%7C01%7Cjiliao%40vmware.com%7Cae01e2275b3a40d5c70d08da2ef50cc9%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637873927270426055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=lJGz01fsA45G%2BHiXg3tl1dGgcPd4HC2p%2FKnq8nwAofE%3D&reserved=0

From: Alexander Murmann 
Date: Thursday, May 5, 2022 at 4:09 PM
To: dev@geode.apache.org 
Subject: Re: [PROPOSAL] RFC for migrating from springfox to springdoc
Thanks for your proposal, Patrick!

I wonder if this even warrants a proposal over a PR. There seems to be neither 
a downside nor a realistic alternative.

From: Patrick Johnson 
Sent: Thursday, May 5, 2022 13:39
To: dev@geode.apache.org 
Subject: [PROPOSAL] RFC for migrating from springfox to springdoc

Hello devs!

Please review this RFC: 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FGEODE%2FMigration%2Bfrom%2Bspringfox%2Bto%2Bspringdoc&data=05%7C01%7Cjiliao%40vmware.com%7Cae01e2275b3a40d5c70d08da2ef50cc9%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637873927270426055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=dUdKtA%2F37oXq6Tt5wEJOWnFcPQzx70JfNs%2BaXJ2QG5E%3D&reserved=0
 on migrating from springfox to springdoc for our swagger needs and provide any 
feedback you have.

Review period until Friday, May 13th.

—Patrick Johnson

Re: [PROPOSAL] RFC for migrating from springfox to springdoc

[Owen Nichols]

It would be great to make the switch to springdoc.  If you are willing, go for 
it!

Slightly outside the scope of this RFC:
Swagger was added as part of the @Experimental manageability REST API [1] and 
is used to generate API docs for each minor [2]. It looks like the API hasn’t 
changed much between the last few minors.  Does this inactivity demonstrate 
maturity (i.e. maybe we should remove the @Experimental annotation) or does it 
indicate a failed or abandoned experiment (i.e. should we consider entirely 
removing all code for this feature, following the same reasoning cited for 
removing @Experimental protobuf [3] and @Experimental redis [4])?

[1] https://cwiki.apache.org/confluence/display/GEODE/Cluster+Management+Service
[2] 
https://cwiki.apache.org/confluence/display/GEODE/Cluster+Management+Service+Rest+API
[3] https://lists.apache.org/thread/zt7jphfjqqgkgjn010clq2wqo9vv2z6n
[4] https://lists.apache.org/thread/7m23h9r0tf536g414bwjsplqh1qv2ct0

From: Alexander Murmann 
Date: Thursday, May 5, 2022 at 4:09 PM
To: dev@geode.apache.org 
Subject: Re: [PROPOSAL] RFC for migrating from springfox to springdoc
Thanks for your proposal, Patrick!

I wonder if this even warrants a proposal over a PR. There seems to be neither 
a downside nor a realistic alternative.

From: Patrick Johnson 
Sent: Thursday, May 5, 2022 13:39
To: dev@geode.apache.org 
Subject: [PROPOSAL] RFC for migrating from springfox to springdoc

Hello devs!

Please review this RFC: 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FGEODE%2FMigration%2Bfrom%2Bspringfox%2Bto%2Bspringdoc&data=05%7C01%7Conichols%40vmware.com%7Cb2503a04cf1b45e6331c08da2eec45bb%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637873889588399147%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=T9N0dXMgG7OYBFL9aPASpklsQ2rDnMbkY2EiVLq%2FfIg%3D&reserved=0
 on migrating from springfox to springdoc for our swagger needs and provide any 
feedback you have.

Review period until Friday, May 13th.

—Patrick Johnson

Re: [PROPOSAL] RFC for migrating from springfox to springdoc

[Anilkumar Gingade]

+1. Thanks for the RFC. Looks good.
Since there is no big impact; does this need to wait till May 13th on this. In 
this case is it good enough to wait for couple of approval. Say, 3 😊

-Anil.


From: Alexander Murmann 
Date: Thursday, May 5, 2022 at 4:09 PM
To: dev@geode.apache.org 
Subject: Re: [PROPOSAL] RFC for migrating from springfox to springdoc
Thanks for your proposal, Patrick!

I wonder if this even warrants a proposal over a PR. There seems to be neither 
a downside nor a realistic alternative.

From: Patrick Johnson 
Sent: Thursday, May 5, 2022 13:39
To: dev@geode.apache.org 
Subject: [PROPOSAL] RFC for migrating from springfox to springdoc

Hello devs!

Please review this RFC: 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FGEODE%2FMigration%2Bfrom%2Bspringfox%2Bto%2Bspringdoc&data=05%7C01%7Cagingade%40vmware.com%7C2ce1ce4542c0451886ed08da2eec3edb%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637873889449292311%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9AUVc8b0Kvs%2BoqKAMp4pC387x3DNfyaFTpIWycMdKNc%3D&reserved=0
 on migrating from springfox to springdoc for our swagger needs and provide any 
feedback you have.

Review period until Friday, May 13th.

—Patrick Johnson

Re: [PROPOSAL] RFC for migrating from springfox to springdoc

[Alexander Murmann]

Thanks for your proposal, Patrick!

I wonder if this even warrants a proposal over a PR. There seems to be neither 
a downside nor a realistic alternative.

From: Patrick Johnson 
Sent: Thursday, May 5, 2022 13:39
To: dev@geode.apache.org 
Subject: [PROPOSAL] RFC for migrating from springfox to springdoc

Hello devs!

Please review this RFC: 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FGEODE%2FMigration%2Bfrom%2Bspringfox%2Bto%2Bspringdoc&data=05%7C01%7Camurmann%40vmware.com%7C48ff71f755ba42678cd008da2ed75b31%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637873799735336667%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2F99oRiToyYEjPVG8Q8sga1dNwU%2FxlVtx9FxwKg7go4Y%3D&reserved=0
 on migrating from springfox to springdoc for our swagger needs and provide any 
feedback you have.

Review period until Friday, May 13th.

—Patrick Johnson

Re: [discuss] Future of the geode-redis module

[Dan Smith]

The PRs to remove this module have been approved merged - from geode, 
geode-benchmarks, and geode-examples.

-Dan

From: Dan Smith 
Sent: Wednesday, May 4, 2022 2:06 PM
To: dev@geode.apache.org 
Subject: Re: [discuss] Future of the geode-redis module

Since it seems there is consensus to remove this module, I created this PR - 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7657&data=05%7C01%7Cdasmith%40vmware.com%7C14930b4554a64bb27a5f08da2e12028a%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637872952170457035%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=l0rohEOfWZASMGmsiq8NCvB%2F1aIN3NbAM45aQdcHS6k%3D&reserved=0.
 If folks approve of this PR there will be additional PRs to geode-benchmarks 
and geode-examples to remove references to this module.

-Dan


From: Alexander Murmann 
Sent: Wednesday, May 4, 2022 11:04 AM
To: dev@geode.apache.org 
Subject: Re: [discuss] Future of the geode-redis module

Hi Donal,

I think Dan, Ray or Jens were going to issue a PR in the next few days that 
would remove the experimental Redis functionality. Given this is not a complex 
architectural change that might warrant deeper discussion, I would expect that 
the voting inherent to the PR would suffice. Especially, given that the 
discussion here seemed very non-controversial.

From: Donal Evans 
Sent: Wednesday, May 4, 2022 09:28
To: dev@geode.apache.org 
Subject: Re: [discuss] Future of the geode-redis module

It's been almost a month since this discussion was started, and all the 
responses have been supportive of the idea. Is this still something that the 
Geode community intends to do? Should there be a [vote] email sent out to 
confirm this course of action?

From: Alexander Murmann 
Sent: Thursday, April 14, 2022 5:15 PM
To: geode 
Subject: [discuss] Future of the geode-redis module

Hi Geode community!

A while ago engineers from VMware started to improve the geode-redis module 
that has been in Geode for several years, but never had been completed. This 
involved adding more tests for existing functionality, as well as adding 
support for more commands.

VMware will not continue this investment in the geode-redis module. While the 
geode-redis module is in a much better place than two years ago there still is 
a lot of work left to make it a viable option for most of our users and the 
module is still in an experimental state.

For the community this poses the question of what we want to do with the 
existing code. This work now has been started and stopped twice. All code comes 
with a maintenance burden which adds 
up.
 Dependencies might need to be updated; flaky tests fixed and it brings 
cognitive overhead for us and our users. Unless someone else in the community 
steps up to take on the task of maintaining the geode-redis module, I propose 
to remove the code from our develop branch and give everyone more bandwidth to 
use elsewhere.

Thank you all in advance for your thoughts

[PROPOSAL] RFC for migrating from springfox to springdoc

[Patrick Johnson]

Hello devs!

Please review this RFC: 
https://cwiki.apache.org/confluence/display/GEODE/Migration+from+springfox+to+springdoc
 on migrating from springfox to springdoc for our swagger needs and provide any 
feedback you have.

Review period until Friday, May 13th.

—Patrick Johnson

[PROPOSAL] RFC Introduce monitoring of async writer thread

[Mario Ivanac]

Hi,

I'd appreciate some more feedback on this published RFC about "Introduce 
monitoring of async writer thread":

https://cwiki.apache.org/confluence/display/GEODE/Introduce+monitoring+of+async+writer+thread

Thanks in advance.
Mario