geode-benchmarks migrate to GH Action
Could someone review and approve this PR? https://github.com/apache/geode-benchmarks/pull/170/files Sai
apiCheck - gradle task japicmp
Could some one explain me what is this gradle task requirement? I see that we are running this japicmp only for JDK 11. Does it build using 11? Sai
Simple build pipeline for develop
All, I would appreciate a review of this PR[1] that adds a GitHub action workflow to build and unit test develop and runs it on every PR to develop. This is just the beginning of this migration work and we would like to merge it as soon as possible. Will follow up with apiCheck and adding windows unit tests. Thanks, Sai [1] https://github.com/apache/geode/pull/7870
Pullrequest required checks
Could someone have info regarding how the required checks are enabled on a Pull Request? In the process of setting up the Github Actions, I see there are still Concourse CI checks as "required" eg: on this PR[1] [1] https://github.com/apache/geode/pull/7870 Thanks Sai
Bad Practice: Static constant values set by system properties
Sai and I worked together yesterday and fixed almost all of the failing unit tests in the new build we're trying to set up. I think we have one failure remaining. Most of the failures we fixed turned out to be caused by new code that was committed to Geode in 2022 that causes values in static constants that are set by system properties breaking later unit tests that will only pass if the constant has the default value. I want to point out that using system properties to set the values in a static constant is definitely an anti-pattern or bad practice that should be avoided going forward. It pollutes the JVM for later unit tests and cannot be unset because constants are defined as final and static. In the coming weeks, I plan to update the Apache Geode wiki to spell out the anti-pattern bad practices that we need to avoid going forward and this will definitely be one of them. Thanks, Kirk
