Starting Pulse with non default credentials

2017-10-30 Thread Amey Barve 
Hello All,

I want to start Pulse with non default credentials, i.e *no admin*.
Here are the steps that I have followed :

1. mkdir /tools/workspace/geode/pulse-config

2. export CLASSPATH=$CLASSPATH:/tools/workspace/geode/pulse-config

3. touch /tools/workspace/geode/pulse-config/pulse-authentication-custom.xml

Details of the pulse-authentication-custom.xml

http://www.springframework.org/schema/security;
 xmlns:beans="http://www.springframework.org/schema/beans;
 xmlns:context="http://www.springframework.org/schema/context;
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
 xsi:schemaLocation="http://www.springframework.org/schema/beans
http://www.springframework.org/schema/beans/spring-beans-4.1.xsd
   http://www.springframework.org/schema/security

http://www.springframework.org/schema/security/spring-security-4.1.xsd
   http://www.springframework.org/schema/context
http://www.springframework.org/schema/context/spring-context-4.1.xsd;>










4. touch /tools/workspace/geode/pulse-config/pulse-users.properties

Details of the pulse-users.properties

*amey*=*ameypassword*,ROLE_USER,enabled

gfsh>start locator --name=loc
--J=-Dspring.profiles.active=pulse.authentication.custom
--classpath=/tools/workspace/geode/pulse-config

gfsh>start pulse


With these settings I try to login to Pulse using *amey* as Username and
*ameypassword* as Password, I get below exception.

http://localhost:7070/pulse/Login.html?error=BAD_CREDS
Incorrect Username or password

Please let me know if anything is wrong in the procedure followed above, or
how to set non admin credentials when starting Pulse ?

Regards,
Amey

Re: New Committer And PMC Member: Joey McAllister

2017-07-25 Thread Amey Barve 
Welcome Joey and Congratulations!

Regards,
Amey

On Wed, Jul 26, 2017 at 1:08 AM, Joey McAllister 
wrote:

> Thanks, everyone!
>
> [drum solos; throws sticks to Fred]
>
>
> On Tue, Jul 25, 2017 at 12:36 PM Nitin Lamba  wrote:
>
> > Welcome Joey!
> >
> > On Tue, Jul 25, 2017 at 12:21 PM, Fred Krone  wrote:
> >
> > > Drum solo!
> > >
> > > On Tue, Jul 25, 2017 at 12:05 PM, Anthony Baker 
> > wrote:
> > >
> > > > Welcome Joey!
> > > >
> > > > > On Jul 25, 2017, at 11:58 AM, Mark Bretl 
> wrote:
> > > > >
> > > > > The Apache Geode Project Management Committee has invited Joey
> > > > McAllister to
> > > > > be committer on the project and join the Geode PMC. We are pleased
> to
> > > > > announce he has accepted.
> > > > >
> > > > > Please join me in welcoming Joey!
> > > > >
> > > > > Best regards,
> > > > >
> > > > > Mark
> > > > > On behalf of the Apache Geode PMC
> > > >
> > > >
> > >
> >
>

Re: New Committer: Deepak Dixit

2017-07-15 Thread Amey Barve 
Welcome Deepak and Congratulations!

Regards,
Amey

On 16 Jul 2017 2:37 am, "Nitin Lamba"  wrote:

Welcome Deepak!
Nitin

On Sat, Jul 15, 2017 at 1:07 AM, Avinash Dongre  wrote:

> Welcome Deepak !
>
> Thanks
> Avinash
>
> On Sat, Jul 15, 2017 at 8:08 AM Anthony Baker  wrote:
>
> > Welcome Deepak!
> >
> > Anthony
> >
> > Sent from my iPhone
> >
> > > On Jul 14, 2017, at 4:46 PM, Mark Bretl  wrote:
> > >
> > > The Apache Geode Project Management Committee has invited Deepak Dixit
> to
> > > be committer on the project. We are pleased to announce he has
> accepted.
> > >
> > > Please join me in welcoming Deepak!
> > >
> > > Thanks,
> > >
> > > Mark
> > > On behalf of the Apache Geode PMC
> >
>

[jira] [Commented] (GEODE-2886) The WaitUntilFlushedFunction throws an IllegalArgumentException instead of an IllegalStateException

2017-05-16 Thread Amey Barve (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013575#comment-16013575
 ] 

Amey Barve commented on GEODE-2886:
---

Hi Barry, 

I agree we should use *IllegalStateException* instead of 
*IllegalArgumentException*
Should this exception be sent to the caller using *sendException* instead of 
just throwing the exception in the execute call ?

Thanks


> The WaitUntilFlushedFunction throws an IllegalArgumentException instead of an 
> IllegalStateException
> ---
>
> Key: GEODE-2886
> URL: https://issues.apache.org/jira/browse/GEODE-2886
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: Amey Barve
>
> When the AEQ doesn't exist, the WaitUntilFlushedFunction throws an 
> IllegalArgumentException like:
> {noformat}
> Caused by: java.lang.IllegalArgumentException: The AEQ does not exist for the 
> index xxx region /yyy
> at 
> org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction.execute(WaitUntilFlushedFunction.java:89)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.executeFunctionLocally(AbstractExecution.java:333)
> {noformat}
> The arguments are actually fine so should it instead throw an 
> IllegalStateException?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2890) Incorrect debug log location in AbstractGatewaySenderEventProcessor.processQueue()

2017-05-09 Thread Amey Barve (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Barve reassigned GEODE-2890:
-

Assignee: Amey Barve

> Incorrect debug log location in 
> AbstractGatewaySenderEventProcessor.processQueue() 
> ---
>
> Key: GEODE-2890
> URL: https://issues.apache.org/jira/browse/GEODE-2890
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Jason Huynh
>Assignee: Amey Barve
>
> The following code snippet in processQueue() for AEQ's appears to be outside 
> of an if condition where we check to see if the node is primary still or not. 
>  This line prints for every event and I believe it should be inside the 
> previous if condition. 
> {noformat}
> if (qpr != null) {
>BucketRegion bucket = qpr.getDataStore().getLocalBucketById(bucketId);
>if (bucket == null || !bucket.getBucketAdvisor().isPrimary()) {
>  event.setPossibleDuplicate(true);
> //I think the debug log should be placed here?
>}
> }
> if (isDebugEnabled) {
>   logger.debug( "Bucket id: {} is no longer primary on this node. The event 
> {} will be dispatched from this node with possibleDuplicate set to true.", 
> bucketId, event);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2780) Typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4

2017-04-14 Thread Amey Barve (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-2780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Barve reassigned GEODE-2780:
-

Assignee: Amey Barve

> Typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4
> -
>
> Key: GEODE-2780
> URL: https://issues.apache.org/jira/browse/GEODE-2780
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>    Reporter: Amey Barve
>    Assignee: Amey Barve
>
> There is typo in client CONTRIBUTING.md file CMake 4.3 should be CMake 3.4
> ### Required Tools
> * [CMake 4.3](https://cmake.org/) or newer
> There is no version 4.3 of CMake



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2763) Remove of nonSingleHopsCount stat in client

2017-04-09 Thread Amey Barve (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Barve reassigned GEODE-2763:
-

Assignee: Amey Barve

> Remove of nonSingleHopsCount stat in client
> ---
>
> Key: GEODE-2763
> URL: https://issues.apache.org/jira/browse/GEODE-2763
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Michael Dodge
>    Assignee: Amey Barve
>
> A pre-existing issue (GEODE-2017) required the removal of the 
> nonSingleHopsCount statistic in the clients. Whilst marked for the native 
> client as well, it was not addressed in the native client. It should be.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2049) unit of measure wrong in DistributionStats tcpFinalCheck statitistics

2017-01-03 Thread Amey Barve (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Barve reassigned GEODE-2049:
-

Assignee: Amey Barve

> unit of measure wrong in DistributionStats tcpFinalCheck statitistics
> -
>
> Key: GEODE-2049
> URL: https://issues.apache.org/jira/browse/GEODE-2049
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce Schuchardt
>    Assignee: Amey Barve
>Priority: Minor
>
> The unit of measure for all of the tcpfinalCheck statistics is currently 
> "nanoseconds" but should be "messages".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (GEODE-1754) InternalLocator.startLocator needs to be cleaned up

2017-01-01 Thread Amey Barve (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15792266#comment-15792266
 ] 

Amey Barve commented on GEODE-1754:
---

[~bschuchardt] were you able to merge my commits ?

> InternalLocator.startLocator needs to be cleaned up
> ---
>
> Key: GEODE-1754
> URL: https://issues.apache.org/jira/browse/GEODE-1754
> Project: Geode
>  Issue Type: Task
>  Components: management
>Reporter: Bruce Schuchardt
>    Assignee: Amey Barve
>
> InternalLocator.startLocator was modified to have a loadSharedConfigFromDir 
> parameter that is never used.  It should be removed.
> {noformat}
>   /**
>* Creates a distribution locator that runs in this VM on the given
>* port and bind address.
>* 
>* This is for internal use only as it does not create a distributed
>* system unless told to do so.
>* 
>* @param port
>*the tcp/ip port to listen on
>* @param logFile
>*the file that log messages should be written to
>* @param logger
>*a log writer that should be used (logFile parameter is ignored)
>* @param securityLogger
>*the logger to be used for security related log messages
>* @param startDistributedSystem
>*if true, a distributed system is started
>* @param dsProperties
>*optional properties to configure the distributed system (e.g., mcast 
> addr/port, other locators)
>* @param peerLocator
>*enable peer location services
>* @param enableServerLocator
>*enable server location services
>* @param hostnameForClients
>*the name to give to clients for connecting to this locator
>* @param loadSharedConfigFromDir TODO:CONFIG
>* @throws IOException 
>*/
>   public static InternalLocator startLocator(
> int port,
> File logFile,
> File stateFile,
> InternalLogWriter logger,
> InternalLogWriter securityLogger,
> InetAddress bindAddress,
> boolean startDistributedSystem,
> java.util.Properties dsProperties,
> boolean peerLocator, 
> boolean enableServerLocator, 
> String hostnameForClients, 
> boolean loadSharedConfigFromDir
> )
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (GEODE-1541) statsListUniqueId should be an AtomicLong

2016-12-19 Thread Amey Barve (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Barve resolved GEODE-1541.
---
Resolution: Fixed

Resolved with https://github.com/apache/geode/pull/319

> statsListUniqueId should be an AtomicLong
> -
>
> Key: GEODE-1541
> URL: https://issues.apache.org/jira/browse/GEODE-1541
> Project: Geode
>  Issue Type: Improvement
>  Components: statistics
>Reporter: Darrel Schneider
>    Assignee: Amey Barve
>
> In InternalDistributedSystem the following instance variables:
>   private long statsListUniqueId = 1;
>   private final Object statsListUniqueIdLock = new Object();
> should be changed to an AtomicLong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (GEODE-1754) InternalLocator.startLocator needs to be cleaned up

2016-12-16 Thread Amey Barve (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Barve reassigned GEODE-1754:
-

Assignee: Amey Barve

> InternalLocator.startLocator needs to be cleaned up
> ---
>
> Key: GEODE-1754
> URL: https://issues.apache.org/jira/browse/GEODE-1754
> Project: Geode
>  Issue Type: Task
>  Components: management
>Reporter: Bruce Schuchardt
>    Assignee: Amey Barve
>
> InternalLocator.startLocator was modified to have a loadSharedConfigFromDir 
> parameter that is never used.  It should be removed.
> {noformat}
>   /**
>* Creates a distribution locator that runs in this VM on the given
>* port and bind address.
>* 
>* This is for internal use only as it does not create a distributed
>* system unless told to do so.
>* 
>* @param port
>*the tcp/ip port to listen on
>* @param logFile
>*the file that log messages should be written to
>* @param logger
>*a log writer that should be used (logFile parameter is ignored)
>* @param securityLogger
>*the logger to be used for security related log messages
>* @param startDistributedSystem
>*if true, a distributed system is started
>* @param dsProperties
>*optional properties to configure the distributed system (e.g., mcast 
> addr/port, other locators)
>* @param peerLocator
>*enable peer location services
>* @param enableServerLocator
>*enable server location services
>* @param hostnameForClients
>*the name to give to clients for connecting to this locator
>* @param loadSharedConfigFromDir TODO:CONFIG
>* @throws IOException 
>*/
>   public static InternalLocator startLocator(
> int port,
> File logFile,
> File stateFile,
> InternalLogWriter logger,
> InternalLogWriter securityLogger,
> InetAddress bindAddress,
> boolean startDistributedSystem,
> java.util.Properties dsProperties,
> boolean peerLocator, 
> boolean enableServerLocator, 
> String hostnameForClients, 
> boolean loadSharedConfigFromDir
> )
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (GEODE-789) Create and clear define index shouldn't be available on disconnected GFSH

2016-12-11 Thread Amey Barve (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Barve updated GEODE-789:
-
Component/s: gfsh

> Create and clear define index shouldn't be available on disconnected GFSH
> -
>
> Key: GEODE-789
> URL: https://issues.apache.org/jira/browse/GEODE-789
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tools
>Reporter: William Markito Oliveira
>    Assignee: Amey Barve
>
> The following gfsh commands for indexes shouldn't be available on a 
> disconnected gfsh session. 
> {code}
> gfsh>create defined indexes --
> Can't execute a remote command without connection. Use 'connect' first to 
> connect.
> gfsh>clear defined indexes
> Can't execute a remote command without connection. Use 'connect' first to 
> connect.
> gfsh>
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (GEODE-1969) oplog closed while writing to oplog with gemfire.syncWrites=true

2016-12-11 Thread Amey Barve (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Barve reassigned GEODE-1969:
-

Assignee: Amey Barve

> oplog closed while writing to oplog with gemfire.syncWrites=true
> 
>
> Key: GEODE-1969
> URL: https://issues.apache.org/jira/browse/GEODE-1969
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Reporter: Darrel Schneider
>    Assignee: Amey Barve
>
> [info 2016/09/29 06:16:06.823 UTC  oplog#6> tid=0x19] OplogCompactor for nsxDiskStore compaction oplog id(s): 
> oplog#6
> [info 2016/09/29 06:16:08.232 UTC  oplog#6> tid=0x19] compaction did 6,310 creates and updates in 1,408 ms
> [info 2016/09/29 06:16:08.248 UTC  tid=0x19] Deleted 
> oplog#6 crf for disk store nsxDiskStore.
> [info 2016/09/29 06:16:08.256 UTC  tid=0x19] Deleted 
> oplog#6 krf for disk store nsxDiskStore.
> [info 2016/09/29 06:16:08.256 UTC  tid=0x19] Deleted 
> oplog#6 drf for disk store nsxDiskStore.
> [info 2016/09/29 06:17:03.887 UTC  GatewaySender_AsyncEventQueue_txLogEventQueue> tid=0x19] Created oplog#8 drf 
> for disk store nsxDiskStore.
> [info 2016/09/29 06:17:03.911 UTC  GatewaySender_AsyncEventQueue_txLogEventQueue> tid=0x19] Created oplog#8 crf 
> for disk store nsxDiskStore.
> [info 2016/09/29 06:17:04.031 UTC  tid=0x19] Created 
> oplog#7 krf for disk store nsxDiskStore.
> [info 2016/09/29 06:17:04.314 UTC  oplog#7> tid=0x19] OplogCompactor for nsxDiskStore compaction oplog id(s): 
> oplog#7
> [error 2016/09/29 06:17:16.075 UTC  oplog#7> tid=0x19] A DiskAccessException has occurred while writing to the 
> disk for disk store nsxDiskStore. The cache will be closed. 
> ?com.gemstone.gemfire.cache.DiskAccessException: For DiskStore: nsxDiskStore: 
> Failed writing key to "/common/nsxapi/data/self/BACKUPnsxDiskStore_7", caused 
> by java.io.IOException: Stream Closed ?at 
> com.gemstone.gemfire.internal.cache.Oplog.flushAll(Oplog.java:5235)
> [warn 2016/09/29 06:17:16.297 UTC  GatewaySender_AsyncEventQueue_txLogEventQueue> tid=0x19] 
> com.gemstone.gemfire.internal.cache.wan.GatewaySenderEventCallbackDispatcher@55bded67:
>  Exception during processing batch 448
> com.gemstone.gemfire.internal.cache.wan.GatewaySenderException: 
> com.gemstone.gemfire.internal.cache.wan.GatewaySenderEventCallbackDispatcher@55bded67:
>  Exception during processing batch 448, caused by 
> com.gemstone.gemfire.cache.CacheClosedException: For DiskStore: nsxDiskStore: 
> Failed writing key to "/common/nsxapi/data/self/BACKUPnsxDiskStore_7", caused 
> by com.gemstone.gemfire.cache.DiskAccessException: For DiskStore: 
> nsxDiskStore: Failed writing key to 
> "/common/nsxapi/data/self/BACKUPnsxDiskStore_7", caused by 
> java.io.IOException: Stream Closed
> at 
> com.gemstone.gemfire.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:173)
> at 
> com.gemstone.gemfire.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:83)
> at 
> com.gemstone.gemfire.internal.cache.wan.AbstractGatewaySenderEventProcessor.processQueue(AbstractGatewaySenderEventProcessor.java:579)
> at 
> com.gemstone.gemfire.internal.cache.wan.serial.SerialGatewaySenderEventProcessor.run(SerialGatewaySenderEventProcessor.java:219)
> Caused by: com.gemstone.gemfire.cache.CacheClosedException: For DiskStore: 
> nsxDiskStore: Failed writing key to 
> "/common/nsxapi/data/self/BACKUPnsxDiskStore_7", caused by 
> com.gemstone.gemfire.cache.DiskAccessException: For DiskStore: nsxDiskStore: 
> Failed writing key to "/common/nsxapi/data/self/BACKUPnsxDiskStore_7", caused 
> by java.io.IOException: Stream Closed
> at 
> com.gemstone.gemfire.internal.cache.GemFireCacheImpl$Stopper.generateCancelledException(GemFireCacheImpl.java:1299)
> at 
> com.gemstone.gemfire.CancelCriterion.checkCancelInProgress(CancelCriterion.java:82)
> at 
> com.gemstone.gemfire.internal.cache.TXManagerImpl.checkClosed(TXManagerImpl.java:606)
> at 
> com.gemstone.gemfire.internal.cache.TXManagerImpl.begin(TXManagerImpl.java:279)
> at 
> com.vmware.nsx.management.container.dao.gemfire.GemFireTxLogDao.processTxLog(GemFireTxLogDao.java:119)
> at 
> com.vmware.nsx.management.container.dao.gemfire.TxLogAsyncEventListener.processEvents(TxLogAsyncEventListener.java:93)
> at 
> com.gemstone.gemfire.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dis

[jira] [Assigned] (GEODE-789) Create and clear define index shouldn't be available on disconnected GFSH

2016-12-11 Thread Amey Barve (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Barve reassigned GEODE-789:


Assignee: Amey Barve

> Create and clear define index shouldn't be available on disconnected GFSH
> -
>
> Key: GEODE-789
> URL: https://issues.apache.org/jira/browse/GEODE-789
> Project: Geode
>  Issue Type: Bug
>  Components: tools
>Reporter: William Markito Oliveira
>    Assignee: Amey Barve
>
> The following gfsh commands for indexes shouldn't be available on a 
> disconnected gfsh session. 
> {code}
> gfsh>create defined indexes --
> Can't execute a remote command without connection. Use 'connect' first to 
> connect.
> gfsh>clear defined indexes
> Can't execute a remote command without connection. Use 'connect' first to 
> connect.
> gfsh>
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (GEODE-1835) A message logged by the configure pdx command is incorrect

2016-12-11 Thread Amey Barve (JIRA) 

 [ 
https://issues.apache.org/jira/browse/GEODE-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amey Barve resolved GEODE-1835.
---
Resolution: Fixed

This issue is resolved with https://github.com/apache/geode/pull/304 pull 
request.

> A message logged by the configure pdx command is incorrect
> --
>
> Key: GEODE-1835
> URL: https://issues.apache.org/jira/browse/GEODE-1835
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Barry Oglesby
>    Assignee: Amey Barve
>
> The message below is only logged when there are no members. Instead, it 
> should be logged when there are members.
> {noformat}
> The command would only take effect on new data members joining the 
> distributed system. It won't affect the existing data members
> {noformat}
> The condition in {{PDXCommands.configurePDX}} is:
> {noformat}
> if (CliUtil.getAllNormalMembers(CliUtil.getCacheIfExists()).isEmpty()) {
>   ird.addLine(CliStrings.CONFIGURE_PDX__NORMAL__MEMBERS__WARNING);
> }
> {noformat}
> It should test for {{!isEmpty}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 54330: GEODE-2179 - Checking for disconnected connection in GatewaySenderMBean

2016-12-06 Thread Amey Barve 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54330/#review158306
---


Ship it!




Ship It!

- Amey Barve


On Dec. 2, 2016, 11:48 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54330/
> ---
> 
> (Updated Dec. 2, 2016, 11:48 p.m.)
> 
> 
> Review request for geode and Barry Oglesby.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Making sure that the mbean returns false for isConnected if the gateway
> is not actually connected to the remote side.
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
>  16b196586e62dcd3707bd9f70406ff8d5d963308 
>   
> geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java
>  9a6cc104a1368fa762bffd1efa1978f007819604 
> 
> Diff: https://reviews.apache.org/r/54330/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

[jira] [Commented] (GEODE-2179) GatewaySenderMBeans isConnected flag does not notice if a connection is destroyed

2016-12-06 Thread Amey Barve (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727774#comment-15727774
 ] 

Amey Barve commented on GEODE-2179:
---

Yes now I can view diff and patch too looks good !

> GatewaySenderMBeans isConnected flag does not notice if a connection is 
> destroyed
> -
>
> Key: GEODE-2179
> URL: https://issues.apache.org/jira/browse/GEODE-2179
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Dan Smith
>Assignee: Amey Barve
>
> The GatewaySenderMBean has a method called isConnected which ultimately calls 
> this code in GatewaySenderEventRemoteDispatcher
> {code}
> @Override
> public boolean isConnectedToRemote() {
>   return connection != null;
> }
> {code}
> However, this doesn't take into account that the connection may be destroyed, 
> but not null. Therefore the mbean can incorrectly indicate that the sender is 
> connected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)