[GitHub] geode pull request #705: GEODE-3111 GatewayReceiver - DEFAULT_MANUAL_START v...

2017-08-09 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/705

GEODE-3111 GatewayReceiver - DEFAULT_MANUAL_START value is ambiguous

Updated user guide and javadocs to agree with actual default setting 
(=false).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-3111

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #705


commit 61e7c38d3e9daa2da992050d9de9e9ef1f4840e0
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-08-09T23:17:14Z

GEODE-3111 GatewayReceiver - DEFAULT_MANUAL_START value is ambiguous




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #703: GEODE-3328 Properties to set Key/Trust Store Type f...

2017-08-09 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/703

GEODE-3328 Properties to set Key/Trust Store Type for SSL configurati…

…on - add to docs

Added documentation for ssl-keystore-type and ssl-truststore-type to the 
user manual in two locations: Implementing SSL and the Properties Reference. 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-3328

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/703.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #703


commit e6fe1e69b104c62608f763054c92e89537012857
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-08-09T22:22:22Z

GEODE-3328 Properties to set Key/Trust Store Type for SSL configuration - 
add to docs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #686: GEODE-3396 Provide pub-tools support for product na...

2017-08-04 Thread davebarnes97
Github user davebarnes97 closed the pull request at:

https://github.com/apache/geode/pull/686


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #686: GEODE-3396 Provide pub-tools support for product name & ve...

2017-08-04 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/686
  
License added to helpers file, as requested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #686: GEODE-3396 Provide pub-tools support for product na...

2017-08-04 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/686

GEODE-3396 Provide pub-tools support for product name & version varia…

Adds three variables for use in docs:

  - geode_product_name
  - geode_product_name_long
  - geode_product_version

Plus Ruby helper functions to support their use in nested contexts (e.g. 
YAML frontmatter "title:" constructs) and usage instructions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-3396

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #686


commit b5d846c32eaf91af79d2158096975e65bd3aa7b6
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-08-04T17:49:05Z

GEODE-3396 Provide pub-tools support for product name & version variables




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #113: (no ticket) Capitalize C# client member func...

2017-07-25 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/113

(no ticket) Capitalize C# client member functions

From Kyle Dunn on Slack:
Looks like a minor typo here : 
http://gemfire-native-90.docs.pivotal.io/native/continuous-querying/5b-writing-cq-listener.html#cqlistener-implementation-(c#-.net)
C# CqListener should implement OnEvent(), OnError(), and Close() - notice 
the first letter capitalization.

NB(db): I also changed onCqDisconnected to OnCqDisconnected, onCqConnected 
to OnCqConnected, and clear to Clear.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/CapMembers

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #113


commit ec06436fad41a5f8cb6dd55f5f4a98b812c8127b
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-07-25T21:41:05Z

(no ticket) Capitalize C# client member functions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

2017-07-19 Thread davebarnes97
Github user davebarnes97 commented on a diff in the pull request:

https://github.com/apache/geode/pull/644#discussion_r128331252
  
--- Diff: geode-docs/tools_modules/gfsh/configuring_gfsh.html.md.erb ---
@@ -24,13 +24,13 @@ The `gfsh.bat` and `gfsh` bash script automatically 
append the required Apache G
 
 ## JAR Libraries in CLASSPATH
 
-When you start up `gfsh`, it will automatically load required JAR files 
that have been packaged in the `gfsh-dependencies.jar` file. You do not need to 
modify your CLASSPATH to run gfsh. When starting servers and locators in gfsh, 
the start server and start locator commands will load `server-dependencies.jar` 
and `locator-dependencies.jar` files into the process CLASSPATH for you.
+When you start up `gfsh`, it will automatically load required JAR files 
that have been packaged in the `gfsh-dependencies.jar` file. You do not need to 
modify your CLASSPATH to run `gfsh`.
 
-These dependency JAR files are packaged in your Apache Geode installation 
in the `$GEMFIRE/lib` (or on Windows, the `%GEODE_HOME%\lib`) directory.
+The JAR files are packaged within your installation directory in the `lib` 
directory.
 
 ## Machine Hostname
 
-On some operating systems, you may need to ensure that the hostname of 
your machine is configured in your system hosts file. For example, on Mac OSX 
you may need to map your machine's hostname to your IP address in the 
`/etc/hosts` file in order for `gfsh` and Pulse to operate correctly.
+On some operating systems, you may need to ensure that the host name of 
your machine is configured in your system hosts file. For example, on Mac OSX 
you may need to map your machine's host name to your IP address in the 
`/etc/hosts` file in order for `gfsh` and Pulse to operate correctly.
--- End diff --

LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-examples issue #8: GEODE-3195 Add querying example to the geode-exampl...

2017-07-12 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-examples/pull/8
  
Encountered one problem: initial run failed rat check. I commented out the 
rat check in build.gradle "/* apply from: "gradle/rat.gradle"*/".
After that, I followed instructions and successfully ran the example from 
start to finish.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #583: GEODE-2854: GEODE REST API Docs Missing Authenticat...

2017-06-15 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/583

GEODE-2854: GEODE REST API Docs Missing Authentication

Reviews requested from: @mmartell, @jaredjstewart @karensmolermiller 
@joeymcallister 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2854

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/583.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #583


commit a77860db914498585fb4bd90f27f3cd488e9
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-06-15T20:43:41Z

GEODE-2854: GEODE REST API Docs Missing Authentication




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #508: GEODE-2908: Adding the new tag as per swagger notification...

2017-06-07 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/508
  
Will add my comment to GEODE-3035 Rest: Swagger UI has lot of references to 
GemFire, instead they should be changed to geode


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #566: GEODE-3044: User Manual: Update Swagger example and...

2017-06-06 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/566

GEODE-3044: User Manual: Update Swagger example and screen shots

Updates Swagger screen shots and the example command lines that create the 
screens.

Request reviews from @karensmolermiller  and @jaredjstewart. Thanks!

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-3044

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/566.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #566


commit 417a8ddcd479fdce09335d48fb0a86041fa23ffb
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-06-06T18:51:23Z

GEODE-3044: User Manual: Update Swagger example and screen shots




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #559: GEODE-1672 When amount of overflowed persisted data exceed...

2017-06-05 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/559
  
Thanks, Darrel. Changes incorporated.

On Mon, Jun 5, 2017 at 3:19 PM, Darrel Schneider <notificati...@github.com>
wrote:

> *@dschneider-pivotal* commented on this pull request.
>
> This looks good. I just had two comments
> --
>
> In geode-docs/managing/troubleshooting/system_
> failure_and_recovery.html.md.erb
> <https://github.com/apache/geode/pull/559#discussion_r120222821>:
>
> > +- Retrieving values asynchronously in a background thread allows a 
relatively quick startup on a "warm" cache
> +that will eventually recover every value.
> +
> +**Retrieve or Ignore LRU values**
> +
> +When a system with persistent LRU regions shuts down, the system does 
not record which of the values
> +were recently used. On subsequent startup, if values are recovered into 
an LRU region they may be
> +the least recently used instead of the most recently used. Also, if LRU 
values are recovered on a
> +heap or an off-heap LRU region, it is possible that the LRU memory limit 
will be exceeded, resulting
> +in an `OutOfMemoryException` during recovery. For these reasons, LRU 
value recovery can be treated
> +differently than non-LRU values.
> +
> +## Default Recovery Behavior for Persistent Regions
> +
> +The default behavior is for the system to recover all keys, then 
asynchronously recover all data
> +values that were resident, leaving LRU values unrecovered. This default 
strategy is best for
>
> drop "that were resident"
> --
>
> In geode-docs/managing/troubleshooting/system_
> failure_and_recovery.html.md.erb
> <https://github.com/apache/geode/pull/559#discussion_r120224399>:
>
> > +  `gemfire.disk.recoverValues` is `false`, then 
`gemfire.disk.recoverLruValues` is ignored, since
> +  no values are recovered.
> +
> +  *How used:* When `false`, shortens recovery time by ignoring LRU 
values. When `true`, restores
> +  more data values to the cache. Recovery of the LRU values increases 
heap memory usage and
> +  could cause an out-of-memory error, preventing the system from 
restarting.
> +
> +- `gemfire.disk.recoverValuesSync`
> +
> +  Default = `false`, recover values by an asynchronous background 
process. If `true`, values are
> +  recovered synchronously, and recovery is not complete until all values 
have been retrieved.  If
> +  `gemfire.disk.recoverValues` is `false`, then 
`gemfire.disk.recoverValuesSync` is ignored since
> +  no values are recovered.
> +
> +  *How used:* When `false`, allows the system to become available 
sooner, but some time must elapse
> +  before the entire cache is refreshed. Some key retrievals will require 
disk access, and some will not.
>
> change "the entire cache is refreshed" to "all values have been read from
> disk into cache memory"
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/geode/pull/559#pullrequestreview-42167706>, or 
mute
> the thread
> 
<https://github.com/notifications/unsubscribe-auth/AMh6OXa0sK3YqVnL799stZ_ZoszSaESGks5sBH78gaJpZM4NwayO>
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #559: GEODE-1672 When amount of overflowed persisted data...

2017-06-05 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/559

GEODE-1672 When amount of overflowed persisted data exceeds heap size…

… startup may run out of memory

This PR Documents a newly-added system property, recoverLRUValues, that 
allows the developer to fine-tune restart behavior on persistent regions with 
an LRU eviction policy that saves overflow values to disk. It also picks up a 
few typo and formatting corrections in related text.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-1672

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/559.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #559


commit 3df55de9fda367ed507f2c2e1dedcdeb76705163
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-06-05T18:25:44Z

GEODE-1672 When amount of overflowed persisted data exceeds heap size 
startup may run out of memory




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #518: GEODE-2913 Update Lucene index documentation

2017-05-18 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/518
  
+1 with Joey's changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-examples issue #4: Updating and simplifying examples

2017-05-09 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-examples/pull/4
  
+1
[Errata: Quoteloader, Bradbury, "...as **a** writer."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #493: GEODE-2815 Incorrect Error Message in REST API docs for {r...

2017-05-08 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/493
  
Received a drive-by +1 from mmartell, the filer of the JIRA ticket.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #493: GEODE-2815 Incorrect Error Message in REST API docs...

2017-05-05 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/493

GEODE-2815 Incorrect Error Message in REST API docs for {region}/{key…

…} HTTP.GET command

404 does mean 'not found', and in the REST API context it can mean 'Region 
not found', 'Key not found' or 'Either key or region not found', depending on 
what was being requested.
Edited the various REST API command docs accordingly.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2815

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/493.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #493


commit d2b99aeb5e28307c95963c8ee4a2ce5bf979f7a9
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-05-05T21:37:07Z

GEODE-2815 Incorrect Error Message in REST API docs for {region}/{key} 
HTTP.GET command




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #485: GEODE-2843 User Guide - example should specify

2017-05-02 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/485
  
Merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #486: GEODE-2830 Required permission for executing a func...

2017-05-02 Thread davebarnes97
Github user davebarnes97 closed the pull request at:

https://github.com/apache/geode/pull/486


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #486: GEODE-2830 Required permission for executing a function sh...

2017-05-02 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/486
  
Merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #486: GEODE-2830 Required permission for executing a func...

2017-05-01 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/486

GEODE-2830 Required permission for executing a function should be 

DATA:WRITE
Simple typo correction

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2830

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/486.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #486


commit cb341752a8039e03c85ca8f9119e5d0930714fb1
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-05-01T23:49:21Z

GEODE-2830 Required permission for executing a function should be DATA:WRITE




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #484: GEODE-2778: gfsh help now uses log4j log levels: up...

2017-05-01 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/484

GEODE-2778: gfsh help now uses log4j log levels: update user guide

Confined changes to gfsh commands, only.
Further changes may be needed for xml-based configs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2778

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/484.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #484






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #482: gfsh help now uses log4j log levels: update user gu...

2017-05-01 Thread davebarnes97
Github user davebarnes97 closed the pull request at:

https://github.com/apache/geode/pull/482


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #482: gfsh help now uses log4j log levels: update user guide

2017-05-01 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/482
  
PR associated itself with a secondary ticket. Will re-post with an improved 
comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #482: gfsh help now uses log4j log levels: update user gu...

2017-04-28 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/482

gfsh help now uses log4j log levels: update user guide

Where gfsh documentation listed log level params, replaced the "old" levels 
(fine, finer, finest, etc) with log4j levels (ALL, TRACE, DEBUG, etc).
Did not replace log level params in non-gfsh contexts (e.g. Java command 
lines or xml config files).
Also did not standardize "loglevel" vs "log-level", which are 
inconsistently used in the gfsh interface (see GEODE-2850).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2778

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/482.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #482


commit 29177fed58851868c698f9c24c7424903ea22461
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-04-28T22:55:50Z

gfsh help now uses log4j log levels: update user guide




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #94: GEODE-2826: Client docs - Delta Propagation A...

2017-04-25 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/94

GEODE-2826: Client docs - Delta Propagation API, correct .NET namespa…

…ce notation

For .NET API, use "." separator instead of "::"

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2826

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #94


commit 7ff2787d8774ce3653d97de400e12c4f465a6035
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-04-25T20:37:50Z

GEODE-2826: Client docs - Delta Propagation API, correct .NET namespace 
notation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #478: GEODE-2821 - Geode User Guide: Add running heads wi...

2017-04-25 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/478

GEODE-2821 - Geode User Guide: Add running heads with logo

Adds Logo and a link to the Geode release notes on the Confluence Wiki.

BEFORE:

![screenshotnologo](https://cloud.githubusercontent.com/assets/13138489/25405444/2b266a9c-29b8-11e7-81a5-020351a12241.png)

AFTER:

![screenshotwithlogo](https://cloud.githubusercontent.com/assets/13138489/25405397/0cfdbffc-29b8-11e7-8662-54871fc0b241.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2821

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #478


commit f1ebffab9eef0363e8d0a23fc32774702e93c92b
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-04-25T20:05:00Z

GEODE-2821 - Geode User Guide: Add running heads with logo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #457: GEODE-728 : Rename Execution.withArgs to Execution.setArgu...

2017-04-17 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/457
  
+1
Reviewed the doc changes, they correctly reflect the code changes and the 
book builds without error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #92: GEODE-2784 Geode client docs: Cmake reqires t...

2017-04-14 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/92

GEODE-2784 Geode client docs: Cmake reqires the --config option when …

…a generator is specified

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2784

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/92.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #92


commit a2860a71e9e13416c74f6b2ccd87e93d4c1aa8c4
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-04-14T22:48:22Z

GEODE-2784 Geode client docs: Cmake reqires the --config option when a 
generator is specified




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #91: GEODE-2710: Geode client docs: Update QuickSt...

2017-04-14 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/91

GEODE-2710: Geode client docs: Update QuickStarts section (updated cm…

…ake command lines)
Updated cmake command lines. WIP, more to do.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2710

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #91


commit c0ac5fd739a423ffe9ab2c3548c093815870beef
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-04-14T21:57:24Z

GEODE-2710: Geode client docs: Update QuickStarts section (updated cmake 
command lines)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #87: Docs: un-brand client cache plugin diagram

2017-04-10 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/87
  
Approved and merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #87: Docs: un-brand client cache plugin diagram

2017-04-10 Thread davebarnes97
Github user davebarnes97 closed the pull request at:

https://github.com/apache/geode-native/pull/87


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #88: Feature/geode 2537 Docs: redraw delta propaga...

2017-04-10 Thread davebarnes97
Github user davebarnes97 closed the pull request at:

https://github.com/apache/geode-native/pull/88


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #88: Feature/geode 2537 Docs: redraw delta propagation im...

2017-04-10 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/88
  
Change accepted & merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #88: Feature/geode 2537 Docs: redraw delta propaga...

2017-04-07 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/88

Feature/geode 2537 Docs: redraw delta propagation image to remove 
proprietary label


![geode-2537-fix](https://cloud.githubusercontent.com/assets/13138489/2482/127a797a-1bb2-11e7-8093-20cfaa314668.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2537

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit c0a89e6d709f8daa4d2fa44a72b6c5e03950c56b
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-04-07T22:14:00Z

Docs: redraw delta propagation image to remove proprietary label

commit c3e24719aa40e6f16efdd5e086c5cf5b53616c9d
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-04-07T23:37:47Z

Docs: redraw delta propagation image to remove proprietary label




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #87: Docs: un-brand client cache plugin diagram

2017-04-07 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/87

Docs: un-brand client cache plugin diagram


![geode-2761-fix](https://cloud.githubusercontent.com/assets/13138489/24815779/4ad26eda-1b8b-11e7-93aa-878db5ca9394.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2761

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #87


commit 7378ac3ef145da9580fb4ef073c3bfe6987fc65f
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-04-07T19:08:51Z

Docs: un-brand client cache plugin diagram




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #86: Feature/geode 2513 security props

2017-04-04 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/86
  
I _did_ fix it. Not sure why the old misspelling was visible to you,
@pivotalsarge.

On Tue, Apr 4, 2017 at 1:55 PM, Dave Barnes <dbar...@pivotal.io> wrote:

> Whoa! Thought I fixed that...
>
> On Tue, Apr 4, 2017 at 12:46 PM, PivotalSarge <notificati...@github.com>
> wrote:
>
>> *@PivotalSarge* approved this pull request.
>>
>> Perhaps "appropreate" is missing an 'i'...
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> 
<https://github.com/apache/geode-native/pull/86#pullrequestreview-30882325>,
>> or mute the thread
>> 
<https://github.com/notifications/unsubscribe-auth/AMh6Oe-CJ5tkbW3YGkiNVjSTk7tjyHedks5rsp4MgaJpZM4MzRTo>
>> .
>>
>
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #86: Feature/geode 2513 security props

2017-04-04 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/86
  
Whoa! Thought I fixed that...

On Tue, Apr 4, 2017 at 12:46 PM, PivotalSarge <notificati...@github.com>
wrote:

> *@PivotalSarge* approved this pull request.
>
> Perhaps "appropreate" is missing an 'i'...
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
<https://github.com/apache/geode-native/pull/86#pullrequestreview-30882325>,
> or mute the thread
> 
<https://github.com/notifications/unsubscribe-auth/AMh6Oe-CJ5tkbW3YGkiNVjSTk7tjyHedks5rsp4MgaJpZM4MzRTo>
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #86: Feature/geode 2513 security props

2017-04-04 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/86

Feature/geode 2513 security props



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-security-props

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #86


commit 03b21c213232831845525dc1445cd7f3dde1418c
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-02-25T00:06:37Z

GEMNC-268 Update security docs. New OpenSSL build procedure, new properties

commit 395285195ec89afee47e807441993f535ffdf98e
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-04-04T18:20:25Z

GEMNC-268: genericize property file names, update ssl-enabled to 
ssl-enabled-components




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #85: GEODE-2513: Rename and reorganize client doc ...

2017-04-03 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/85

GEODE-2513: Rename and reorganize client doc sources

Deleted unused files, renamed to replace underscores with hyphens and 
remove the word 'native'. Edited headings and subnav so they match each other.
This is the 'final' draft of the open-source client documentation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-TopLevel

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #85


commit 3178603eb5f4481116756ab64f78b132e620d2da
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-04-03T22:50:47Z

GEODE-2513: Rename and reorganize client doc sources




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #84: GEODE-2513 Unbranding docs: Added Geode logos to doc...

2017-03-31 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/84
  

![docs-branding-os-client](https://cloud.githubusercontent.com/assets/13138489/24570739/112e7296-1622-11e7-9f01-55b0402bf200.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #84: GEODE-2513 Unbranding docs: Added Geode logos...

2017-03-31 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/84

GEODE-2513 Unbranding docs: Added Geode logos to doc headers.

Added Geode logos to the documentation's top frame and at the top of 
individual topics. Patterned after the Geode website, with a white-on-black 
logo in the browser frame and a color-on-white log in the page body.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-branding

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #84


commit 8a940fdcd72129bc84ca6c77ef1cd0e6d4ff6ab5
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-03-31T21:47:55Z

GEODE-2513 Unbranding docs: Added Geode logos to doc headers.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #81: GEODE-2513 Unbranding docs: QuickStart exampl...

2017-03-29 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/81

GEODE-2513 Unbranding docs: QuickStart examples




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-QS

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/81.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #81






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #78: GEODE-2513 Unbranding docs: security

2017-03-28 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/78

GEODE-2513 Unbranding docs: security

The scope of this pull request is to eliminate occurrences of `gemfire` and 
`native` from the terminology, along with proprietary-ish names such as `GFCPP`.
The actual procedures in this section may be out-of-date, but updating them 
is a separate task.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-security

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit 49609436786b48144b2ce3c39b22cb29c92b82cd
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-03-28T23:16:11Z

GEODE-2513 Unbranding docs: security




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #73: GEODE-2513 Unbrand C++ API docs: Getting Started sec...

2017-03-24 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/73
  
Round 2 incorporates suggestions from reviewers.
Per PivotalSarge, more consistency in the uses of "Client" and "Geode 
Client".
Per echobravopapa, a lot less system-specific hand-holding. Entire sections 
about running on Linux, Solaris, and Windows have been deleted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #73: GEODE-2513 Unbrand C++ API docs: Getting Star...

2017-03-23 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/73

GEODE-2513 Unbrand C++ API docs: Getting Started section

Please review for terminology only. Also in scope is a rewrite of the 
system "requirements" which are now "guidelines".
NOT in scope are (1) making sure the QuickStarts still run with the new 
names in place, and (2) un-branding filenames. These are the subjects of 
separate pull requests in progress.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-GetStarted

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #73


commit ce3b552689d204a554af66dd49118aacf473d815
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-03-23T23:26:05Z

GEODE-2513 Unbrand C++ API docs: Getting Started section




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #69: GEODE-2513 Unbrand C++ API docs

2017-03-22 Thread davebarnes97
Github user davebarnes97 commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/69#discussion_r107524367
  
--- Diff: 
docs/geode-native-docs/cpp-caching-api/accessing-entry.html.md.erb ---
@@ -35,11 +35,11 @@ for ( int32_t i=0; i< 100; i++) {
 
 ## Bulk Get Operations Using getAll
 
-You can use the `Region::getAll` API (`Region.GetAll` for .NET) to get 
values for an array of keys from the local cache or server. If the value for a 
key is not present locally, then it is requested from the server.
+You can use the `Region::getAll` methond to get values for an array of 
keys from the local cache or server. If the value for a key is not present 
locally, then it is requested from the server.
--- End diff --

in cpp-caching-api/accessing-entry.html.md.erb, "methond" should be 
"method".



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #64: GEODE-2513 Unbrand geode-native docs: Continu...

2017-03-20 Thread davebarnes97
Github user davebarnes97 commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/64#discussion_r107042429
  
--- Diff: 
docs/geode-native-docs/continuous-querying/3-native-client-cq-api.html.md.erb 
---
@@ -21,9 +21,10 @@ limitations under the License.
 
 This chapter documents the primary native client API for CQ management.
 
-The Apache Geode native client API allows your clients to create and 
manage CQs. (The server side does not have an API.) Continuous querying 
provides native client query syntax, events-based management, integration with 
client/server architecture, active query execution, and interest criteria based 
on data values. For complete information on the classes and interfaces 
described here, see the API documentation at 
[http://gemfire-apis.docs.pivotal.io](http://gemfire-apis.docs.pivotal.io).
+The Apache Geode native client API allows your clients to create and 
manage CQs. (The server side does not have an API.) Continuous querying 
provides native client query syntax, events-based management, integration with 
client/server architecture, active query execution, and interest criteria based 
on data values. For complete information on the classes and interfaces 
described here, 
+see the API documentation for [C++](/releases/latest/api/cppdocs) or 
[C\#](/releases/latest/api/dotnetdocs).
 
-**Gemstone::GemFire::Cache**
+**Apache.Geode.Client.Cache**
--- End diff --

The preceding text says it will be using C# notation, so it should have 
been C# all along.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #64: GEODE-2513 Unbrand geode-native docs: Continu...

2017-03-20 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/64

GEODE-2513 Unbrand geode-native docs: Continuous Query



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-CQ

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #64


commit f23911f4b3252562a6b4a6f92f7036b9329c36f1
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-03-20T22:49:50Z

GEODE-2513 Unbrand geode-native docs: Continuous Query




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #62: GEODE-2513 Unbrand Connection Pools section o...

2017-03-17 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/62

GEODE-2513 Unbrand Connection Pools section of docs



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-ConPools

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #62


commit 4c438ddbeadeaa3f3dad734342ecbb8f272f68cd
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-03-17T23:06:28Z

GEODE-2513 Unbrand Connection Pools section of docs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #59: GEODE-2513 Unbrand Function Execution section...

2017-03-16 Thread davebarnes97
Github user davebarnes97 commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/59#discussion_r106495072
  
--- Diff: 
docs/geode-native-docs/function-execution/handling-function-results.html.md.erb 
---
@@ -19,7 +19,7 @@ See the License for the specific language governing 
permissions and
 limitations under the License.
 -->
 
-Geode provides a default result collector. If you need special results 
handling, code a custom `ResultsCollector` implementation to replace the 
provided default. Use the `Execution::withCollector` method to define your 
custom collector.
+There is a default result collector. If you need special results handling, 
code a custom `ResultsCollector` implementation to replace the provided 
default. Use the `Execution::withCollector` method to define your custom 
collector.
--- End diff --

As long as you (@karensmolermiller) are satisfied that no meaning was lost, 
you have my +1 for this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #425: GEODE-2379 Document new behavior of export logs

2017-03-14 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/425

GEODE-2379 Document new behavior of export logs



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2379

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/425.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #425


commit 2439a0c7bf7024768fb0df648ba4f87160717a2f
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-03-14T19:48:52Z

GEODE-2379 Document new behavior of export logs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #52: GEODE-2513 Rename gfcpp.properties file to geode.pro...

2017-03-13 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/52
  
Good catch, @karensmolermiller  - corrections incorporated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #52: GEODE-2513 Rename gfcpp.properties file to ge...

2017-03-13 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/52

GEODE-2513 Rename gfcpp.properties file to geode.properties - updated…

… references, moved and renamed files

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-PropFile

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #52


commit 35b7fca6e142a08a8976806621d58785117c2765
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-03-13T18:24:17Z

GEODE-2513 Rename gfcpp.properties file to geode.properties - updated 
references, moved and renamed files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #423: Feature/geode 1195

2017-03-10 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/423

Feature/geode 1195

Improve "Synchronizing Your Offline Disk Store with Your Cache" docs

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-1195

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #423


commit 98283f5b9768dba9983f1317b65d758ca4c1047f
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-03-09T22:28:15Z

GEODE-1195 Improve "Synchronizing Your Offline Disk Store with Your Cache" 
docs

commit 49af86f30ee1439e492560c7ded1fd5236c9a1a3
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-03-10T19:40:00Z

GEODE-1195 Improve "Synchronizing Your Offline Disk Store with Your Cache" 
docs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #419: GEODE-2592 Document Lucene-related gfsh commands

2017-03-10 Thread davebarnes97
Github user davebarnes97 closed the pull request at:

https://github.com/apache/geode/pull/419


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #49: GEODE-2513 Unbrand docs section on Preserving...

2017-03-09 Thread davebarnes97
Github user davebarnes97 commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/49#discussion_r105226885
  
--- Diff: 
docs/geode-native-docs/preserving-data/configuring-durable-nc.html.md.erb ---
@@ -19,19 +19,19 @@ See the License for the specific language governing 
permissions and
 limitations under the License.
 -->
 
-The durable native client can be configured in the `gfcpp.properties` 
file, or in the `CacheFactory::set(name, value)` call.
+The durable client can be configured in the `gfcpp.properties` file, or in 
the `CacheFactory::set(name, value)` call.
 
--   **Durable client ID**—You indicate that the client is durable by 
giving it a `durable-client-ID`. The servers use this ID to identify the 
client. For a non-durable client, the `durable-client-ID` is an empty string. 
The ID can be any number that is unique among the clients attached to servers 
in the same distributed system.
+-   **Durable client ID**—Indicate that the client is durable by giving 
it a `durable-client-ID`. The servers use this ID to identify the client. For a 
non-durable client, the `durable-client-ID` is an empty string. The ID can be 
any number that is unique among the clients attached to servers in the same 
distributed system.
 
 -   **Durable timeout**—The `durable-timeout` setting specifies how long 
this client’s servers should wait after the client disconnects before 
terminating its message queue. During that time, the servers consider the 
client alive and continue to accumulate messages for it. The default is 300 
seconds.
 
 The `durable-timeout` setting is a tuning parameter. When setting the 
timeout, take into account the normal activity of your application, the average 
size of your messages, and the level of risk you can handle. Assuming that no 
messages are being removed from the queue, how long can the application run 
before the queue reaches the maximum message count? In addition, how long can 
it run before the queued messages consume all the memory on the client host? 
How serious is each of those failures to your operation?
 
-To assist with tuning, Geode provides statistics that track message queues 
for durable clients through the disconnect and reconnect cycles. For statistics 
documentation, see 
[Statistics](geodeman/managing/statistics/chapter_overview.html).
+To assist with tuning, Geode statistics track message queues for durable 
clients through the disconnect and reconnect cycles.
 
-When the queue is full, it blocks further operations that add messages 
until the queue size drops to an acceptable level. The action to take is 
specified on the server. For details on configuring the queue, see 
[Implementing Durable Client/Server 
Messaging](geodeman/developing/events/implementing_durable_client_server_messaging.html).
+When the queue is full, it blocks further operations that add messages 
until the queue size drops to an acceptable level. Server configuration sets 
the action to take. See details on server configuration of the queue in the 
server documentation section [Implementing Durable Client/Server 
Messaging](geodeman/developing/events/implementing_durable_client_server_messaging.html).
 
-## Configuring a Durable Native Client Using gfcpp.properties
+## Configuring a Durable Client Using gfcpp.properties
--- End diff --

True. gfcpp.properties was changed to geode.properties with PR #13.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #46: GEODE-2603 Docs: geode-native user guide >> S...

2017-03-07 Thread davebarnes97
Github user davebarnes97 closed the pull request at:

https://github.com/apache/geode-native/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #46: GEODE-2603 Docs: geode-native user guide >> S...

2017-03-06 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/46

GEODE-2603 Docs: geode-native user guide >> Security >> SSL setup nee…

…ds update

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2603

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #46


commit 6b73495fd355f3ef730185eb78b7a343b2196510
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-03-06T23:45:33Z

GEODE-2603 Docs: geode-native user guide >> Security >> SSL setup needs 
update




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #413: GEODE-2591 User guide: Lucene headings should be re...

2017-03-03 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/413

GEODE-2591 User guide: Lucene headings should be reflected in navigat…

…ion pane

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2591

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/413.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #413


commit 15587b22c92c3df85d0c9249eac56f42fc0bf931
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-03-03T22:19:35Z

GEODE-2591 User guide: Lucene headings should be reflected in navigation 
pane




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #41: GEODE-2513 Rebrand Setting System Properties section

2017-02-28 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/41
  
+1
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #34: GEODE-2513 Rebrand Delta Propagation section of

2017-02-27 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/34
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #31: GEODE-2486 Developer can use encrypted cipher...

2017-02-23 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/31

GEODE-2486 Developer can use encrypted ciphers. Modified SSL section …

…to remove prior statement of limitations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2486

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit a8430291f1e36a74bcd8c24d749a2933fa48f7f7
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-02-24T01:56:01Z

GEODE-2486 Developer can use encrypted ciphers. Modified SSL section to 
remove prior statement of limitations.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #26: GEODE-2527 geode-native docs: Fix broken link...

2017-02-22 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/26

GEODE-2527 geode-native docs: Fix broken links to Geode User Manual

Fix links to geode userman by modifying a redirect entry.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2527

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit 2f2d064a80e93e7661f2ca3e235f0d9eb23a389c
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-02-22T22:50:04Z

GEODE-2527 geode-native docs: Fix broken links to Geode User Manual




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #20: GEODE-2512 Geode Native docs: book fails to b...

2017-02-21 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/20

GEODE-2512 Geode Native docs: book fails to build



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/GEODE-2512

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit 12e0230a9142136390fcf2694ced990fe6b8726b
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-02-21T23:32:00Z

GEODE-2512 Geode Native docs: book fails to build




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #366: GEODE-2282: Provide ability to sort field while cre...

2017-01-26 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/366

GEODE-2282: Provide ability to sort field while creating pdxType for …

…jSON document (Need to document system property)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2282

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/366.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #366


commit 5ea0bf0274d74f610ffbab0a1a2ae8ffadd31fc7
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-01-26T22:43:36Z

GEODE-2282: Provide ability to sort field while creating pdxType for jSON 
document (Need to document system property)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #364: GEODE-2353 Verify no clear-text passwords in docume...

2017-01-25 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/364

GEODE-2353 Verify no clear-text passwords in documentation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2353

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #364


commit 7a2485565b512724ca920552f44af3d6ccff5492
Author: Dave Barnes <dbar...@pivotal.io>
Date:   2017-01-26T01:30:05Z

GEODE-2353 Verify no clear-text passwords in documentation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #363: Feature/geode 2353

2017-01-25 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/363
  
Messy PR, will clean up and resubmit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #363: Feature/geode 2353

2017-01-25 Thread davebarnes97
Github user davebarnes97 closed the pull request at:

https://github.com/apache/geode/pull/363


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #363: Feature/geode 2353

2017-01-25 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/363

Feature/geode 2353



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2353

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #363






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode pull request #362: GEODE-2300 Document default names for start locator...

2017-01-25 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/362

GEODE-2300 Document default names for start locator/server

Documented new default naming convention for gfsh start locator and start 
server commands. Did not attempt to insert at every occurrence of the commands. 
Focused on introductory sections, and deleted the 'required' designation for 
the '--name' parameter in reference tables.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2300

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #362






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #328: [GEODE-2138] #comment Fix issues GEODE-2138

2017-01-03 Thread davebarnes97
Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/328
  
+1
Looks good to me. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---