[GitHub] geode pull request #648: GEODE-3206 : Corrected order of lucene search resul...
GitHub user deepakddixit opened a pull request: https://github.com/apache/geode/pull/648 GEODE-3206 : Corrected order of lucene search results based on score. * Lucene results with higher score value are more relevant than lower once. Used descending comparator for lucene search result based on score, so most relevant results will be listed first. * Added test case to verify the changed order. * Modified expected result from test case, as the order of result is changed to match relevancy of result searched. * Optimized imports with new style file. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [X] Is your initial contribution a single, squashed commit? - [X] Does `gradlew build` run cleanly? - [X] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/deepakddixit/incubator-geode bugfix/GEODE-3206 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/648.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #648 commit 4e0e921793f535fee9827b6c77ba63194bcc0f66 Author: Deepak Dixit <deepakdixit2...@gmail.com> Date: 2017-07-18T14:07:36Z GEODE-3206 : Corrected order of lucene search results based on score. * Lucene results with higher score value are more relevant than lower once. Using descending comparator for lucene search result based on score, so most relevant results will be listed first. * Added test case to verify the changed order. * Modified expected result from test case, as the order of result is changed to match relevancy of result searched. * Optimized imports with new style file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #568: GEODE-290: Removed deprecated methods from Launcher classe...
Github user deepakddixit commented on the issue: https://github.com/apache/geode/pull/568 @kirklund Thanks for review. As noted, I missed following commit guidelines. I have amended git message. Also updated PR title and description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #568: GEODE-290 : Removed deprecated method stopWithPort ...
GitHub user deepakddixit opened a pull request: https://github.com/apache/geode/pull/568 GEODE-290 : Removed deprecated method stopWithPort from LocatorLauncher⦠Removed deprecated properties. Modified test cases to use alternate constants. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? Yes. GEODE-290 - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [x] Have you written or updated unit tests to verify your changes? Modified existing test cases. - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/deepakddixit/incubator-geode GEODE-290 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/568.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #568 commit 920a8d13fb5ec221e1359e9ea6887d31f21d15d7 Author: Deepak Dixit <deepakdixit2...@gmail.com> Date: 2017-06-06T17:09:14Z GEODE-290 : Removed deprecated method stopWithPort from LocatorLauncher. Removed deprecated properties. Modified test cases to use alternate constants. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #541: GEODE-2960 : Trim field parameter values from creat...
GitHub user deepakddixit opened a pull request: https://github.com/apache/geode/pull/541 GEODE-2960 : Trim field parameter values from create lucene index. Added logic to trim leading and trailing spaces from values provided against 'field'. Modify existing test case to verify changes. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [x] Have you written or updated unit tests to verify your changes? Updated existing test. - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? No new dependency added. ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/deepakddixit/incubator-geode bug/GEODE-2960 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/541.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #541 commit cd853456c2622412dbcb2cd0807be613070d1269 Author: Deepak Dixit <deepakdixit2...@gmail.com> Date: 2017-05-26T11:29:41Z GEODE-2960 : Trim field parameter values from create lucene index. Added logic to trim leading and trailing spaces from values provided against 'field'. Modify existing test case to verify changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #526: GEODE-269 : Removing deprecated API's from Function...
GitHub user deepakddixit opened a pull request: https://github.com/apache/geode/pull/526 GEODE-269 : Removing deprecated API's from FunctionService. Modified test cases after removing deprecated API's Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? Yes.GEODE-269 - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? Yes - [x] Does `gradlew build` run cleanly? Yes - [x] Have you written or updated unit tests to verify your changes? Updated existing test cases. - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? No new dependencies added ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/deepakddixit/incubator-geode GEODE-269 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/526.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #526 commit 4d1663fde42272dcb730d490afe553725442ef37 Author: Deepak Dixit <deepakdixit2...@gmail.com> Date: 2017-05-23T04:17:13Z GEODE-269 : Removing deprecated API's from FunctionService. Modified test cases after removing deprecated API's --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #511: Feature/geode 269
Github user deepakddixit commented on the issue: https://github.com/apache/geode/pull/511 @jhuynh1 Sure will open new PR without conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #511: Feature/geode 269
GitHub user deepakddixit opened a pull request: https://github.com/apache/geode/pull/511 Feature/geode 269 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? Yes. JIRA reference is GEODE-269. - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? Yes. - [ ] Is your initial contribution a single, squashed commit? No. It is multiple commit, one actual code change and other is resolving conflict with latest develop - [ ] Does `gradlew build` run cleanly? Yes - [ ] Have you written or updated unit tests to verify your changes? Updated unit tests - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? Not adding dependencies. ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/deepakddixit/incubator-geode feature/GEODE-269 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #511 commit e2f337a23303822f8cd28bc887afca7203759673 Author: Deepak Dixit <deepakdixit2...@gmail.com> Date: 2017-05-10T16:52:03Z GEODE-269 : Removing deprecated API's from FunctionService. commit 929687e28335ee5ace679be5c540857080afd48f Author: Deepak Dixit <deepakdixit2...@gmail.com> Date: 2017-05-12T08:33:39Z GEODE-269 : Resolving conflicts with develop. commit 3054de42d38aa8bfadd8912f0ab4dde259a701ef Author: Deepak Dixit <deepakdixit2...@gmail.com> Date: 2017-05-12T08:38:21Z GEODE-269 : Resolving conflicts with develop. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #326: Feature/geode 2103 : Adding --http-service-port and --http...
Github user deepakddixit commented on the issue: https://github.com/apache/geode/pull/326 @metatype I have updated the golden-help-offline.properties. The integration test HelpCommandsIntegrationTest is generic one checking the help and confirms the contents from golden-help-offline.properties. It is passing with changes made in golden-help-offline.properties --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #327: GEODE-2236: Remove all cache-listners using Gfsh
GitHub user deepakddixit opened a pull request: https://github.com/apache/geode/pull/327 GEODE-2236: Remove all cache-listners using Gfsh Added check before instantiating cache listner class. Added test to verify change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/deepakddixit/incubator-geode bugfix/GEODE-2236 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/327.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #327 commit 8fe84be51f2ce5e4a604a440bcf0662f227d69ca Author: Deepak Dixit <deepakdixit2...@gmail.com> Date: 2017-01-02T06:34:24Z GEODE-2236: Remove all cache-listners using Gfsh Added check before instantiating cache listner class. Added test to verify change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #326: Feature/geode 2103 : Adding --http-service-port and...
GitHub user deepakddixit opened a pull request: https://github.com/apache/geode/pull/326 Feature/geode 2103 : Adding --http-service-port and --http-service-bind-address option in start locator command You can merge this pull request into a Git repository by running: $ git pull https://github.com/deepakddixit/incubator-geode feature/GEODE-2103 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/326.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #326 commit f5428414f976c20989d2e8a4e9c152b079789b4c Author: Deepak Dixit <deepakdixit2...@gmail.com> Date: 2016-12-24T05:12:55Z GEODE-2103: start locator command should include --http-service-port and --http-service-bind-address Adding --http-service-port and --http-service-bind-address parameters to start locator command Added Junit test to verify command line parameters commit 6d6d856b705a35b204521e3a90c61315f1bb93c7 Author: Deepak Dixit <deepakdixit2...@gmail.com> Date: 2016-12-24T05:32:57Z GEODE-2103: start locator command should include --http-service-port and --http-service-bind-address Fixing HelpCommandsIntegrationTest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #297: GEODE-734: gfsh export stack-traces should not require an ...
Github user deepakddixit commented on the issue: https://github.com/apache/geode/pull/297 Thank you @kirklund and @metatype for review and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #297: GEODE-734: gfsh export stack-traces should not r...
Github user deepakddixit commented on the issue: https://github.com/apache/incubator-geode/pull/297 @metatype and @kirklund I have addressed the review comments. Kindly have a look. precheckin is successful. I am not sure why travis is failed with spotlessJavaCheck, at my box it is successful. I tried spotlessApply but it shows no changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #297: GEODE-734: gfsh export stack-traces shoul...
Github user deepakddixit commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/297#discussion_r90585692
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowStackTraceDUnitTest.java
---
@@ -90,6 +90,20 @@ public void run() {
public void testExportStacktrace() throws ClassNotFoundException,
IOException {
setupSystem();
+// Test non txt extension file is allowed
+File stacktracesFile = new File("allStackTraces.log");
--- End diff --
Thanks @kirklund. Will use TemporaryFolder to work with files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
