[GitHub] geode issue #749: GEODE-3502: Added awaitility clauses.

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/749
  
@ladyVader @jhuynh1 @upthewaterspout @boglesby 
-- Potential reviewers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #749: GEODE-3502: Added awaitility clauses.

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/749

GEODE-3502: Added awaitility clauses.

* Added awaitility clauses while waiting for the stat comparison checks
* Replaced the deprecated Wait Criterion with Awaitility clause with 
increased timeout
* Replaced the invokeAsync with invoke to make the test identical to 
the one in ClientHealthStatsDUnitTest
* Removed the commented out flaky tag

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3502

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/749.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #749


commit 1c24be8dfb1e57d6fa8db96871103890fdde
Author: nabarun <n...@pivotal.io>
Date:   2017-08-29T18:05:28Z

GEODE-3502: Added awaitility clauses.

* Added awaitility clauses while waiting for the stat comparison checks
* Replaced the deprecated Wait Criterion with Awaitility clause with 
increased timeout
* Replaced the invokeAsync with invoke to make the test identical to 
the one in ClientHealthStatsDUnitTest
* Removed the commented out flaky tag




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #743: GEODE-3131: Increasing the time

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/743

GEODE-3131: Increasing the time

* Increasing the time elapsed before the dispatchers are started.
* All validations must be done before the dispatcher start dispatching.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3131

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/743.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #743


commit ab1988b765d6192101aa0fccbce9e0ac9f8e3b14
Author: nabarun <n...@pivotal.io>
Date:   2017-08-24T23:02:21Z

GEODE-3131: Increasing the time

* Increasing the time elapsed before the dispatchers are started.
* All validations must be done before the dispatcher start dispatching.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #732: GEODE-3276: Managing race conditions while the send...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/732

GEODE-3276: Managing race conditions while the senders are stopped

* When a connection is initialized, a readAckThread may be alive from a 
previous incarnation.
* This AckThread will be stuck on a read socket with no timeout as 
nothing was dispatched.
* Also while it was stuck on the read, it will hold a connection 
lifecycle read lock
* The initialize connection needs a connection life cycle write lock to 
start the connection but the read lock is held by the ack thread.
* This results in a deadlock and eventually a hang.
* Another situation is that we set the flag isStopped for the event 
processor before actually shutting down the diapatcher and ack thread.
* So after the flag is set and before actually shutting down the 
dispatcher and ackThread, a gateway proxy stomper thread gets in between these 
two steps of execution.
* The stomper thread checks the isStopped flag, which was set to true, 
and proceeds to destroy the connection pool. However the dispatcher and 
ackThread were still running.
* This results in a out of heap memory exception while the ack thread 
is reading from the socket while connection pool was destroyed.
* To solve this issue, the stomper thread checks if the event processor 
and dispatcher exists, if true then we close the input streams before 
destroying the connection pool.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3276

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #732


commit 9618f69d2620f5a3d3a6a8576631906a61b512f9
Author: nabarun <n...@pivotal.io>
Date:   2017-08-17T17:51:15Z

GEODE-3276: Managing race conditions while the senders are stopped

* When a connection is initialized, a readAckThread may be alive from a 
previous incarnation.
* This AckThread will be stuck on a read socket with no timeout as 
nothing was dispatched.
* Also while it was stuck on the read, it will hold a connection 
lifecycle read lock
* The initialize connection needs a connection life cycle write lock to 
start the connection but the read lock is held by the ack thread.
* This results in a deadlock and eventually a hang.
* Another situation is that we set the flag isStopped for the event 
processor before actually shutting down the diapatcher and ack thread.
* So after the flag is set and before actually shutting down the 
dispatcher and ackThread, a gateway proxy stomper thread gets in between these 
two steps of execution.
* The stomper thread checks the isStopped flag, which was set to true, 
and proceeds to destroy the connection pool. However the dispatcher and 
ackThread were still running.
* This results in a out of heap memory exception while the ack thread 
is reading from the socket while connection pool was destroyed.
* To solve this issue, the stomper thread checks if the event processor 
and dispatcher exists, if true then we close the input streams before 
destroying the connection pool.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

[nabarunnag]

Github user nabarunnag closed the pull request at:

https://github.com/apache/geode/pull/659


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #681: Lucene refactoring and clean up

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/681
  
Potential reviewers
@ladyVader @jhuynh1 @boglesby @upthewaterspout @gesterzhou


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #681: Lucene refactoring and clean up

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/681

Lucene refactoring and clean up

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3387

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #681


commit 2cfa243ece0494dc983f04e1f1300c46713db5b4
Author: nabarun <n...@pivotal.io>
Date:   2017-08-03T01:31:52Z

GEODE-3387: Cleaned up and minor refactoring of lucene module

* In waitUntilFlushedFunction, cleaned out the unused vaiables
* Removed mentions of gemfire from the module in comments
* Removed comment “/* wrapper of IndexWriter */“ in 
LuceneIndexForPartitionedRegion
* Renamed initializeAEQ to more suitable / function appropriate name.

commit 90f1dff2d6b5c197410ccb13f3a76a2751f10221
Author: nabarun <n...@pivotal.io>
Date:   2017-08-03T02:37:47Z

GEODE-3387: Removing the unused imports and typos




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #678: GEODE-3384: Javadoc change for PageableLuceneQueryR...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/678

GEODE-3384: Javadoc change for PageableLuceneQueryResults

* Javadocs now mention that PageableLuceneQueryResults are serializable 
and can be sent to other members

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3384

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #678


commit 5eddfc9ac1b70757e7dedf9c4e8cb9d0c3078614
Author: nabarun <n...@pivotal.io>
Date:   2017-08-02T17:26:07Z

GEODE-3384: Javadoc change for PageabelLuceneQueryResults

* Javadocs now mention that PageableLuceneQueryResults are serializable 
and can be sent to other members




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #674: GEODE-3380: There're 2 problems here

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/674#discussion_r130654524
  
--- Diff: 
geode-cq/src/test/java/org/apache/geode/internal/cache/PutAllCSDUnitTest.java 
---
@@ -500,6 +502,81 @@ public void run2() throws CacheException {
   }
 
   /**
+   * Create PR without redundancy on 2 servers with lucene index. Feed 
some key s. From a client, do
+   * removeAll on keys in server1. During the removeAll, restart server1 
and trigger the removeAll
+   * to retry. The retried removeAll should return the version tag of 
tombstones. Do removeAll again
+   * on the same key, it should get the version tag again.
+   */
+  @Test
+  public void test51871() throws CacheException, InterruptedException {
--- End diff --

Will it be possible to change the test name to follow the when() naming convention


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/659#discussion_r129679647
  
--- Diff: 
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java
 ---
@@ -0,0 +1,1044 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.cache.lucene;
+
+import static org.apache.geode.test.dunit.Assert.fail;
+import static org.junit.Assert.assertEquals;
+
+import java.io.File;
+import java.io.IOException;
+import java.lang.reflect.Constructor;
+import java.lang.reflect.Method;
+import java.net.InetAddress;
+import java.net.UnknownHostException;
+import java.util.Collection;
+import java.util.List;
+import java.util.Properties;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.commons.io.FileUtils;
+import org.apache.logging.log4j.Logger;
+import org.awaitility.Awaitility;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import org.apache.geode.cache.GemFireCache;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.cache.client.ClientRegionFactory;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.cache.server.CacheServer;
+import org.apache.geode.cache30.CacheSerializableRunnable;
+import org.apache.geode.distributed.Locator;
+import org.apache.geode.distributed.internal.DistributionConfig;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.internal.Version;
+import org.apache.geode.internal.cache.GemFireCacheImpl;
+import org.apache.geode.internal.logging.LogService;
+import org.apache.geode.test.dunit.DistributedTestUtils;
+import org.apache.geode.test.dunit.Host;
+import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.Invoke;
+import org.apache.geode.test.dunit.NetworkUtils;
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase;
+import org.apache.geode.test.dunit.standalone.DUnitLauncher;
+import org.apache.geode.test.dunit.standalone.VersionManager;
+import org.apache.geode.test.junit.categories.BackwardCompatibilityTest;
+import org.apache.geode.test.junit.categories.DistributedTest;
+import 
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
+
+@Category({DistributedTest.class, BackwardCompatibilityTest.class})
+@RunWith(Parameterized.class)

+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
+public class LuceneSearchWithRollingUpgradeDUnit extends 
JUnit4DistributedTestCase {
+
+
+  @Parameterized.Parameters
+  public static Collection data() {
+List result = 
VersionManager.getInstance().getVersionsWithoutCurrent();
+// Lucene Compatibility checks start with Apache Geode v1.2.0
+// Removing the versions older than v1.2.0
+result.removeIf(s -> Integer.parseInt(s) < 120);
+if (result.size() < 1) {
+  throw new RuntimeException("No older versions of Geode were found to 
test against");
+} else {
+  System.out.println("running against these versions: " + result);
+}
+return result;
+  }
+
+  private File[] testingDirs = new File[3];
+
+  private static String INDEX_NAME = "index";
+
+  private static String diskDir = "LuceneSearchWithRollingUpgradeDUnit";
+
+  // Each vm will have a cache object
+  private static Object cache;
+
+  // the old version of Geode we're testing against
+  private String oldVersion;
+
+  private void deleteVMFiles() throws Exception {
+System.out.println("d

[GitHub] geode issue #659: GEODE-3308: Lucene rolling upgrade and backwards compatibi...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/659
  
* These tests were ported from RollingUpgradeDUnitTest and 
RollingUpgrade2DUnitTest
* Instead of put and get verification, it is now lucent query result size 
verification

Potential Reviewers
@ladyVader @jhuynh1 @DivineEnder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/659

GEODE-3308: Lucene rolling upgrade and backwards compatibility tests …

…added
 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3308

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #659


commit c9d9e71e8d31feccfd1c7d0ba2ac83d7296fbcbf
Author: nabarun <n...@pivotal.io>
Date:   2017-07-18T23:09:28Z

GEODE-3308: Lucene rolling upgrade and backwards compatibility tests added




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #628: GEODE-3131: Replaced Thread.sleep

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/628
  
Thank you @ladyVader .
Fixed the typo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #628: GEODE-3131: Replaced Thread.sleep

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/628
  
Potential Reviewers:
@ladyVader @boglesby @jhuynh1 @upthewaterspout @gesterzhou @DivineEnder 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #628: GEODE-3131: Replaced Thread.sleep

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/628

GEODE-3131: Replaced Thread.sleep

* Replaced sleeps with an Awaitility clause which waits for the region 
sizes to be correct before starting validation.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3131

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/628.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #628


commit 5d3d3cc8f5cf7bb69f28bd55024f6906fc41040a
Author: nabarun <n...@pivotal.io>
Date:   2017-07-12T21:07:48Z

GEODE-3131: Replaced Thread.sleep

* Replaced sleeps with an Awaitility clause which waits for the region 
sizes to be correct before starting validation.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #625: GEODE-1988: Increased the readTimeout

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/625
  
Potential reviewers
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/622
  
Merging into develop


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #588: GEODE-2820: Added awaitlity clause to wait for the region ...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/588
  
@jhuynh1 Changed the validation  checks to verify that the size of the 
indexes are correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #588: GEODE-2820: Added awaitlity clause to wait for the ...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/588

GEODE-2820: Added awaitlity clause to wait for the region size to be …

…correct

* Added awaitility clause to wait for all the regions to have all the 
entries
* This is done to make sure that the queries are executed.
* This may not solve the issue of queries being executed before async 
index is updated
* However this shortens the window of failure happening.


Potential reviewers
@jhuynh1 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2820

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/588.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #588


commit 61ebad2b6d8f2b06a69f1de669e1be49008b6136
Author: nabarun <n...@pivotal.io>
Date:   2017-06-15T23:32:46Z

GEODE-2820: Added awaitlity clause to wait for the region size to be correct

* Added awaitility clause to wait for all the regions to have all the 
entries
* This is done to make sure that the queries are executed.
* This may not solve the issue of queries being executed before async 
index is updated
* However this shortens the window of failure happening.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #574: GEODE-3066: Test tweaks to stabilize it.

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/574
  
@jhuynh1 , Last when we experimented with this function in WANTestBase 
tests, the listener is destroyed once the vm is closed, which I believe that 
happens at the end of each test.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #574: GEODE-3066: Test tweaks to stabilize it.

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/574

GEODE-3066: Test tweaks to stabilize it.

* Regions created before senders and receivers are started.
* Added a listener to slow down the puts so that when the remote region 
is destroyed, the put operation is still ongoing.

Potential reviewers
@jhuynh1 @upthewaterspout @boglesby @ladyVader @gesterzhou 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3066

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/574.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #574


commit d7565767794697ae231b3702903e001aa9cf4dc4
Author: nabarun <n...@pivotal.io>
Date:   2017-06-12T18:33:37Z

GEODE-3066: Test tweaks to stabilize it.

* Regions created before senders and receivers are started.
* Added a listener to slow down the puts so that when the remote region 
is destroyed, the put operation is still ongoing.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #562: GEODE-3025: GET operation before Lucene query

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/562
  
@ladyVader @upthewaterspout @boglesby @gesterzhou 
-- Adding more potential reviewers.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #562: GEODE-3025: GET operation before Lucene query

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/562

GEODE-3025: GET operation before Lucene query

* To allow Lucene queries in single hop with transaction enabled mode, 
the client must get the metadata about the regions.
* A Get operation will asynchronously fetch the metadata and the Lucene 
query will not throw an exception.

@jhuynh1 
Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-3025

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #562


commit bb8e94ffa340a82fe3304959f0b4ddd20edaad85
Author: nabarun <n...@pivotal.io>
Date:   2017-06-05T21:44:39Z

GEODE-3025: GET operation before Lucene query

* To allow Lucene queries in single hop with transaction enabled mode, 
the client must get the metadata about the regions.
* A Get operation will asynchronously fetch the metadata and the Lucene 
query will not throw an exception.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #547: GEODE-2957: Create Lucene index analyzer help updated to i...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/547
  
I will be merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #543: GEODE-2957 gfsh create lucene index "null" becomes "DEFAUL...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/543
  
I will be merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #541: GEODE-2960 : Trim field parameter values from create lucen...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/541
  
Working on merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #523: GEODE-2967: ResultCollection instead of StructCollection

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/523
  
@DivineEnder



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #523: GEODE-2967: ResultCollection instead of StructColle...

[nabarunnag]

Github user nabarunnag closed the pull request at:

https://github.com/apache/geode/pull/523


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #526: GEODE-269 : Removing deprecated API's from FunctionService...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/526
  
Working on merging this change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #523: GEODE-2967: ResultCollection instead of StructCollection

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/523
  
Potential reviewers
@jhuynh1 @ladyVader @boglesby @gesterzhou @upthewaterspout 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #523: GEODE-2967: ResultCollection instead of StructColle...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/523

GEODE-2967: ResultCollection instead of StructCollection

* If we have one runtime iterator which is in case of self joins, 
ResultSet or ResultBags are created
* Otherwise StructBag or StructSets are used

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2967

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/523.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #523


commit dfa777eff383119d99fe51d2ec6bfb7c099ca643
Author: nabarun <n...@pivotal.io>
Date:   2017-05-22T18:34:52Z

GEODE-2967: ResultCollection instead of StructCollection

* If we have one runtime iterator which is in case of self joins, 
ResultSet or ResultBags are created
* Otherwise StructBag or StructSets are used




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/517
  
Yes, we are opening a new ticket for eliminating the repeated code.
Analyzing the testcode for ORDER BY queries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/517
  
@ladyVader I am assuming that there should be tests already present testing 
the functional aspect. One of the tests did fail and caught an issue in my fix.
@jhuynh1 what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/517
  
Potential Reviewers
@ladyVader @jhuynh1 @boglesby @upthewaterspout @gesterzhou  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #517: GEODE-2587: Refactored the OrderByComparator's comp...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/517

GEODE-2587: Refactored the OrderByComparator's compare method

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2587

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #517


commit 5a2a36e05cb0dbf88a527091797da256780a1cc4
Author: nabarunnag <n...@cs.wisc.edu>
Date:   2017-05-15T05:19:26Z

GEODE-2587: Refactored the OrderByComparator's compare method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #516: GEODE-2587: Refactored the OrderByComparator's comp...

[nabarunnag]

Github user nabarunnag closed the pull request at:

https://github.com/apache/geode/pull/516


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #516: GEODE-2587: Refactored the OrderByComparator's comp...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/516

GEODE-2587: Refactored the OrderByComparator's compare method

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2587

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/516.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #516


commit edf70471a8efc963d3086e663918a67b039b2efd
Author: nabarunnag <n...@cs.wisc.edu>
Date:   2017-05-15T05:19:26Z

GEODE-2587: Refactored the OrderByComparator's compare method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #514: GEODE-2905: Added extra logging to determine the ca...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/514

GEODE-2905: Added extra logging to determine the cause of failure.

* Replaced assertTrue with assertEquals so that the commandResult is 
displayed in case of an error.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2905

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #514


commit a3c347e8a21e3d53152a0bdb03ae79c094489da6
Author: nabarunnag <n...@cs.wisc.edu>
Date:   2017-05-14T18:17:02Z

GEODE-2905: Added extra logging to determine the cause of failure.

* Replaced assertTrue with assertEquals so that the commandResult is 
displayed in case of an error.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #512: GEODE-2637: Refactored LuceneQueryFactory.setResultLimit()

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/512
  
Potential reviewers
@ladyVader @upthewaterspout @jhuynh1 @boglesby @gesterzhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #512: GEODE-2637: Refactored LuceneQueryFactory.setResult...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/512

GEODE-2637: Refactored LuceneQueryFactory.setResultLimit()

* Renamed LuceneQueryFactory.getResult to setLimit()
* This is done to match the cwiki documents

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2637

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/512.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #512


commit efbe53cbafe30c5fb17681e22a3c83f3042e08ae
Author: nabarunnag <n...@cs.wisc.edu>
Date:   2017-05-12T13:01:01Z

GEODE-2637: Refactored LuceneQueryFactory.setResultLimit()

* Renamed LuceneQueryFactory.getResult to setLimit()
* This is done to match the cwiki documents




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115629507
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java
 ---
@@ -39,6 +41,8 @@
* Return score the score of the entry matching the query. Scores are 
computed by Lucene based on
* how closely documents match the query.
*
+   * @return float value representing the score of the document / entry 
obtained as a result of
--- End diff --

Fixed on both the lines


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115629448
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java ---
@@ -19,39 +19,62 @@
 
 import org.apache.lucene.analysis.Analyzer;
 
-import org.apache.geode.annotations.Experimental;
-
 
 /**
  * 
- * An Lucene index is built over the data stored in a GemFire Region.
+ * LuceneIndex represents the Lucene index created over the data stored in 
Apache Geode regions. The
+ * Lucene indexes are maintained automatically by Apache Geode whenever 
the entries are updated in
+ * the associated regions. Lucene Indexes are created using {@link 
LuceneService#createIndexFactory}
+ * by specifying the Lucene index name, the region associated with the 
Lucene index, the fields on
--- End diff --

Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/503#discussion_r115629459
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java ---
@@ -37,21 +42,38 @@
  * Results are returned in order of their score with respect to this query.
  * 
  */
-@Experimental
 public interface LuceneQuery<K, V> {
   /**
* Execute the query and return the region keys that match this query, 
up to the limit specified
* by {@link #getLimit()}.
-   * 
+   *
+   * @return Collection of Apache Geode region keys that satisfy the 
Lucene query.
* @throws LuceneQueryException if the query could not be parsed or 
executed.
+   * @throws CacheClosedException if the cache was closed while the Lucene 
query was being executed.
+   * @throws PrimaryBucketException if the primary bucket was moved from 
the node on which the
--- End diff --




Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/503

GEODE-2907: Removed @Experimental tag from the Lucene module

* Removed the @experimental tag fromt the files in Lucene module.
* Improve on the javadocs for the interfaces present in the Lucene 
module.

This is the first draft for the javadocs improvements as a part of the task 
to remove the @Experimatal tags present in the Lucene Module.

Potential reviewers
@upthewaterspout @jhuynh1 @boglesby @ladyVader @gesterzhou 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2907

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #503


commit daf89a331ce59c87ca0d1c3c414bf76f78c1edfb
Author: nabarun <n...@pivotal.io>
Date:   2017-05-09T22:15:59Z

GEODE-2907: Removed @Experimental tag from the Lucene module

* Removed the @experimental tag fromt the files in Lucene module.
* Improve on the javadocs for the interfaces present in the Lucene 
module.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #492: GEODE-2754: Changed the name of unknown host

[nabarunnag]

Github user nabarunnag closed the pull request at:

https://github.com/apache/geode/pull/492


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #498: GEODE-2881: Wait for waitForFlushBeforeExecuteTextS...

[nabarunnag]

Github user nabarunnag closed the pull request at:

https://github.com/apache/geode/pull/498


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #499: GEODE-2879: Shutdown() called from close() in Loner...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/499

GEODE-2879: Shutdown() called from close() in LonerDistributionManager

* LonerDistributionManager shutdown was not being called from close() 
method call.
* This resulted in the thread pool's threads to wait for 1 minute of 
inactivity for them to be killed.
* This resulted in an extra delay while test executions.
* shutdown called from close method

Potential reviewers
@upthewaterspout @jhuynh1 @gesterzhou @ladyVader @boglesby 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2879

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #499


commit 57ff93335a01d8ae49fb087a0cd299dbb426485a
Author: nabarun <n...@pivotal.io>
Date:   2017-05-05T23:28:17Z

GEODE-2879: Shutdown() called from close() in LonerDistributionManager

* LonerDistributionManager shutdown was not being called from close() 
method call.
* This resulted in the thread pool's threads to wait for 1 minute of 
inactivity for them to be killed.
* This resulted in an extra delay while test executions.
* shutdown called from close method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #498: GEODE-2881: Wait for waitForFlushBeforeExecuteTextS...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/498

GEODE-2881: Wait for waitForFlushBeforeExecuteTextSearch to complete

* Test now waits for waitForFlushBeforeExecuteTextSearch initiated by 
the test hook.
* The test hook gets called when GII is requested.
* This task may hit CacheClosedException if the test get completed 
before the flush operations of GII


Potential Reviewers
@upthewaterspout @jhuynh1 @gesterzhou @ladyVader 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2881

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/498.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #498


commit 2e7c610adefe01f81c98acf3294aacede18a5c91
Author: nabarun <n...@pivotal.io>
Date:   2017-05-06T00:13:20Z

GEODE-2881: Wait for waitForFlushBeforeExecuteTextSearch to complete

* Test now waits for waitForFlushBeforeExecuteTextSearch initiated by 
the test hook.
* The test hook gets called when GII is requested.
* This task may hit CacheClosedException if the test get completed 
before the flush operations of GII




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #492: GEODE-2754: Changed the name of unknown host

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/492

GEODE-2754: Changed the name of unknown host

* Assert failures occured if the network contained machines named 
"unknown" as the test function also named the unknown host as "unknown"
* This led to test to find multiple machines named "unknown" rather 
than one.
* Changed the name of the unknown host set by the test to be 
"unknownGeodeHostWanAutoDiscoveryDUnitTest"

Potential reviewers:
@jhuynh1 @upthewaterspout @gesterzhou @ladyVader @boglesby 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2754

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #492


commit e2c50637e36d3a51abf4469d02c8843fff3b25fd
Author: nabarun <n...@pivotal.io>
Date:   2017-05-04T00:45:45Z

GEODE-2754: Changed the name of unknown host

* Assert failures occured if the network contained machines named 
"unknown" as the test function also named the unknown host as "unknown"
* This led to test to find multiple machines named "unknown" rather 
than one.
* Changed the name of the unknown host set by the test to be 
"unknownGeodeHostWanAutoDiscoveryDUnitTest"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114175681
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 ---
@@ -78,17 +87,9 @@ protected RepositoryManager createRepositoryManager() {
 // create PR fileAndChunkRegion, but not to create its buckets for now
 final String fileRegionName = createFileRegionName();
 PartitionAttributes partitionAttributes = 
dataRegion.getPartitionAttributes();
-
-
-// create PR chunkRegion, but not to create its buckets for now
-
-// we will create RegionDirectories on the fly when data comes in
-HeterogeneousLuceneSerializer mapper = new 
HeterogeneousLuceneSerializer(getFieldNames());
-PartitionedRepositoryManager partitionedRepositoryManager =
-new PartitionedRepositoryManager(this, mapper);
 DM dm = 
this.cache.getInternalDistributedSystem().getDistributionManager();
 LuceneBucketListener lucenePrimaryBucketListener =
-new LuceneBucketListener(partitionedRepositoryManager, dm);
+new LuceneBucketListener((PartitionedRepositoryManager) 
partitionedRepositoryManager, dm);
--- End diff --

I made createLuceneListenerAndFileChunkRegion method take in 
PartitionedRepositoryManager
which removed all the casting in the LuceneIndexForPartitionRegion.java but 
I would like a suggestion on how to remove the casting in 
createLuceneListenersAndFileChunkRegions(  (PartitionedRepositoryManager) 
repositoryManager); in the LuceneIndexImpl.java file. As the repositoryManager 
is being created by createRepositoryManager() which creates  repository manager 
for both RawLuceneIndex as well as LuceneIndexForPartitionRegion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114175765
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
 ---
@@ -131,30 +131,41 @@ protected void initialize() {
 if (!hasInitialized) {
   /* create index region */
   dataRegion = getDataRegion();
-  // assert dataRegion != null;
-
-  repositoryManager = createRepositoryManager();
-
-  // create AEQ, AEQ listener and specify the listener to 
repositoryManager
-  createAEQ(dataRegion);
-
+  createLuceneListenersAndFileChunkRegions(
+  (AbstractPartitionedRepositoryManager) repositoryManager);
--- End diff --

Please refer to the comment above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114164780
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 ---
@@ -111,6 +121,10 @@ protected IndexRepository computeRepository(Integer 
bucketId) {
 return repo;
   }
 
+  protected void allowRepositoryComputation() {
--- End diff --

I was under the impression that the latch is waiting before 
indexRepositories.compute in the computeRepositories method call hence the repo 
was not created yet. But the coutdown allows it to move ahead an compute the 
repository.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/481

GEODE-2828: AEQ being created before the user region

Potential Reviewers
@gesterzhou @jhuynh1 @upthewaterspout @ladyVader @boglesby 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2828

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/481.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #481


commit eb3f7e988c518c2009acfd3f49a6f6bab987bfb0
Author: nabarun <n...@pivotal.io>
Date:   2017-04-26T01:20:37Z

GEODE-2828: AEQ being created before the user region




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region

[nabarunnag]

Github user nabarunnag closed the pull request at:

https://github.com/apache/geode/pull/479


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #479: GEODE-2828: AEQ created before the user region

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/479
  
Sending in a fresh pull request with all modification


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/479#discussion_r113630780
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java
 ---
@@ -53,6 +54,8 @@
   Logger logger = LogService.getLogger();
 
   private final RepositoryManager repositoryManager;
+  private CountDownLatch isFileAndChunkRegionReady = new CountDownLatch(1);
+  private boolean ready = false;
--- End diff --

Removed the flag and lucene precheckin was success.
Futher testing is ongoing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/479#discussion_r113630711
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
 ---
@@ -166,28 +166,28 @@ public void createIndex(final String indexName, 
String regionPath, final Analyze
* 
* Public because this is called by the Xml parsing code
*/
-  public void afterDataRegionCreated(final String indexName, final 
Analyzer analyzer,
-  final String dataRegionPath, final Map<String, Analyzer> 
fieldAnalyzers,
-  final String... fields) {
-LuceneIndexImpl index = createIndexRegions(indexName, dataRegionPath);
-index.setSearchableFields(fields);
-index.setAnalyzer(analyzer);
-index.setFieldAnalyzers(fieldAnalyzers);
+  public void afterDataRegionCreated(LuceneIndexImpl index) {
 index.initialize();
 registerIndex(index);
 if (this.managementListener != null) {
   this.managementListener.afterIndexCreated(index);
 }
+
+  }
+
+  public LuceneIndexImpl beforeDataRegionCreated(final String indexName, 
final String regionPath,
+  RegionAttributes attributes, final Analyzer analyzer,
+  final Map<String, Analyzer> fieldAnalyzers, String aeqId, final 
String... fields) {
+LuceneIndexImpl index = createIndexRegions(indexName, regionPath);
--- End diff --

Changed it to createIndexObject - any better suggestion is welcomed 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #476: GEODE-2816: Redundancy recovery inititiated even if...

[nabarunnag]

Github user nabarunnag closed the pull request at:

https://github.com/apache/geode/pull/476


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #479: GEM-1331: AEQ created before the user region

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/479
  
Pushed to develop
Failure in Travis fixed in GEODE-2632


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #479: GEM-1331: AEQ created before the user region

[nabarunnag]

GitHub user nabarunnag reopened a pull request:

https://github.com/apache/geode/pull/479

GEM-1331: AEQ created before the user region

Potential reviewers
@gesterzhou @upthewaterspout @jhuynh1 @ladyVader 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2828

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/479.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #479


commit 01e70078cec53536807b0e85dd30fca7ad790de2
Author: nabarun <n...@pivotal.io>
Date:   2017-04-26T01:20:37Z

GEODE-2828: AEQ being created before the user region




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #479: GEM-1331: AEQ created before the user region

[nabarunnag]

Github user nabarunnag closed the pull request at:

https://github.com/apache/geode/pull/479


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #479: GEM-1331: AEQ created before the user region

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/479

GEM-1331: AEQ created before the user region

Potential reviewers
@gesterzhou @upthewaterspout @jhuynh1 @ladyVader 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2828

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/479.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #479


commit 01e70078cec53536807b0e85dd30fca7ad790de2
Author: nabarun <n...@pivotal.io>
Date:   2017-04-26T01:20:37Z

GEODE-2828: AEQ being created before the user region




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #442: AEQ being created before region

[nabarunnag]

Github user nabarunnag closed the pull request at:

https://github.com/apache/geode/pull/442


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #476: GEODE-2816: Redundancy recovery inititiated even if...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/476

GEODE-2816: Redundancy recovery inititiated even if redundancy set to 0

Potential reviewers
@upthewaterspout @jhuynh1 @gesterzhou @boglesby @ladyVader 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2816

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #476


commit 074349cd03c3e19ea16ee80a6c257a6d7a7322b3
Author: nabarun <n...@pivotal.io>
Date:   2017-04-24T17:50:06Z

GEODE-2816: Redundancy recovery inititated even if redundancy set to 0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #449: GEODE-2764: Added checks on the region name

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/449
  
@jhuynh1 
I have the changes you mentioned and also added a dunit test to confirm the 
behaviour


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #451: GEODE-2768: Lucene Queries executed before index is...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/451#discussion_r111272945
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java
 ---
@@ -132,6 +133,25 @@ private LuceneIndexImpl getLuceneIndex(final Region 
region,
 try {
   index =
   (LuceneIndexImpl) service.getIndex(searchContext.getIndexName(), 
region.getFullPath());
+  if (index == null && service instanceof LuceneServiceImpl) {
+if (((LuceneServiceImpl) 
service).getDefinedIndex(searchContext.getIndexName(),
+region.getFullPath()) != null) {
+  // The node may be in the process of recovering, where we have 
the index defined but yet
+  // to be recovered
+  // If we retry fast enough, we could get a stack overflow based 
on the way function
+  // execution is currently written
+  // Instead we will add an artificial sleep to slow down the 
retry at this point
+  // Hopefully in the future, the function execution would retry 
without adding to the stack
+  // and this can be removed
+  try {
--- End diff --

Can there be a possibility that this node never recovers but another node 
is ready to execute the query and we are stuck here for 10 seconds?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #449: GEODE-2764: Added checks on the region name

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/449#discussion_r111037135
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/CreateIndexFunction.java
 ---
@@ -93,6 +91,31 @@ public void execute(FunctionContext context) {
 }
   }
 
+  private void setResultInSender(FunctionContext context, IndexInfo 
indexInfo, String memberId,
+  Cache cache, String regionPath) {
+if (regionPath == null) {
+  String message = 
CliStrings.format(CliStrings.CREATE_INDEX__INVALID__REGIONPATH,
+  indexInfo.getRegionPath());
+  context.getResultSender().lastResult(new CliFunctionResult(memberId, 
false, message));
+} else {
+  XmlEntity xmlEntity =
+  new XmlEntity(CacheXml.REGION, "name", 
cache.getRegion(regionPath).getName());
+  context.getResultSender().lastResult(new CliFunctionResult(memberId, 
xmlEntity));
+}
+  }
+
+  private String getValidRegionName(Cache cache, String regionPath) {
+while (cache.getRegion(regionPath) == null && regionPath != null) {
--- End diff --

Its fixed now.
thank you !!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #449: GEODE-2764: Added checks on the region name

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/449

GEODE-2764: Added checks on the region name

* Substring the region name till the last occurance of '.'
* Check if this substring is a valid region name
* Continue this till we get valid region name
* If there are no '.' left to substring on, send region not found 
exception.

@jhuynh1 @ladyVader @gesterzhou 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2764

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/449.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #449


commit b1f4f8ba53cf25d5df8a0cdbbf8e9fcc29763bb2
Author: nabarun <n...@pivotal.io>
Date:   2017-04-10T18:41:14Z

GEODE-2764: Added checks on the region name

* Substring the region name till the last occurance of '.'
* Check if this substring is a valid region name
* Continue this till we get valid region name
* If there are no '.' left to substring on, send region not found 
exception.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #442: AEQ being created before region

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/442

AEQ being created before region

@jhuynh1 Please do review , Is there any  window where the redundancy 
failure may occur?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode aeqCreatePreRegion

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #442


commit 13b4c93938fe005c21b4336e91431fbfc539
Author: nabarun <n...@pivotal.io>
Date:   2017-04-04T02:06:45Z

AEQ being created before region




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #424: GEODE-2655: Added DUnit tests for lucene indexes on...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/424

GEODE-2655: Added DUnit tests for lucene indexes on mixed objects.

* Lucene must be able to index on the common field name of mixed objects
* Lucene indexes must also work when there are mixed objects with no 
common field names.


Will add more tests as per incoming review comments.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2655

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/424.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #424


commit fe01f5fe64010bab3e3e78da3c19382a8005a46d
Author: nabarun <n...@pivotal.io>
Date:   2017-03-14T07:02:51Z

GEODE-2655: Added DUnit tests for lucene indexes on mixed objects.

* Lucene must be able to index on the common field name of mixed objects
* Lucene indexes must also work when there are mixed objects with no 
common field names.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #422: GEODE-2639: Added DUnit tests for expiration on Luc...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/422

GEODE-2639: Added DUnit tests for expiration on Lucene

* Tests added to validate the effect of the expiration of Lucene Index 
entries.
* Once the entries expire, the lucene index entries must be updated.

@jhuynh1 @upthewaterspout @boglesby @ladyVader @gesterzhou 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2639

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #422


commit f07c5f19f542a8b84b89c903d1fa3398b120a29e
Author: nabarun <n...@pivotal.io>
Date:   2017-03-10T19:00:09Z

GEODE-2639: Added DUnit tests for expiration on Lucene

* Tests added to validate the effect of the expiration of Lucene Index 
entries.
* Once the entries expire, the lucene index entries must be updated.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #420: GEODE-2635: Creating DUnit tests to test eviction i...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/420

GEODE-2635: Creating DUnit tests to test eviction in lucene

* DUnit tests for eviction with local destroy and overflow
* Refactored the integration tests for eviction

@upthewaterspout @jhuynh1 @boglesby @gesterzhou @ladyVader 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2635

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/420.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #420


commit 642634cb1359249cba1d3030f761260dddaf217e
Author: nabarunnag <n...@cs.wisc.edu>
Date:   2017-03-09T00:16:52Z

GEODE-2635: Creating DUnit tests to test eviction in lucene

* DUnit tests for eviction with local destroy and overflow
* Refactored the integration tests for eviction




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #418: GEODE-2620: Rate stats removed from LuceneIndexMetr...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/418

GEODE-2620: Rate stats removed from LuceneIndexMetrics

* Commit Rate, update rate and query rate removed from 
LuceneIndexMetrics
* They can be added back again when the getRate method in 
StatsRate.java is fixed

@upthewaterspout @jhuynh1 @ladyVader @gesterzhou @boglesby 

-- Lucene precheckin and spotlessApply passed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2620

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/418.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #418


commit cecda0015583decaffd0929464a75a578fd4ac55
Author: nabarun <n...@pivotal.io>
Date:   2017-03-07T23:05:47Z

GEODE-2620: Rate stats removed from LuceneIndexMetrics

* Commit Rate, update rate and query rate removed from 
LuceneIndexMetrics
* They can be added back again when the getRate method in 
StatsRate.java is fixed




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #416: GEODE-2618: PrimaryBucketExceptions handled in Luce...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/416

GEODE-2618: PrimaryBucketExceptions handled in LuceneQueryFunction.ex…

…ecute

* PrimaryBucketException while executing a LuceneQuery will now be 
caught and wrapped as a InternalFunctionInvocationTargetException
* This will trigger a re-execution of the LuceneQuery on the member 
which will have the primary bucket.

@jhuynh1 @upthewaterspout @boglesby @gesterzhou @ladyVader 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2618

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #416


commit bdbde172845c91bc6c5d53fbd8528bb78ffe27a5
Author: nabarun <n...@pivotal.io>
Date:   2017-03-07T22:55:54Z

GEODE-2618: PrimaryBucketExceptions handled in LuceneQueryFunction.execute

* PrimaryBucketException while executing a LuceneQuery will now be 
caught and wrapped as a InternalFunctionInvocationTargetException
* This will trigger a re-execution of the LuceneQuery on the member 
which will have the primary bucket.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #415: GEODE-2604: Added javadoc comments to LuceneIndexMe...

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/415

GEODE-2604: Added javadoc comments to LuceneIndexMetrics.java

@upthewaterspout @jhuynh1 @gesterzhou @boglesby @ladyVader 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2604

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/415.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #415


commit 9d597dce47c3f9edc52cab0b70d9ca912a0c94d2
Author: nabarun <n...@pivotal.io>
Date:   2017-03-07T00:51:01Z

GEODE-2604: Added javadoc comments to LuceneIndexMetrics.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #414: GEODE-2596: Lucene metrics moved to public API

[nabarunnag]

GitHub user nabarunnag opened a pull request:

https://github.com/apache/geode/pull/414

GEODE-2596: Lucene metrics moved to public API

* LuceneIndexMetrics and LuceneServiceMXBean were moved to 
org.apache.geode.cache.lucene.management


-- Lucene precheckin passed

@upthewaterspout @jhuynh1 @ladyVader @gesterzhou @boglesby 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-2596

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #414


commit f832d15d2b3152b93fb09933a42b90aeae8f92da
Author: nabarun <n...@pivotal.io>
Date:   2017-03-06T19:59:33Z

GEODE-2596: Lucene metrics moved to public API

* LuceneIndexMetrics and LuceneServiceMXBean were moved to 
org.apache.geode.cache.lucene.management
* They are now public API




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---