[GitHub] geode-examples issue #2: Build updates for examples
Github user metatype commented on the issue: https://github.com/apache/geode-examples/pull/2 We have an ASF-developed `gradlew` script that does not require the `gradle-wrapper.jar` file to be present, unlike the version from the gradle distribution. We don't have an equivalent `gradlew.bat` script. It's really not *that* complicated, but more than I want to do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples issue #2: Build updates for examples
Github user jdeppe-pivotal commented on the issue: https://github.com/apache/geode-examples/pull/2 I'm not sure I understand the issue with `gradlew.bat`. Why raise the bar for Windows devs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples issue #2: Build updates for examples
Github user metatype commented on the issue: https://github.com/apache/geode-examples/pull/2 Good suggestion on verification. Here's my thinking on removing gradlew.bat: - We know we can't include `gradle-wrapper.jar` in a source release, so a user who downloads it on windows would need to run `gradlew` anyway using cygwin or a container like virtual box, docker, etc. - If you're a developer, you can probably figure out how to install gradle. - I'd like to keep things simple and only include one version of the gradle wrapper scripts instead of 2 like we do in geode. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples issue #2: Build updates for examples
Github user upthewaterspout commented on the issue: https://github.com/apache/geode-examples/pull/2 Wowsers, good stuff! A couple of comments/questions: 1. Should we really remove gradlew.bat? That means windows users won't be able to run the examples. 2. Since you are using the mirrors, it's probably a good idea to verify the downloaded geode binary before running it, to protect against a malicious mirror. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
