[GitHub] geode-native issue #107: GEODE-3019: Refactor Struct class

2017-07-20 Thread echobravopapa
Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/107
  
@dgkimura @pivotal-jbarrett I think this is all ready for final inspection


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #107: GEODE-3019: Refactor Struct class

2017-07-13 Thread echobravopapa
Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/107
  
@dgkimura @pivotal-jbarrett added unit tests and throwing an exception for 
out of range now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native issue #107: GEODE-3019: Refactor Struct class

2017-07-11 Thread echobravopapa
Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/107
  
@dgkimura @pivotal-jbarrett I squashed the latest so you won't get 
notified, which is a bummer, but please have a look when you have a minute.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---