[GitHub] geode-native pull request #102: GEODE-2741: Adding a warning for 64bit Windo...

[vjr]

Github user vjr commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/102#discussion_r126127440
  
--- Diff: src/CMakeLists.txt ---
@@ -17,6 +17,15 @@ project(nativeclient)
 
 list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/../cmake)
 
+if(CMAKE_GENERATOR MATCHES Win64*)
+  if ((CMAKE_GENERATOR MATCHES "Visual Studio") AND 
(CMAKE_GENERATOR_TOOLSET STREQUAL ""))
+message(WARNING "GEODE expects that a user must provode -Thost=x64 if 
you are using a"
--- End diff --

Typo - "provode" should be "provide" ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #102: GEODE-2741: Adding a warning for 64bit Windo...

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/102#discussion_r121248442
  
--- Diff: src/CMakeLists.txt ---
@@ -17,6 +17,15 @@ project(nativeclient)
 
 list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/../cmake)
 
+if(CMAKE_GENERATOR MATCHES Win64*)
+  if ((CMAKE_GENERATOR MATCHES "Visual Studio") AND 
(CMAKE_GENERATOR_TOOLSET STREQUAL ""))
--- End diff --

Why not just set the `CMAKE_GENERATOR_TOOLSET`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #102: GEODE-2741: Adding a warning for 64bit Windo...

[mhansonp]

GitHub user mhansonp opened a pull request:

https://github.com/apache/geode-native/pull/102

GEODE-2741: Adding a warning for 64bit Windows Tools sets

- Need to include -Thost=x64 in the configuration step

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mhansonp/geode-native feature/GEODE-2741

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #102


commit 262de6dce946f449b68f7dcb253b391a62a9920e
Author: Mark Hanson 
Date:   2017-06-09T21:09:59Z

GEODE-2741: Adding a warning for 64bit Windows Tools sets

- Need to include -Thost=x64 in the configuration step




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---