[GitHub] geode-native pull request #11: GEODE-2486: Initialize OpenSSL for DEFAULT ci...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #11: GEODE-2486: Initialize OpenSSL for DEFAULT ci...

[echobravopapa]

Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/11#discussion_r101287739
  
--- Diff: src/cryptoimpl/SSLImpl.cpp ---
@@ -52,25 +52,23 @@ SSLImpl::SSLImpl(ACE_SOCKET sock, const char 
*pubkeyfile,
 
   if (SSLImpl::s_initialized == false) {
 ACE_SSL_Context *sslctx = ACE_SSL_Context::instance();
-SSL_CTX *opensslctx = sslctx->context();
 
-if (SSL_CTX_set_cipher_list(opensslctx, "eNULL:DEFAULT") == 0) {
-  // if it fails here error is caught at connect.
-}
-// sslctx->set_mode(ACE_SSL_Context::SSLv23_client);
+SSL_CTX_set_cipher_list(sslctx->context(), "DEFAULT");
+sslctx->set_mode(ACE_SSL_Context::SSLv23_client);
--- End diff --

+1 for setting the mode


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #11: GEODE-2486: Initialize OpenSSL for DEFAULT ci...

[pivotal-jbarrett]

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/11

GEODE-2486: Initialize OpenSSL for DEFAULT cipher support.

- Init SSLv23_client mode to support negotiation of all SSL/TLS
  versions.
- Cleanup C++ style issues.
- Update tests to use NON-NULL cipher.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native 
feature/GEODE-2486

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11


commit ad8b5a83bac8d972d7ad46bbee201b056c1d436d
Author: Jacob Barrett 
Date:   2017-02-15T06:28:05Z

GEODE-2486: Initialize OpenSSL for DEFAULT cipher support.

- Init SSLv23_client mode to support negotiation of all SSL/TLS
  versions.
- Cleanup C++ style issues.
- Update tests to use NON-NULL cipher.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---