[GitHub] geode-native pull request #113: (no ticket) Capitalize C# client member func...

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/113


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #113: (no ticket) Capitalize C# client member func...

2017-07-25 Thread davebarnes97
GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/113

(no ticket) Capitalize C# client member functions

From Kyle Dunn on Slack:
Looks like a minor typo here : 
http://gemfire-native-90.docs.pivotal.io/native/continuous-querying/5b-writing-cq-listener.html#cqlistener-implementation-(c#-.net)
C# CqListener should implement OnEvent(), OnError(), and Close() - notice 
the first letter capitalization.

NB(db): I also changed onCqDisconnected to OnCqDisconnected, onCqConnected 
to OnCqConnected, and clear to Clear.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native feature/CapMembers

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #113


commit ec06436fad41a5f8cb6dd55f5f4a98b812c8127b
Author: Dave Barnes 
Date:   2017-07-25T21:41:05Z

(no ticket) Capitalize C# client member functions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---