[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103713640
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,16 +26,6 @@ elseif(UNIX)
set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${NATIVECLIENT_DIR}/lib)
endif()
--- End diff --
-verbose flag LTGM, I had made the same changes locally
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103572486
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,16 +26,6 @@ elseif(UNIX)
set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${NATIVECLIENT_DIR}/lib)
endif()
--- End diff --
Perhaps I'm missing context? I'm not sure what it means.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/42#discussion_r103572140 --- Diff: src/quickstart/runcpp.sh.in --- @@ -69,7 +69,6 @@ else echo 22.PdxRemoteQuery echo 23.PdxSerializer echo 24.PdxInstance -echo 25.PdxAutoSerializer echo 26.Quit --- End diff -- Yes, thanks for catching. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/42#discussion_r103572155 --- Diff: src/quickstart/runcpp.sh.in --- @@ -150,9 +149,6 @@ else "24") exname='PdxInstance' ;; - "25") -exname='PdxAutoSerializer' - ;; "26") --- End diff -- Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/42#discussion_r103568625 --- Diff: src/quickstart/runcpp.sh.in --- @@ -150,9 +149,6 @@ else "24") exname='PdxInstance' ;; - "25") -exname='PdxAutoSerializer' - ;; "26") --- End diff -- see above --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103569428
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,16 +26,6 @@ elseif(UNIX)
set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${NATIVECLIENT_DIR}/lib)
endif()
--- End diff --
what I did locally to be able to build the quickstarts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/42#discussion_r103564551 --- Diff: src/tests/cli/NewFwkLib/NewFwkLib.csproj.in --- @@ -272,9 +272,6 @@ SmokePerf\NoopAuthInit.cs - - PdxTest\PdxAutoSerializerObj.cs --- End diff -- Hmm.. besides the mistake that this referenced file isn't in the pull-request, I'm not sure this can go so easily. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #42: GEODE-2441: Remove leftover pdx auto serializ...
GitHub user dgkimura opened a pull request: https://github.com/apache/geode-native/pull/42 GEODE-2441: Remove leftover pdx auto serializer references Remove leftover references from previous commits under GEODE-2441. After this pull-request there are no references returned from grep in src directory. `$ grep -n -R -i pdxautoserializer *` You can merge this pull request into a Git repository by running: $ git pull https://github.com/dgkimura/geode-native feature/GEODE-2441 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
