[GitHub] geode-native pull request #57: GEODE-2513 Unbrand Programming Examples secti...

2017-03-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/57


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #57: GEODE-2513 Unbrand Programming Examples secti...

2017-03-15 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/57#discussion_r106279511
  
--- Diff: 
docs/geode-native-book/master_middleman/source/subnavs/geode-nc-nav.erb ---
@@ -883,7 +883,7 @@ limitations under the License.
 Programming
 Examples
 
 
-Declaring
 a Native Client Region
+Declaring
 a Client Region
--- End diff --

That was an odd way to put it, in the original wording... I think "native" 
snuck in there, but was not correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode-native pull request #57: GEODE-2513 Unbrand Programming Examples secti...

2017-03-15 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode-native/pull/57

GEODE-2513 Unbrand Programming Examples section

- also removed ancient examples, and replaced them with pointers
to the QuickStart examples

@davebarnes97 @joeymcallister @mmartell @dgkimura @echobravopapa 
@PivotalSarge Please review these minor changes to the documentation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode-native 
feature/GEODE-2513-8

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit 0138dbd5a753c7671c82773fcee76f847a6edebb
Author: Karen Miller 
Date:   2017-03-15T20:34:41Z

GEODE-2513 Unbrand Programming Examples section

- also removed ancient examples, and replaced them with pointers
to the QuickStart examples




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---