[GitHub] geode issue #389: GEODE-1434: Add ASF headers

2017-02-07 Thread PivotalSarge
Github user PivotalSarge commented on the issue:

https://github.com/apache/geode/pull/389
  
I pulled this PR, built it on Windows, and ran the quick integration tests. 
This validates that the header addition has not broken the Visual Studio 
project files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #389: GEODE-1434: Add ASF headers

2017-02-06 Thread metatype
Github user metatype commented on the issue:

https://github.com/apache/geode/pull/389
  
`rake` is a ruby thing.  We need a .travis.yml file to build and run unit 
tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #389: GEODE-1434: Add ASF headers

2017-02-06 Thread kirklund
Github user kirklund commented on the issue:

https://github.com/apache/geode/pull/389
  
Travis failed due to rake (I'm not sure what that even is).

rake aborted!
No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, 
Rakefile.rb)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---