[GitHub] geode issue #404: Geode 2469

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/404
  
At this point this PR is a bit out of date. To merge, all of the .class, 
.pdf, .fig, etc. files would need to be removed, the merge fix done and 
whatever other cleanup is necessary. It also looks like there may be a 
concurrency bug, so that should be tested and fixed if necessary. And whatever 
other fixes are necessary. It's not a trivial amount of work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/404
  
What would it take to get this PR merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on the issue:

https://github.com/apache/geode/pull/404
  
@yhilem @ggreen @bbaynes, there is currently a feature branch 
https://github.com/apache/geode/tree/feature/GEODE-2444, which started 
splitting the Redis Adapter into its own module.
I would prefer this splitting of the Redis adapter into its own module to 
be part of the integration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[bbaynes]

Github user bbaynes commented on the issue:

https://github.com/apache/geode/pull/404
  
@yhilem @ggreen  Looks like a great use case.  The PR may need a little 
cleanup (based on Galen's comments), but it would be good to get this in.  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[yhilem]

Github user yhilem commented on the issue:

https://github.com/apache/geode/pull/404
  
Hi Team,
Would you like to integrate this PR in the next delivery please?
Best regards,
Youcef HILEM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/404
  
@ggreen If you can clean up the history from where my PR was merged this 
will be much easier to review. In general, even though we've added the 
`@Experimental` tag, I would like the PR to be complete and release-ready once 
we merge it to develop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[ggreen]

Github user ggreen commented on the issue:

https://github.com/apache/geode/pull/404
  
@galen-pivotal and @metatype, are there any suggestions on how to move this 
pull request forward?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[ggreen]

Github user ggreen commented on the issue:

https://github.com/apache/geode/pull/404
  
@galen-pivotal and @metatype, are there any suggestions on how to move this 
pull request forward?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/404
  
@galen-pivotal dlock approach seems too heavy-weight for updating a key.  
Every hash is single-threaded through this lock.  I think the granularity we 
want is concurrent updates over different hashes, but thread-safe updates of a 
particular hash.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on the issue:

https://github.com/apache/geode/pull/404
  
I like the fact that we are now dealing with collections on a single 
machine, rather than all the elements spread distributed. Would you possibly 
have some perf metrics in relation to larger collections. e.g 1mil entries vs 
100. 

I imagine that as the number of entries in the collections grow, so will 
the insert performance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/404
  
Thanks for the contribution.  Could you fix the test failure in 
`RegionProviderTest`?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #404: Geode 2469

[ggreen]

Github user ggreen commented on the issue:

https://github.com/apache/geode/pull/404
  
Hello,
Sorry about that.
It is there now
geode/SetExecutor.java at GEODE-2469 · ggreen/geode · GitHub

  
|  
|   
|   
|   ||

   |

  |
|  
||  
geode/SetExecutor.java at GEODE-2469 · ggreen/geode · GitHub
 geode - Mirror of Apache Geode  |   |

  |

  |

 

 

On Wednesday, February 22, 2017 12:21 PM, Bruce Schuchardt 
 wrote:
 

 @bschuchardt requested changes on this pull request.Hi ggreen, would you 
update the PR to include the missing SetInterpreter class?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.  

   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---