[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 Yes, we are opening a new ticket for eliminating the repeated code. Analyzing the testcode for ORDER BY queries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...
Github user jhuynh1 commented on the issue: https://github.com/apache/geode/pull/517 We definitely have order by in the tests, whether or not they are adequate I am not sure. doing a find on "order by" will show a log of queries in the tests... The changes look good to me, if in the future we could collapse common code or extract some into smaller methods that would be great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 @ladyVader I am assuming that there should be tests already present testing the functional aspect. One of the tests did fail and caught an issue in my fix. @jhuynh1 what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #517: GEODE-2587: Refactored the OrderByComparator's compare met...
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/517 Potential Reviewers @ladyVader @jhuynh1 @boglesby @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
