[GitHub] geode issue #522: GEODE-2953: Imports optimized in every file with a wildcar...
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/522 Yeah, while I do firmly believe that there is value in good form and adherence to best practices, this PR ended up a lot bigger than I had initially expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #522: GEODE-2953: Imports optimized in every file with a wildcar...
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/522 Please review the diff, or run a regex search matching `import .*\*;\n`. This regex hits 1024 occurrences in production and 2205 occurrences in test code. Some of these occurrences are commented out. Matching `^import .*\*;\n` hits 827 production and 2175 test occurrences. 1388 classes going against best practices is indeed alarming, but I do not believe it is incorrect. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
