[GitHub] geode issue #613: GEODE-3151: Internal Region Registration in JMX as per con...

2017-08-18 Thread jaredjstewart
Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/613
  
Hi Dinesh,

Sorry to be so slow in responding to your PR.  Since the changes you are 
proposing in GEODE-3151 involve changing a public-facing API (in 
DistributionConfig, I think it first needs to be discussed on 
dev@geode.apache.org before we could pull this in.  Would you mind sending an 
email to that list with your proposal and the use-case you have in mind?

Thank you,
Jared


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #613: GEODE-3151: Internal Region Registration in JMX as per con...

2017-08-18 Thread kirklund
Github user kirklund commented on the issue:

https://github.com/apache/geode/pull/613
  
I think this sort of change should be proposed and discussed on the dev 
list. This is effectively adding new User APIs and that requires more 
discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #613: GEODE-3151: Internal Region Registration in JMX as per con...

2017-07-03 Thread dineshpune2006
Github user dineshpune2006 commented on the issue:

https://github.com/apache/geode/pull/613
  
 i have added  etc/eclipseFormatterProfile.xml in eclipse profile & did the 
code style set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #613: GEODE-3151: Internal Region Registration in JMX as per con...

2017-06-30 Thread PurelyApplied
Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/613
  
If you are using IntelliJ as your IDE, please remember to update your style 
file to that located in `geode/etc/intellij-java-modified-google-style.xml` to 
be consistent with Geode's established style guide.  This file was updated June 
13 with commit `a561bd12` to be consistent with documented expectations.

After having done so, please optimize the imports to the correct order and 
to eliminate the use of the wildcard imports. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---