[GitHub] geode issue #676: GEODE-3321: Adding ErrorCode values to protobuf protocol

2017-08-02 Thread WireBaron
Github user WireBaron commented on the issue:

https://github.com/apache/geode/pull/676
  
Rebased to fix conflicts and added an error code to the new 
GetAvailableServers handler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #676: GEODE-3321: Adding ErrorCode values to protobuf protocol

2017-08-02 Thread galen-pivotal
Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/676
  
Looks like there are some conflicts that need to be resolved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #676: GEODE-3321: Adding ErrorCode values to protobuf protocol

2017-08-02 Thread bschuchardt
Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/676
  
The license header was probably damaged during some search 
operations to transform the google-doc version of the list into an enum


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] geode issue #676: GEODE-3321: Adding ErrorCode values to protobuf protocol

2017-08-01 Thread galen-pivotal
Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/676
  
It looks like this is failing in Travis due to `:rat`, but you've got a 
license in your only new file. I'm a bit mystified. Closing the pull request 
and reopening it can be a good way to trigger a new Travis build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---