[GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...
Github user mmartell closed the pull request at: https://github.com/apache/geode/pull/391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...
I filed a separate JIRA for this as there is no geode.jar and
KillJavaProcesses() will not work correctly.
> On 8 Feb, 2017, at 14:47, dgkimura wrote:
>
> Github user dgkimura commented on a diff in the pull request:
>
>https://github.com/apache/geode/pull/391#discussion_r100191055
>
>--- Diff: src/clicache/integration-test/CacheHelperN.cs ---
>@@ -2389,7 +2389,7 @@ public static void KillJavaProcesses()
> string commandline = item["CommandLine"].ToString();
>
> Util.Log("processId:{0} name:{1}", item["ProcessId"],
> item["Name"]);
>- if (commandline.Contains("geode.jar"))
>+ if (commandline.Contains("gemfire.jar"))
>--- End diff --
>
>I'm curious why this one you're switching geode with gemfire. What makes
> this one different?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode/pull/391#discussion_r100191415
--- Diff: src/clicache/integration-test/CacheHelperN.cs ---
@@ -2389,7 +2389,7 @@ public static void KillJavaProcesses()
string commandline = item["CommandLine"].ToString();
Util.Log("processId:{0} name:{1}", item["ProcessId"],
item["Name"]);
- if (commandline.Contains("geode.jar"))
+ if (commandline.Contains("gemfire.jar"))
--- End diff --
We have a story to remove this as is unused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode/pull/391#discussion_r100191055
--- Diff: src/clicache/integration-test/CacheHelperN.cs ---
@@ -2389,7 +2389,7 @@ public static void KillJavaProcesses()
string commandline = item["CommandLine"].ToString();
Util.Log("processId:{0} name:{1}", item["ProcessId"],
item["Name"]);
- if (commandline.Contains("geode.jar"))
+ if (commandline.Contains("gemfire.jar"))
--- End diff --
I'm curious why this one you're switching geode with gemfire. What makes
this one different?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...
GitHub user mmartell opened a pull request: https://github.com/apache/geode/pull/391 GEODE-2422: Switch remaining GemFire strings to Geode. - includes rename GemFireCache.hpp to GeodeCache.hpp - GemFire, Gemfire, and gemfire replaced with Geode, Geode, geode - includes only source changes: .cs, .cpp, and .hpp - doesn't include guard statement changes You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode feature/GEODE-2422 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/391.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #391 commit c6b7d55022fbc7111b93447430d984b95896e688 Author: Mike Martell Date: 2017-02-04T19:22:38Z GEODE-2422: Switch remaining GemFire strings to Geode. - includes rename GemFireCache.hpp to GeodeCache.hpp - GemFire, Gemfire, and gemfire replaced with Geode, Geode, geode - includes only source changes: .cs, .cpp, and .hpp - doesn't include guard statement changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
