[GitHub] geode pull request #560: Geode 2818: Adding aliases to any command options t...

2017-06-14 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/560


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #560: Geode 2818: Adding aliases to any command options t...

2017-06-09 Thread kirklund 
Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/560#discussion_r121197448
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
 ---
@@ -736,7 +736,7 @@ public Result exportData(
   @CliOption(key = CliStrings.EXPORT_DATA__FILE,
   unspecifiedDefaultValue = CliMetaData.ANNOTATION_NULL_VALUE, 
mandatory = true,
   help = CliStrings.EXPORT_DATA__FILE__HELP) String filePath,
-  @CliOption(key = CliStrings.EXPORT_DATA__MEMBER,
+  @CliOption(key = CliStrings.MEMBER,
--- End diff --

This makes me wonder if we should file a Jira ticket to make sure all Gfsh 
commands with MEMBER option are consistently allowing comma-delimited lists of 
members.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #560: Geode 2818: Adding aliases to any command options t...

2017-06-05 Thread YehEmily 
GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/560

Geode 2818: Adding aliases to any command options that involve "group", 
"member", or "jar"

… "member", "jar" and replace CliString variables with GROUP, MEMBER, 
JAR, etc.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-2818

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/560.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #560


commit 24958612611c293497cec7300856c68f2bfb819a
Author: YehEmily 
Date:   2017-06-05T20:03:39Z

GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar" and replace CliString variables with GROUP, MEMBER, JAR, etc.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---