[GitHub] geode pull request #576: Geode 2920, 2921, 2922, 2924
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/576#discussion_r123578810 --- Diff: geode-core/src/main/java/org/apache/geode/management/CacheServerMXBean.java --- @@ -352,44 +352,44 @@ * * @param clientId ID of the client for which to retrieve information. */ - public ClientHealthStatus showClientStats(String clientId) throws Exception; + ClientHealthStatus showClientStats(String clientId) throws Exception; /** * Returns the number of clients who have existing subscriptions. */ - public int getNumSubscriptions(); + int getNumSubscriptions(); /** * Returns health and statistic information for all clients. Some of the information (CPUs, * NumOfCacheListenerCalls, NumOfGets,NumOfMisses, NumOfPuts,NumOfThreads, ProcessCpuTime) only * available for clients which have set a "StatisticsInterval". */ - public ClientHealthStatus[] showAllClientStats() throws Exception; + ClientHealthStatus[] showAllClientStats() throws Exception; /** * Shows a list of client with their queue statistics. Client queue statistics shown in this * method are the following * - * eventsEnqued,eventsRemoved , eventsConflated ,markerEventsConflated , eventsExpired, + * eventsEnqueued,eventsRemoved , eventsConflated ,markerEventsConflated , eventsExpired, --- End diff -- (Nit) This (and the following javadoc comment) are kinda ugly with the spacing around the commas. While you're fixing the spelling why not also fix the rest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #576: Geode 2920, 2921, 2922, 2924
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/576 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #576: Geode 2920, 2921, 2922, 2924
GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/576 Geode 2920, 2921, 2922, 2924 This PR is intended for initial review, not to be actively considered for acceptance. Sufficient testing is still required and `develop` shifted enough today that I need to rebase again. This currently addresses most of the finer-grained security as listed [here](https://cwiki.apache.org/confluence/display/GEODE/Finer+grained+security). As yet unaddressed remains: * alter disk-store * disconnect * echo * encrypt password * execute function * import cluster-configuration * DistributedSystemMXBean.backupAllMembers Additional points of concern: * compact offline-disk-store is not actually updated? [None -> None] * Should destroy region also require CLUSTER:WRITE:DISK if persistent? * These do not exist: *GatewayReceiverMXBean.pauseDATA:MANAGE CLUSTER:MANAGE:GATEWAY *GatewayReceiverMXBean.rebalanceDATA:MANAGE CLUSTER:MANAGE:GATEWAY *GatewayReceiverMXBean.resume DATA:MANAGE CLUSTER:MANAGE:GATEWAY * `execute function` is listed twice, with different "original" permissions. Do these refer to different executions? For your convenience, the functional diff is the second commit. The first commit only resolves `imports`, and the third commit is a general cleanup of touched files. == Current commit log: GEODE-292*: Migration of security from DATA:MANAGE * DATA:MANAGE -> CLUSTER:MANAGE * * configure pdx * LockServiceMXBean.becomeLockGrantor * * DATA:MANAGE -> CLUSTER:MANAGE:DISK * * compact disk-store * create disk-store * destroy disk-store * revoke missing-disk-store * DiskStoreMXBean.forceRoll * DiskStoreMXBean.forceCompaction * DiskStoreMXBean.flush * DiskStoreMXBean.setDiskUsageWarningPercentage * DiskStoreMXBean.setDiskUsageCriticalPercentage * DistributedSystemMXBean.revokeMissingDiskStores * MemberMXBean.compactAllDistStores * * DATA:MANAGE -> CLUSTER:MANAGE:GATEWAY * * create gateway-receiver * create gateway-sender * destroy gateway-sender * load-balance gateway-sender * pause gateway-sender * resume gateway-sender * start gateway-receiver * start gateway-sender * stop gateway-receiver * stop gateway-sender * GatewayReceiverMXBean.start * GatewayReceiverMXBean.stop * GatewaySenderMXBean.start * GatewaySenderMXBean.stop * GatewaySenderMXBean.pause * GatewaySenderMXBean.resume * GatewaySenderMXBean.rebalance * * DATA:MANAGE -> CLUSTER:MANAGE:JAR * * create async-event-queue (Requires CLUSTER:WRITE:DISK if persistent) * destroy function * undeploy * * DATA:MANAGE -> CLUSTER:MANAGE:QUERY * * clear defined indexes * close durable-client * close durable-cq * create defined indexes * stop continuous-query * CacheServerMXBean.closeAllContinuousQuery * CacheServerMXBean.closeContinuousQuery * DistributedSystemMXBean.setQueryResultSetLimit * DistributedSystemMXBean.setQueryCollectionsDepth * * DATA:READ -> CLUSTER:READ * * list region * * DATA:MANAGE -> [None] * * pdx rename * * DATA:READ -> DATA:READ and CLUSTER:WRITE:DISK * * backup disk-store * * DATA:MANAGE:RegionName -> CLUSTER:MANAGE:QUERY * * create index * create lucene index (also requires CLUSTER:WRITE:DISK) * define index * destroy lucene index * * DATA:MANAGE, DATA:WRITE, CLUSTER:MANAGE, and CLUSTER:WRITE -> CLUSTER:MANAGE:JAR * * deploy * * DATA:MANAGE or DATA:MANAGE:RegionName -> CLUSTER:MANAGE:QUERY * * destroy index * * CLUSTER:READ -> CLUSTER:READ:QUERY * * describe lucene index * list lucene indexes * * DATA:WRITE -> DATA:READ:Region * * search lucene index * * DATA:MANAGE -> DATA:MANAGE and CLUSTER:WRITE:DISK if persistent * create region You can merge this pull request into a Git repository by running: $ git pull https://github.com/PurelyApplied/geode geode-2924 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/576.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #576 commit d8155ae44e767890790566b66cb7cc5ed7ea0cbc Author: Patrick
