[GitHub] geode pull request #582: GEODE-2601: Fix banner being logged twice
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #582: GEODE-2601: Fix banner being logged twice
Github user YehEmily commented on a diff in the pull request:
https://github.com/apache/geode/pull/582#discussion_r122476764
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
---
@@ -2167,7 +2191,7 @@ private static void
notifyReconnectListeners(InternalDistributedSystem oldsys,
private void notifyResourceEventListeners(ResourceEvent event, Object
resource) {
for (Iterator iter =
resourceListeners.iterator(); iter.hasNext();) {
--- End diff --
How nice! Thank you, I'll edit this and update the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #582: GEODE-2601: Fix banner being logged twice
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/582#discussion_r122332971 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java --- @@ -469,15 +470,13 @@ private InternalLocator(int port, File logF, File stateF, InternalLogWriter logW LogWriterAppenders.getOrCreateAppender(LogWriterAppenders.Identifier.SECURITY, true, false, this.config, false); --- End diff -- delete extra blank line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #582: GEODE-2601: Fix banner being logged twice
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/582#discussion_r122332566
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
---
@@ -2167,7 +2191,7 @@ private static void
notifyReconnectListeners(InternalDistributedSystem oldsys,
private void notifyResourceEventListeners(ResourceEvent event, Object
resource) {
for (Iterator iter =
resourceListeners.iterator(); iter.hasNext();) {
--- End diff --
This loop looks like it could be rewritten as a foreach type loop
`
for (ResourceEventListnener listener:resourceListeners) {
...
}
`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
