[GitHub] geode pull request #645: GEODE-3113: Modify HARegionQueue test to use Awaiti...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/645


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #645: GEODE-3113: Modify HARegionQueue test to use Awaiti...

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/645#discussion_r128376504
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARQAddOperationJUnitTest.java
 ---
@@ -287,12 +289,11 @@ public void testNoExpiryOnThreadIdentifier() {
   eventsMap.get(threadId));
 
   // wait for some more time to allow expiry on data
--- End diff --

Should probably remove this comment about waiting for some time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #645: GEODE-3113: Modify HARegionQueue test to use Awaiti...

[ladyVader]

GitHub user ladyVader opened a pull request:

https://github.com/apache/geode/pull/645

GEODE-3113: Modify HARegionQueue test to use Awaitility vs. timeouts

* Modify test to use Awaitility (at most 60 seconds) vs. sleeps prior to 
checking expiration

@upthewaterspout @nabarunnag

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3113

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/645.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #645


commit f286244a864e3eb61bbb586b678d39e0227bd574
Author: Lynn Hughes-Godfrey 
Date:   2017-07-18T20:48:24Z

GEODE-3113: Modify HARegionQueue test to use Awaitility vs. timeouts

* Modify test to use Awaitility (at most 60 seconds) vs. sleeps prior to 
checking expiration




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---