[GitHub] geode pull request #748: GEODE-3472: Remove a great deal of commented-out co...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/748


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #748: GEODE-3472: Remove a great deal of commented-out co...

[PurelyApplied]

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/748

GEODE-3472: Remove a great deal of commented-out code.

This pull request replaces #730.

Nontrivial conflicts were introduced after rebasing against GEODE-3436 
(`be8a13`).

This pull request includes all suggestions made in #730, as well as a 
number of other minor refactorings.

Precheckin running.

-

* Additionally refactored touched files, driven by suggested changes in a 
previous pull request and IDE inspections.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a: refactoring] Have you written or updated unit tests to verify your 
changes?

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3472-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/748.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #748


commit 4fecf79d76f2caec59f0c8e5afb0744954e5e203
Author: Patrick Rhomberg 
Date:   2017-08-18T20:59:44Z

GEODE-3472: Remove a great deal of commented-out code.

* Additionally refactored touched files, driven by suggested changes in a 
previous pull request and IDE inspections.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---