[jira] [Commented] (GEODE-2172) CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows

2017-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850867#comment-15850867
 ] 

ASF GitHub Bot commented on GEODE-2172:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/348


> CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows
> -
>
> Key: GEODE-2172
> URL: https://issues.apache.org/jira/browse/GEODE-2172
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 1.0.0-incubating
> Environment: Windows
>Reporter: Kirk Lund
>Assignee: Kai Jiang
>  Labels: IntegrationTest, Windows
> Fix For: 1.2.0
>
>
> cacheLogWriterMessageShouldMatchCustomConfig fails with AssertionError:
> {noformat}
> java.lang.AssertionError: 
> Expecting:
>   "CUSTOM: level=INFO time=2016/11/30 13:49:13.780 PST message=
> 
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:14.497 PST message=Running in local 
> mode since no locators were specified.
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:15.496 PST message=Initializing 
> region _monitoringRegion_192.168.1.410
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:15.542 PST message=Initialization of 
> region _monitoringRegion_192.168.1.410 completed
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:17.492 PST message=this is a log 
> statement from cacheLogWriterMessageShouldMatchCustomConfig
> throwable=
> "
> to contain pattern:
>   "CUSTOM: level=INFO time=.* message=this is a log statement from 
> cacheLogWriterMessageShouldMatchCustomConfig
> throwable=
> "
>   at 
> org.apache.geode.internal.logging.log4j.custom.CustomConfigWithCacheIntegrationTest.cacheLogWriterMessageShouldMatchCustomConfig(CustomConfigWithCacheIntegrationTest.java:149)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1$1.evaluate(LogPrintStream.java:30)
>   at 
> org.junit.contrib.java.lang.system.internal.PrintStreamHandler$3.evaluate(PrintStreamHandler.java:48)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1.evaluate(LogPrintStream.java:26)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1$1.evaluate(LogPrintStream.java:30)
>   at 
> org.junit.contrib.java.lang.system.internal.PrintStreamHandler$3.evaluate(PrintStreamHandler.java:48)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1.evaluate(LogPrintStream.java:26)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
>

[jira] [Commented] (GEODE-2172) CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows

2017-02-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850866#comment-15850866
 ] 

ASF subversion and git services commented on GEODE-2172:


Commit add48b18f57c3259b82f65f6de3eaddca824ac33 in geode's branch 
refs/heads/develop from [~vectorijk]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=add48b1 ]

GEODE-2172 CustomConfigWithCacheIntegrationTest fails on Windows

This closes #348


> CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows
> -
>
> Key: GEODE-2172
> URL: https://issues.apache.org/jira/browse/GEODE-2172
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 1.0.0-incubating
> Environment: Windows
>Reporter: Kirk Lund
>Assignee: Kai Jiang
>  Labels: IntegrationTest, Windows
>
> cacheLogWriterMessageShouldMatchCustomConfig fails with AssertionError:
> {noformat}
> java.lang.AssertionError: 
> Expecting:
>   "CUSTOM: level=INFO time=2016/11/30 13:49:13.780 PST message=
> 
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:14.497 PST message=Running in local 
> mode since no locators were specified.
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:15.496 PST message=Initializing 
> region _monitoringRegion_192.168.1.410
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:15.542 PST message=Initialization of 
> region _monitoringRegion_192.168.1.410 completed
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:17.492 PST message=this is a log 
> statement from cacheLogWriterMessageShouldMatchCustomConfig
> throwable=
> "
> to contain pattern:
>   "CUSTOM: level=INFO time=.* message=this is a log statement from 
> cacheLogWriterMessageShouldMatchCustomConfig
> throwable=
> "
>   at 
> org.apache.geode.internal.logging.log4j.custom.CustomConfigWithCacheIntegrationTest.cacheLogWriterMessageShouldMatchCustomConfig(CustomConfigWithCacheIntegrationTest.java:149)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1$1.evaluate(LogPrintStream.java:30)
>   at 
> org.junit.contrib.java.lang.system.internal.PrintStreamHandler$3.evaluate(PrintStreamHandler.java:48)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1.evaluate(LogPrintStream.java:26)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1$1.evaluate(LogPrintStream.java:30)
>   at 
> org.junit.contrib.java.lang.system.internal.PrintStreamHandler$3.evaluate(PrintStreamHandler.java:48)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1.evaluate(LogPrintStream.java:26)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
>

[jira] [Commented] (GEODE-2172) CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows

2017-01-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/GEODE-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831643#comment-15831643
 ] 

ASF GitHub Bot commented on GEODE-2172:
---

GitHub user vectorijk opened a pull request:

https://github.com/apache/geode/pull/348

[GEODE-2172] CustomConfigWithCacheIntegrationTest fails with AssertionError 
on Windows

> The issues is related to incorrect regex pattern. The regex pattern used 
to match log string contains newline character. To fix this issue, I've 
replaced Unix newline character in regex pattern into System.lineSeparator(), a 
Platform-dependent newline character in Java.
> 
> I've run this unit test both on Windows and MacOS. And it passes.

Review Board: 
[https://reviews.apache.org/r/54586/](https://reviews.apache.org/r/54586/)

Since this has been marked as `Ship it`, this PR here will be easy for 
merging.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vectorijk/geode GEODE-2172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #348


commit bc33c54e7afa5c8d09a18ec857ff385559639e0a
Author: Kai Jiang 
Date:   2016-12-09T12:43:16Z

reason

commit e407c12546de05492580b9cfdf1fbe8db7068782
Author: Kai Jiang 
Date:   2016-12-19T12:38:10Z

delete unused test method




> CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows
> -
>
> Key: GEODE-2172
> URL: https://issues.apache.org/jira/browse/GEODE-2172
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 1.0.0-incubating
> Environment: Windows
>Reporter: Kirk Lund
>Assignee: Kai Jiang
>  Labels: IntegrationTest, Windows
>
> cacheLogWriterMessageShouldMatchCustomConfig fails with AssertionError:
> {noformat}
> java.lang.AssertionError: 
> Expecting:
>   "CUSTOM: level=INFO time=2016/11/30 13:49:13.780 PST message=
> 
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:14.497 PST message=Running in local 
> mode since no locators were specified.
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:15.496 PST message=Initializing 
> region _monitoringRegion_192.168.1.410
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:15.542 PST message=Initialization of 
> region _monitoringRegion_192.168.1.410 completed
> throwable=
> CUSTOM: level=INFO time=2016/11/30 13:49:17.492 PST message=this is a log 
> statement from cacheLogWriterMessageShouldMatchCustomConfig
> throwable=
> "
> to contain pattern:
>   "CUSTOM: level=INFO time=.* message=this is a log statement from 
> cacheLogWriterMessageShouldMatchCustomConfig
> throwable=
> "
>   at 
> org.apache.geode.internal.logging.log4j.custom.CustomConfigWithCacheIntegrationTest.cacheLogWriterMessageShouldMatchCustomConfig(CustomConfigWithCacheIntegrationTest.java:149)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1$1.evaluate(LogPrintStream.java:30)
>   at 
> org.junit.contrib.java.lang.system.internal.PrintStreamHandler$3.evaluate(PrintStreamHandler.java:48)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1.evaluate(LogPrintStream.java:26)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1$1.evaluate(LogPrintStream.java:30)
>   at 
> org.junit.contrib.java.lang.system.internal.PrintStreamHandler$3.evaluate(PrintStreamHandler.java:48)
>   at 
> org.junit.contrib.java.lang.system.internal.LogPrintStream$1.evaluate(LogPrintStream.java:26)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at