[jira] [Commented] (GEODE-2961) Distinct query with an or condition may miss results
[
https://issues.apache.org/jira/browse/GEODE-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023686#comment-16023686
]
ASF GitHub Bot commented on GEODE-2961:
---
Github user DivineEnder closed the pull request at:
https://github.com/apache/geode/pull/527
> Distinct query with an or condition may miss results
>
>
> Key: GEODE-2961
> URL: https://issues.apache.org/jira/browse/GEODE-2961
> Project: Geode
> Issue Type: Bug
> Components: querying
>Reporter: Jason Huynh
>Assignee: David Anuta
>
> Sample query where this may be an issue:
> "select id from /region where r.status in set('active') or r.name in
> set('joe')"
> The results will contain only one of the predicates.
> The issue might be:
> {noformat}
> } else if (isDistinct && !isConditioningNeeded) {
> intermediateResults = filterResults;
> {noformat}
> but it should probably read as:
> {noformat}
> } else if (isDistinct && !isConditioningNeeded) {
> intermediateResults.addAll(filterResults);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2961) Distinct query with an or condition may miss results
[
https://issues.apache.org/jira/browse/GEODE-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022010#comment-16022010
]
ASF subversion and git services commented on GEODE-2961:
Commit 456ee15768fb08c8e1c8c5836479d27e1bc61835 in geode's branch
refs/heads/feature/GEODE-2632-17 from [~DivineEnder]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=456ee15 ]
GEODE-2961: Fixed distinct multiple OR query returning partial results
> Distinct query with an or condition may miss results
>
>
> Key: GEODE-2961
> URL: https://issues.apache.org/jira/browse/GEODE-2961
> Project: Geode
> Issue Type: Bug
> Components: querying
>Reporter: Jason Huynh
>Assignee: David Anuta
>
> Sample query where this may be an issue:
> "select id from /region where r.status in set('active') or r.name in
> set('joe')"
> The results will contain only one of the predicates.
> The issue might be:
> {noformat}
> } else if (isDistinct && !isConditioningNeeded) {
> intermediateResults = filterResults;
> {noformat}
> but it should probably read as:
> {noformat}
> } else if (isDistinct && !isConditioningNeeded) {
> intermediateResults.addAll(filterResults);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2961) Distinct query with an or condition may miss results
[
https://issues.apache.org/jira/browse/GEODE-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021866#comment-16021866
]
ASF subversion and git services commented on GEODE-2961:
Commit 456ee15768fb08c8e1c8c5836479d27e1bc61835 in geode's branch
refs/heads/develop from [~DivineEnder]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=456ee15 ]
GEODE-2961: Fixed distinct multiple OR query returning partial results
> Distinct query with an or condition may miss results
>
>
> Key: GEODE-2961
> URL: https://issues.apache.org/jira/browse/GEODE-2961
> Project: Geode
> Issue Type: Bug
> Components: querying
>Reporter: Jason Huynh
>Assignee: David Anuta
>
> Sample query where this may be an issue:
> "select id from /region where r.status in set('active') or r.name in
> set('joe')"
> The results will contain only one of the predicates.
> The issue might be:
> {noformat}
> } else if (isDistinct && !isConditioningNeeded) {
> intermediateResults = filterResults;
> {noformat}
> but it should probably read as:
> {noformat}
> } else if (isDistinct && !isConditioningNeeded) {
> intermediateResults.addAll(filterResults);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2961) Distinct query with an or condition may miss results
[
https://issues.apache.org/jira/browse/GEODE-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021860#comment-16021860
]
ASF GitHub Bot commented on GEODE-2961:
---
Github user DivineEnder commented on the issue:
https://github.com/apache/geode/pull/527
@nabarunnag @upthewaterspout @jhuynh1 @ladyVader @boglesby
> Distinct query with an or condition may miss results
>
>
> Key: GEODE-2961
> URL: https://issues.apache.org/jira/browse/GEODE-2961
> Project: Geode
> Issue Type: Bug
> Components: querying
>Reporter: Jason Huynh
>Assignee: David Anuta
>
> Sample query where this may be an issue:
> "select id from /region where r.status in set('active') or r.name in
> set('joe')"
> The results will contain only one of the predicates.
> The issue might be:
> {noformat}
> } else if (isDistinct && !isConditioningNeeded) {
> intermediateResults = filterResults;
> {noformat}
> but it should probably read as:
> {noformat}
> } else if (isDistinct && !isConditioningNeeded) {
> intermediateResults.addAll(filterResults);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2961) Distinct query with an or condition may miss results
[
https://issues.apache.org/jira/browse/GEODE-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021857#comment-16021857
]
ASF GitHub Bot commented on GEODE-2961:
---
GitHub user DivineEnder opened a pull request:
https://github.com/apache/geode/pull/527
GEODE-2961: Fixed distinct multiple OR query returning partial results
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DivineEnder/geode feature/GEODE-2961
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/527.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #527
commit 8f77fc2ad87fbc7b7b565005f120ab0ae822aca7
Author: David Anuta
Date: 2017-05-23T20:53:19Z
GEODE-2961: Fixed distinct multiple OR query returning partial results
> Distinct query with an or condition may miss results
>
>
> Key: GEODE-2961
> URL: https://issues.apache.org/jira/browse/GEODE-2961
> Project: Geode
> Issue Type: Bug
> Components: querying
>Reporter: Jason Huynh
>Assignee: David Anuta
>
> Sample query where this may be an issue:
> "select id from /region where r.status in set('active') or r.name in
> set('joe')"
> The results will contain only one of the predicates.
> The issue might be:
> {noformat}
> } else if (isDistinct && !isConditioningNeeded) {
> intermediateResults = filterResults;
> {noformat}
> but it should probably read as:
> {noformat}
> } else if (isDistinct && !isConditioningNeeded) {
> intermediateResults.addAll(filterResults);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
