Re: Build failed in Jenkins: Geode-nightly #762 - adongre, please read

2017-02-28 Thread Jared Stewart
Thanks for the tips, Kirk! I think #2 is something I ought to do more often.

On Feb 28, 2017 5:59 PM, "Kirk Lund"  wrote:

> Everything is building fine now, so I'm going to revert that commit.
>
> Avinash, go ahead and recommit it after the issue with the sub-class
> parameterization is fixed and it passes review and precheckin.
>
> I don't know of any way to make JUnit Parameterized work with JUnitParams,
> and I'd recommend not trying to do that.
>
> Here's a few generalized JUnit test recommendations. One or two might be of
> help in this case:
>
> 1) JUnitParams seems more flexible and parameterizes at the test method
> level, whereas Parameterized parameterizes at the class level which forces
> all of the test methods to repeat with new parameters.
>
> 2) I favor splitting tests. If you have a test method that requires
> different setUp/tearDown or parameterization and it no longer fits well,
> then splitting it up into multiple test classes is probably a good idea.
>
> 3) I've seen subclassing of tests be horribly abused, so I'd recommend
> avoiding this whenever possible. It's frequently better to use a custom
> JUnit Rule or even to repeat code in setUp/tearDown.
>
> 4) As an addendum to #3, don't be tempted to have one test class
> instantiate another test class and invoke methods on it. This just creates
> horrible spaghetti.
>
> On Tue, Feb 28, 2017 at 11:29 AM, Mark Bretl  wrote:
>
> > There is an AWS outage right now, not sure if that is affecting the
> Gradle
> > plugin site...
> >
> > --Mark
> >
> > On Tue, Feb 28, 2017 at 10:53 AM, Bruce Schuchardt <
> bschucha...@pivotal.io
> > >
> > wrote:
> >
> > > I deleted my gradle cache & am also having trouble downloading things
> > >
> > >:buildSrc:build UP-TO-DATE
> > >
> > >FAILURE: Build failed with an exception.
> > >
> > >* What went wrong:
> > >A problem occurred configuring root project 'geode'.
> > > > Could not resolve all dependencies for configuration
> ':classpath'.
> > >> Could not resolve
> > >gradle.plugin.org.nosphere.apache:creadur-rat-gradle:0.2.0.
> > >  Required by:
> > >  :geode:unspecified
> > >   > Could not resolve
> > >gradle.plugin.org.nosphere.apache:creadur-rat-gradle:0.2.0.
> > >  > Could not get resource
> > >'https://plugins.gradle.org/m2/gradle/plugin/org/nosphere/a
> > > pache/creadur-rat-gradle/0.2.0/creadur-rat-gradle-0.2.0.pom'.
> > > > Could not GET
> > >'https://plugins.gradle.org/m2/gradle/plugin/org/nosphere/a
> > > pache/creadur-rat-gradle/0.2.0/creadur-rat-gradle-0.2.0.pom'.
> > >Received status code 503 from server: Service Unavailable
> > >etc.
> > >
> > > I'm getting 503s on everything but the initial gradle download.
> > >
> > >
> > > Le 2/28/2017 à 10:40 AM, Avinash Dongre a écrit :
> > >
> > >> I am getting following error while running precheckin.
> > >>
> > >> * Where:
> > >> Build file '/home/ampool/private/geode/java/geode/geode-old-versions/
> bu
> > >> ild.gradle'
> > >> line: 58
> > >>
> > >> * What went wrong:
> > >> Execution failed for task ':geode-old-versions:createGeo
> > >> deClasspathsFile'.
> > >>
> > >>> Could not resolve all dependencies for configuration
> > >>> ':geode-old-versions:
> > >>>
> > >> test110Runtime'.
> > >> > Could not download geode-cq.jar (org.apache.geode:geode-cq:1.
> 1.0)
> > >>> Could not get resource 'https://repo1.maven.org/
> > >> maven2/org/apache/geode/geode-cq/1.1.0/geode-cq-1.1.0.jar'.
> > >>   > Could not GET 'https://repo1.maven.org/
> > >> maven2/org/apache/geode/geode-cq/1.1.0/geode-cq-1.1.0.jar'. Received
> > >> status
> > >> code 503 from server: Connection timed out
> > >>
> > >>
> > >>
> > >> On Tue, Feb 28, 2017 at 11:06 PM, Avinash Dongre 
> > >> wrote:
> > >>
> > >> It is my mistake.
> > >>>
> > >>> I will revert back my changes for this Test and raise a PR.
> > >>>
> > >>> Thanks
> > >>> Avinash
> > >>>
> > >>>
> > >>> On Tue, Feb 28, 2017 at 10:26 PM, Bruce Schuchardt <
> > >>> bschucha...@pivotal.io
> > >>>
> >  wrote:
> >  ClientServerMiscBCDUnitTest is failing due to adongre's commit
> >  yesterday.  A parameterized test was added to a superclass, causing
> >  conflict with the subclass's parameterization of all the
> superclass's
> >  methods
> > 
> > 
> >  java.lang.Exception: Method testProxyRegionClientServerOp should
> have
> > no
> >  parameters
> > 
> >   at org.junit.runners.model.FrameworkMethod.
> validatePublicVoidNo
> >  Arg(FrameworkMethod.java:76)
> >   at org.junit.runners.ParentRunner.
> validatePublicVoidNoArgMethod
> >  s(ParentRunner.java:155)
> >   at org.junit.runners.BlockJUnit4ClassRunner.
> validateTestMethods
> >  (BlockJUnit4ClassRunner.java:208)
> >   at org.junit.runners.BlockJUnit4ClassRunner.
> validateInstanceMet
> >  

Re: Build failed in Jenkins: Geode-nightly #762 - adongre, please read

2017-02-28 Thread Kirk Lund
Everything is building fine now, so I'm going to revert that commit.

Avinash, go ahead and recommit it after the issue with the sub-class
parameterization is fixed and it passes review and precheckin.

I don't know of any way to make JUnit Parameterized work with JUnitParams,
and I'd recommend not trying to do that.

Here's a few generalized JUnit test recommendations. One or two might be of
help in this case:

1) JUnitParams seems more flexible and parameterizes at the test method
level, whereas Parameterized parameterizes at the class level which forces
all of the test methods to repeat with new parameters.

2) I favor splitting tests. If you have a test method that requires
different setUp/tearDown or parameterization and it no longer fits well,
then splitting it up into multiple test classes is probably a good idea.

3) I've seen subclassing of tests be horribly abused, so I'd recommend
avoiding this whenever possible. It's frequently better to use a custom
JUnit Rule or even to repeat code in setUp/tearDown.

4) As an addendum to #3, don't be tempted to have one test class
instantiate another test class and invoke methods on it. This just creates
horrible spaghetti.

On Tue, Feb 28, 2017 at 11:29 AM, Mark Bretl  wrote:

> There is an AWS outage right now, not sure if that is affecting the Gradle
> plugin site...
>
> --Mark
>
> On Tue, Feb 28, 2017 at 10:53 AM, Bruce Schuchardt  >
> wrote:
>
> > I deleted my gradle cache & am also having trouble downloading things
> >
> >:buildSrc:build UP-TO-DATE
> >
> >FAILURE: Build failed with an exception.
> >
> >* What went wrong:
> >A problem occurred configuring root project 'geode'.
> > > Could not resolve all dependencies for configuration ':classpath'.
> >> Could not resolve
> >gradle.plugin.org.nosphere.apache:creadur-rat-gradle:0.2.0.
> >  Required by:
> >  :geode:unspecified
> >   > Could not resolve
> >gradle.plugin.org.nosphere.apache:creadur-rat-gradle:0.2.0.
> >  > Could not get resource
> >'https://plugins.gradle.org/m2/gradle/plugin/org/nosphere/a
> > pache/creadur-rat-gradle/0.2.0/creadur-rat-gradle-0.2.0.pom'.
> > > Could not GET
> >'https://plugins.gradle.org/m2/gradle/plugin/org/nosphere/a
> > pache/creadur-rat-gradle/0.2.0/creadur-rat-gradle-0.2.0.pom'.
> >Received status code 503 from server: Service Unavailable
> >etc.
> >
> > I'm getting 503s on everything but the initial gradle download.
> >
> >
> > Le 2/28/2017 à 10:40 AM, Avinash Dongre a écrit :
> >
> >> I am getting following error while running precheckin.
> >>
> >> * Where:
> >> Build file '/home/ampool/private/geode/java/geode/geode-old-versions/bu
> >> ild.gradle'
> >> line: 58
> >>
> >> * What went wrong:
> >> Execution failed for task ':geode-old-versions:createGeo
> >> deClasspathsFile'.
> >>
> >>> Could not resolve all dependencies for configuration
> >>> ':geode-old-versions:
> >>>
> >> test110Runtime'.
> >> > Could not download geode-cq.jar (org.apache.geode:geode-cq:1.1.0)
> >>> Could not get resource 'https://repo1.maven.org/
> >> maven2/org/apache/geode/geode-cq/1.1.0/geode-cq-1.1.0.jar'.
> >>   > Could not GET 'https://repo1.maven.org/
> >> maven2/org/apache/geode/geode-cq/1.1.0/geode-cq-1.1.0.jar'. Received
> >> status
> >> code 503 from server: Connection timed out
> >>
> >>
> >>
> >> On Tue, Feb 28, 2017 at 11:06 PM, Avinash Dongre 
> >> wrote:
> >>
> >> It is my mistake.
> >>>
> >>> I will revert back my changes for this Test and raise a PR.
> >>>
> >>> Thanks
> >>> Avinash
> >>>
> >>>
> >>> On Tue, Feb 28, 2017 at 10:26 PM, Bruce Schuchardt <
> >>> bschucha...@pivotal.io
> >>>
>  wrote:
>  ClientServerMiscBCDUnitTest is failing due to adongre's commit
>  yesterday.  A parameterized test was added to a superclass, causing
>  conflict with the subclass's parameterization of all the superclass's
>  methods
> 
> 
>  java.lang.Exception: Method testProxyRegionClientServerOp should have
> no
>  parameters
> 
>   at org.junit.runners.model.FrameworkMethod.validatePublicVoidNo
>  Arg(FrameworkMethod.java:76)
>   at org.junit.runners.ParentRunner.validatePublicVoidNoArgMethod
>  s(ParentRunner.java:155)
>   at org.junit.runners.BlockJUnit4ClassRunner.validateTestMethods
>  (BlockJUnit4ClassRunner.java:208)
>   at org.junit.runners.BlockJUnit4ClassRunner.validateInstanceMet
>  hods(BlockJUnit4ClassRunner.java:188)
>   at org.junit.runners.BlockJUnit4ClassRunner.collectInitializati
>  onErrors(BlockJUnit4ClassRunner.java:128)
>   at org.junit.runners.ParentRunner.validate(
> ParentRunner.java:416)
>   at org.junit.runners.ParentRunner.(ParentRunner.java:84)
>   at org.junit.runners.BlockJUnit4ClassRunner.(BlockJUnit4C
>  lassRunner.java:65)
>   at 

Re: Build failed in Jenkins: Geode-nightly #762 - adongre, please read

2017-02-28 Thread Mark Bretl
There is an AWS outage right now, not sure if that is affecting the Gradle
plugin site...

--Mark

On Tue, Feb 28, 2017 at 10:53 AM, Bruce Schuchardt 
wrote:

> I deleted my gradle cache & am also having trouble downloading things
>
>:buildSrc:build UP-TO-DATE
>
>FAILURE: Build failed with an exception.
>
>* What went wrong:
>A problem occurred configuring root project 'geode'.
> > Could not resolve all dependencies for configuration ':classpath'.
>> Could not resolve
>gradle.plugin.org.nosphere.apache:creadur-rat-gradle:0.2.0.
>  Required by:
>  :geode:unspecified
>   > Could not resolve
>gradle.plugin.org.nosphere.apache:creadur-rat-gradle:0.2.0.
>  > Could not get resource
>'https://plugins.gradle.org/m2/gradle/plugin/org/nosphere/a
> pache/creadur-rat-gradle/0.2.0/creadur-rat-gradle-0.2.0.pom'.
> > Could not GET
>'https://plugins.gradle.org/m2/gradle/plugin/org/nosphere/a
> pache/creadur-rat-gradle/0.2.0/creadur-rat-gradle-0.2.0.pom'.
>Received status code 503 from server: Service Unavailable
>etc.
>
> I'm getting 503s on everything but the initial gradle download.
>
>
> Le 2/28/2017 à 10:40 AM, Avinash Dongre a écrit :
>
>> I am getting following error while running precheckin.
>>
>> * Where:
>> Build file '/home/ampool/private/geode/java/geode/geode-old-versions/bu
>> ild.gradle'
>> line: 58
>>
>> * What went wrong:
>> Execution failed for task ':geode-old-versions:createGeo
>> deClasspathsFile'.
>>
>>> Could not resolve all dependencies for configuration
>>> ':geode-old-versions:
>>>
>> test110Runtime'.
>> > Could not download geode-cq.jar (org.apache.geode:geode-cq:1.1.0)
>>> Could not get resource 'https://repo1.maven.org/
>> maven2/org/apache/geode/geode-cq/1.1.0/geode-cq-1.1.0.jar'.
>>   > Could not GET 'https://repo1.maven.org/
>> maven2/org/apache/geode/geode-cq/1.1.0/geode-cq-1.1.0.jar'. Received
>> status
>> code 503 from server: Connection timed out
>>
>>
>>
>> On Tue, Feb 28, 2017 at 11:06 PM, Avinash Dongre 
>> wrote:
>>
>> It is my mistake.
>>>
>>> I will revert back my changes for this Test and raise a PR.
>>>
>>> Thanks
>>> Avinash
>>>
>>>
>>> On Tue, Feb 28, 2017 at 10:26 PM, Bruce Schuchardt <
>>> bschucha...@pivotal.io
>>>
 wrote:
 ClientServerMiscBCDUnitTest is failing due to adongre's commit
 yesterday.  A parameterized test was added to a superclass, causing
 conflict with the subclass's parameterization of all the superclass's
 methods


 java.lang.Exception: Method testProxyRegionClientServerOp should have no
 parameters

  at org.junit.runners.model.FrameworkMethod.validatePublicVoidNo
 Arg(FrameworkMethod.java:76)
  at org.junit.runners.ParentRunner.validatePublicVoidNoArgMethod
 s(ParentRunner.java:155)
  at org.junit.runners.BlockJUnit4ClassRunner.validateTestMethods
 (BlockJUnit4ClassRunner.java:208)
  at org.junit.runners.BlockJUnit4ClassRunner.validateInstanceMet
 hods(BlockJUnit4ClassRunner.java:188)
  at org.junit.runners.BlockJUnit4ClassRunner.collectInitializati
 onErrors(BlockJUnit4ClassRunner.java:128)
  at org.junit.runners.ParentRunner.validate(ParentRunner.java:416)
  at org.junit.runners.ParentRunner.(ParentRunner.java:84)
  at org.junit.runners.BlockJUnit4ClassRunner.(BlockJUnit4C
 lassRunner.java:65)
  at org.junit.runners.parameterized.BlockJUnit4ClassRunnerWithPa
 rameters.(BlockJUnit4ClassRunnerWithParameters.java:27)
  at org.apache.geode.test.junit.runners.CategoryWithParameterize
 dRunner.(CategoryWithParameterizedRunner.java:29)
  at org.apache.geode.test.junit.runners.CategoryWithParameterize
 dRunnerFactory.createRunnerForTestWithParameters(CategoryWit
 hParameterizedRunnerFactory.java:40)
  at org.junit.runners.Parameterized.createRunnersForParameters(P
 arameterized.java:313)
  at org.junit.runners.Parameterized.(Parameterized.java:248)
  at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
 Method)
  at sun.reflect.NativeConstructorAccessorImpl.newInstance(Native
 ConstructorAccessorImpl.java:62)
  at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(De
 legatingConstructorAccessorImpl.java:45)
  at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
  at org.junit.internal.builders.AnnotatedBuilder.buildRunner(Ann
 otatedBuilder.java:104)
  at org.junit.internal.builders.AnnotatedBuilder.runnerForClass(
 AnnotatedBuilder.java:86)
  at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(Run
 nerBuilder.java:59)
  at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.r
 unnerForClass(AllDefaultPossibilitiesBuilder.java:26)
  at 

Re: Build failed in Jenkins: Geode-nightly #762 - adongre, please read

2017-02-28 Thread Bruce Schuchardt

I deleted my gradle cache & am also having trouble downloading things

   :buildSrc:build UP-TO-DATE

   FAILURE: Build failed with an exception.

   * What went wrong:
   A problem occurred configuring root project 'geode'.
> Could not resolve all dependencies for configuration ':classpath'.
   > Could not resolve
   gradle.plugin.org.nosphere.apache:creadur-rat-gradle:0.2.0.
 Required by:
 :geode:unspecified
  > Could not resolve
   gradle.plugin.org.nosphere.apache:creadur-rat-gradle:0.2.0.
 > Could not get resource
   
'https://plugins.gradle.org/m2/gradle/plugin/org/nosphere/apache/creadur-rat-gradle/0.2.0/creadur-rat-gradle-0.2.0.pom'.
> Could not GET
   
'https://plugins.gradle.org/m2/gradle/plugin/org/nosphere/apache/creadur-rat-gradle/0.2.0/creadur-rat-gradle-0.2.0.pom'.
   Received status code 503 from server: Service Unavailable
   etc.

I'm getting 503s on everything but the initial gradle download.

Le 2/28/2017 à 10:40 AM, Avinash Dongre a écrit :

I am getting following error while running precheckin.

* Where:
Build file 
'/home/ampool/private/geode/java/geode/geode-old-versions/build.gradle'
line: 58

* What went wrong:
Execution failed for task ':geode-old-versions:createGeodeClasspathsFile'.

Could not resolve all dependencies for configuration ':geode-old-versions:

test110Runtime'.
> Could not download geode-cq.jar (org.apache.geode:geode-cq:1.1.0)
   > Could not get resource 'https://repo1.maven.org/
maven2/org/apache/geode/geode-cq/1.1.0/geode-cq-1.1.0.jar'.
  > Could not GET 'https://repo1.maven.org/
maven2/org/apache/geode/geode-cq/1.1.0/geode-cq-1.1.0.jar'. Received status
code 503 from server: Connection timed out



On Tue, Feb 28, 2017 at 11:06 PM, Avinash Dongre  wrote:


It is my mistake.

I will revert back my changes for this Test and raise a PR.

Thanks
Avinash


On Tue, Feb 28, 2017 at 10:26 PM, Bruce Schuchardt 

Re: Build failed in Jenkins: Geode-nightly #762 - adongre, please read

2017-02-28 Thread Avinash Dongre
I am getting following error while running precheckin.

* Where:
Build file 
'/home/ampool/private/geode/java/geode/geode-old-versions/build.gradle'
line: 58

* What went wrong:
Execution failed for task ':geode-old-versions:createGeodeClasspathsFile'.
> Could not resolve all dependencies for configuration ':geode-old-versions:
test110Runtime'.
   > Could not download geode-cq.jar (org.apache.geode:geode-cq:1.1.0)
  > Could not get resource 'https://repo1.maven.org/
maven2/org/apache/geode/geode-cq/1.1.0/geode-cq-1.1.0.jar'.
 > Could not GET 'https://repo1.maven.org/
maven2/org/apache/geode/geode-cq/1.1.0/geode-cq-1.1.0.jar'. Received status
code 503 from server: Connection timed out



On Tue, Feb 28, 2017 at 11:06 PM, Avinash Dongre  wrote:

> It is my mistake.
>
> I will revert back my changes for this Test and raise a PR.
>
> Thanks
> Avinash
>
>
> On Tue, Feb 28, 2017 at 10:26 PM, Bruce Schuchardt  > wrote:
>
>> ClientServerMiscBCDUnitTest is failing due to adongre's commit
>> yesterday.  A parameterized test was added to a superclass, causing
>> conflict with the subclass's parameterization of all the superclass's
>> methods
>>
>>
>> java.lang.Exception: Method testProxyRegionClientServerOp should have no
>> parameters
>>
>> at org.junit.runners.model.FrameworkMethod.validatePublicVoidNo
>> Arg(FrameworkMethod.java:76)
>> at org.junit.runners.ParentRunner.validatePublicVoidNoArgMethod
>> s(ParentRunner.java:155)
>> at org.junit.runners.BlockJUnit4ClassRunner.validateTestMethods
>> (BlockJUnit4ClassRunner.java:208)
>> at org.junit.runners.BlockJUnit4ClassRunner.validateInstanceMet
>> hods(BlockJUnit4ClassRunner.java:188)
>> at org.junit.runners.BlockJUnit4ClassRunner.collectInitializati
>> onErrors(BlockJUnit4ClassRunner.java:128)
>> at org.junit.runners.ParentRunner.validate(ParentRunner.java:416)
>> at org.junit.runners.ParentRunner.(ParentRunner.java:84)
>> at org.junit.runners.BlockJUnit4ClassRunner.(BlockJUnit4C
>> lassRunner.java:65)
>> at org.junit.runners.parameterized.BlockJUnit4ClassRunnerWithPa
>> rameters.(BlockJUnit4ClassRunnerWithParameters.java:27)
>> at org.apache.geode.test.junit.runners.CategoryWithParameterize
>> dRunner.(CategoryWithParameterizedRunner.java:29)
>> at org.apache.geode.test.junit.runners.CategoryWithParameterize
>> dRunnerFactory.createRunnerForTestWithParameters(CategoryWit
>> hParameterizedRunnerFactory.java:40)
>> at org.junit.runners.Parameterized.createRunnersForParameters(P
>> arameterized.java:313)
>> at org.junit.runners.Parameterized.(Parameterized.java:248)
>> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
>> Method)
>> at sun.reflect.NativeConstructorAccessorImpl.newInstance(Native
>> ConstructorAccessorImpl.java:62)
>> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(De
>> legatingConstructorAccessorImpl.java:45)
>> at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
>> at org.junit.internal.builders.AnnotatedBuilder.buildRunner(Ann
>> otatedBuilder.java:104)
>> at org.junit.internal.builders.AnnotatedBuilder.runnerForClass(
>> AnnotatedBuilder.java:86)
>> at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(Run
>> nerBuilder.java:59)
>> at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.r
>> unnerForClass(AllDefaultPossibilitiesBuilder.java:26)
>> at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(Run
>> nerBuilder.java:59)
>> at org.junit.internal.requests.ClassRequest.getRunner(ClassRequ
>> est.java:33)
>> at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs
>> (JUnit4IdeaTestRunner.java:49)
>> at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.star
>> tRunnerWithArgs(IdeaTestRunner.java:51)
>> at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsA
>> ndStart(JUnitStarter.java:237)
>> at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStart
>> er.java:70)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce
>> ssorImpl.java:62)
>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe
>> thodAccessorImpl.java:43)
>> at java.lang.reflect.Method.invoke(Method.java:497)
>> at com.intellij.rt.execution.application.AppMain.main(AppMain.j
>> ava:147)
>>
>> here is the commit:
>>
>> commit f2721dc81256bcec84e855e9dc52d2f234e745da
>> Author: adongre  
>> Date:   Sat Feb 4 21:34:37 2017 +0530
>>
>> GEODE-1887: Now Size api goes through ServerProxy when cache is of
>> type client and DataPolicy is Empty.
>> Added a test for both PR and Replicated regions.
>>
>> GEODE-1887: Addressing review comments, refactor test based on the
>> region type.
>>
>> GEODE-1887: Spotless fixes.
>>
>> GEODE-1887: Addressing Review Comments.
>>

Re: Build failed in Jenkins: Geode-nightly #762 - adongre, please read

2017-02-28 Thread Avinash Dongre
It is my mistake.

I will revert back my changes for this Test and raise a PR.

Thanks
Avinash


On Tue, Feb 28, 2017 at 10:26 PM, Bruce Schuchardt 
wrote:

> ClientServerMiscBCDUnitTest is failing due to adongre's commit yesterday.
> A parameterized test was added to a superclass, causing conflict with the
> subclass's parameterization of all the superclass's methods
>
>
> java.lang.Exception: Method testProxyRegionClientServerOp should have no
> parameters
>
> at org.junit.runners.model.FrameworkMethod.validatePublicVoidNo
> Arg(FrameworkMethod.java:76)
> at org.junit.runners.ParentRunner.validatePublicVoidNoArgMethod
> s(ParentRunner.java:155)
> at org.junit.runners.BlockJUnit4ClassRunner.validateTestMethods
> (BlockJUnit4ClassRunner.java:208)
> at org.junit.runners.BlockJUnit4ClassRunner.validateInstanceMet
> hods(BlockJUnit4ClassRunner.java:188)
> at org.junit.runners.BlockJUnit4ClassRunner.collectInitializati
> onErrors(BlockJUnit4ClassRunner.java:128)
> at org.junit.runners.ParentRunner.validate(ParentRunner.java:416)
> at org.junit.runners.ParentRunner.(ParentRunner.java:84)
> at org.junit.runners.BlockJUnit4ClassRunner.(BlockJUnit4C
> lassRunner.java:65)
> at org.junit.runners.parameterized.BlockJUnit4ClassRunnerWithPa
> rameters.(BlockJUnit4ClassRunnerWithParameters.java:27)
> at org.apache.geode.test.junit.runners.CategoryWithParameterize
> dRunner.(CategoryWithParameterizedRunner.java:29)
> at org.apache.geode.test.junit.runners.CategoryWithParameterize
> dRunnerFactory.createRunnerForTestWithParameters(CategoryWit
> hParameterizedRunnerFactory.java:40)
> at org.junit.runners.Parameterized.createRunnersForParameters(P
> arameterized.java:313)
> at org.junit.runners.Parameterized.(Parameterized.java:248)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(Native
> ConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(De
> legatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
> at org.junit.internal.builders.AnnotatedBuilder.buildRunner(Ann
> otatedBuilder.java:104)
> at org.junit.internal.builders.AnnotatedBuilder.runnerForClass(
> AnnotatedBuilder.java:86)
> at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(Run
> nerBuilder.java:59)
> at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.
> runnerForClass(AllDefaultPossibilitiesBuilder.java:26)
> at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(Run
> nerBuilder.java:59)
> at org.junit.internal.requests.ClassRequest.getRunner(ClassRequ
> est.java:33)
> at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs
> (JUnit4IdeaTestRunner.java:49)
> at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.star
> tRunnerWithArgs(IdeaTestRunner.java:51)
> at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsA
> ndStart(JUnitStarter.java:237)
> at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStart
> er.java:70)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce
> ssorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe
> thodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at com.intellij.rt.execution.application.AppMain.main(AppMain.
> java:147)
>
> here is the commit:
>
> commit f2721dc81256bcec84e855e9dc52d2f234e745da
> Author: adongre  
> Date:   Sat Feb 4 21:34:37 2017 +0530
>
> GEODE-1887: Now Size api goes through ServerProxy when cache is of
> type client and DataPolicy is Empty.
> Added a test for both PR and Replicated regions.
>
> GEODE-1887: Addressing review comments, refactor test based on the
> region type.
>
> GEODE-1887: Spotless fixes.
>
> GEODE-1887: Addressing Review Comments.
>
> GEODE-1887: Spotless
>
>
>
>
> Le 2/28/2017 à 8:35 AM, Apache Jenkins Server a écrit :
>
> See 
> 
>  
> 
>
> Changes:
>
> [adongre] GEODE-2428: Adding support of Serialization/deserialization of
>
> [adongre] GEODE-1887: Now Size api goes through ServerProxy when cache is of 
> type
>
> [ukohlmeyer] GEODE-2142: Removal of offending JSON.ORG code and license 
> information
>
> [ukohlmeyer] GEODE-2142: Removal of offending JSON.ORG code and license 
> information
>
> [ukohlmeyer] GEODE-2142: Adding JSON library from the
>
> [ukohlmeyer] GEODE-2142: Amending JSONObject.java with cyclicalDependency 
> management
>
> [ukohlmeyer] GEODE-2142: Refactoring of tests to work with new JSONObject 
> class.
>
> [ukohlmeyer] 

Re: Build failed in Jenkins: Geode-nightly #762 - adongre, please read

2017-02-28 Thread Bruce Schuchardt
ClientServerMiscBCDUnitTest is failing due to adongre's commit 
yesterday.  A parameterized test was added to a superclass, causing 
conflict with the subclass's parameterization of all the superclass's 
methods



   java.lang.Exception: Method testProxyRegionClientServerOp should
   have no parameters

at
   
org.junit.runners.model.FrameworkMethod.validatePublicVoidNoArg(FrameworkMethod.java:76)
at
   
org.junit.runners.ParentRunner.validatePublicVoidNoArgMethods(ParentRunner.java:155)
at
   
org.junit.runners.BlockJUnit4ClassRunner.validateTestMethods(BlockJUnit4ClassRunner.java:208)
at
   
org.junit.runners.BlockJUnit4ClassRunner.validateInstanceMethods(BlockJUnit4ClassRunner.java:188)
at
   
org.junit.runners.BlockJUnit4ClassRunner.collectInitializationErrors(BlockJUnit4ClassRunner.java:128)
at org.junit.runners.ParentRunner.validate(ParentRunner.java:416)
at org.junit.runners.ParentRunner.(ParentRunner.java:84)
at
   
org.junit.runners.BlockJUnit4ClassRunner.(BlockJUnit4ClassRunner.java:65)
at
   
org.junit.runners.parameterized.BlockJUnit4ClassRunnerWithParameters.(BlockJUnit4ClassRunnerWithParameters.java:27)
at
   
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunner.(CategoryWithParameterizedRunner.java:29)
at
   
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory.createRunnerForTestWithParameters(CategoryWithParameterizedRunnerFactory.java:40)
at
   
org.junit.runners.Parameterized.createRunnersForParameters(Parameterized.java:313)
at org.junit.runners.Parameterized.(Parameterized.java:248)
at
   sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
   
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
   
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
at
   
org.junit.internal.builders.AnnotatedBuilder.buildRunner(AnnotatedBuilder.java:104)
at
   
org.junit.internal.builders.AnnotatedBuilder.runnerForClass(AnnotatedBuilder.java:86)
at
   
org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
at
   
org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:26)
at
   
org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
at
   org.junit.internal.requests.ClassRequest.getRunner(ClassRequest.java:33)
at
   
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:49)
at
   
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
at
   
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:237)
at
   com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
   sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
   
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
   com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)

here is the commit:

   commit f2721dc81256bcec84e855e9dc52d2f234e745da
   Author: adongre 
   Date:   Sat Feb 4 21:34:37 2017 +0530

GEODE-1887: Now Size api goes through ServerProxy when cache is
   of type client and DataPolicy is Empty.
Added a test for both PR and Replicated regions.

GEODE-1887: Addressing review comments, refactor test based on the
region type.

GEODE-1887: Spotless fixes.

GEODE-1887: Addressing Review Comments.

GEODE-1887: Spotless




Le 2/28/2017 à 8:35 AM, Apache Jenkins Server a écrit :

See 


Changes:

[adongre] GEODE-2428: Adding support of Serialization/deserialization of

[adongre] GEODE-1887: Now Size api goes through ServerProxy when cache is of 
type

[ukohlmeyer] GEODE-2142: Removal of offending JSON.ORG code and license 
information

[ukohlmeyer] GEODE-2142: Removal of offending JSON.ORG code and license 
information

[ukohlmeyer] GEODE-2142: Adding JSON library from the

[ukohlmeyer] GEODE-2142: Amending JSONObject.java with cyclicalDependency 
management

[ukohlmeyer] GEODE-2142: Refactoring of tests to work with new JSONObject class.

[ukohlmeyer] GEODE-2142: spotless

[ukohlmeyer] GEODE-2142: cyclical dependency in gradle build

[ukohlmeyer] GEODE-2142: final compiling build

[ukohlmeyer] GEODE-2142: removing tests so run precheckin

[ukohlmeyer] GEODE-2142: Removing JSON licence stuff from