subject:"Re\: Review Request 59852\: GEODE\-2632\: make SecurityService immutable to improve client\/server performance"

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-09 Thread Ken Howe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177483
---


Ship it!




Ship It!

- Ken Howe


On June 8, 2017, 9:22 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 8, 2017, 9:22 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
> e06949c94ab3dd861e9dc64089bec809b3568a6c 
>   geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
> 4de1a95f9acdcdbc843a3412fd773c60910dc43a 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   geode-core/src/main/java/org/apache/geode/internal/ClassLoadUtil.java 
> 60d1d3968916697ae1bbac979f6ad5f4a6ad30bd 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java
>  988be0a72b97cf6d67dd7dd930e229f6eb867166 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> 67fcce85c0f812e062f602e97d604dd39c0edd9f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
>  037bff6ebd0f49b7afe6b5aad4c0edd9ca3b139a 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntriesMessage.java
>  489ffbaddabfc2d2a46d87d3060d5c61b76c7f32 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
> d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  9658f98da808e50b87fe54854df249b28b97662d 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
>  1fb8c8cac62c54b582d40688a423fddcae23b36e 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-08 Thread Jared Stewart


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177391
---




geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
Line 317 (original), 302 (patched)


It looks to me like this `securityService` isn't used.



geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java
Lines 182 (patched)


It looks like there is a lot of duplication in these methods (which 
basically call authorize with the correct String args) between 
`CustomSecurityService` and `IntegratedSecurityMethods`.  Might be worth 
circling back after this change to abstract these duplicated methods into one 
place.



geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitialization.java
Lines 36 (patched)


It might be nice to change this (in a future ticket) from a hardcoded 
String to  `GeodePermissionResolver.class.getCanonicalName()` so that it would 
be picked up by an IDE if someone refactors the name or package of 
`GeodePermissionResolver`.


- Jared Stewart


On June 8, 2017, 9:22 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 8, 2017, 9:22 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
> e06949c94ab3dd861e9dc64089bec809b3568a6c 
>   geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
> 4de1a95f9acdcdbc843a3412fd773c60910dc43a 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   geode-core/src/main/java/org/apache/geode/internal/ClassLoadUtil.java 
> 60d1d3968916697ae1bbac979f6ad5f4a6ad30bd 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java
>  988be0a72b97cf6d67dd7dd930e229f6eb867166 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-08 Thread Jared Stewart


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177410
---


Ship it!




Ship It!

- Jared Stewart


On June 8, 2017, 9:22 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 8, 2017, 9:22 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
> e06949c94ab3dd861e9dc64089bec809b3568a6c 
>   geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
> 4de1a95f9acdcdbc843a3412fd773c60910dc43a 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   geode-core/src/main/java/org/apache/geode/internal/ClassLoadUtil.java 
> 60d1d3968916697ae1bbac979f6ad5f4a6ad30bd 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java
>  988be0a72b97cf6d67dd7dd930e229f6eb867166 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> 67fcce85c0f812e062f602e97d604dd39c0edd9f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
>  037bff6ebd0f49b7afe6b5aad4c0edd9ca3b139a 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntriesMessage.java
>  489ffbaddabfc2d2a46d87d3060d5c61b76c7f32 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
> d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  9658f98da808e50b87fe54854df249b28b97662d 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
>  1fb8c8cac62c54b582d40688a423fddcae23b36e 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-08 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

(Updated June 8, 2017, 9:22 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Changes
---

Add SecurityTest category to new security tests.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
e06949c94ab3dd861e9dc64089bec809b3568a6c 
  geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
4de1a95f9acdcdbc843a3412fd773c60910dc43a 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/ClassLoadUtil.java 
60d1d3968916697ae1bbac979f6ad5f4a6ad30bd 
  
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java
 988be0a72b97cf6d67dd7dd930e229f6eb867166 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
67fcce85c0f812e062f602e97d604dd39c0edd9f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
 037bff6ebd0f49b7afe6b5aad4c0edd9ca3b139a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntriesMessage.java
 489ffbaddabfc2d2a46d87d3060d5c61b76c7f32 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 388f838e3c906aaba1e6993051f2fcf2ae3c9e82

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-08 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

(Updated June 8, 2017, 9:04 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
e06949c94ab3dd861e9dc64089bec809b3568a6c 
  geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
4de1a95f9acdcdbc843a3412fd773c60910dc43a 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/ClassLoadUtil.java 
60d1d3968916697ae1bbac979f6ad5f4a6ad30bd 
  
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java
 988be0a72b97cf6d67dd7dd930e229f6eb867166 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
67fcce85c0f812e062f602e97d604dd39c0edd9f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
 037bff6ebd0f49b7afe6b5aad4c0edd9ca3b139a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntriesMessage.java
 489ffbaddabfc2d2a46d87d3060d5c61b76c7f32 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 388f838e3c906aaba1e6993051f2fcf2ae3c9e82 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-08 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

(Updated June 8, 2017, 9:02 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Changes
---

Feedback fixup and extract utility methods from SecurityService to static 
utility classes. Note: I did not cleanup imports in any classes I didn't 
directly edit.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
e06949c94ab3dd861e9dc64089bec809b3568a6c 
  geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
4de1a95f9acdcdbc843a3412fd773c60910dc43a 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/ClassLoadUtil.java 
60d1d3968916697ae1bbac979f6ad5f4a6ad30bd 
  
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java
 988be0a72b97cf6d67dd7dd930e229f6eb867166 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
67fcce85c0f812e062f602e97d604dd39c0edd9f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
 037bff6ebd0f49b7afe6b5aad4c0edd9ca3b139a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntriesMessage.java
 489ffbaddabfc2d2a46d87d3060d5c61b76c7f32 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-07 Thread Patrick Rhomberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177204
---




geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
Lines 474-492 (original), 452-470 (patched)


Remove dead code?



geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
Line 557 (original), 516 (patched)


This and the below assignments appear to be unused and seem only to 
duplicate the comment immediately above each assignment.

Remove this unused variable.



geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
Lines 189-244 (original), 198-253 (patched)


I don't think the `this`s are necessary here, but if you're making changes 
anyway, these nested `try / finally` make me cringe and should be flattened.



geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/UpdateClientNotification.java
Lines 46-72 (original), 47-73 (patched)


May as well rip out the dead code / pointless `try / finally` while we're 
here.



geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceTest.java
Lines 199-202 (original), 183-207 (patched)


Remove or restore dead test.


- Patrick Rhomberg


On June 6, 2017, 11:57 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 11:57 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-07 Thread Patrick Rhomberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177199
---




geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
Lines 358 (patched)


Complete, remove, or be more explicit in your TODO.



geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
Lines 394 (patched)


Complete, remove, or be more explicit in your TODO.



geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
Line 3793 (original), 3791 (patched)


Complete, remove, or be more explicit in your TODO.



geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
Lines 35-39 (patched)


Delete these?



geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
Lines 49 (patched)


Complete, remove, or be more explicit in your TODO.



geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
Lines 132 (patched)


This is only used once, below.  I'd drop the unused parameter from the 
signature.


- Patrick Rhomberg


On June 6, 2017, 11:57 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 11:57 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-07 Thread Patrick Rhomberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177198
---



Things that are identifiable by inspections on Changed Files:

Explode wildcard imports in:
- ClientReady.java
- Default.java
- Invalid.java
- MakePrimary.java
- PeriodicAck.java
- Ping.java
- UpdateClientNotification.java

Remove unused imports.  (Some of these may be a fault of my closed side not 
linking correctly):
- BlockingHARegionJUnitTest.java
- CacheServerImpl.java
- ContainsKey66Test.java
- CQPDXPostProcessorDUnitTest.java
- CreateRegionTest.java
- Destroy65Test.java
- DestroyRegionTest.java
- DestroyTest.java
- ExecuteFunction65Test.java
- ExecuteFunction66Test.java
- ExecuteFunctionTest.java
- GemFireCacheImpl.java
- Get70Test.java
- GetAll651Test.java
- GetAll70Test.java
- GetAllTest.java
- GetAllWithCallbackTest.java
- GetClientPartitionAttributesCommand66Test.java
- GetClientPartitionAttributesCommandTest.java
- IndexCommands.java
- InvalidateTest.java
- KeySetTest.java
- LegacySecurityService.java
- LoginHandlerInterceptor.java
- MembershipJUnitTest.java
- PDXGfshPostProcessorOnRemoteServerTest.java
- PDXPostProcessorDUnitTest.java
- Put61Test.java
- Put65Test.java
- PutTest.java
- RegisterInterest61Test.java
- RegisterInterestList61Test.java
- RegisterInterestList66Test.java
- RegisterInterestListTest.java
- RegisterInterestTest.java
- RemoveAllTest.java
- RequestTest.java
- RestAPIsAndInterOpsDUnitTest.java
- ServerConnectionTest.java
- ServerRule.java
- UnregisterInterestTest.java

Remove empty dangling docstring at header in:
- ClearRegion.java
- ClientReady.java
- CloseConnection.java
- CommitCommand.java
- Default.java
- Invalid.java
- KeySet.java
- MakePrimary.java
- PeriodicAck.java
- Ping.java
- RegisterInstantiators.java
- RegisterInterest.java
- UnregisterInterestList.java
- UpdateClientNotification.java

- Patrick Rhomberg


On June 6, 2017, 11:57 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 11:57 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-06 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

(Updated June 6, 2017, 11:57 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Changes
---

Updated with review feedback.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 388f838e3c906aaba1e6993051f2fcf2ae3c9e82 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 485ccae143f9897a52e57cf82b1386e709d9e22c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
 6534b68510f5d6c4db4d8cfe23b3adc25b455f61 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
 2cb36cdb4d90a18a0c274f09d8f1bf62dded2430 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
 3feba0d22986600d8f10c84d6e072f790bb4c74f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
 ab199542469ae7c578ef9612d6d789f3d58f8023 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
 cf9c470e79d6a8aaf636de5983abb207250efa12

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-06 Thread Kirk Lund



> On June 6, 2017, 10:23 p.m., Jinmei Liao wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
> > Lines 79 (patched)
> > 
> >
> > this seems like a good utility method to find the security service if 
> > it's not passed down in the method or in the member variable. Should we 
> > make it public and put it in say: GemfireCacheImpl.findSecurityService()?
> 
> Kirk Lund wrote:
> Maybe SecurityService.findSecurityService(). I want to avoid adding more 
> stuff (especially static methods) to GemFireCacheImpl.

I moved this method to SecurityServiceFactory.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177108
---


On June 6, 2017, 10:26 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 10:26 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
> d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  9658f98da808e50b87fe54854df249b28b97662d 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
>  1fb8c8cac62c54b582d40688a423fddcae23b36e 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
>  adf702a1d361ba28f4ebe46695325d23344db756 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
>  fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
>   
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-06 Thread Kirk Lund



> On June 6, 2017, 10:23 p.m., Jinmei Liao wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
> > Lines 84 (patched)
> > 
> >
> > this seems to be added by some merge operation? It was recently 
> > deleted, I think.
> 
> Kirk Lund wrote:
> IndexCommands on develop has this line 235:
> ```java
>   final Set targetMembers = 
> CliUtil.findMembers(group, memberNameOrID);
> ```
> I extracted that to the method which overrides getMembers defined in 
> GfshCommand:
> ```java
>   @Override
>   public Set getMembers(final InternalCache cache) {
> // TODO determine what this does (as it is untested and unmockable!)
> return CliUtil.getAllMembers(cache);
>   }
> ```
> I don't know why they're different, but I wanted to clarify what 
> IndexCommands was really doing. I don't want to change how IndexCommands is 
> getting members in this commit so I'm not going to change this. We could 
> inline it back into the getIndexListing method but I made this change to make 
> it very obvious that IndexCommands is finding members differently from other 
> commands. Maybe they did it to prevent a deadlock or (I don't know) -- I 
> think we should leave it until we decide to delete CliUtil.

I decided to delete it. Line 235 reverted somehow anyway.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177108
---


On June 6, 2017, 10:26 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 10:26 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-06 Thread Kirk Lund



> On June 6, 2017, 10:23 p.m., Jinmei Liao wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
> > Lines 79 (patched)
> > 
> >
> > this seems like a good utility method to find the security service if 
> > it's not passed down in the method or in the member variable. Should we 
> > make it public and put it in say: GemfireCacheImpl.findSecurityService()?

Maybe SecurityService.findSecurityService(). I want to avoid adding more stuff 
(especially static methods) to GemFireCacheImpl.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177108
---


On June 6, 2017, 10:26 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 10:26 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
> d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  9658f98da808e50b87fe54854df249b28b97662d 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
>  1fb8c8cac62c54b582d40688a423fddcae23b36e 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
>  adf702a1d361ba28f4ebe46695325d23344db756 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
>  fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-06 Thread Kirk Lund



> On June 6, 2017, 10:23 p.m., Jinmei Liao wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
> > Lines 84 (patched)
> > 
> >
> > this seems to be added by some merge operation? It was recently 
> > deleted, I think.

IndexCommands on develop has this line 235:
```java
  final Set targetMembers = CliUtil.findMembers(group, 
memberNameOrID);
```
I extracted that to the method which overrides getMembers defined in 
GfshCommand:
```java
  @Override
  public Set getMembers(final InternalCache cache) {
// TODO determine what this does (as it is untested and unmockable!)
return CliUtil.getAllMembers(cache);
  }
```
I don't know why they're different, but I wanted to clarify what IndexCommands 
was really doing. I don't want to change how IndexCommands is getting members 
in this commit so I'm not going to change this. We could inline it back into 
the getIndexListing method but I made this change to make it very obvious that 
IndexCommands is finding members differently from other commands. Maybe they 
did it to prevent a deadlock or (I don't know) -- I think we should leave it 
until we decide to delete CliUtil.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177108
---


On June 6, 2017, 10:26 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 10:26 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
> d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
>   
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-06 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

(Updated June 6, 2017, 10:26 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Changes
---

Add JMH benchmark results (improvement of 882.061 ops/s)


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 388f838e3c906aaba1e6993051f2fcf2ae3c9e82 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 485ccae143f9897a52e57cf82b1386e709d9e22c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
 6534b68510f5d6c4db4d8cfe23b3adc25b455f61 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
 2cb36cdb4d90a18a0c274f09d8f1bf62dded2430 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
 3feba0d22986600d8f10c84d6e072f790bb4c74f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
 ab199542469ae7c578ef9612d6d789f3d58f8023 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
 cf9c470e79d6a8aaf636de5983abb207250efa12

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-06 Thread Jinmei Liao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/#review177108
---




geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
Lines 84 (patched)


this seems to be added by some merge operation? It was recently deleted, I 
think.



geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java
Lines 79 (patched)


this seems like a good utility method to find the security service if it's 
not passed down in the method or in the member variable. Should we make it 
public and put it in say: GemfireCacheImpl.findSecurityService()?



geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityService.java
Lines 30 (patched)


this is where that public utility method I mentioned in earlier comment 
would come in handy.



geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/SecurityServiceProvider.java
Lines 17 (patched)


seems like no one is using this class.


- Jinmei Liao


On June 6, 2017, 9:29 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59852/
> ---
> 
> (Updated June 6, 2017, 9:29 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> See https://github.com/apache/geode/pull/450 for JMH benchmark 
> ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
> minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
> Done" section with performance numbers when that finishes running. My 
> measurements include current develop branch and feature/GEODE-2632-21.
> 
> The changes in this change-set involve making the SecurityService 
> implementation(s) immutable to improve performance of client/server as 
> measured by the JMH benchmark ClientCachePutBench.
> 
> Sorry it's such a long diff again -- I tried to shrink this one down. I could 
> leave out the bulk of client Command classes and tests -- let me know if this 
> review is too big and unwieldy.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
>  45e7a6139b30c800e6096d61d1f23db36c017f99 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 38fdac692315153cda9b4956d0fbbf66fa8f6399 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java
>  0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
>  029e6377f56d80dd81e4cec430f106ac743e5178 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
>  f324e3355e77cc64a8e1cce878b3c03ad4180106 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
>  60249663aad0a59f1d292d0c5336cac33e503204 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
>  bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
>  1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
>  ab0ca6b4533a52528818ab3b8059576c0bd1518f 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
> 670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  5e352241ac114b891adb178e1820e8c74017fa64 
>   geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
> d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
> d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
>  9658f98da808e50b87fe54854df249b28b97662d 
>   
>

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-06 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

(Updated June 6, 2017, 9:29 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Changes
---

Fix SecurityServiceWithCustomRealmIntegrationTest


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 388f838e3c906aaba1e6993051f2fcf2ae3c9e82 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 485ccae143f9897a52e57cf82b1386e709d9e22c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
 6534b68510f5d6c4db4d8cfe23b3adc25b455f61 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
 2cb36cdb4d90a18a0c274f09d8f1bf62dded2430 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
 3feba0d22986600d8f10c84d6e072f790bb4c74f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
 ab199542469ae7c578ef9612d6d789f3d58f8023 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
 cf9c470e79d6a8aaf636de5983abb207250efa12

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-06 Thread Kirk Lund


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59852/
---

(Updated June 6, 2017, 9:18 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Changes
---

Test, FlakyTest are GREEN. One IntegrationTest failure so far.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

See https://github.com/apache/geode/pull/450 for JMH benchmark 
ClientCachePutBench. I increased the runtime of ClientCachePutBench from 30 
minutes to 2 hours to get more accurate measurement. I'll update the "Testing 
Done" section with performance numbers when that finishes running. My 
measurements include current develop branch and feature/GEODE-2632-21.

The changes in this change-set involve making the SecurityService 
implementation(s) immutable to improve performance of client/server as measured 
by the JMH benchmark ClientCachePutBench.

Sorry it's such a long diff again -- I tried to shrink this one down. I could 
leave out the bulk of client Command classes and tests -- let me know if this 
review is too big and unwieldy.


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
 45e7a6139b30c800e6096d61d1f23db36c017f99 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
38fdac692315153cda9b4956d0fbbf66fa8f6399 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
0d678ca4d08d100ac99266c5d550d9cee7a13ea3 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
 029e6377f56d80dd81e4cec430f106ac743e5178 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 7caad3f33ee55f72dc61c4adc2ab3de5429a1607 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java
 f324e3355e77cc64a8e1cce878b3c03ad4180106 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java
 60249663aad0a59f1d292d0c5336cac33e503204 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java
 bc94ab5afd3e6c9bb5deb9e0beed5f1f84d924fa 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java
 1404b3b6f2a44aeaf3c76b99dad8a428b1b5d1f7 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java
 ab0ca6b4533a52528818ab3b8059576c0bd1518f 
  geode-core/src/main/java/org/apache/geode/internal/cache/CacheServerImpl.java 
670c697c7f6c3d22a3c79d10be4e9c9929cd612b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
5e352241ac114b891adb178e1820e8c74017fa64 
  geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 
d9a34e1cfa85cc08ff4f0af81b6adc2bdbd7e869 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Command.java 
d7f7c7b20372351963dbc6cb1e8bab506ffcc1d0 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
 9658f98da808e50b87fe54854df249b28b97662d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
 1fb8c8cac62c54b582d40688a423fddcae23b36e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
 adf702a1d361ba28f4ebe46695325d23344db756 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientNotifier.java
 fd5154f9c5bdd516dad2eb93cd78e7b73213255f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
 8450db905a3834374bd451b55d8720d313d21d2a 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
 388f838e3c906aaba1e6993051f2fcf2ae3c9e82 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 485ccae143f9897a52e57cf82b1386e709d9e22c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerHandShakeProcessor.java
 6534b68510f5d6c4db4d8cfe23b3adc25b455f61 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxEnum.java
 2cb36cdb4d90a18a0c274f09d8f1bf62dded2430 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/AddPdxType.java
 3feba0d22986600d8f10c84d6e072f790bb4c74f 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClearRegion.java
 ab199542469ae7c578ef9612d6d789f3d58f8023 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ClientReady.java
 cf9c470e79d6a8aaf636de5983abb207250efa12

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

18 matches

Site Navigation

Mail list logo

Footer information