Re: Review Request 60834: GEODE-3051: Remove unreachable exception handling in AcceptorImpl.accept
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60834/#review180578 --- Ship it! Ship It! - Udo Kohlmeyer On July 13, 2017, 12:35 a.m., Brian Rowe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60834/ > --- > > (Updated July 13, 2017, 12:35 a.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen > O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer. > > > Bugs: GEODE-3051 > https://issues.apache.org/jira/browse/GEODE-3051 > > > Repository: geode > > > Description > --- > > This removes handling of SSL exceptions from the AccepterImpl.accept call, as > the SSL handling code is now all done in another thread. > The exception handling being done in the other thread appears to be correct, > as validated by CacheServerSSLConnectionDUnitTest.testNonSSLClient > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java > 3c424d397 > > > Diff: https://reviews.apache.org/r/60834/diff/1/ > > > Testing > --- > > > Thanks, > > Brian Rowe > >
Re: Review Request 60834: GEODE-3051: Remove unreachable exception handling in AcceptorImpl.accept
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60834/#review180546 --- Ship it! Ship It! - Galen O'Sullivan On July 13, 2017, 12:35 a.m., Brian Rowe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60834/ > --- > > (Updated July 13, 2017, 12:35 a.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen > O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer. > > > Bugs: GEODE-3051 > https://issues.apache.org/jira/browse/GEODE-3051 > > > Repository: geode > > > Description > --- > > This removes handling of SSL exceptions from the AccepterImpl.accept call, as > the SSL handling code is now all done in another thread. > The exception handling being done in the other thread appears to be correct, > as validated by CacheServerSSLConnectionDUnitTest.testNonSSLClient > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java > 3c424d397 > > > Diff: https://reviews.apache.org/r/60834/diff/1/ > > > Testing > --- > > > Thanks, > > Brian Rowe > >
Re: Review Request 60834: GEODE-3051: Remove unreachable exception handling in AcceptorImpl.accept
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60834/#review180441 --- Ship it! Ship It! - Bruce Schuchardt On July 12, 2017, 5:35 p.m., Brian Rowe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60834/ > --- > > (Updated July 12, 2017, 5:35 p.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen > O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer. > > > Bugs: GEODE-3051 > https://issues.apache.org/jira/browse/GEODE-3051 > > > Repository: geode > > > Description > --- > > This removes handling of SSL exceptions from the AccepterImpl.accept call, as > the SSL handling code is now all done in another thread. > The exception handling being done in the other thread appears to be correct, > as validated by CacheServerSSLConnectionDUnitTest.testNonSSLClient > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java > 3c424d397 > > > Diff: https://reviews.apache.org/r/60834/diff/1/ > > > Testing > --- > > > Thanks, > > Brian Rowe > >
