Re: Review Request 54330: GEODE-2179 - Checking for disconnected connection in GatewaySenderMBean

2016-12-06 Thread Amey Barve

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54330/#review158306
---


Ship it!




Ship It!

- Amey Barve


On Dec. 2, 2016, 11:48 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54330/
> ---
> 
> (Updated Dec. 2, 2016, 11:48 p.m.)
> 
> 
> Review request for geode and Barry Oglesby.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Making sure that the mbean returns false for isConnected if the gateway
> is not actually connected to the remote side.
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
>  16b196586e62dcd3707bd9f70406ff8d5d963308 
>   
> geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java
>  9a6cc104a1368fa762bffd1efa1978f007819604 
> 
> Diff: https://reviews.apache.org/r/54330/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>



Re: Review Request 54330: GEODE-2179 - Checking for disconnected connection in GatewaySenderMBean

2016-12-02 Thread Jason Huynh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54330/#review157860
---


Ship it!




Ship It!

- Jason Huynh


On Dec. 2, 2016, 11:48 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54330/
> ---
> 
> (Updated Dec. 2, 2016, 11:48 p.m.)
> 
> 
> Review request for geode and Barry Oglesby.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Making sure that the mbean returns false for isConnected if the gateway
> is not actually connected to the remote side.
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
>  16b196586e62dcd3707bd9f70406ff8d5d963308 
>   
> geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java
>  9a6cc104a1368fa762bffd1efa1978f007819604 
> 
> Diff: https://reviews.apache.org/r/54330/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>



Review Request 54330: GEODE-2179 - Checking for disconnected connection in GatewaySenderMBean

2016-12-02 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54330/
---

Review request for geode and Barry Oglesby.


Repository: geode


Description
---

Making sure that the mbean returns false for isConnected if the gateway
is not actually connected to the remote side.


Diffs
-

  
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
 16b196586e62dcd3707bd9f70406ff8d5d963308 
  
geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java 
9a6cc104a1368fa762bffd1efa1978f007819604 

Diff: https://reviews.apache.org/r/54330/diff/


Testing
---


Thanks,

Dan Smith