Re: Review Request 55393: GEODE-2260 Remove geode-examples from geode repo and geode build

2017-01-16 Thread Mark Bretl

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55393/#review161776
---


Ship it!




Ship It!

- Mark Bretl


On Jan. 10, 2017, 2:39 p.m., Karen Miller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55393/
> ---
> 
> (Updated Jan. 10, 2017, 2:39 p.m.)
> 
> 
> Review request for geode, Anthony Baker, William Markito, Mark Bretl, and Dan 
> Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2260 Remove geode-examples from geode repo and geode build
> 
> 
> Diffs
> -
> 
>   build.gradle c9915358bd7b7071ddae9f8c058b2388db5a415b 
>   geode-assembly/build.gradle dba5dc768a0b4829aff17c4143e8da3b87106319 
>   geode-examples/.gitignore b1001a6575698224615e5d4b6ff804e9c4506d0a 
>   geode-examples/README.md 62666035ab1bde5f9d5548e887e0133f006c2ef9 
>   geode-examples/build.gradle 1e638bc2f18f5aed2ba007e60e7b8e48711383b9 
>   geode-examples/gradle.properties c1739aff2825d87e10717f877cc4a12f4101c6c1 
>   geode-examples/gradle/wrapper/gradle-wrapper.jar 
> 2c6137b87896c8f70315ae454e00a969ef5f6019 
>   geode-examples/gradle/wrapper/gradle-wrapper.properties 
> 6132c99fbc50c6921e25432874c31a55382ef8fc 
>   geode-examples/gradlew 9d82f78915133e1c35a6ea51252590fb38efac2f 
>   geode-examples/gradlew.bat 5f192121eb4f5b109f22fa96a6246eb39e749ed6 
>   geode-examples/replicated/.gitignore 
> b858ea877b065d2420484a484d649f98054c9cc0 
>   geode-examples/replicated/README.md 
> ea923ddc76b3143bc288daf615e2c6a02e84447d 
>   geode-examples/replicated/build.gradle 
> 52283ecef776b3f6a484bdc6e7cc3cdc5b1ffe29 
>   geode-examples/replicated/scripts/.gitignore 
> 32f8870d0e0514786c159a18c9bcc6b62ac48956 
>   geode-examples/replicated/scripts/pidkiller.sh 
> ecf8f2d6911121f12df29d69dbbde7c0a67b5ced 
>   geode-examples/replicated/scripts/setEnv.sh 
> e9e860e271f523d4818f13b73de5df64897c19ed 
>   geode-examples/replicated/scripts/startAll.sh 
> 2b08f197191ced868481462752b91cbe7d6e45b6 
>   geode-examples/replicated/scripts/stopAll.sh 
> a6364a861395e8e2077ff63f27946eee616e0b6b 
>   
> geode-examples/replicated/src/main/java/org/apache/geode/examples/replicated/BaseClient.java
>  3e656f6a5b86b226db3611559eae13f92bf76b38 
>   
> geode-examples/replicated/src/main/java/org/apache/geode/examples/replicated/Consumer.java
>  7954bb57b7a86bfe4baf8ba3b9798d713f71830e 
>   
> geode-examples/replicated/src/main/java/org/apache/geode/examples/replicated/Producer.java
>  79d5dfecb2c21a09a9f926d505d466490e18c0b6 
>   
> geode-examples/replicated/src/test/java/org/apache/geode/examples/replicated/ConsumerTest.java
>  2fab5087c0ce41dfeb57d2c97113165051d84096 
>   
> geode-examples/replicated/src/test/java/org/apache/geode/examples/replicated/ProducerTest.java
>  9b4a2511bf27b83dbcd5552a5ed46ac2d85c1163 
>   
> geode-examples/replicated/src/test/java/org/apache/geode/examples/replicated/ReplicatedTest.java
>  ab84485f8cd26a7da246fb59dc7856c79d1bcca2 
>   geode-examples/settings.gradle 432a8ebc38f85e7e3e6c8b7d71328b90bc1356e4 
>   
> geode-examples/utils/src/main/java/org/apache/geode/example/utils/ShellUtil.java
>  c5290b826ab40df4474e714e2a4d298e9f10e7f5 
> 
> Diff: https://reviews.apache.org/r/55393/diff/
> 
> 
> Testing
> ---
> 
> Ran
> `./gradlew precheckin -xdistributedTest -xintegrationTest -xflakyTest`
> to verify that a geode-examples directory is not included in the source 
> distribution.
> 
> Ran
> `./gradlew build -Dskip.tests=true`
> to verify no errors in the build (without tests).
> 
> Ran
> `./gradlew tasks`
> to observe that there were no tasks involving Examples.
> 
> 
> Thanks,
> 
> Karen Miller
> 
>



Review Request 55393: GEODE-2260 Remove geode-examples from geode repo and geode build

2017-01-10 Thread Karen Miller

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55393/
---

Review request for geode, Anthony Baker, William Markito, Mark Bretl, and Dan 
Smith.


Repository: geode


Description
---

GEODE-2260 Remove geode-examples from geode repo and geode build


Diffs
-

  build.gradle c9915358bd7b7071ddae9f8c058b2388db5a415b 
  geode-assembly/build.gradle dba5dc768a0b4829aff17c4143e8da3b87106319 
  geode-examples/.gitignore b1001a6575698224615e5d4b6ff804e9c4506d0a 
  geode-examples/README.md 62666035ab1bde5f9d5548e887e0133f006c2ef9 
  geode-examples/build.gradle 1e638bc2f18f5aed2ba007e60e7b8e48711383b9 
  geode-examples/gradle.properties c1739aff2825d87e10717f877cc4a12f4101c6c1 
  geode-examples/gradle/wrapper/gradle-wrapper.jar 
2c6137b87896c8f70315ae454e00a969ef5f6019 
  geode-examples/gradle/wrapper/gradle-wrapper.properties 
6132c99fbc50c6921e25432874c31a55382ef8fc 
  geode-examples/gradlew 9d82f78915133e1c35a6ea51252590fb38efac2f 
  geode-examples/gradlew.bat 5f192121eb4f5b109f22fa96a6246eb39e749ed6 
  geode-examples/replicated/.gitignore b858ea877b065d2420484a484d649f98054c9cc0 
  geode-examples/replicated/README.md ea923ddc76b3143bc288daf615e2c6a02e84447d 
  geode-examples/replicated/build.gradle 
52283ecef776b3f6a484bdc6e7cc3cdc5b1ffe29 
  geode-examples/replicated/scripts/.gitignore 
32f8870d0e0514786c159a18c9bcc6b62ac48956 
  geode-examples/replicated/scripts/pidkiller.sh 
ecf8f2d6911121f12df29d69dbbde7c0a67b5ced 
  geode-examples/replicated/scripts/setEnv.sh 
e9e860e271f523d4818f13b73de5df64897c19ed 
  geode-examples/replicated/scripts/startAll.sh 
2b08f197191ced868481462752b91cbe7d6e45b6 
  geode-examples/replicated/scripts/stopAll.sh 
a6364a861395e8e2077ff63f27946eee616e0b6b 
  
geode-examples/replicated/src/main/java/org/apache/geode/examples/replicated/BaseClient.java
 3e656f6a5b86b226db3611559eae13f92bf76b38 
  
geode-examples/replicated/src/main/java/org/apache/geode/examples/replicated/Consumer.java
 7954bb57b7a86bfe4baf8ba3b9798d713f71830e 
  
geode-examples/replicated/src/main/java/org/apache/geode/examples/replicated/Producer.java
 79d5dfecb2c21a09a9f926d505d466490e18c0b6 
  
geode-examples/replicated/src/test/java/org/apache/geode/examples/replicated/ConsumerTest.java
 2fab5087c0ce41dfeb57d2c97113165051d84096 
  
geode-examples/replicated/src/test/java/org/apache/geode/examples/replicated/ProducerTest.java
 9b4a2511bf27b83dbcd5552a5ed46ac2d85c1163 
  
geode-examples/replicated/src/test/java/org/apache/geode/examples/replicated/ReplicatedTest.java
 ab84485f8cd26a7da246fb59dc7856c79d1bcca2 
  geode-examples/settings.gradle 432a8ebc38f85e7e3e6c8b7d71328b90bc1356e4 
  
geode-examples/utils/src/main/java/org/apache/geode/example/utils/ShellUtil.java
 c5290b826ab40df4474e714e2a4d298e9f10e7f5 

Diff: https://reviews.apache.org/r/55393/diff/


Testing
---

Ran
`./gradlew precheckin -xdistributedTest -xintegrationTest -xflakyTest`
to verify that a geode-examples directory is not included in the source 
distribution.

Ran
`./gradlew build -Dskip.tests=true`
to verify no errors in the build (without tests).

Ran
`./gradlew tasks`
to observe that there were no tasks involving Examples.


Thanks,

Karen Miller